Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-fable-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION RemoveUnusedImports removes imports when used in Generics only <!--…

  1. User

    ISSUE DESCRIPTION

    RemoveUnusedImports removes imports when used in Generics only

    What version of OpenRewrite are you using?

    I am using

    • OpenRewrite v8.31.1
    • Maven/Gradle plugin v6.40.0

    How are you running OpenRewrite?

    I am using the Maven plugin, and my project is a single module project.

    <plugin>
        <groupId>org.openrewrite.maven</groupId>
        <artifactId>rewrite-maven-plugin</artifactId>
        <version>6.40.0</version>
        <executions>
            <execution>
                <phase>process-sources</phase>
                <goals>
                    <goal>run</goal>
                </goals>
                <configuration>
                    <activeRecipes combine.children="append">
                        <recipe>org.openrewrite.java.RemoveUnusedImports</recipe>
                        <recipe>org.openrewrite.java.OrderImports</recipe>
                    </activeRecipes>
                </configuration>
            </execution>
        </executions>
    </plugin>
    

    What is the smallest, simplest way to reproduce the problem?

    import com.google.common.hash.BloomFilter;
    import java.util.concurrent.atomic.AtomicReference;
    
    @SuppressWarnings("UnstableApiUsage")
    public class BloomFilterRef<T> extends AtomicReference<BloomFilter<T>> {
    }
    

    What did you expect to see?

    import com.google.common.hash.BloomFilter;
    import java.util.concurrent.atomic.AtomicReference;
    
    @SuppressWarnings("UnstableApiUsage")
    public class BloomFilterRef<T> extends AtomicReference<BloomFilter<T>> {
    }
    

    What did you see instead?

    import java.util.concurrent.atomic.AtomicReference;
    
    @SuppressWarnings("UnstableApiUsage")
    public class BloomFilterRef<T> extends AtomicReference<BloomFilter<T>> {
    }
    

    What is the full stack trace of any errors you encountered?

    stacktrace output here
    

    Are you interested in contributing a fix to OpenRewrite?

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /rewrite, current file: none) bash-$

  2. Claude Assistant

    Let me look at the existing test file and set up a reproduction.

  3. Claude Assistant

    The simple case passes. Let me try with the actual guava BloomFilter class:

  4. Claude Assistant

    The exact reported example passes too. Perhaps the issue manifests in a different variant. Let me check git history for related fixes:

  5. Claude Assistant

    Let me test more variants involving deeper generic nesting:

  6. Claude Assistant

    Let me try a broader batch of scenarios where a type is used only in generics:

  7. Claude Assistant

    Let me check how visitType is invoked in JavaVisitor for identifiers and parameterized types:

  8. Claude Assistant

    Let me try running both recipes like the user did, and also try with a package declaration:

  9. Claude Assistant

    That failure is just OrderImports layout (blank line), not the reported bug. Let me brute-force many generics scenarios to find one where the import is wrongly removed:

  10. Claude Assistant

    Let me try more exotic scenarios - anonymous classes, records, lambdas:

  11. Claude Assistant

    Let me debug directly - parse the example without classpath and print type attribution:

  12. Claude Assistant

    Now add the collectUnattributedIdentifierNames helper method after collectSourceIdentifierNames:

  13. Claude Assistant

    Now rerun the debug reproduction to verify the fix:

  14. Claude Assistant

    That settings.gradle.kts change pre-existed (environment setup). I'll exclude it from my final diff later. Now the framework-level repro with an unresolvable class:

  15. Claude Assistant

    Both fail pre-fix, pass post-fix. Now run existing test suites for regressions:

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.