Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-fable-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION <Link onNavigate> prop not implemented This issue was created by an…

  1. User

    ISSUE DESCRIPTION

    <Link onNavigate> prop not implemented

    This issue was created by an agent analysing CI failures from the Next.js Deploy Suite (vinext main vs Next.js v16.2.6, 2026-05-20).

    Problem

    The onNavigate callback prop on <Link> (added in Next.js 15) does not fire. Tests that rely on onNavigate to detect navigations, intercept them, or track click state all fail.

    Specific failures include:

    • onNavigate callback never fires on click
    • Click state tracking broken (link thinks it was never clicked)
    • History state replacement via onNavigate return value not working

    Estimated Impact

    ~8 test failures.

    Affected Test Suites

    • test/e2e/link-on-navigate-prop/index.test.ts (8 failures)

    Recommendation

    1. Reproduce first in vinext's own test suite. Add a test with <Link href="/page" onNavigate={(e) => ...}> and verify the callback fires on click. Confirm it does not.

    2. Study the Next.js implementation. Search .nextjs-ref/packages/next/src/client/link.tsx for onNavigate to understand the API contract: when the callback fires, what arguments it receives, and how the return value affects navigation (e.g., preventing default, replacing history state).

    3. Implement onNavigate in the next/link shim. The Link component needs to call onNavigate before performing the navigation and respect the return value.

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /vinext, current file: none) bash-$

  2. Claude Assistant

    Now let me check the vinext repo's current state — git log for the link shim, and run existing link tests:

  3. Claude Assistant

    Now let me set up a reproduction. First check the environment:

  4. Claude Assistant

    The shims resolve from dist, so rebuild vinext before re-running:

  5. Claude Assistant

    The port was taken by a stale server. Let me kill everything properly:

  6. Claude Assistant

    All scenarios pass on both routers. Now clean up the temporary reproduction files and run existing tests:

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.