Skip to content
TheChatArchiveThe Chat Archive
DeepSeekdeepseek/deepseek-v4-pro· deepseekHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION Cap eval table page size for non-export requests Summary GET…

  1. User

    ISSUE DESCRIPTION

    Cap eval table page size for non-export requests

    Summary

    GET /api/eval/:id/table accepts any positive integer for limit on normal table requests. The route already intentionally treats export requests differently by using Number.MAX_SAFE_INTEGER when format is set, but non-export page requests currently do not have an upper bound.

    Why this matters

    A very large limit can make a normal table request ask the server to load and serialize a large amount of eval result data in one response. Other list-style APIs in the server already bound their page sizes, so the eval table endpoint should follow the same resource-control pattern.

    Proposed change

    • Add a maximum limit for non-export GET /api/eval/:id/table requests.
    • Keep format=csv / format=json exports unchanged so full-table exports still work as intended.
    • Return validation errors for excessive non-export limits, consistent with nearby API schema validation.

    A cap of 500 or 1000 would likely cover normal UI usage while preventing accidental oversized page requests.

    Validation

    Suggested tests:

    • schema test rejects EvalSchemas.Table.Query.safeParse({ limit: '<cap + 1>' })
    • route validation test returns 400 for excessive non-export limit
    • export route tests continue to use Number.MAX_SAFE_INTEGER when format is present

    Interface

    Type: Constant Name: EVAL_TABLE_MAX_PAGE_SIZE Path: src/types/api/eval.ts Value/Type: constant literal value 1000 (number) Description: Server-enforced upper bound for the limit parameter on non-export eval table page requests. Exports using format (csv/json) are exempt from this cap; UI pagination controls derive their available page-size options from this value.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /promptfoo, current file: none) bash-$

  2. DeepSeek Assistant

    Let me start by understanding the repository structure and finding the relevant files mentioned in the issue description.

    The issue is about:

    1. Adding a maximum page size constant EVAL_TABLE_MAX_PAGE_SIZE in src/types/api/eval.ts
    2. Using it to cap the limit parameter for non-export GET /api/eval/:id/table requests
    3. Export requests (with format=csv or format=json) should be exempt from this cap

    Let me explore the repository structure first.

  3. DeepSeek Assistant

    Let me find the relevant files. I need to look at:

    1. src/types/api/eval.ts - where the constant should be added
    2. The eval table route handler
    3. The schema validation for the table query

    Let me search for these files.

  4. DeepSeek Assistant

    Let me examine the key files - the types file, the route handler, and the schema validation

  5. DeepSeek Assistant

    Let me use bash_terminal to open the file.

  6. DeepSeek Assistant

    Now let me look at the route handler for the eval table endpoint:

  7. DeepSeek Assistant

    Let me see the full route handler, specifically the table route

  8. DeepSeek Assistant

    Let me look at the table route handler around line 311:

  9. DeepSeek Assistant

    Let me find where UNLIMITED_RESULTS is defined:

  10. DeepSeek Assistant

    Now let me look at existing tests related to the eval table route:

  11. DeepSeek Assistant

    Let me find any existing tests for the eval table route:

  12. DeepSeek Assistant

    Let me check the validation test file and the schema test file:

  13. DeepSeek Assistant

    Let me check the schema validation test and the export test:

  14. DeepSeek Assistant

    Let me check the eval export test file

  15. DeepSeek Assistant

    Now I have a clear picture. Let me implement the changes. Let me first check if there are tests I should understand around this

  16. DeepSeek Assistant

    Let me check the existing schema tests:

  17. DeepSeek Assistant

    Let me also check how the frontend uses the limit parameter and if it references any constant:

  18. DeepSeek Assistant

    Let me check the store and downloads to understand frontend usage:

  19. DeepSeek Assistant

    Now I have a complete understanding. Let me implement the changes:

    1. Add EVAL_TABLE_MAX_PAGE_SIZE = 1000 constant in src/types/api/eval.ts
    2. Modify EvalTableQuerySchema to validate limit ≤ 1000 when format is not present

    Let me start with adding the constant:

  20. DeepSeek Assistant

    Now let me add the constant and modify the schema. First, I'll add the constant:

  21. DeepSeek Assistant

    I see the JSDoc comment lost the backticks. Let me fix that and then add the .refine() to the schema:

  22. DeepSeek Assistant

    Let me use the replace command to fix the comment with backticks:

  23. DeepSeek Assistant

    Now let me add the .refine() validation to the EvalTableQuerySchema. I'll replace the closing }); of the schema with the refined version

  24. DeepSeek Assistant

    Now let me verify the changes look correct and run the relevant tests:

  25. DeepSeek Assistant

    All existing tests pass. Let me now run the eval validation tests and the export tests:

  26. DeepSeek Assistant

    All tests pass. Let me run the export tests too

  27. DeepSeek Assistant

    All tests pass. Let me now create a small verification script to confirm our changes work correctly:

  28. DeepSeek Assistant

    Let me re-run the verification with proper escaping to avoid bash issues

  29. DeepSeek Assistant

    All verification tests pass. Let me run the full test suite for the server routes to make sure nothing is broken:

  30. DeepSeek Assistant

    The 3 failing test suites are due to pre-existing native SQLite binding issues, not related to my changes. All relevant tests pass (eval.validation, eval.export, serverApiSchemas, apiSchemas.redteam).

    Let me verify the final state of my changes:

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.