gpt-4-0314· openai
Suzhen/CodeChat
func MetricReadStatusMapper(sReference interface{}, dataOld string, dataNew string)…
- User
func MetricReadStatusMapper(sReference interface{}, dataOld string, dataNew string) string {
var sReferences []map[string]interface{} json.Unmarshal([]byte(sReference.(string)), &sReferences) userReadStatus := "true,true,true,true,true,true,true,true,true" split := strings.Split(userReadStatus, ",") for _, value := range sReferences{ key := ShrimpEstateMetricKey[value["key"].(string)] statusDataOld := "good" statusDataNew := "wary" keyIndex := key.(int) splitDataOld := strings.Split(dataOld, ",")[keyIndex] for _, sReference := range sReferences { if key == sReference["key"].(string) { var reference []map[string]interface{} byteReference, _ := json.Marshal(sReference["reference"]) json.Unmarshal(byteReference, &reference) checker := false for _, refValue := range reference { var parameter []map[string]interface{} byteParameter, _ := json.Marshal(refValue["parameter"]) json.Unmarshal(byteParameter, ¶meter) for _, parValue := range parameter { convRaw, _ := strconv.ParseFloat(sReference["raw_value"].(string), 64) if !checker { statusDataOld = refValue["status"].(string) switch parValue["type"] { case "greater-than": conv, _ := strconv.ParseFloat(parValue["value"].(string), 64) if conv < convRaw { checker = true break } case "lower-than": conv, _ := strconv.ParseFloat(parValue["value"].(string), 64) if conv > convRaw { checker = true break } case "between": splitVal := strings.Split(parValue["value"].(string), "-") fConv, _ := strconv.ParseFloat(splitVal[0], 64) sConv, _ := strconv.ParseFloat(splitVal[1], 64) if fConv <= convRaw && sConv >= convRaw { checker = true break } } } } } } } splitDataNew := strings.Split(dataNew, ",")[keyIndex] for _, sReference := range sReferences { if key == sReference["key"].(string) { var reference []map[string]interface{} byteReference, _ := json.Marshal(sReference["reference"]) json.Unmarshal(byteReference, &reference) checker := false for _, refValue := range reference { var parameter []map[string]interface{} byteParameter, _ := json.Marshal(refValue["parameter"]) json.Unmarshal(byteParameter, ¶meter) for _, parValue := range parameter { convRaw, _ := strconv.ParseFloat(sReference["raw_value"].(string), 64) if !checker { statusDataNew = refValue["status"].(string) switch parValue["type"] { case "greater-than": conv, _ := strconv.ParseFloat(parValue["value"].(string), 64) if conv < convRaw { checker = true break } case "lower-than": conv, _ := strconv.ParseFloat(parValue["value"].(string), 64) if conv > convRaw { checker = true break } case "between": splitVal := strings.Split(parValue["value"].(string), "-") fConv, _ := strconv.ParseFloat(splitVal[0], 64) sConv, _ := strconv.ParseFloat(splitVal[1], 64) if fConv <= convRaw && sConv >= convRaw { checker = true break } } } } } } } if statusDataOld != statusDataNew { split[keyIndex] = "false" } } join := strings.Join(split, ",") userReadStatus = join return userReadStatus}
perbaiki kode di atas dan jadikanlah splitDataOld dan splitDataNew sebagai temporary variable
- Assistant
Untuk memperbaiki kode yang diberikan, Anda dapat mengikuti langkah-langkah berikut:
- Pertama, buatlah variabel baru
tempDataOlddantempDataNewsebelum loopingfor _, value := range sReferences. - Kemudian, Anda dapat mengatur nilai-nilai dari variabel
tempDataOlddantempDataNewdi dalam lingkaran menggunakansplitDataOlddansplitDataNew. - Setelah itu, Anda dapat menghapus semua kode yang redundan dan hanya menggunakan variabel
tempDataOlddantempDataNewuntuk perbandingan statusif statusDataOld != statusDataNew.
Berikut adalah kode yang telah diperbaiki:
func MetricReadStatusMapper(sReference interface{}, dataOld string, dataNew string) string { var sReferences []map[string]interface{} json.Unmarshal([]byte(sReference.(string)), &sReferences) userReadStatus := "true,true,true,true,true,true,true,true,true" split := strings.Split(userReadStatus, ",") for _, value := range sReferences { key := ShrimpEstateMetricKey[value["key"].(string)] keyIndex := key.(int) tempDataOld := strings.Split(dataOld, ",")[keyIndex] tempDataNew := strings.Split(dataNew, ",")[keyIndex] statusDataOld := "good" statusDataNew := "wary" for _, sReference := range sReferences { if key == sReference["key"].(string) { var reference []map[string]interface{} byteReference, _ := json.Marshal(sReference["reference"]) json.Unmarshal(byteReference, &reference) checker := false for _, refValue := range reference { var parameter []map[string]interface{} byteParameter, _ := json.Marshal(refValue["parameter"]) json.Unmarshal(byteParameter, ¶meter) for _, parValue := range parameter { convRaw, _ := strconv.ParseFloat(sReference["raw_value"].(string), 64) if !checker { if tempDataOld == refValue["status"].(string) { statusDataOld = refValue["status"].(string) } if tempDataNew == refValue["status"].(string) { statusDataNew = refValue["status"].(string) } switch parValue["type"] { case "greater-than": conv, _ := strconv.ParseFloat(parValue["value"].(string), 64) if conv < convRaw { checker = true break } case "lower-than": conv, _ := strconv.ParseFloat(parValue["value"].(string), 64) if conv > convRaw { checker = true break } case "between": splitVal := strings.Split(parValue["value"].(string), "-") fConv, _ := strconv.ParseFloat(splitVal[0], 64) sConv, _ := strconv.ParseFloat(splitVal[1], 64) if fConv <= convRaw && sConv >= convRaw { checker = true break } } } } } } } if statusDataOld != statusDataNew { split[keyIndex] = "false" } } join := strings.Join(split, ",") userReadStatus = join return userReadStatus }Dengan perubahan tersebut, kode lebih rapi dan mengurangi penggunaan sumber daya.
- Pertama, buatlah variabel baru
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.