I used this code: import time from binance.client import Client from binance.enums…
- User
I used this code: import time from binance.client import Client from binance.enums import * from binance.exceptions import BinanceAPIException import pandas as pd import requests import json import numpy as np import pytz import datetime as dt import asyncio
date = dt.datetime.now().strftime("%m/%d/%Y %H:%M:%S") print(date)
url = "https://api.binance.com/api/v1/time" t = time.time()*1000 r = requests.get(url) result = json.loads(r.content)
API keys and other configuration
API_KEY = '' API_SECRET = ''
client = Client(API_KEY, API_SECRET)
STOP_LOSS_PERCENTAGE = -50 TAKE_PROFIT_PERCENTAGE = 100 MAX_TRADE_QUANTITY_PERCENTAGE = 100 POSITION_SIDE_SHORT = 'SELL' POSITION_SIDE_LONG = 'BUY' symbol = 'BTCUSDT' quantity = 1 order_type = 'MARKET' leverage = 125 max_trade_quantity_percentage = 1
client = Client(API_KEY, API_SECRET)
def getminutedata(symbol, interval, lookback): klines = client.get_historical_trades(symbol=symbol,interval=interval, limit=lookback+1, endTime=int(time.time()*1000)) frame = pd.DataFrame(klines, columns=['Open time', 'Open', 'High', 'Low', 'Close', 'Volume', 'Close time', 'Quote asset volume', 'Number of trades', 'Taker buy base asset volume', 'Taker buy quote asset volume', 'Ignore']) frame = frame[['Open time', 'Open', 'High', 'Low', 'Close', 'Volume']] frame['Open time'] = pd.to_datetime(frame['Open time'], unit='ms').dt.tz_localize('UTC').dt.tz_convert('Etc/GMT+3') frame.set_index('Open time', inplace=True) frame.drop(frame.tail(1).index, inplace=True) # drop the last candle we fetched return frame df = getminutedata('BTCUSDT', '1m', '44640') def signal_generator(df): open = df.Open.iloc[-1] close = df.Close.iloc[-1] previous_open = df.Open.iloc[-2] previous_close = df.Close.iloc[-2]
# Bearish pattern if (open>close and previous_open<previous_close and close<previous_open and open>=previous_close): return 'sell' # Bullish pattern elif (open<close and previous_open>previous_close and close>previous_open and open<=previous_close): return 'buy' # No clear pattern else: return ''def order_execution(symbol, signal, max_trade_quantity_percentage, leverage): signal = signal_generator(df) max_trade_quantity = None account_balance = client.futures_account_balance() usdt_balance = float([x['balance'] for x in account_balance if x['asset'] == 'USDT'][0]) max_trade_quantity = usdt_balance * max_trade_quantity_percentage/100
# Close long position if signal is opposite long_position = None short_position = None positions = client.futures_position_information(symbol=symbol) for p in positions: if p['positionSide'] == 'LONG': long_position = p elif p['positionSide'] == 'SHORT': short_position = p if long_position is not None and short_position is not None: print("Multiple positions found. Closing both positions.") if long_position is not None: client.futures_create_order( symbol=symbol, side=SIDE_SELL, type=ORDER_TYPE_MARKET, quantity=long_position['positionAmt'], reduceOnly=True ) time.sleep(1) if short_position is not None: client.futures_create_order( symbol=symbol, side=SIDE_BUY, type=ORDER_TYPE_MARKET, quantity=short_position['positionAmt'], reduceOnly=True ) time.sleep(1) print("Both positions closed.") if signal == 'buy': position_side = POSITION_SIDE_LONG opposite_position = short_position elif signal == 'sell': position_side = POSITION_SIDE_SHORT opposite_position = long_position else: print("Invalid signal. No order placed.") return order_quantity = 0 if opposite_position is not None: order_quantity = min(max_trade_quantity, abs(float(opposite_position['positionAmt']))) if opposite_position is not None and opposite_position['positionSide'] != position_side: print("Opposite position found. Closing position before placing order.") client.futures_create_order( symbol=symbol, side=SIDE_SELL if opposite_position['positionSide'] == POSITION_SIDE_LONG else SIDE_BUY, type=ORDER_TYPE_MARKET, quantity=order_quantity, reduceOnly=True, positionSide=opposite_position['positionSide'] ) time.sleep(1) order = client.futures_create_order( symbol=symbol, side=SIDE_BUY if signal == 'buy' else SIDE_SELL, type=ORDER_TYPE_MARKET, quantity=order_quantity, reduceOnly=False, timeInForce=TIME_IN_FORCE_GTC, positionSide=position_side, # add position side parameter leverage=leverage ) if order is None: print("Order not placed successfully. Skipping setting stop loss and take profit orders.") return order_id = order['orderId'] print(f"Placed {signal} order with order ID {order_id} and quantity {order_quantity}") time.sleep(1) # Set stop loss and take profit orders # Get the order details to determine the order price order_info = client.futures_get_order(symbol=symbol, orderId=order_id) if order_info is None: print("Error getting order information. Skipping setting stop loss and take profit orders.") return order_price = float(order_info['avgPrice']) # Set stop loss and take profit orders stop_loss_price = order_price * (1 + STOP_LOSS_PERCENTAGE / 100) if signal == 'sell' else order_price * (1 - STOP_LOSS_PERCENTAGE / 100) take_profit_price = order_price * (1 + TAKE_PROFIT_PERCENTAGE / 100) if signal == 'buy' else order_price * (1 - TAKE_PROFIT_PERCENTAGE / 100) stop_loss_order = client.futures_create_order( symbol=symbol, side=SIDE_SELL if signal == 'buy' else SIDE_BUY, type=ORDER_TYPE_STOP_LOSS, quantity=order_quantity, stopPrice=stop_loss_price, reduceOnly=True, timeInForce=TIME_IN_FORCE_GTC, positionSide=position_side # add position side parameter ) take_profit_order = client.futures_create_order( symbol=symbol, side=SIDE_SELL if signal == 'buy' else SIDE_BUY, type=ORDER_TYPE_LIMIT, quantity=order_quantity, price=take_profit_price, reduceOnly=True, timeInForce=TIME_IN_FORCE_GTC, positionSide=position_side # add position side parameter ) # Print order creation confirmation messages print(f"Placed stop loss order with stop loss price {stop_loss_price}") print(f"Placed take profit order with take profit price {take_profit_price}") time.sleep(1)while True: current_time = dt.datetime.now().strftime("%Y-%m-%d %H:%M:%S") df = getminutedata('BTCUSDT', '1m', '44640') # Get minute data each loop if df is None: continue current_signal = signal_generator(df) print(f"The signal time is: {current_time} :{current_signal}") if current_signal: order_execution('BTCUSDT', current_signal, max_trade_quantity_percentage, leverage) time.sleep(1) # Add a delay of 1 second But I getting ERROR: 05/31/2023 09:51:47 Traceback (most recent call last): File "c:\Users\Alan.vscode\jew_bot\jew_bot\jew_bot.py", line 50, in df = getminutedata('BTCUSDT', '1m', '44640') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "c:\Users\Alan.vscode\jew_bot\jew_bot\jew_bot.py", line 41, in getminutedata klines = client.get_historical_trades(symbol=symbol,interval=interval, limit=lookback+1, endTime=int(time.time()*1000)) ~~~~~~~~^~ TypeError: can only concatenate str (not "int") to str Please tell me what I need to change
- Assistant
The
lookbackparameter in thegetminutedatafunction is being passed as a string, but it needs to be an integer. Change the line that calls the function to:df = getminutedata('BTCUSDT', '1m', 44640)This should fix the
TypeErroryou're getting. - User
How it need to seem ?
- Assistant
Change the line that calls the
getminutedatafunction to pass an integer instead of a string for thelookbackparameter:df = getminutedata('BTCUSDT', '1m', 44640)This should fix the
TypeErroryou're getting. - User
How it need to seem ? I can't understand
- Assistant
You need to change the line that calls the
getminutedatafunction by passing an integer instead of a string for thelookbackparameter. The line should look like this:df = getminutedata('BTCUSDT', '1m', 44640)This means instead of passing the value of
'44640'as a string to thelookbackparameter, you pass the integer44640. - User
Oay, I did it , but I getting ERROR: 05/31/2023 09:57:24 Traceback (most recent call last): File "c:\Users\Alan.vscode\jew_bot\jew_bot\jew_bot.py", line 50, in df = getminutedata('BTCUSDT', '1m', 44640) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "c:\Users\Alan.vscode\jew_bot\jew_bot\jew_bot.py", line 42, in getminutedata frame = pd.DataFrame(klines, columns=['Open time', 'Open', 'High', 'Low', 'Close', 'Volume', 'Close time',
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\Alan\AppData\Roaming\Python\Python311\site-packages\pandas\core\frame.py", line 817, in init raise ValueError("DataFrame constructor not properly called!") ValueError: DataFrame constructor not properly called! sys:1: RuntimeWarning: coroutine 'ClientBase._request' was never awaited - Assistant
It looks like there is an issue with the
DataFrameconstructor in thegetminutedatafunction. The error message suggests that it was not properly called. One issue may be that the column names in the constructor do not match the number and names of columns inklines.To fix this error, try changing the column names in the
DataFrameconstructor to match the actual column names inklines. You can print outklinesto see what the column names are.Regarding the
RuntimeWarning, it may be related to thetime.sleep(1)calls in the code. Try removing them to see if the warning goes away. If it persists, you may need to useasyncioproperly to await coroutines. - User
Please give me right line of code
- Assistant
Change the following line in the
getminutedatafunction:frame = pd.DataFrame(klines, columns=['Open time', 'Open', 'High', 'Low', 'Close', 'Volume', 'Close time', 'Quote asset volume', 'Number of trades', 'Taker buy base asset volume', 'Taker buy quote asset volume', 'Ignore'])To:
frame = pd.DataFrame(klines, columns=['id', 'price', 'qty', 'time', 'isBuyerMaker', 'isBestMatch'])This should fix the
ValueErroryou're getting, assuming thatklineshas columns with these names.Regarding the
RuntimeWarning, you can try commenting out thetime.sleep(1)calls in the code to see if the warning goes away.