Skip to content
TheChatArchiveThe Chat Archive
gpt-4-0314· openaiHugging Face Suzhen/CodeChat

como puedo refactorizar este metodo para crear un metodo que pueda ser llamado cada vez…

  1. User

    como puedo refactorizar este metodo para crear un metodo que pueda ser llamado cada vez que creo una ficha nueva graficamente: "private void GenerateScreenBoard() { Vector2 screenSize = new Vector2(Screen.width, Screen.height); Debug.Log(screenSize);

        float iconSize = 50f;
        float spacing = 15f;
    
        float tableWidth = 6 * (iconSize + spacing) - spacing;
        float tableHeight = 6 * (iconSize + spacing) - spacing;
        Vector2 tablePosition = (screenSize - new Vector2(tableWidth, tableHeight)) / 2f;
    
        List<Vector2> iconPositions = new List<Vector2>();
        List<Vector2> iconWorldPositions = new List<Vector2>();
        for (int row = 0; row < 6; row++)
        {
            for (int col = 0; col < 6; col++)
            {
                float x = tablePosition.x + col * (iconSize + spacing);
                float y = tablePosition.y + row * (iconSize + spacing);
                iconPositions.Add(new Vector2(x, y));
            }
        }
    
        //tranlate to world position
        foreach (var iconPosition in iconPositions)
        {
            Vector2 iconWorldPosition = Camera.main.ScreenToWorldPoint(new Vector3(iconPosition.x, iconPosition.y, 0));
            iconWorldPositions.Add(iconWorldPosition);
        }
    
        Debug.Log(string.Join(Environment.NewLine, iconWorldPositions.Select(p => p.ToString())));
    
        //create icons with _board data
        for (int row = 0; row < 6; row++)
        {
            for (int col = 0; col < 6; col++)
            {
                var rowi = 5 - row;
                int index = rowi * 6 + col;
                Vector2 iconWorldPosition = iconWorldPositions[index];
                char icon = _board[row][col];
                int spriteIndex = Array.IndexOf(G, icon);
                GameObject newPiece = Instantiate(gemPrefab, iconWorldPosition, Quaternion.identity);
                newPiece.transform.parent = transform;
                newPiece.name = $"Piece_{row}_{col}";
                Position pos = new Position();
                pos.row = row;
                pos.col = col;
                pos.x = iconWorldPosition.x;
                pos.y = iconWorldPosition.y;
                positions.Add(pos);
                newPiece.GetComponent<SpriteRenderer>().sprite = sprites[spriteIndex];
            }
        }
    }"
    
  2. Assistant

    Puedes refactorizar este método dividiendo la funcionalidad en varios métodos más pequeños que realicen tareas específicas. Un enfoque podría ser tener métodos separados para calcular las posiciones de los íconos y para crear las fichas.

    Así es como podría verse el código refactorizado:

    private void GenerateScreenBoard()
    {
        Vector2 screenSize = new Vector2(Screen.width, Screen.height);
        Debug.Log(screenSize);
        
        float iconSize = 50f;
        float spacing = 15f;
    
        float tableWidth = 6 * (iconSize + spacing) - spacing;
        float tableHeight = 6 * (iconSize + spacing) - spacing;
        Vector2 tablePosition = (screenSize - new Vector2(tableWidth, tableHeight)) / 2f;
    
        List<Vector2> iconPositions = CalculateIconPositions(tablePosition, iconSize, spacing);
        List<Vector2> iconWorldPositions = CalculateIconWorldPositions(iconPositions);
    
        CreateIcons(iconWorldPositions);
    }
    
    private List<Vector2> CalculateIconPositions(Vector2 tablePosition, float iconSize, float spacing)
    {
        List<Vector2> iconPositions = new List<Vector2>();
        for (int row = 0; row < 6; row++)
        {
            for (int col = 0; col < 6; col++)
            {
                float x = tablePosition.x + col * (iconSize + spacing);
                float y = tablePosition.y + row * (iconSize + spacing);
                iconPositions.Add(new Vector2(x, y));
            }
        }
    
        return iconPositions;
    }
    
    private List<Vector2> CalculateIconWorldPositions(List<Vector2> iconPositions)
    {
        List<Vector2> iconWorldPositions = new List<Vector2>();
        foreach (var iconPosition in iconPositions)
        {
            Vector2 iconWorldPosition = Camera.main.ScreenToWorldPoint(new Vector3(iconPosition.x, iconPosition.y, 0));
            iconWorldPositions.Add(iconWorldPosition);
        }
    
        return iconWorldPositions;
    }
    
    private void CreateIcons(List<Vector2> iconWorldPositions)
    {
        //create icons with _board data
        for (int row = 0; row < 6; row++)
        {
            for (int col = 0; col < 6; col++)
            {
                var rowi = 5 - row;
                int index = rowi * 6 + col;
                Vector2 iconWorldPosition = iconWorldPositions[index];
                char icon = _board[row][col];
                int spriteIndex = Array.IndexOf(G, icon);
                GameObject newPiece = Instantiate(gemPrefab, iconWorldPosition, Quaternion.identity);
                newPiece.transform.parent = transform;
                newPiece.name = $"Piece_{row}_{col}";
                Position pos = new Position();
                pos.row = row;
                pos.col = col;
                pos.x = iconWorldPosition.x;
                pos.y = iconWorldPosition.y;
                positions.Add(pos);
                newPiece.GetComponent<SpriteRenderer>().sprite = sprites[spriteIndex];
            }
        }
    }
    

    Ahora, el método principal GenerateScreenBoard() se ha vuelto más fácil de leer y comprender, ya que delega el trabajo a métodos más pequeños que realizan tareas específicas. Esto también facilitará la modificación y el mantenimiento del código en el futuro.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.