Download of 01.11.2023.xlsx was not completed.…
- User
Download of 01.11.2023.xlsx was not completed.
ElementClickInterceptedException Traceback (most recent call last) Cell In[11], line 19 16 next_date = min(end_of_month, end_date)
18 # Вызвать функцию download_file ---> 19 download_file(current_date, next_date) 21 # Найти новую стартовую дату 22 current_date = next_date + timedelta(days=1)Cell In[10], line 15, in download_file(date1, date2) 12 new_file_name = os.path.join(download_dir, file_name) 14 # Вызвать функцию с датами date1 и date2 ---> 15 select_range_in_calendar(date1, date2)
17 # Подождать, пока сформируется выгрузка в Reporting 18 time.sleep(10)Cell In[8], line 4, in select_range_in_calendar(date1, date2) 2 def select_range_in_calendar(date1, date2):
3 # Вызвать календарь ----> 4 driver.find_element(By.CSS_SELECTOR, 'input.dates-container.form-control').click() 6 # Определить левую часть календаря 7 driver.find_element(By.CSS_SELECTOR, '.drp-calendar.left').click()File ~\AppData\Local\anaconda3\Lib\site-packages\selenium\webdriver\remote\webelement.py:93, in WebElement.click(self) 91 def click(self) -> None: 92 """Clicks the element.""" ---> 93 self._execute(Command.CLICK_ELEMENT)
File ~\AppData\Local\anaconda3\Lib\site-packages\selenium\webdriver\remote\webelement.py:394, in WebElement._execute(self, command, params) 392 params = {} 393 params["id"] = self._id --> 394 return self._parent.execute(command, params)
File ~\AppData\Local\anaconda3\Lib\site-packages\selenium\webdriver\remote\webdriver.py:347, in WebDriver.execute(self, driver_command, params) 345 response = self.command_executor.execute(driver_command, params) 346 if response: --> 347 self.error_handler.check_response(response) 348 response["value"] = self._unwrap_value(response.get("value", None)) 349 return response
File ~\AppData\Local\anaconda3\Lib\site-packages\selenium\webdriver\remote\errorhandler.py:229, in ErrorHandler.check_response(self, response) 227 alert_text = value["alert"].get("text") 228 raise exception_class(message, screen, stacktrace, alert_text) # type: ignore[call-arg] # mypy is not smart enough here --> 229 raise exception_class(message, screen, stacktrace) Modify the code to fix that
- Assistant
To fix the ElementClickInterceptedException, you can try the following modifications:
- Add a wait before clicking the element to ensure it is clickable:
from selenium.webdriver.support.ui import WebDriverWait from selenium.webdriver.support import expected_conditions as EC from selenium.webdriver.common.by import By def select_range_in_calendar(date1, date2): # Locate the element calendar_input = driver.find_element(By.CSS_SELECTOR, 'input.dates-container.form-control') # Wait until the element is clickable wait = WebDriverWait(driver, 10) calendar_input = wait.until(EC.element_to_be_clickable((By.CSS_SELECTOR, 'input.dates-container.form-control'))) # Click the element calendar_input.click()- You can try scrolling the element into view before clicking it:
def select_range_in_calendar(date1, date2): # Locate the element calendar_input = driver.find_element(By.CSS_SELECTOR, 'input.dates-container.form-control') # Scroll the element into view driver.execute_script("arguments[0].scrollIntoView();", calendar_input) # Click the element calendar_input.click()Try using one of these modifications and see if it resolves the issue.
- User
Check the code. Maybe, some improvement is required
Определить функцию для выбора даты
def select_date_in_calendar(date): # Выделить день, месяц и год из даты day = date.day month = date.month year = date.year
# Выбрать нужный месяц в календаре monthselect = driver.find_element(By.CLASS_NAME, 'monthselect') monthselect.find_element(By.CSS_SELECTOR, f"option[value='{int(month)-1}']").click() # Выбрать нужный год в календаре yearselect = driver.find_element(By.CLASS_NAME, 'yearselect') yearselect.find_element(By.CSS_SELECTOR, f"option[value='{year}']").click() # Определить data-title (можно сказать, идентификатор) для нужного дня в календаре html = driver.page_source soup = BeautifulSoup(html, 'html.parser') days = soup.find_all('td', class_=['available', 'weekend available']) for day_s in days: if int(day_s.text) == day: data_title = day_s['data-title'] break # Выбрать нужный день в календаре driver.find_element(By.CSS_SELECTOR, f"td[data-title='{data_title}']").click() - Assistant
The code seems fine and should work correctly. However, one potential improvement could be to use a more specific CSS selector when selecting the day in the calendar. Instead of using
td[data-title='{data_title}'], you can usetd[data-title='{data_title}'] > ato select the anchor element inside the table cell. This can help improve the robustness of the code by directly clicking on the anchor element rather than the table cell.Here's the modified code for selecting the day in the calendar:
# Выбрать нужный день в календаре driver.find_element(By.CSS_SELECTOR, f"td[data-title='{data_title}'] > a").click()This modification ensures that the click action is performed on the anchor element associated with the day, rather than the table cell itself.
- User
Check the other part of code
Определить функцию для выбора диапазона дат и вывода данных для заданного диапазона дат
def select_range_in_calendar(date1, date2):
# Вызвать календарь driver.find_element(By.CSS_SELECTOR, 'input.dates-container.form-control').click()# Определить левую часть календаря driver.find_element(By.CSS_SELECTOR, '.drp-calendar.left').click() wait = WebDriverWait(driver, 5) wait.until(EC.visibility_of_element_located((By.CSS_SELECTOR, '.drp-calendar.left'))) # Отменить выбор изначально выбранной даты driver.find_element(By.XPATH, "//td[contains(@class, 'active start-date available in-range')]").click() # Выбрать начальную и конечную дату select_date_in_calendar(date1) select_date_in_calendar(date2) # Нажать на кнопку Выбор driver.find_element(By.XPATH, "//button[contains(text(), 'Выбор')]").click() # Нажать на кнопку Обновить driver.find_element(By.XPATH, "//button[contains(text(), 'Обновить ')]").click() - Assistant
The code for selecting the date range and clicking the buttons looks good. However, there are a couple of improvements you can make to enhance the code's reliability:
-
Use explicit waits: Instead of using fixed time delays like
time.sleep(), it's better to use explicit waits usingWebDriverWaitto ensure that the elements are available before interacting with them. -
Improve the precision of the CSS selectors: Instead of using generic class selectors like
drp-calendar.left, you can make the selectors more specific by using unique IDs or more precise class selectors if available.
Here's the modified code with these improvements:
from selenium.webdriver.support.ui import WebDriverWait from selenium.webdriver.support import expected_conditions as EC def select_range_in_calendar(date1, date2): # Wait until the calendar input is clickable wait = WebDriverWait(driver, 10) calendar_input = wait.until(EC.element_to_be_clickable((By.CSS_SELECTOR, 'input.dates-container.form-control'))) # Click the calendar input calendar_input.click() # Wait for the left calendar to be visible wait.until(EC.visibility_of_element_located((By.CSS_SELECTOR, '#leftCalendar'))) # Find and click the start date start_date = driver.find_element(By.CSS_SELECTOR, '#leftCalendar .start-date') start_date.click() # Select the start and end dates select_date_in_calendar(date1) select_date_in_calendar(date2) # Click the "Select" button select_button = driver.find_element(By.XPATH, "//button[contains(text(), 'Выбор')]") select_button.click() # Click the "Обновить" button update_button = driver.find_element(By.XPATH, "//button[contains(text(), 'Обновить')]") update_button.click()These modifications make the code more reliable by using explicit waits and more precise CSS selectors.
-
- User
Check this function
Определить функцию для проверки, полностью ли скачан файл
def is_download_complete(filename): # Первоначальный размер файла prev_size = -1
while True: time.sleep(10) # Текущий размер файла curr_size = os.path.getsize(filename) # Если размер файла не изменился, то скачивание завершено if curr_size == prev_size: return True # Обновить размер файла для следующей итерации prev_size = curr_size - Assistant
The
is_download_completefunction checks if the file download is complete by comparing the previous file size with the current file size after a delay of 10 seconds.While the function seems reasonable, there are a few improvements you can make:
-
Add a maximum number of retries: To avoid getting stuck in an infinite loop if the file size doesn't change for some reason, you can introduce a maximum number of retries. If the file size doesn't change within the specified number of retries, you can assume that the download is complete.
-
Handle exceptions: The current implementation doesn't handle any exceptions that may occur during file size retrieval. It's a good practice to add exception handling to handle possible exceptions like
FileNotFoundError.
Here's an updated version of the function that includes these improvements:
import time import os def is_download_complete(filename, max_retries=10, delay=10): prev_size = -1 retries = 0 while retries < max_retries: time.sleep(delay) try: curr_size = os.path.getsize(filename) except FileNotFoundError: curr_size = -1 if curr_size == prev_size: return True prev_size = curr_size retries += 1 return FalseIn this updated version, the function allows a maximum of 10 retries with a delay of 10 seconds between each retry. If the file size remains the same for 10 consecutive retries, the function returns
False, indicating that the download may not be complete. -
- User
Check this code
Определить функцию для выгрузки данных в формате Excel и для переименования файла
def download_file(date1, date2): # Выделить день, месяц и год из даты date1
day = date1.strftime("%d") month = date1.strftime("%m") year = date1.year# Определить имя файла file_name = f"{day}.{month}.{year}{data_extension}" # Определить путь и новое название файла new_file_name = os.path.join(download_dir, file_name) # Вызвать функцию с датами date1 и date2 select_range_in_calendar(date1, date2) # Подождать, пока сформируется выгрузка в Reporting time.sleep(10) # Нажать кнопку для скачивания файла driver.find_element(By.XPATH, f"//button[contains(text(), '{data_format}')]").click() # Подождать, пока файл будет полностью скачан while not is_download_complete(current_file_name): time.sleep(1) # Rename the file os.rename(current_file_name, new_file_name) - Assistant
The code for downloading the file and renaming it looks good and should work correctly. However, there is a small issue in the code.
In the
download_filefunction, there is a variablecurrent_file_nameused in thewhileloop to check if the download is complete. However, this variable is not defined in the code snippet.To fix this, you should replace
current_file_namewithnew_file_namein thewhileloop:# Подождать, пока файл будет полностью скачан while not is_download_complete(new_file_name): time.sleep(1)This modification ensures that the correct
new_file_nameis used to check if the download is complete.