I will provide you disassembly from a computer game that runs in MS-DOS. The game was…
- User
I will provide you disassembly from a computer game that runs in MS-DOS. The game was written in C with a Watcom compiler. Some library function calls are already identified. Explain the functions I give to you and suggest names and C-language function signatures for them, including which parameters map to which registers or stack values. Also suggest names for global values if you have enough context to do so. FUN_00050069 is a function that exits the game with an error message.
FUN_0008dce3 PUSH EBP MOV EBP,ESP PUSH ECX PUSH ESI PUSH EDI SUB ESP,0x18 MOV dword ptr [EBP + local_28],EAX MOV dword ptr [EBP + local_24],EDX MOV dword ptr [EBP + local_20],EBX MOV EBX,dword ptr [EBP + local_20] MOV EDX,dword ptr [EBP + local_24] MOV EAX,dword ptr [EBP + local_28] MOV EAX,dword ptr [EAX + 0x3f] CALL FUN_0008db21 MOV dword ptr [EBP + local_1c],EAX MOV EAX,dword ptr [EBP + local_28] MOV EDX,dword ptr [EBP + local_1c] MOV dword ptr [EDX + 0x43],EAX MOV EAX,dword ptr [EBP + local_1c] MOV dword ptr [EBP + local_18],EAX LAB_0008dd1b CMP dword ptr [EBP + local_18],0x0 JZ LAB_0008dd35 MOV EAX,dword ptr [EBP + local_18] MOV EDX,dword ptr [EBP + local_28] MOV dword ptr [EDX + 0x3f],EAX MOV EAX,dword ptr [EBP + local_18] MOV EAX,dword ptr [EAX + 0x3b] MOV dword ptr [EBP + local_18],EAX JMP LAB_0008dd1b LAB_0008dd35 MOV EAX,dword ptr [EBP + local_1c] MOV dword ptr [EBP + local_14],EAX MOV EAX,dword ptr [EBP + local_14] LEA ESP=>local_10,[EBP + -0xc] POP EDI POP ESI POP ECX POP EBP RET
FUN_0008db21 PUSH EBP MOV EBP,ESP PUSH ECX PUSH ESI PUSH EDI SUB ESP,0x18 MOV dword ptr [EBP + local_28],EAX MOV dword ptr [EBP + local_24],EDX MOV dword ptr [EBP + local_20],EBX MOV EAX,dword ptr [EBP + local_20] ADD EAX,0x47 MOV dword ptr [EBP + local_1c],EAX MOV EAX,dword ptr [EBP + local_1c] ADD EAX,0x12 SUB dword ptr [DAT_001a9b38],EAX MOV EDX,dword ptr [EBP + local_1c] MOV EAX,DAT_00195e18 CALL FUN_00069f8a MOV dword ptr [EBP + local_18],EAX CMP dword ptr [EBP + local_18],0x0 JNZ LAB_0008db6b MOV EAX,s_Unable_to_allocate_OBJECT_memory_00176e70 = "Unable to allocate OBJECT memory." CALL FUN_00050069 LAB_0008db6b CMP dword ptr [EBP + local_24],0x0 JZ LAB_0008dbd0 PUSH 0x4 PUSH 0xa3 MOV ECX,s_object.c_00176e44 = "object.c" MOV EBX,0x37 MOV EDX,dword ptr [EBP + local_24] MOV EAX,dword ptr [EBP + local_18] CALL FUN_000a1023 PUSH 0x4 PUSH 0xa4 MOV ECX,s_object.c_00176e44 = "object.c" MOV EBX,dword ptr [EBP + local_1c] SUB EBX,0x47 MOV EDX,dword ptr [EBP + local_24] ADD EDX,0x47 MOV EAX,dword ptr [EBP + local_18] ADD EAX,0x47 CALL FUN_000a1023 PUSH 0x4 PUSH 0xa5 MOV ECX,s_object.c_00176e44 = "object.c" MOV EBX,0x10 XOR EDX,EDX MOV EAX,dword ptr [EBP + local_18] ADD EAX,0x37 CALL FUN_000a0040 JMP LAB_0008dbfb LAB_0008dbd0 PUSH 0x4 PUSH 0xa9 MOV ECX,s_object.c_00176e44 = "object.c" MOV EBX,dword ptr [EBP + local_1c] XOR EDX,EDX MOV EAX,dword ptr [EBP + local_18] CALL FUN_000a0040 MOV EAX,0x1 CALL FUN_0008eb88 MOV EDX,EAX MOV EAX,dword ptr [EBP + local_18] MOV dword ptr [EAX + 0x1f],EDX LAB_0008dbfb CMP dword ptr [EBP + local_28],0x0 JZ LAB_0008dc0c MOV EDX,dword ptr [EBP + local_18] MOV EAX,dword ptr [EBP + local_28] CALL FUN_0008e09a LAB_0008dc0c MOV EAX,dword ptr [EBP + local_18] MOV dword ptr [EBP + local_14],EAX MOV EAX,dword ptr [EBP + local_14] LEA ESP=>local_10,[EBP + -0xc] POP EDI POP ESI POP ECX POP EBP RET
FUN_00069f8a PUSH EBP MOV EBP,ESP PUSH EBX PUSH ECX PUSH ESI PUSH EDI SUB ESP,0x18 MOV dword ptr [EBP + local_2c],EAX MOV dword ptr [EBP + local_28],EDX MOV EAX,dword ptr [EBP + local_28] INC EAX AND AL,0xfe MOV dword ptr [EBP + local_1c],EAX ADD dword ptr [EBP + local_1c],0x12 MOV EAX,dword ptr [EBP + local_2c] MOV EAX,dword ptr [EAX + 0x4] MOV dword ptr [EBP + local_24],EAX LAB_00069fb3 CMP dword ptr [EBP + local_24],0x0 JZ LAB_00069fea MOV EAX,dword ptr [EBP + local_24] MOV EAX,dword ptr [EAX + 0xc] CMP EAX,dword ptr [EBP + local_1c] JL LAB_00069fd5 MOV EAX,dword ptr [EBP + local_24] MOV AX,word ptr [EAX + 0x10] AND EAX,0x1 CWDE TEST EAX,EAX JZ LAB_00069fe6 LAB_00069fd5 MOV EAX,dword ptr [EBP + local_24] MOV dword ptr [EBP + local_20],EAX MOV EAX,dword ptr [EBP + local_24] MOV EAX,dword ptr [EAX + 0x4] MOV dword ptr [EBP + local_24],EAX JMP LAB_00069fe8 LAB_00069fe6 JMP LAB_00069fea LAB_00069fe8 JMP LAB_00069fb3 LAB_00069fea CMP dword ptr [EBP + local_24],0x0 JNZ LAB_00069ffc MOV dword ptr [EBP + local_18],0x0 JMP LAB_0006a098 LAB_00069ffc MOV EAX,dword ptr [EBP + local_24] MOV EAX,dword ptr [EAX + 0xc] CMP EAX,dword ptr [EBP + local_1c] JZ LAB_0006a05d MOV EAX,dword ptr [EBP + local_24] ADD EAX,dword ptr [EBP + local_1c] MOV dword ptr [EBP + local_20],EAX MOV EAX,dword ptr [EBP + local_24] MOV EDX,dword ptr [EAX + 0x4] MOV EAX,dword ptr [EBP + local_20] MOV dword ptr [EAX + 0x4],EDX MOV EAX,dword ptr [EBP + local_24] MOV EDX,dword ptr [EBP + local_20] MOV dword ptr [EDX + 0x8],EAX MOV EAX,dword ptr [EBP + local_24] MOV EAX,dword ptr [EAX + 0xc] SUB EAX,dword ptr [EBP + local_1c] MOV EDX,dword ptr [EBP + local_20] MOV dword ptr [EDX + 0xc],EAX MOV EAX,dword ptr [EBP + local_20] MOV word ptr [EAX + 0x10],0x0 MOV EAX,dword ptr [EBP + local_20] MOV dword ptr [EAX],0x69696969 MOV EAX,dword ptr [EBP + local_20] CMP dword ptr [EAX + 0x4],0x0 JZ LAB_0006a05b MOV EAX,dword ptr [EBP + local_20] MOV EDX,dword ptr [EAX + 0x4] MOV EAX,dword ptr [EBP + local_20] MOV dword ptr [EDX + 0x8],EAX LAB_0006a05b JMP LAB_0006a06a LAB_0006a05d MOV EAX,dword ptr [EBP + local_24] MOV EAX,dword ptr [EAX + 0x4] MOV dword ptr [EBP + local_20],EAX ADD dword ptr [EBP + local_1c],0x12 LAB_0006a06a MOV EAX,dword ptr [EBP + local_20] MOV EDX,dword ptr [EBP + local_24] MOV dword ptr [EDX + 0x4],EAX MOV EAX,dword ptr [EBP + local_1c] SUB EAX,0x12 MOV EDX,dword ptr [EBP + local_24] MOV dword ptr [EDX + 0xc],EAX MOV EAX,dword ptr [EBP + local_24] OR byte ptr [EAX + 0x10],0x1 MOV EAX,dword ptr [EBP + local_24] MOV dword ptr [EAX],0x69696969 MOV EAX,dword ptr [EBP + local_24] ADD EAX,0x12 MOV dword ptr [EBP + local_18],EAX LAB_0006a098 MOV EAX,dword ptr [EBP + local_18] LEA ESP=>local_14,[EBP + -0x10] POP EDI POP ESI POP ECX POP EBX POP EBP RET
FUN_000a1023 PUSH EBP MOV EBP,ESP PUSH ESI PUSH EDI PUSH EAX MOV EDI,EAX MOV dword ptr [EBP + local_10],EDX MOV ESI,EBX PUSH ECX PUSH dword ptr [EBP + Stack[0x4]] PUSH dword ptr [EBP + Stack[0x8]] CALL FUN_000a0f39 MOV EBX,ESI MOV EDX,dword ptr [EBP + local_10] MOV EAX,EDI CALL FUN_000a71e9 LEA ESP=>local_c,[EBP + -0x8] POP EDI POP ESI POP EBP RET 0x8
FUN_000a0f39 PUSH EBP MOV EBP,ESP PUSH dword ptr [EBP + Stack[0xc]] PUSH dword ptr [EBP + Stack[0x8]] CALL FUN_000a0ed9 CMP byte ptr [DAT_00188aad],0x1 JNZ LAB_000a0f58 MOV EAX,dword ptr [EBP + Stack[0x4]] MOV [DAT_00188aba],EAX LAB_000a0f58 POP EBP RET 0xc
FUN_000a71e9 PUSH EBP MOV EBP,ESP PUSH ECX PUSH ESI PUSH EDI PUSH EAX MOV ESI,EAX MOV EDI,EDX MOV dword ptr [EBP + local_14],EBX MOV EAX,0x11 CALL FUN_000a3580 CALL FUN_000a3477 TEST AL,AL JZ LAB_000a721d PUSH ESI PUSH EDI PUSH dword ptr [EBP + local_14] PUSH 0x4 PUSH 0x8011 PUSH 0x0 CALL FUN_000a89e8 LAB_000a721d MOV EBX,dword ptr [EBP + local_14] MOV EDX,EDI MOV EAX,ESI CALL memcpy MOV ESI,EAX CALL FUN_000a3594 MOV EAX,ESI LEA ESP=>local_10,[EBP + -0xc] POP EDI POP ESI POP ECX POP EBP RET
- Assistant
FUN_0008dce3: This function seems to be adding a new object to a linked list. It first calls FUN_0008db21 to allocate memory for a new object, then updates the previous object's next pointer to the new object, and iterates through the list until it reaches the end.
Suggested name: addObjectToList
Suggested signature:
void addObjectToList(Object *newObject, Object *listHead);Where EAX maps to newObject and EDX maps to listHead.
Global values: None identified.
FUN_0008db21: This function allocates memory for a new object and initializes its memory. If the second input parameter (EDX) is non-zero, it also copies some data from the input object to the newly allocated object.
Suggested name: allocateAndInitializeObject
Suggested signature:
Object* allocateAndInitializeObject(int object_offset, Object *inputObject);Where EAX maps to object_offset and EDX maps to inputObject.
Global values: None identified.
FUN_00069f8a: This function seems to allocate memory from a memory pool (DAT_001a9b38) based on the size requested by input parameter EDX, and returns a pointer to the allocated memory.
Suggested name: allocateMemoryFromPool
Suggested signature:
void* allocateMemoryFromPool(int pool, int size);Where EAX maps to pool and EDX maps to size.
Global values:
- DAT_001a9b38: Memory pool
FUN_000a1023: This function appears to log the memory address allocated to an object.
Suggested name: logMemoryAllocation
Suggested signature:
void logMemoryAllocation(void *address, int size, const char *filename, int line);Where: EAX maps to address, EDX maps to size, ECX maps to filename, and EBX maps to line.
Global values: None identified.
FUN_000a0f39: This function seems to be a wrapper for FUN_000a0ed9 (which is not provided), and possibly logs information depending on the value of DAT_00188aad.
Suggested name: logWrapper
Suggested signature:
void logWrapper(int arg1, int arg2, int arg3);Where: [__Stack+0x4] maps to arg1, [__Stack+0x8] maps to arg2, and [__Stack+0xc] maps to arg3.
Global values:
- DAT_00188aad: Log flag
- DAT_00188aba: Log data
FUN_000a71e9: This function appears to copy data from one memory location to another (using memcpy) and performs some checks and additional operations using FUN_000a3580, FUN_000a3477, and FUN_000a3594 (which are not provided).
Suggested name: copyMemoryWithChecks
Suggested signature:
void* copyMemoryWithChecks(void *destination, void *source, size_t size);Where: EAX maps to destination, EDX maps to source, and EBX maps to size.
Global values: None identified.
- User
Do the same for the following functions. Also, with this new information, re-examine the previous functions and, if necessary, revise your previous answer.
FUN_000a0040 PUSH EBP MOV EBP,ESP PUSH ESI PUSH EDI PUSH EAX MOV EDI,EAX MOV dword ptr [EBP + local_10],EDX MOV ESI,EBX PUSH ECX PUSH dword ptr [EBP + Stack[0x4]] PUSH dword ptr [EBP + Stack[0x8]] CALL FUN_000a0f39 MOV EBX,ESI MOV EDX,dword ptr [EBP + local_10] MOV EAX,EDI CALL FUN_000a1944 POP EDI POP ESI POP EBP RET 0x8
FUN_000a1944 PUSH EBP MOV EBP,ESP PUSH ECX PUSH ESI PUSH EDI PUSH EAX MOV EDI,EAX MOV dword ptr [EBP + local_14],EDX MOV ESI,EBX PUSH 0x13 CALL FUN_000a34b8 CALL FUN_000a3477 TEST AL,AL JZ LAB_000a1971 PUSH EDI PUSH -0x6 PUSH ESI PUSH 0x4 PUSH 0x13 PUSH 0x0 CALL FUN_000a89e8 LAB_000a1971 MOV EBX,ESI MOV EDX,dword ptr [EBP + local_14] MOV EAX,EDI CALL memset MOV ESI,EAX CALL FUN_000a351e MOV EAX,ESI LEA ESP=>local_10,[EBP + -0xc] POP EDI POP ESI POP ECX POP EBP RET
FUN_0008eb88 PUSH EBP MOV EBP,ESP PUSH EBX PUSH ECX PUSH EDX PUSH ESI PUSH EDI SUB ESP,0xc MOV dword ptr [EBP + local_24],EAX CMP dword ptr [DAT_00187fdc],0xf618 JL LAB_0008ebaf MOV dword ptr [DAT_00187fdc],0x2710 LAB_0008ebaf MOV EAX,dword ptr [EBP + local_24] SHL EAX,0x10 MOV EDX,dword ptr [DAT_00187fdc] INC dword ptr [DAT_00187fdc] ADD EAX,EDX MOV dword ptr [EBP + local_20],EAX MOV EDX,dword ptr [EBP + local_20] MOV EAX,[DAT_00195ac4] CALL FUN_0008e925 TEST EAX,EAX JNZ LAB_0008ebe8 MOV EDX,dword ptr [EBP + local_20] MOV EAX,[DAT_001959a8] CALL FUN_0008e925 TEST EAX,EAX JZ LAB_0008ebea LAB_0008ebe8 JMP LAB_0008ebaf LAB_0008ebea MOV EAX,dword ptr [EBP + local_20] MOV dword ptr [EBP + local_1c],EAX MOV EAX,dword ptr [EBP + local_1c] LEA ESP=>local_18,[EBP + -0x14] POP EDI POP ESI POP EDX POP ECX POP EBX POP EBP RET
FUN_0008e925 PUSH EBP MOV EBP,ESP PUSH EBX PUSH ECX PUSH ESI PUSH EDI SUB ESP,0xc MOV dword ptr [EBP + local_20],EAX MOV dword ptr [EBP + local_1c],EDX MOV EAX,dword ptr [EBP + local_1c] MOV [DAT_001a9b18],EAX MOV dword ptr [DAT_001a9b14],0x0 CMP dword ptr [EBP + local_20],0x0 JNZ LAB_0008e99f MOV EDX,FUN_0008e8e9 MOV EAX,[DAT_00195ac4] CALL FUN_0008e3f7 MOV EAX,[DAT_001a9b14] MOV [DAT_00199770],EAX CMP dword ptr [DAT_001a9b14],0x0 JZ LAB_0008e97c MOV EAX,[DAT_001a9b14] MOV dword ptr [EBP + local_18],EAX JMP LAB_0008e9b4 LAB_0008e97c MOV EDX,FUN_0008e8e9 MOV EAX,[DAT_001959a8] CALL FUN_0008e3f7 MOV EAX,[DAT_001a9b14] MOV [DAT_00199770],EAX MOV EAX,[DAT_001a9b14] MOV dword ptr [EBP + local_18],EAX JMP LAB_0008e9b4 LAB_0008e99f MOV EDX,FUN_0008e8e9 MOV EAX,dword ptr [EBP + local_20] CALL FUN_0008e55f MOV EAX,[DAT_001a9b14] MOV dword ptr [EBP + local_18],EAX LAB_0008e9b4 MOV EAX,dword ptr [EBP + local_18] LEA ESP=>local_14,[EBP + -0x10] POP EDI POP ESI POP ECX POP EBX POP EBP RET
FUN_0008e3f7 PUSH EBP MOV EBP,ESP PUSH EBX PUSH ECX PUSH ESI PUSH EDI SUB ESP,0xc MOV dword ptr [EBP + local_20],EAX MOV dword ptr [EBP + local_1c],EDX LAB_0008e40a CMP dword ptr [EBP + local_20],0x0 JZ LAB_0008e43e MOV EAX,dword ptr [EBP + local_20] MOV EAX,dword ptr [EAX + 0x37] MOV dword ptr [EBP + local_18],EAX MOV EAX,dword ptr [EBP + local_20] CMP dword ptr [EAX + 0x3f],0x0 JZ LAB_0008e430 MOV EDX,dword ptr [EBP + local_1c] MOV EAX,dword ptr [EBP + local_20] MOV EAX,dword ptr [EAX + 0x3f] CALL FUN_0008e3f7 LAB_0008e430 MOV EAX,dword ptr [EBP + local_20] CALL dword ptr [EBP + local_1c] MOV EAX,dword ptr [EBP + local_18] MOV dword ptr [EBP + local_20],EAX JMP LAB_0008e40a LAB_0008e43e LEA ESP=>local_14,[EBP + -0x10] POP EDI POP ESI POP ECX POP EBX POP EBP RET
FUN_0008e55f PUSH EBP MOV EBP,ESP PUSH EBX PUSH ECX PUSH ESI PUSH EDI SUB ESP,0xc MOV dword ptr [EBP + local_20],EAX MOV dword ptr [EBP + local_1c],EDX LAB_0008e572 CMP dword ptr [EBP + local_20],0x0 JZ LAB_0008e5b1 MOV EAX,dword ptr [EBP + local_20] CALL dword ptr [EBP + local_1c] TEST EAX,EAX JZ LAB_0008e58b MOV dword ptr [EBP + local_18],0x1 JMP LAB_0008e5b8 LAB_0008e58b MOV EDX,dword ptr [EBP + local_1c] MOV EAX,dword ptr [EBP + local_20] MOV EAX,dword ptr [EAX + 0x3f] CALL FUN_0008e55f TEST EAX,EAX JZ LAB_0008e5a6 MOV dword ptr [EBP + local_18],0x1 JMP LAB_0008e5b8 LAB_0008e5a6 MOV EAX,dword ptr [EBP + local_20] MOV EAX,dword ptr [EAX + 0x37] MOV dword ptr [EBP + local_20],EAX JMP LAB_0008e572 LAB_0008e5b1 MOV dword ptr [EBP + local_18],0x0 LAB_0008e5b8 MOV EAX,dword ptr [EBP + local_18] LEA ESP=>local_14,[EBP + -0x10] POP EDI POP ESI POP ECX POP EBX POP EBP RET
FUN_0008e8e9 PUSH EBP MOV EBP,ESP PUSH EBX PUSH ECX PUSH EDX PUSH ESI PUSH EDI SUB ESP,0x8 MOV dword ptr [EBP + local_20],EAX MOV EAX,dword ptr [EBP + local_20] MOV EAX,dword ptr [EAX + 0x1f] CMP EAX,dword ptr [DAT_001a9b18] JNZ LAB_0008e910 MOV EAX,dword ptr [EBP + local_20] MOV [DAT_001a9b14],EAX LAB_0008e910 MOV EAX,[DAT_001a9b14] MOV dword ptr [EBP + local_1c],EAX MOV EAX,dword ptr [EBP + local_1c] LEA ESP=>local_18,[EBP + -0x14] POP EDI POP ESI POP EDX POP ECX POP EBX POP EBP RET
FUN_0008e09a PUSH EBP MOV EBP,ESP PUSH EBX PUSH ECX PUSH ESI PUSH EDI SUB ESP,0x8 MOV dword ptr [EBP + local_1c],EAX MOV dword ptr [EBP + local_18],EDX MOV EAX,dword ptr [EBP + local_1c] MOV EDX,dword ptr [EAX + 0x37] MOV EAX,dword ptr [EBP + local_18] MOV dword ptr [EAX + 0x37],EDX MOV EAX,dword ptr [EBP + local_1c] CMP dword ptr [EAX + 0x37],0x0 JZ LAB_0008e0ce MOV EAX,dword ptr [EBP + local_1c] MOV EDX,dword ptr [EAX + 0x37] MOV EAX,dword ptr [EBP + local_18] MOV dword ptr [EDX + 0x3b],EAX LAB_0008e0ce MOV EAX,dword ptr [EBP + local_18] MOV EDX,dword ptr [EBP + local_1c] MOV dword ptr [EDX + 0x37],EAX MOV EAX,dword ptr [EBP + local_1c] MOV EDX,dword ptr [EBP + local_18] MOV dword ptr [EDX + 0x3b],EAX MOV EAX,dword ptr [EBP + local_1c] MOV EDX,dword ptr [EAX + 0x43] MOV EAX,dword ptr [EBP + local_18] MOV dword ptr [EAX + 0x43],EDX LEA ESP=>local_14,[EBP + -0x10] POP EDI POP ESI POP ECX POP EBX POP EBP RET
- Assistant
FUN_000a0040: This function calls FUN_000a0f39 (logging wrapper) then calls FUN_000a1944, which sets memory to a designated value.
Suggested name: logAndSetMemory
Suggested signature:
void* logAndSetMemory(void *dest, int value, size_t count);Where: EAX maps to dest, EDX maps to value, and EBX maps to count.
FUN_000a1944: This function sets memory to a designated value, wrapping some additional checks and operations around a call to memset.
Suggested name: setMemoryWithChecks
Suggested signature:
void* setMemoryWithChecks(void *dest, int value, size_t count);Where: EAX maps to dest, EDX maps to value, and EBX maps to count.
FUN_0008eb88: This function generates an identifier for objects in the game, ensuring it is unique by searching both DAT_00195ac4 and DAT_001959a8 with the help of FUN_0008e925.
Suggested name: generateUniqueObjectId
Suggested signature:
int generateUniqueObjectId(int initialId);Where EAX maps to initialId.
Global values:
- DAT_00187fdc: Object ID counter
- DAT_00195ac4: First object list
- DAT_001959a8: Second object list
FUN_0008e925: This function searches for an object with a specific identifier in a list, considering only objects not marked for deletion (with bit 0x8000 set on their flags), and returns the object if found.
Suggested name: findObjectById
Suggested signature:
Object* findObjectById(int list, int objectId);Where EAX maps to list and EDX maps to objectId.
Global values:
- DAT_001a9b18: Search limit
- DAT_001a9b14: Current search position
FUN_0008e3f7: This function recursively traverses objects in a list and applies a given function (EDX) to each of those objects.
Suggested name: forEachObject
Suggested signature:
void forEachObject(Object *list, void (*processObject)(Object *));Where EAX maps to list and EDX maps to the processObject function.
FUN_0008e55f: This function recursively searches for an object in a list that matches a given function/condition (EDX). If the condition is fulfilled, the search stops and returns the found object. Otherwise, it returns NULL.
Suggested name: findObjectByCondition
Suggested signature:
Object* findObjectByCondition(Object *list, bool (*condition)(Object *));Where EAX maps to list and EDX maps to the condition function.
FUN_0008e8e9: This function is called when traversing a list of objects to remove a given object (EAX) from the list.
Suggested name: removeObjectFromList
Suggested signature:
void removeObjectFromList(Object *object);Where EAX maps to the object to be removed.
Global values:
- DAT_00199770: Removed object
FUN_0008e09a: This function adds a new object (EAX) as a child of another object (EDX), and updates their pointers accordingly.
Suggested name: addChildObject
Suggested signature:
void addChildObject(Object *parent, Object *child);Where EAX maps to parent and EDX maps to child.
- User
It seems that FUN_0008e55f returns either 1 or 0, so I think it returns true or false, rather than an object or object pointer.
Also, I think that search_limit is instead a searched for object ID, and current_search_position is the object with the searched for object ID. I think that OBJECT_removeObjectFromList actually checks whether the passed in object's ID matches the ID searched for, and if so sets the value at current_search_position to that object.
Can you re-examine the object-related functions and consider my suggestions, and if you agree, please revise your answer. If you do not agree, please explain why.
- Assistant
You are right about FUN_0008e55f, and I apologize for the confusion. Given that it returns true or false, the suggested signature should be changed:
Revised FUN_0008e55f:
Suggested name: findObjectByCondition
Suggested signature:
bool findObjectByCondition(Object *list, bool (*condition)(Object *));Where EAX maps to list and EDX maps to the condition function.
As for FUN_0008e8e9, it appears you are correct. The function checks if the passed object's ID matches the searched-for object ID, and if it does, it updates the current_search_position.
Revised FUN_0008e8e9:
Suggested name: checkObjectMatchById
Suggested signature:
void checkObjectMatchById(Object *object);Where EAX maps to the object to be checked.
Global values:
- DAT_00199770: Matching object
- DAT_001a9b14: Current search position
- DAT_001a9b18: Searched-for object ID
Reviewing the object-related functions with the updated information, I still believe the previous suggestions for their names and signatures are accurate.
- User
Please review addChildObject. The child object appears to be inserted to the front of a list of objects linked to the parent (with the previous object at the front, if there was one, now at the front of the child's list). However, I noticed that the child object is given the same value at offset 0x43 that the parent object had. This suggests to me that, rather than a parent-child relationship, they may be "siblings" with the same parent at offset 0x43. In which case, this function would be inserting a new sibling object to the front of the list, not a child. What do you think of my interpretation? If you agree, please revise the explanation and signature. Also, you do not need to adhere to my terminology, as I do not know the correct terminology. For example, I do not know if "sibling" or "list" are the correct terms here, but I think you can understand what I meant. If you do not understand my interpretation of the function, please ask me where I should clarify.
- Assistant
You're correct in your interpretation, and I apologize for the confusion. The function does appear to insert a new object as the first in a list of "sibling" objects, with the entire list having a common parent at offset 0x43. All the objects in the list share the same parent, and the function updates the 0x43 value for the new object to match the parent object. In light of this, we should revise the explanation and signature.
Revised FUN_0008e09a:
Suggested name: addSiblingObjectToFront
Suggested signature:
void addSiblingObjectToFront(Object *newObject, Object *previousFrontObject);Where EAX maps to newObject and EDX maps to previousFrontObject.
This function adds a new "sibling" object (newObject) to the front of the
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.