Skip to content
TheChatArchiveThe Chat Archive
gpt-3.5-turbo-0613· openaiHugging Face Suzhen/CodeChat

I used your signalgenerator code: def signalgenerator(df): Calculate EMA and MA lines…

  1. User

    I used your signal_generator code: def signal_generator(df): # Calculate EMA and MA lines df['EMA5'] = df['Close'].ewm(span=5, adjust=False).mean() df['EMA10'] = df['Close'].ewm(span=10, adjust=False).mean() df['EMA20'] = df['Close'].ewm(span=20, adjust=False).mean() df['EMA50'] = df['Close'].ewm(span=50, adjust=False).mean() df['EMA100'] = df['Close'].ewm(span=100, adjust=False).mean() df['EMA200'] = df['Close'].ewm(span=200, adjust=False).mean() df['MA10'] = df['Close'].rolling(window=10).mean() df['MA20'] = df['Close'].rolling(window=20).mean() df['MA50'] = df['Close'].rolling(window=50).mean() df['MA100'] = df['Close'].rolling(window=100).mean() # Extract necessary prices from df # Extract necessary prices from df # Extract necessary prices from df open_price = df.Open.iloc[-1] close_price = df.Close.iloc[-1] previous_open = df.Open.iloc[-2] previous_close = df.Close.iloc[-2]

    # Calculate the last candlestick
    last_candle = df.iloc[-1]
    current_price = df.Close.iloc[-1]
    
    # Initialize analysis variables
    ema_analysis = []
    candle_analysis = []
    
    # EMA greatest line strategy - buy signal
    if df.EMA10.iloc[-1] > df.EMA50.iloc[-1] and close_price > max(df['EMA10'].iloc[-2], df['EMA50'].iloc[-2]):
        ema_analysis.append('buy')
    
    # EMA greatest line strategy - sell signal
    elif df.EMA10.iloc[-1] < df.EMA50.iloc[-1] and close_price < min(df['EMA10'].iloc[-2], df['EMA50'].iloc[-2]):
        ema_analysis.append('sell')
    
    # Check for bullish candlestick patterns
    if open_price > close_price and previous_open < previous_close and close_price < previous_open and open_price >= previous_close:
        candle_analysis.append('sell')
    
    elif open_price < close_price and previous_open > previous_close and close_price > previous_open and open_price <= previous_close:
        candle_analysis.append('buy')
                               
        # Combine all analysis into final signal
    ema_signal = 'buy' if 'buy' in ema_analysis else 'sell' if 'sell' in ema_analysis else ''
    candle_signal = 'buy' if 'buy' in candle_analysis else 'sell' if 'sell' in candle_analysis else ''
    
    if ema_signal == 'buy' and candle_signal == 'buy':
        return 'buy'
    elif ema_signal == 'sell' and candle_signal == 'sell':
        return 'sell'
    else:
        return ''
    

    But itgiveing me wrong signals, please can you change my EMA lines strategy to greatest strategy and save my candle_analyze strategy please

  2. Assistant

    Sure, I've updated your code to use the "greatest strategy" for the EMA lines and keep the candlestick analysis strategy. Here's the modified code:

    def signal_generator(df):
        # Calculate EMA and MA lines
        df['EMA5'] = df['Close'].ewm(span=5, adjust=False).mean()
        df['EMA10'] = df['Close'].ewm(span=10, adjust=False).mean()
        df['EMA20'] = df['Close'].ewm(span=20, adjust=False).mean()
        df['EMA50'] = df['Close'].ewm(span=50, adjust=False).mean()
        df['EMA100'] = df['Close'].ewm(span=100, adjust=False).mean()
        df['EMA200'] = df['Close'].ewm(span=200, adjust=False).mean()
        df['MA10'] = df['Close'].rolling(window=10).mean()
        df['MA20'] = df['Close'].rolling(window=20).mean()
        df['MA50'] = df['Close'].rolling(window=50).mean()
        df['MA100'] = df['Close'].rolling(window=100).mean()
        
        # Extract necessary prices from df
        open_price = df.Open.iloc[-1]
        close_price = df.Close.iloc[-1]
        previous_open = df.Open.iloc[-2]
        previous_close = df.Close.iloc[-2]
    
        # Calculate the last candlestick
        last_candle = df.iloc[-1]
        current_price = df.Close.iloc[-1]
    
        # Initialize analysis variables
        ema_analysis = []
        candle_analysis = []
    
        # EMA greatest line strategy - buy signal
        if df.EMA10.iloc[-1] == max(df['EMA10'].iloc[-1], df['EMA50'].iloc[-1]) and close_price > max(df['EMA10'].iloc[-2], df['EMA50'].iloc[-2]):
            ema_analysis.append('buy')
    
        # EMA greatest line strategy - sell signal
        elif df.EMA10.iloc[-1] == min(df['EMA10'].iloc[-1], df['EMA50'].iloc[-1]) and close_price < min(df['EMA10'].iloc[-2], df['EMA50'].iloc[-2]):
            ema_analysis.append('sell')
    
        # Check for bullish candlestick patterns
        if open_price > close_price and previous_open < previous_close and close_price < previous_open and open_price >= previous_close:
            candle_analysis.append('sell')
    
        elif open_price < close_price and previous_open > previous_close and close_price > previous_open and open_price <= previous_close:
            candle_analysis.append('buy')
                                   
        # Combine all analysis into final signal
        ema_signal = 'buy' if 'buy' in ema_analysis else 'sell' if 'sell' in ema_analysis else ''
        candle_signal = 'buy' if 'buy' in candle_analysis else 'sell' if 'sell' in candle_analysis else ''
    
        if ema_signal == 'buy' and candle_signal == 'buy':
            return 'buy'
        elif ema_signal == 'sell' and candle_signal == 'sell':
            return 'sell'
        else:
            return ''
    

    This code should use the greatest strategy for the EMA lines and maintain the candlestick analysis strategy.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.