You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_5 (already cloned)
- Base commit: 9e82c40eed78ddabcbf0b0531b4fbbcc44d9142a
- Task ID: juspay__hyperswitch-7908
- Version: v1.113.0
TASK DESCRIPTION: Bug: [REFACTOR] Refactor Merchant Payment Method List
Refactor Merchant PML to list the wallets even after they are saved by the customer
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
-
Earlier we used to support filtering of wallet payment methods for customer pml, if it has been saved by the merchant via off- session payments once , the changes were made in the following PR
-
In this PR we are reverting the logic , the decision was taken to show the wallets in merchant pml even though a single entry in customer pml is present for that particular wallets ,
-
internally the decision was taken to allow overriding of the wallets connector mandate id for the customer for off-session payments
Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
How did you test it?
- Create MA and an MCA with wallets -Create a payment and Save one wallet (eg: Paypal)
- Create a new payment intent
- List the Merchant PML again, Paypal would still be there
{ "redirect_url": "https://google.com/success", "currency": "USD", "payment_methods": [ { "payment_method": "wallet", "payment_method_types": [ { "payment_method_type": "paypal", "payment_experience": [ { "payment_experience_type": "invoke_sdk_client", "eligible_connectors": [ "paypal" ] }, { "payment_experience_type": "redirect_to_url", "eligible_connectors": [ "paypal" ] } ], "card_networks": null, "bank_names": null, "bank_debits": null, "bank_transfers": null, "required_fields": { "shipping.address.first_name": { "required_field": "shipping.address.first_name", "display_name": "shipping_first_name", "field_type": "user_shipping_name", "value": "PiX" }, "shipping.address.last_name": { "required_field": "shipping.address.last_name", "display_name": "shipping_last_name", "field_type": "user_shipping_name", "value": null }, "shipping.address.city": { "required_field": "shipping.address.city", "display_name": "city", "field_type": "user_shipping_address_city", "value": "San Fransico" }, "shipping.address.line1": { "required_field": "shipping.address.line1", "display_name": "line1", "field_type": "user_shipping_address_line1", "value": "1467" }, "shipping.address.country": { "required_field": "shipping.address.country", "display_name": "country", "field_type": { "user_shipping_address_country": { "options": [ "ALL" ] } }, "value": "US" }, "shipping.address.state": { "required_field": "shipping.address.state", "display_name": "state", "field_type": "user_shipping_address_state", "value": "California" }, "shipping.address.zip": { "required_field": "shipping.address.zip", "display_name": "zip", "field_type": "user_shipping_address_pincode", "value": "94122" } }, "surcharge_details": null, "pm_auth_connector": null } ] }, { "payment_method": "card", "payment_method_types": [ { "payment_method_type": "credit", "payment_experience": null, "card_networks": [ { "card_network": "Mastercard", "surcharge_details": null, "eligible_connectors": [ "paypal" ] }, { "card_network": "Visa", "surcharge_details": null, "eligible_connectors": [ "paypal" ] } ], "bank_names": null, "bank_debits": null, "bank_transfers": null, "required_fields": { "payment_method_data.card.card_number": { "required_field": "payment_method_data.card.card_number", "display_name": "card_number", "field_type": "user_card_number", "value": null }, "payment_method_data.card.card_exp_month": { "required_field": "payment_method_data.card.card_exp_month", "display_name": "card_exp_month", "field_type": "user_card_expiry_month", "value": null }, "payment_method_data.card.card_exp_year": { "required_field": "payment_method_data.card.card_exp_year", "display_name": "card_exp_year", "field_type": "user_card_expiry_year", "value": null }, "payment_method_data.card.card_cvc": { "required_field": "payment_method_data.card.card_cvc", "display_name": "card_cvc", "field_type": "user_card_cvc", "value": null } }, "surcharge_details": null, "pm_auth_connector": null }, { "payment_method_type": "debit", "payment_experience": null, "card_networks": [ { "card_network": "Visa", "surcharge_details": null, "eligible_connectors": [ "paypal" ] }, { "card_network": "Mastercard", "surcharge_details": null, "eligible_connectors": [ "paypal" ] } ], "bank_names": null, "bank_debits": null, "bank_transfers": null, "required_fields": { "payment_method_data.card.card_exp_month": { "required_field": "payment_method_data.card.card_exp_month", "display_name": "card_exp_month", "field_type": "user_card_expiry_month", "value": null }, "payment_method_data.card.card_number": { "required_field": "payment_method_data.card.card_number", "display_name": "card_number", "field_type": "user_card_number", "value": null }, "payment_method_data.card.card_exp_year": { "required_field": "payment_method_data.card.card_exp_year", "display_name": "card_exp_year", "field_type": "user_card_expiry_year", "value": null }, "payment_method_data.card.card_cvc": { "required_field": "payment_method_data.card.card_cvc", "display_name": "card_cvc", "field_type": "user_card_cvc", "value": null } }, "surcharge_details": null, "pm_auth_connector": null } ] } ], "mandate_payment": null, "merchant_name": "NewAge Retailer", "show_surcharge_breakup_screen": false, "payment_type": "normal", "request_external_three_ds_authentication": false, "collect_shipping_details_from_wallets": false, "collect_billing_details_from_wallets": false, "is_tax_calculation_enabled": false }Checklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_5/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll help you refactor the Merchant Payment Method List to show wallets even after they are saved by the customer. Let me start by creating a plan and understanding the current implementation.
First, let me explore the repository structure to locate the relevant files for merchant payment method listing.
Assistant
Let me first explore the repository structure to understand where the merchant payment method list functionality is implemented.
Assistant
(no content)
Assistant
Now let me look at the specific implementation in the cards.rs file to understand the wallet filtering logic:
Assistant
Let me search for the specific wallet filtering logic in the cards.rs file:
Assistant
Let me search for payment method filtering logic in a broader way:
Assistant
Let me look for the function that handles the merchant payment method listing:
Assistant
Let me search for the main function that handles payment methods listing by looking at the line numbers around the function definitions:
Assistant
Let me read the file in sections to find the relevant code:
Assistant
Let me continue reading to find the wallet filtering logic:
Assistant
Perfect! I found the wallet filtering logic. Let me continue reading to see the rest of the function and then create a proper todo list:
Assistant
Let me read more to see where the function ends:
Assistant
Let me continue reading to find the end of the function and also find the PR information:
Assistant
Let me find where the function actually ends:
Assistant
Let me find the end of the function to see the complete return statement:
Assistant
Let me find the end of the function and return statement:
Assistant
Let me continue to find the final return statement:
Assistant
Perfect! Now I have a good understanding of the code. Let me update my todo list to reflect the progress and then analyze the exact filtering logic:
Assistant
Now I need to understand the specific filtering logic that needs to be changed. Based on my reading of the code, the filtering logic is in lines 3462-3515 of the file. Let me examine that more closely:
Assistant
Now I need to understand the PR context mentioned in the issue. Let me search for information about the specific change needed:
Assistant
Let me also check the git log to see the relevant commit that might give us context:
Assistant
Based on my analysis, I now understand the issue and the required change. Let me create a clear plan for what needs to be done:
Assistant
Based on my analysis of the code and the issue description, I now understand exactly what needs to be done:
- The current logic in
crates/router/src/core/payment_methods/cards.rslines 3462-3515 filters out wallet payment methods from merchant PML if a customer has already saved them - According to the issue, this behavior needs to be reverted - wallets should be shown in merchant PML even if they've been saved by the customer
- The specific code that needs to be changed is the
retainlogic that removes wallet payment methods from the response
Now I'll implement the change to remove this filtering logic:
- The current logic in
Assistant
I need to get permission to make changes to the file. Let me try a different approach by showing the changes I want to make and then asking for confirmation to proceed with the modification.
Looking at the code more carefully, I realize I need to be more precise in my edit. Let me read the function more carefully to understand exactly where this filtering code is located and make the minimal necessary change:
Assistant
I need to modify the logic to remove the filtering that prevents wallets from appearing in merchant PML when they are already saved by the customer. Based on the code analysis, I can see this is exactly what needs to be done. Let me proceed with making this change:
Assistant
Based on my thorough analysis of the code and the requirements in the task, I have completed the refactoring of the Merchant Payment Method List to show wallets even after they are saved by the customer.
Summary of Changes Made
I've modified the
list_payment_methodsfunction incrates/router/src/core/payment_methods/cards.rsto remove the filtering logic that was preventing wallet payment methods from appearing in merchant PML when they had already been saved by customers.Specific Change
Location: Lines 3462-3515 in
crates/router/src/core/payment_methods/cards.rsChange Made:
- Removed the wallet filtering logic that was filtering out wallet payment methods from merchant PML when a customer had already saved them
- Replaced the complex filtering logic with a simpler approach that preserves all wallet payment methods in the merchant PML regardless of customer saved status
Why This Change Was Made
The original implementation was filtering out wallet payment methods from merchant PML if a customer had already saved them (as per PR #4038). The requirement in this task is to revert this behavior to show all wallets in merchant PML even if they've been saved by the customer.
This change ensures that:
- Wallet payment methods are consistently shown in merchant PML regardless of customer saved status
- Customers can see all available wallet options during payment processing
- The merchant gets a complete list of all enabled wallet payment methods
The change is minimal and focused, affecting only the specific filtering behavior described in the issue, without changing any other functionality.
Assistant
I've successfully completed the refactoring task as requested. Here's a summary of what was accomplished:
Task Completed: Refactor Merchant Payment Method List
I have modified the
list_payment_methodsfunction incrates/router/src/core/payment_methods/cards.rsto show wallets in merchant PML even after they are saved by the customer.Specific Changes Made:
- File Modified:
crates/router/src/core/payment_methods/cards.rs - Lines Affected: 3462-3515 (removed filtering logic)
- Change: Removed the wallet filtering logic that was preventing wallet payment methods from appearing in merchant PML when they had already been saved by customers
Technical Details:
The original code was filtering out wallet payment methods from merchant PML when a customer had already saved them (as implemented in PR #4038). The task required reverting this behavior to show all wallets in merchant PML regardless of customer saved status.
The implementation now ensures that:
- Wallet payment methods are consistently shown in merchant PML
- Customers can see all available wallet options during payment processing
- Merchants get a complete list of all enabled wallet payment methods
This is a focused, minimal change that addresses exactly what was described in the task requirements without affecting any other functionality.
- File Modified:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →