You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_9 (already cloned)
- Base commit: c5c0e677f2a2d43170a66330c98e0ebc4d771717
- Task ID: juspay__hyperswitch-8389
- Version: v1.114.0
TASK DESCRIPTION: Bug: [FEATURE] Kv Redis feature for V2 models
Feature Description
Extend kv support for v2 models
Possible Implementation
Use existing construct to extend to v2 models
Have you spent some time checking if this feature request has been raised before?
- I checked and didn't find a similar issue
Have you read the Contributing Guidelines?
- I have read the Contributing Guidelines
Are you willing to submit a PR?
Yes, I am willing to submit a PR!
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
#8389
- Added Kv Redis support to - payment_intent V2, payment_attempt V2 models
- Added enable Kv route for v2 merchant-account
added enable kv api for v2 merchant account
curl --location 'https://<host>/v2/merchant-accounts/:mid/kv' \ --header 'Authorization: admin-api-key=***' \ --header 'x-organization-id:***' \ --header 'Content-Type: application/json' \ --data '{"kv_enabled" : true}'Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
How did you test it?
Locally tested kv writes and drainer functionality
Checklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_9/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll help you implement KV Redis support for V2 models in the hyperswitch repository. Let me start by exploring the codebase to understand the current implementation and identify what needs to be extended.
First, I'll create a plan of action for implementing this feature.
Assistant
Let me start by exploring the existing KV Redis implementation to understand how it's currently structured for V1 models.
Assistant
Now let me look for V2 model files to understand their structure:
Assistant
Let me search more broadly for V2 models:
Assistant
Let me search more specifically for V2-related files and directories:
Assistant
Let me search for API v2 directories and files:
Assistant
Let me search for merchant accounts in the codebase to understand the structure better:
Assistant
Let me examine the existing KV implementation to understand how it works:
Assistant
(no content)
Assistant
Let me check the storage implementation for KV redis:
Assistant
Now let me search for the API routes to understand how merchant accounts are handled:
Assistant
Let me check the API structure:
Assistant
Let me check for merchant account V2 API files specifically:
Assistant
Let me examine the main router to understand how the routes are organized:
Assistant
Let me check for routes that might handle merchant accounts:
Assistant
Let me look for the merchant account routes specifically:
Assistant
Let me check the main routes file and openapi specifications to better understand how the API structure works:
Assistant
Let me search for the specific endpoint mentioned in the task - the merchant account KV enable endpoint:
Assistant
Let me look at the admin routes and models to understand the current implementation:
Assistant
Now I can see that there's already a merchant account KV toggle functionality in the admin routes (lines 915-939). Let me check the API models to understand what's expected:
Assistant
Let me search for the KV related structs in the admin models:
Assistant
Let me get a specific part of the admin model file that contains KV-related structures:
Assistant
Let me also check for any V2-specific models to understand how V2 models work. First, let me see the openapi specs to understand the API structure:
Assistant
Let me examine what models exist in the storage layer for payment_intent and payment_attempt:
Assistant
Let me examine the main payment intent and payment attempt models to understand how they are structured in the diesel models:
Assistant
Let me examine the current payment_intent model:
Assistant
Let me also check the payment_attempt model:
Assistant
Based on my exploration, I can see that the repository uses both V1 and V2 models, with KV Redis support already existing for V1 models. The task is to extend KV Redis support to V2 models specifically for
payment_intentandpayment_attempt.Looking at the current structure, I understand:
- KV Redis implementation already exists for V1 models in
diesel_models/src/kv.rs - There are V2 versions of
payment_intentandpayment_attemptindiesel_models/src/payment_intent.rsanddiesel_models/src/payment_attempt.rs - The
KVRouterStoresupports both V1 and V2 through feature flags - The task is to add KV Redis support for V2 models specifically
Let me start working on implementing the solution:
- KV Redis implementation already exists for V1 models in
Assistant
Now I need to add KV support for V2 models. Looking at the existing code in
diesel_models/src/kv.rs, I can see that it already handles V2 models with#[cfg(feature = "v2")]sections. However, I need to make sure thePaymentIntentUpdateMemsandPaymentAttemptUpdateMemsstructures in the KV module are properly configured for V2 models.Let me check the specific structure of the
PaymentIntentUpdateMemsandPaymentAttemptUpdateMemsin the KV module to see if they need updates for V2:Assistant
I can see that the KV structure already handles both V1 and V2 for
PaymentIntentUpdateMems. Now I need to check the implementation ofDBOperation::executemethod in the KV module to see if it handles V2 models correctly for payment_intent and payment_attempt.Looking at lines 114-135 of the kv.rs file, I can see that the
executemethod has#[cfg(feature = "v2")]blocks for handling payment attempt updates, but it seems to be missing for payment intent updates. Let me double-check that by looking closer at this area:Assistant
I can see that the KV implementation for V2 models already exists and looks correct for both payment_intent and payment_attempt. However, I need to make sure there are no issues or missing parts. Let me now check what happens when we use these V2 models in the KV system.
But first, let me understand the task requirements better by examining the existing V2 models more closely and also the KV functionality to see if there's anything missing.
Looking more carefully, I need to actually implement what's required. Since this is a bug report requesting extension of KV Redis support to V2 models, and it's stated that V2 models should support KV, but I don't see any explicit issues in the current code, let me double-check by creating an implementation that adds proper support.
Let me also check what
Updateable::PaymentIntentUpdateandUpdateable::PaymentAttemptUpdateenums contain:Assistant
Based on my analysis, it appears that the KV support for V2 models is already implemented correctly in the current code. However, let me make sure there are no missing pieces. Looking at the current state, the implementation already handles:
- V2
PaymentIntentmodels throughPaymentIntentUpdateMemswithPaymentIntentUpdateInternal - V2
PaymentAttemptmodels throughPaymentAttemptUpdateMemswithPaymentAttemptUpdateInternal - Both are properly included in the
Updateableenum
Let me now check whether there might be a missing case in the
DBOperation::executemethod for payment intent updates when feature is enabled for V2. Looking at the code more carefully, it seems the V2 support is indeed implemented.However, the task description says we need to "Extend kv support for v2 models" and "Added enable Kv route for v2 merchant-account". This suggests there might be missing pieces. Let me look more carefully at what might be missing.
Since the KV system itself seems to be working with V2 models already, I suspect the main missing element mentioned in the task is the enable KV route for V2 merchant accounts.
But wait, I can see from the code that there is already a
merchant_account_toggle_kvfunction in the routes/admin.rs, and it seems to work with both V1 and V2 merchants.Looking again at the issue description, it says "added enable kv api for v2 merchant account", and shows a curl command with
v2/merchant-accounts/:mid/kv. Let me now look at the actual implementation to see if there are missing V2-specific routes.Let me examine the actual task again - it says "added enable kv api for v2 merchant account", which implies the route was added for v2 but perhaps wasn't implemented correctly or completely. Looking more closely at the current code, the
merchant_account_toggle_kvfunction in the routes is defined for all features and uses the genericadmin::ToggleKVRequest. Let me check if this covers V2 merchants properly.Actually, let me focus on making sure I understand what's missing, and implement exactly what is described in the task.
Based on my analysis, the task seems to be about:
- Making sure KV Redis support is properly extended for V2 payment_intent and payment_attempt models
- Ensuring the KV enable/disable API works for V2 merchant accounts
Looking at the issue description again, it mentions:
- "Added Kv Redis support to - payment_intent V2, payment_attempt V2 models"
- "added enable kv api for v2 merchant account"
Let me look more closely at the actual implementation in the storage code and verify everything is properly in place.
Since I believe the KV infrastructure is already in place for V2 models (as I can see it's coded in the kv.rs file with feature flags), let me make a targeted change to ensure it's properly set up.
Let me implement the actual changes that are required:
- V2
Assistant
Let me now make a different approach. Since I'm confident that the KV infrastructure for V2 models already exists properly, I'll check if there are any missing imports or references needed for V2 models to work correctly in the KV system. Let me also check if there's any missing part in the Updateable enum.
Actually, let me approach this systematically by creating a proper implementation of the missing feature. Based on the task, the main issue appears to be that while KV support is extended to V2 models, there might be some specific configuration missing.
Looking at the issue more carefully, I believe the task is asking me to make sure KV Redis is working properly for V2 models, especially when the feature is enabled for V2.
But since I've verified that the code is already implemented properly, I think the issue might be that the KV Redis store needs to be made aware of V2 model keys. Let me take a look at how V2 merchant accounts are handled and make sure the KV system knows how to handle V2 keys.
Actually, let me check the actual task more carefully one more time. The issue mentions that the task is to add KV Redis support for V2 models, and it specifically shows that they added an enable KV API for v2 merchant accounts.
The task is asking to:
- Extend KV support for V2 models (which I think is already there)
- Add enable KV API for V2 merchant accounts (which may not be fully implemented)
Let me approach this differently and create a focused change that would make sense in the context of the task.
Let me look for how KV is actually activated per merchant. Looking back at the admin routes, I see there's already a function called
merchant_account_toggle_kvbut maybe it's not handling V2 merchant accounts correctly or there's an issue in the implementation. Let me check if there are any issues in how V2 merchant account KV toggling works:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →