You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_2 (already cloned)
- Base commit: bc767b9131e2637ce90997da9018085d2dadb80b
- Task ID: juspay__hyperswitch-8430
- Version: v1.114.0
TASK DESCRIPTION: Bug: [BUG] adyen connector creates connector's customer reference on the fly
Bug Description
Connector's customer ID is a unique identifier for a customer's entity in the underlying connector for HyperSwitch for mapping a customer. This identifier is stored under
connector_customerincustomerstable.However, for Adyen - this field is a combination of merchant ID and customer ID in HyperSwitch which is unique across different merchants and customers.
This is a blocker for migrated customers whose
shopperReference(customer ID in Adyen) can be in a different format.Expected Behavior
Adyen should rely on the
connector_customerfield for customer and fallback to any default connector specific behavior.Actual Behavior
Adyen uses a default behavior for generating
connector_customer_idSteps To Reproduce
--
Context For The Bug
--
Environment
--
Have you spent some time checking if this bug has been raised before?
- I checked and didn't find a similar issue
Have you read the Contributing Guidelines?
- I have read the Contributing Guidelines
Are you willing to submit a PR?
None
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
Adyen now uses
connector_customer_idto formshopper_referenceif the field is present, else falls to previous implementation.Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
How did you test it?
Checklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_2/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll work on fixing the Adyen connector customer reference bug. Let me start by understanding the issue and exploring the relevant code.
First, I'll create a plan of action for this bug fix:
Assistant
I'll first explore the codebase to understand how the Adyen connector handles customer references. Let me search for Adyen-related files and customer handling code.
Assistant
(no content)
Assistant
Let me now look at the specific Adyen connector implementation to understand how it currently handles customer references.
Assistant
Let me examine the main Adyen connector implementation to understand how it currently handles customer references:
Assistant
Let me search for customer-related code in the Adyen connector:
Assistant
Let me look at the transformers file which likely contains the customer reference logic:
Assistant
Let me search for specific terms in the Adyen connector:
Assistant
Let me look at the connector customer details structure to understand how it's defined:
Assistant
Let me check the payment_methods.rs file where ConnectorCustomerDetails is defined:
Assistant
Now let me search for how shopperReference is constructed in the Adyen connector:
Assistant
Let me examine the key parts of the Adyen transformer file to understand customer creation:
Assistant
Let me check for customer creation methods in the Adyen connector:
Assistant
Let me read the entire transformers.rs file to understand the structure better. Let me try a different approach by looking at customer related structures:
Assistant
Let me search for the specific function that generates shopperReference in the Adyen connector:
Assistant
Let me search more broadly for where shopper_reference is assigned:
Assistant
Let me search for customer creation logic in the broader Adyen connector:
Assistant
Let me now look for the main transform function that builds the payment request to understand how shopper_reference gets populated:
Assistant
Let me examine the file further to understand how the payment request is transformed and where shopper reference is handled:
Assistant
Now let me continue reading more of the file to find the relevant transformation code for shopper_reference:
Assistant
Now I've found a key function! Let me read more of the relevant sections to understand how shopper_reference is currently built. I can see the
build_shopper_referencefunction at line 1970. This is likely where the issue lies. Let me search for where the customer creation happens to understand the full context:Assistant
Now I need to understand how the customer ID from connector_customer is handled in the customers module. Let me check the customers.rs file to understand how customers are created:
Assistant
Let me search for the relevant parts that handle the connector_customer field in the customer creation logic:
Assistant
Let me look for the Customer model definition and how connector_customer fields are stored:
Assistant
Let me check the customer storage model directly:
Assistant
Let me check the diesel models for customer to understand the storage structure:
Assistant
Perfect! I can see the
connector_customerfield in the Customer struct at line 25. Now I need to understand theConnectorCustomerMapstructure:Assistant
Now let me go back to the Adyen connector logic to understand the current behavior and make the fix. I need to check where the shopper reference is constructed and make it use the connector_customer if available:
Assistant
Looking at the code, I can see that the issue is in how
shopper_referenceis generated in the Adyen connector. Let me analyze the current situation and implement the fix.Based on my examination:
- The
build_shopper_referencefunction intransformers.rsline 1970-1981 creates a shopper reference from merchant ID and customer ID - However, it doesn't check if there's already a
connector_customerfield that should be used instead - The
ConnectorCustomerDetailsstructure containsconnector_customer_idthat should be used when available
Looking at the payment flow in the Adyen connector, I need to modify the logic to check if there's a connector_customer_id available and use that instead of generating a new one.
Let me now implement the fix:
- The
Assistant
Now I can see the issue. Looking at line 2901-2904 in the payment request building for Cards, I can see that it's calling
build_shopper_referencebut it doesn't check for an existing connector customer reference. I need to check where the connector_customer data is available in the request.Looking at how the request is structured, I need to find a way to access connector customer details from the payments authorize request to override the default shopper reference generation. Let me examine the
PaymentsAuthorizeRouterDatato see if it has access to customer connector details.Let me check how to access connector_customer in the context:
Assistant
Great! I can see that
RouterDataalready has aconnector_customerfield at line 30. This means that when the customer is already created with a connector customer reference, it's already available in the router data.Now let me create a helper function that will check for the existing connector customer reference and use it instead of generating a new one. I'll modify the
build_shopper_referencefunction or create a new one:Assistant
I need to be more careful about what I'm changing. I should only modify the places where the shopper reference is actually being built in the Adyen connector. Let me first look at all the places where
build_shopper_referenceis called to see what I need to modify.Assistant
(no content)
Assistant
Let me search for where shopper reference is set in the Adyen connector's payment request construction:
Assistant
Let me find where the shopper_reference is assigned in the AdyenPaymentRequest:
Assistant
I found it! Line 2901-2904 shows where the shopper reference is currently built. I need to modify this section to use the connector_customer when available. Let me look at how to access the connector_customer in the router data context.
Looking at the code structure, I see that in the
RouterDatathere's already aconnector_customerfield. So I can directly use it. Let me make this change now:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →