You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_5 (already cloned)
- Base commit: e30842892a48ff6e4bc0e7c0a4990d3e5fc50027
- Task ID: juspay__hyperswitch-9250
- Version: v1.116.0
TASK DESCRIPTION: Bug: fix(users): Add Bad request response in openidconnect
Currently, when users provide an invalid or expired code during SSO login, the system returns a 500 response. This is misleading, as the issue is with the client input rather than a server error. This change introduces a proper 400 BadRequest response to better reflect the actual problem and improve error handling.
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
Added a BadRequest response for SSO login when an invalid authorization code is provided.
Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
Currently, when users provide an invalid or expired code during SSO login, the system returns a 500 response. This is misleading, as the issue is with the client input rather than a server error. This change introduces a proper 400 BadRequest response to better reflect the actual problem and improve error handling.
How did you test it?
curl --location '<BASE URL>/user/oidc' \ --header 'Content-Type: application/json' \ --data '{ "state": "<correct state>", "code": "<wrong code>" }'This should give
400instead of 500.Checklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_5/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll tackle this bug fix for the OpenID Connect SSO login issue. Let me first understand the problem and locate the relevant code.
The issue is that when invalid or expired codes are provided during SSO login, the system returns a 500 error instead of a proper 400 BadRequest response. I need to find the OpenID Connect related code and fix this error handling.
Let me start by exploring the codebase to locate the relevant files:
Assistant
(no content)
Assistant
Let me examine the specific OpenID Connect implementation file to understand how it handles errors currently:
Assistant
Now let me examine the authentication routes to see how the OIDC endpoint is handled:
Assistant
Let me search for OIDC-related route definitions to see how the endpoint is registered:
Assistant
(no content)
Assistant
Let me search more specifically for the OIDC route:
Assistant
(no content)
Assistant
Let me search for the unified authentication service which might contain the OIDC endpoint:
Assistant
Now let me look at the API models to see what authentication request structures are defined:
Assistant
Looking at the issue, I need to identify where the OpenID Connect endpoint is defined that receives a "code" and "state" for SSO login. Let me search for any files that define a user/oidc endpoint:
Assistant
Let me examine the routes/app.rs file to understand how the endpoints are organized:
Assistant
(no content)
Assistant
Great! I found it. Let me examine the user module that contains the SSO sign endpoint:
Assistant
I notice that there's a
sso_signfunction that's referenced but I haven't seen the actual implementation yet. Let me search for where the sso_sign function is actually implemented:Assistant
Let me search for where the
/user/oidcendpoint is actually implemented in the codebase:Assistant
Perfect! Now let me examine both files to understand the current implementation:
Assistant
Now I found the
sso_signfunction. Let me also check the core user implementation to see how it's implemented:Assistant
Now I have a good understanding of the codebase. Let me look at the SSO sign function that's causing the issue. I can see in the
sso_signfunction (around line 2776) that it callsopenidconnect::get_user_email_from_oidc_provider()and it's expecting the error to be returned properly, but it looks like when an invalid/expired code is provided, it's returning a 500 instead of 400.Let me check the
openidconnect::get_user_email_from_oidc_providerfunction in the service layer:Assistant
Let me create a detailed plan for fixing this bug. Looking at the code, I can see the problem clearly now.
Based on my investigation, I've identified the issue:
-
In the
sso_signfunction (incrates/router/src/core/user.rsaround line 2776), when an invalid or expired authorization code is passed toopenidconnect::get_user_email_from_oidc_provider, it returns a 500 Internal Server Error instead of a 400 Bad Request. -
The problem occurs in the
openidconnect::get_user_email_from_oidc_providerfunction (incrates/router/src/services/openidconnect.rs) where it catches all errors and converts them toUserErrors::InternalServerErrorregardless of the actual error type. -
The specific error happens during
client.exchange_code(...)which is an external call that can fail for many reasons including invalid/expired codes, and this failure gets mapped to a generic 500 error.
I need to create a plan to make the error handling more specific so that bad requests (like invalid/expired codes) return 400 instead of 500.
-
Assistant
Let me first look at what error types are available for handling in the UserErrors enum:
Assistant
(no content)
Assistant
(no content)
Assistant
Let me check the error handling in the OpenID Connect service more closely to understand what error type we need to handle:
Assistant
Let me examine what the
openidconnectcrate returns and how we can differentiate between bad request vs internal server error scenarios. First, let me understand how the error propagation works in the current implementation:- User
Here are the existing contents of your todo list:
[1. [pending] Identify where in the openidconnect service the specific error types are generated for invalid/expired authorization codes 2. [pending] Create specific error types for invalid/expired codes that can be mapped to 400 status codes 3. [pending] Modify the openidconnect::get_user_email_from_oidc_provider function to return more specific errors 4. [pending] Update the sso_sign function to handle and map specific errors to appropriate HTTP status codes]
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →