You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_4 (already cloned)
- Base commit: 7943fb4bfb156e22d5329d45a580f90e02283604
- Task ID: juspay__hyperswitch-8394
- Version: v1.114.0
TASK DESCRIPTION: Bug: feat(revenue_recovery): Invoke attempt list instead of payment get in recovery webhooks flow
Previously we were using payment get to find whether attempt is present in db or not, but for the first invoice webhook there won't be any attempt present in db and recently we added a validation to use payment get only in case of attempt is present.
Also for stripe billing / stripe connector_transaction_id remains same instead charge id keeps changing , so we need to add support for this by checking if charge id is present we compare charge id if not we check for connector transaction id.
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
Previously we were using payment get to find whether attempt is present in db or not, but for the first invoice webhook there won't be any attempt present in db and recently we added a validation to use payment get only in case of attempt is present. This PR solves this issue by invoking payment get attempt list instead of payment get.
Also for stripe billing / stripe connector_transaction_id remains same instead charge id keeps changing , so we added a support for this by checking if charge id is present we compare charge id if not we check for connector transaction id.
Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
How did you test it?
Tested complete revenue recovery flow with stripebilling
- Set up merchant and mca for billing and payment connector for stripebilling and stripe
- Make sure merchant have retry_algorithm_type to cascading in business profile
- Trigger payment invoice from stripe, after threshold external attempts , pt entry should be done in and start triggering internal payments.
Checklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_4/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll help you implement the bug fix for the revenue recovery webhook flow. Let me first understand the current implementation by examining the relevant files.
Assistant
Let me search for files related to revenue recovery and webhook handling to understand the current implementation:
Assistant
Now let me search for webhook handling related to stripe billing:
Assistant
Let me search more broadly for webhook handling code:
Assistant
Let me look at the key webhook recovery file and the stripe billing connector:
Assistant
Now let me check the stripe billing connector to understand how it handles connector transaction IDs:
Assistant
Let me look at the transformers file for the stripe billing connector to understand the structure better:
Assistant
Now I need to look at how the payment attempts are checked to understand the current implementation and where we need to make changes. Let me also search for recent changes to the payment get validation:
Assistant
Let me look at how payment attempts are retrieved in the revenue recovery flow, particularly focusing on the specific code around the payment get:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →