You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_7 (already cloned)
- Base commit: 7943fb4bfb156e22d5329d45a580f90e02283604
- Task ID: juspay__hyperswitch-8394
- Version: v1.114.0
TASK DESCRIPTION: Bug: feat(revenue_recovery): Invoke attempt list instead of payment get in recovery webhooks flow
Previously we were using payment get to find whether attempt is present in db or not, but for the first invoice webhook there won't be any attempt present in db and recently we added a validation to use payment get only in case of attempt is present.
Also for stripe billing / stripe connector_transaction_id remains same instead charge id keeps changing , so we need to add support for this by checking if charge id is present we compare charge id if not we check for connector transaction id.
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
Previously we were using payment get to find whether attempt is present in db or not, but for the first invoice webhook there won't be any attempt present in db and recently we added a validation to use payment get only in case of attempt is present. This PR solves this issue by invoking payment get attempt list instead of payment get.
Also for stripe billing / stripe connector_transaction_id remains same instead charge id keeps changing , so we added a support for this by checking if charge id is present we compare charge id if not we check for connector transaction id.
Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
How did you test it?
Tested complete revenue recovery flow with stripebilling
- Set up merchant and mca for billing and payment connector for stripebilling and stripe
- Make sure merchant have retry_algorithm_type to cascading in business profile
- Trigger payment invoice from stripe, after threshold external attempts , pt entry should be done in and start triggering internal payments.
Checklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_7/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll work on this bug fix for the revenue recovery webhook flow. Let me first understand the current implementation by exploring the relevant files and code.
Assistant
Let me first explore the repository structure to understand where the revenue recovery and webhook code is located.
Assistant
(no content)
Assistant
Now let me look at the specific implementation files that handle the revenue recovery webhook flow and payment attempt logic:
Assistant
(no content)
Assistant
Let me examine the recovery incoming webhook handler:
Assistant
Now let me look at the payment attempt logic and how it currently checks for payment attempts:
Assistant
Let me check the psync flow since it seems relevant to the issue:
Assistant
Let me search for payment get operations in the payments core:
Assistant
Let me look at the payment operations to understand how payment get is implemented:
Assistant
Let me now search for how payment attempts are retrieved specifically for the recovery flow. Looking at the code from the revenue recovery flow, I can see that at lines 470-528 in recovery_incoming.rs, there's a
get_payment_attemptmethod that uses the PaymentGet operation to fetch the attempt. Let me also check for the connector transaction ID logic:Assistant
Now I need to examine how the connector transaction ID logic works. Let me look for the methods that deal with finding attempts by connector transaction ID:
Assistant
(no content)
Assistant
Let me search for the specific method in the payments file more specifically:
Assistant
(no content)
Assistant
Let me search more broadly:
Assistant
Let me check the structure of the PaymentsResponse to understand the connector transaction ID matching:
Assistant
Perfect! I can now see the key method
find_attempt_in_attempts_list_using_connector_transaction_idthat's used in the recovery flow. Now I need to understand how to find the appropriate payment attempt. Let me check the actual current implementation that needs to be changed.Looking at the code in
recovery_incoming.rslines 500-508, I can see that the current implementation only looks for the attempt in the list usingconnector_transaction_idbut according to the task description, we need to:- Change from using
payment gettopayment get attempt list(because for first invoice webhook there won't be any attempt in DB) - Support both charge ID and connector_transaction_id comparison for Stripe billing
Let me now update the code to reflect these changes:
- Change from using
Assistant
(no content)
Assistant
Now let me check the revenue recovery data structure to understand how it handles charge ID vs connector_transaction_id:
Assistant
(no content)
Assistant
(no content)
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →