You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_1 (already cloned)
- Base commit: b133c534fb1ce40bd6cca27fac4f2d58b0863e30
- Task ID: juspay__hyperswitch-8969
- Version: v1.117.0
TASK DESCRIPTION: Bug: [BUG] Logging sensitive information on deserialization failure
Bug Description
In
common_utils/src/ext_traits.rswe are logging serde_json Values in plaintext when deserialization fails. This is a problem in cases where the JSON objects contain sensitive data.Expected Behavior
Sensitive data is not logged. Values are logged after masking.
Actual Behavior
Sensitive information is logged.
Steps To Reproduce
Supply malformed data to the
parse_valuemethod inValueExttrait.Context For The Bug
No response
Environment
Are you using hyperswitch hosted version? Yes
Have you spent some time checking if this bug has been raised before?
- I checked and didn't find a similar issue
Have you read the Contributing Guidelines?
- I have read the Contributing Guidelines
Are you willing to submit a PR?
Yes, I am willing to submit a PR!
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
- Modified
parse_valuemethod inValueExttrait to log the JSON object after masking on deserialization failure. - Modified
parse_structmethod inBytesExt,ByteSliceExtandStringExtto log values after converting them into aserde_json::Valueand then masking
Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
Closes #8969
How did you test it?
Tested by supplying malformed data to the method and verified it logs data after masking.
Object:
String:
Array:
Checklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_1/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll work on fixing the bug where sensitive information is being logged during deserialization failures. Let me start by examining the relevant file mentioned in the bug report.
Assistant
Let me check the repository structure to find the correct path for ext_traits.rs.
Assistant
Now I can see the correct path. Let me read the common_utils/src/ext_traits.rs file:
Assistant
Now I need to examine the
errors.rsfile to understand the error types and how logging is implemented:Assistant
Let me check the common_utils/src/errors.rs file to understand the error types better:
Assistant
Now let me also check what masking utilities are available to understand how to mask sensitive data:
Assistant
Let me search for masking-related code in the project to understand how masking is implemented:
Assistant
Let me check how masking is imported in the ext_traits.rs file and understand the masking strategy:
Assistant
Let me also look at the masking crate usage in other parts of the codebase to understand the pattern:
Assistant
Based on my examination of the codebase, I now understand the issue and what needs to be fixed. Let me create a plan of action and then implement the fix.
Looking at the code in
ext_traits.rs, I can see that in theValueExttrait implementations, specifically in theparse_valuemethod around lines 222-229, sensitive data is being logged in plaintext when deserialization fails. The problem is on line 224 where&selfis logged directly, which can contain sensitive information.The fix involves:
- Masking the sensitive data before logging in
ValueExt::parse_value - Applying the same approach to
BytesExt::parse_struct,ByteSliceExt::parse_struct, andStringExt::parse_struct
Let me implement this fix now.
- Masking the sensitive data before logging in
Assistant
I'll work on fixing the logging of sensitive information during deserialization failures. Let me start by examining the exact areas that need to be modified and then make the necessary changes.
Assistant
Let me look more closely at the specific logging code that needs to be fixed:
Assistant
(no content)
Assistant
(no content)
Assistant
Let me check the specific lines in the file that contain the problematic logging code by viewing the actual lines:
Assistant
(no content)
Assistant
(no content)
Assistant
(no content)
Assistant
Let me look at the complete context of all the methods that need to be fixed by reading the relevant sections of the file:
Assistant
(no content)
Assistant
Let me read more of the file to find the ByteSliceExt implementation:
Assistant
And let me also check the StringExt implementation:
Assistant
Now I need to look at how masking is supposed to be applied. Let me also check what imports are already available:
Assistant
I see that
maskingis imported and the code already works withSecrettypes. Now I need to understand how to properly mask JSON values. Since I'm implementing this fix correctly, I'll now make the changes to mask sensitive data in logging. Let me now implement the fixes for each of the locations identified.Assistant
Now I'll modify the ValueExt::parse_value method to mask sensitive data before logging:
Assistant
Let me first make sure we're looking at the right file and make the proper modification. I need to understand how to properly mask sensitive values. Let me research how masking works in this project by examining how Secret types are handled elsewhere:
Assistant
Let me look at how other parts of the codebase handle masking of sensitive values by examining the masking pattern used in the project:
Assistant
Looking at the codebase, I can see that the issue is in these four locations where the raw data gets logged:
- Line 224 in
ValueExt::parse_value- logs&selfdirectly - Line 178 in
BytesExt::parse_struct- logsself:?directly - Line 205 in
ByteSliceExt::parse_struct- logs&selfdirectly - Line 292 in
StringExt::parse_struct- logs&selfdirectly
But to properly mask sensitive data, I need to understand what the
Secrettype provides. Since I can see that the code already importsmasking::{ExposeInterface, PeekInterface, Secret, Strategy}, let me check how masking works with serde_json::Value.Actually, let me first implement a simple fix by modifying the logging to avoid printing the sensitive data. Based on the bug report and code analysis, I need to create a new version of the logging that doesn't expose the sensitive data in plain text.
- Line 224 in
Assistant
I need to make the changes with appropriate permissions. Let me first check what the current git status is to understand what we're working with.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →