You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_8 (already cloned)
- Base commit: 953bace38c1509c95fc8c1e2426fda72c65e3bf8
- Task ID: juspay__hyperswitch-8341
- Version: v1.114.0
TASK DESCRIPTION: Bug: chore(ci):
adyenandstripepostman tests are failingMultiple Test Cases have been failing on Postman,
- Adyen: 88 Failures
- Stripe: 3 Failures
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
Deleting API Key needs Merchant ID. So, deleting it after deleting the merchant itself yields a error message in the response which goes like
"API key not provided or invalid API key used", but, its solely because the Merchant ID used is not authenticated because the Merchant ID is already deleted.Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
The respective test case was failing in the Automated Tests Run.
How did you test it?
The Remaining failures are because of outdated certificates and their keys. Once we update that it will be like the following
Checklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_8/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll help you fix the failing Adyen and Stripe Postman tests in the hyperswitch repository. Let me start by examining the issue and understanding what's causing these test failures.
First, I'll create a plan of action to address this problem:
Assistant
Let me first explore the repository structure to understand where the Postman tests and related code might be located:
Assistant
(no content)
Assistant
Let me look at the specific error mentioned in the task description and examine the merchant deletion flow more closely:
Assistant
Let me examine the merchant deletion function specifically:
Assistant
(no content)
Assistant
Let me search for the merchant deletion function in a broader way:
Assistant
Let me search for API key deletion related functions:
Assistant
Let me examine the specific API key deletion code:
Assistant
Now let me examine the merchant deletion flow in admin.rs:
Assistant
Let me search for the merchant deletion function more broadly:
Assistant
Let me look at the specific merchant deletion function in the admin module by examining the file around the area where it's likely to be:
Assistant
Now I found the merchant deletion function. Let me see more of this function to understand the full deletion flow:
Assistant
Now I need to see the Postman test failures to better understand the issue. Let me look for Postman collection files to understand the failing test scenarios:
Assistant
Let me also check the stripe collection:
Assistant
Now, let me understand what exactly is happening with the issue. From the task description, it seems the problem is with API key deletion after merchant deletion, where the error "API key not provided or invalid API key used" occurs because the merchant ID is no longer valid.
Looking at the code, I see in the
merchant_account_deletefunction at line 1251-1255, there's a call toauthentication::decision::revoke_api_keythat uses the merchant's publishable key. But if the merchant account was already deleted (which happens before this call), then the API key verification fails because it's looking for a merchant that no longer exists.Let me first examine how the API key revocation process works and where this error is triggered:
- User
Here are the existing contents of your todo list:
[1. [pending] Investigate the failing Adyen and Stripe Postman tests to understand the root cause 2. [pending] Identify the API key deletion logic that's causing merchant ID authentication errors 3. [pending] Review the merchant deletion flow and API key cleanup process 4. [pending] Analyze test failure logs to understand specific error messages 5. [pending] Fix the API key deletion logic to handle merchant ID deletion properly]
Assistant
Based on my investigation, I now understand the issue better. Let me examine the specific error message mentioned in the task description to make sure I understand the core problem.
Let me also examine the error handling more closely to see how the authentication decision service handles missing merchants:
Assistant
Let me check what the actual error messages look like by examining more of the authentication decision service:
Assistant
Let me update my todo list with more precise actions based on my findings:
Assistant
Based on my investigation, I can now see the issue clearly. The problem is in the merchant deletion flow in
/workspace/archit/trace_generation/repos/hyperswitch_pool_8/crates/router/src/core/admin.rs.Looking at lines 1249-1258, there's a call to
authentication::decision::revoke_api_keythat attempts to revoke the merchant's publishable key after the merchant account has already been deleted. Since the merchant account no longer exists, this causes authentication errors when the decision service tries to validate the API key.The issue is that the code is trying to revoke the merchant's publishable key after the merchant has already been deleted, which leads to authentication failures in the decision service.
Let me make the fix by modifying the merchant deletion flow to prevent calling the authentication decision service for a merchant that no longer exists:
Assistant
Let me check the permissions again and proceed with the fix. I need to make the change to the merchant deletion flow to prevent calling authentication services on a deleted merchant.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →