Resolve OpenAPI $ref response objects during DSL v4 import Problem DSL v4 OpenAPI import…
- User
Resolve OpenAPI $ref response objects during DSL v4 import
Problem
DSL v4 OpenAPI import currently misses valid response objects that are expressed as
$refs.import_responsecallsselect_json_response, andselect_json_responselooks forcontentdirectly on each response object without first resolving$ref.Code references:
crates/coral-spec/src/v4/mod.rs:972crates/coral-spec/src/v4/mod.rs:1290
A valid OpenAPI shape like this is treated as if the operation has no JSON response:
responses: '200': $ref: '#/components/responses/Foo' components: responses: Foo: content: application/json: schema: type: array items: type: objectImpact
The importer falls through to
OutputCardinality::None, which causes otherwise valid read operations to be hidden/dropped from the generated projection catalog. This can make major portions of a real OpenAPI descriptor disappear from DSL v4 sources.Acceptance criteria
- Response
$refs under operation responses are resolved before selecting JSON responses. - Missing or external response refs produce diagnostics consistent with existing schema/parameter ref diagnostics.
- A regression test covers a
200response that references#/components/responses/...and verifies the projection is published.
Interface
No new interfaces are introduced.
- Assistant
I'll inspect the OpenAPI import path and how existing
$refresolution works for schemas and parameters, then add the same handling for response refs. - Assistant
Implementing response
$refresolution inselect_json_responseand adding a regression test. - Assistant
Merging the duplicate impl blocks, then adding tests.
- Assistant
Resolved response
$refs during DSL v4 OpenAPI import so operations with component response references are no longer dropped.Change
select_json_responseis now a method onOpenApiImporterthat resolves each operation response throughresolve_refbefore looking forcontent.application/json. That reuses the same ref handling as parameters and schemas:#/components/responses/...refs resolve to the component response- Missing refs emit
OPENAPI_REF_NOT_FOUND - External refs emit
OPENAPI_EXTERNAL_REF_UNSUPPORTED
fn select_json_response( &self, operation_id: &str, responses: Option<&Map<String, Value>>, diagnostics: &mut Vec<Diagnostic>, ) -> Option<(u16, String, Value)> { let responses = responses?; let mut candidates = Vec::new(); for (status, response) in responses { // ... let Some(resolved) = self.resolve_ref(response, operation_id, diagnostics) else { continue; }; let Some(content) = resolved.get("content").and_then(Value::as_object) else { continue; }; // ... } candidates .into_iter() .min_by_key(|(status, _, _)| (*status != 200, *status)) }Tests
Added two regression tests in
openapi_tests.rs:importer_resolves_response_component_refs— a200response referencing#/components/responses/FooproducesOutputCardinality::Listand a published table projectionimporter_warns_for_missing_response_component_refs— a missing response ref emitsOPENAPI_REF_NOT_FOUNDand falls back toOutputCardinality::None
All 9 OpenAPI import tests pass.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- fable-5Compare side by side →
- fable-5Compare side by side →