Fail on HTTP Status 204 (No Content) Hello, I'm using Synadia Cloud which has a DELETE…
- User
Fail on HTTP Status 204 (No Content) Hello,
I'm using Synadia Cloud which has a
DELETEAPI that returns a response with no body.$ restish synadia delete-nats-user --help Deletes a NATS user from an account ## Argument Schema: { user-id: (string) } ## Responses 204/400/401/403/404 Response has no bodyIn this case, it's expected to have an empty body. Nevertheless,
restishfails with the error:ERROR: Parse response error ERROR: Caught error: EOFHere is the full log:
DEBUG: API loading took 6.245709ms DEBUG: Configuration: [REDACTED] DEBUG: Adding TLS configuration DEBUG: Making request: DELETE /api/core/beta/nats-users/[REDACTED] HTTP/1.1 Host: cloud.synadia.com Accept: application/msgpack;q=0.8,application/cbor;q=0.9,application/ion;q=0.6,application/json;q=0.5,application/yaml;q=0.5,text/*;q=0.2,*/* Accept-Encoding: deflate, gzip, br Authorization: [REDACTED] User-Agent: restish-0.20.0 DEBUG: Got response from server in 426.428041ms: HTTP/2.0 204 No Content Content-Encoding: gzip Date: Mon, 26 May 2025 19:48:15 GMT Set-Cookie: [REDACTED] Strict-Transport-Security: max-age=15768000 ; includeSubDomains Vary: Accept-Encoding X-Content-Type-Options: nosniff X-Frame-Options: SAMEORIGIN DEBUG: Decoding response from gzip ERROR: Parse response error ERROR: Caught error: EOF DEBUG: goroutine 1 [running]: runtime/debug.Stack() /opt/hostedtoolcache/go/1.18.10/x64/src/runtime/debug/stack.go:24 +0x68 github.com/danielgtaylor/restish/cli.Run.func1() /home/runner/work/restish/restish/cli/cli.go:849 +0x68 panic({0x1051c4f40, 0x140001900f0}) /opt/hostedtoolcache/go/1.18.10/x64/src/runtime/panic.go:838 +0x204 github.com/danielgtaylor/restish/cli.MakeRequestAndFormat(0x1052d4830?) /home/runner/work/restish/restish/cli/request.go:568 +0x118 github.com/danielgtaylor/restish/cli.Operation.command.func1(0x14000693800?, {0x1400061e8a0, 0x1, 0x2}) /home/runner/work/restish/restish/cli/operation.go:142 +0x814 github.com/spf13/cobra.(*Command).execute(0x14000693800, {0x1400061e880, 0x2, 0x2}) /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x5dc github.com/spf13/cobra.(*Command).ExecuteC(0x1400034e600) /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x35c github.com/spf13/cobra.(*Command).Execute(...) /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968 github.com/danielgtaylor/restish/cli.Run() /home/runner/work/restish/restish/cli/cli.go:857 +0x9a8 main.main() /home/runner/work/restish/restish/main.go:40 +0x370Interface
No new interfaces are introduced.
- Assistant
Investigating how Restish handles HTTP 204 responses and where the EOF parse error occurs.
- Assistant
Reproducing the bug with a test case matching the reported scenario:
- Assistant
Implementing the fix: skip body decoding for HTTP statuses that must not include a body (204, 205, 304).
- Assistant
Fixed. The Synadia DELETE API returns 204 No Content with an empty body but also sends
Content-Encoding: gzip. Restish tried to gzip-decompress that empty body, andgzip.NewReaderfails withEOF— which matches the error you saw.Root cause
Per HTTP spec, 204, 205, and 304 responses must not include a message body. Some servers still send
Content-Encodingon those responses. Restish was attempting decompression anyway.Fix
Added
ResponseHasNoBody()ininternal/output/response.goand skip body decompression/decoding for those status codes:// ResponseHasNoBody reports whether the HTTP response status forbids a message // body. Servers sometimes send Content-Encoding on these responses even though // the body must be empty; callers should not attempt to decompress or decode. func ResponseHasNoBody(resp *http.Response) bool { if resp == nil { return false } switch resp.StatusCode { case http.StatusNoContent, http.StatusResetContent, http.StatusNotModified: return true default: return false } }The same guard is applied in
rawResponseBodyBytesanddecompressedResponseBodyininternal/cli/http.gofor consistency.Tests
TestNormalize_NoContentWithContentEncoding— unit test for 204 + gzip/deflate/brTestNormalizeHTTPResponseNoContentWithContentEncoding— CLI normalization pathTestGeneratedCommandDeleteNoContentWithContentEncoding— end-to-end generated DELETE command
All tests pass. After this change,
restish synadia delete-nats-user <user-id>should succeed on a 204 response even when the server sendsContent-Encoding: gzip.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- fable-5Compare side by side →
- fable-5Compare side by side →