Skip to content
TheChatArchiveThe Chat Archive
composer-2.5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

Untitled conversation

  1. User

    [Bug] WebSocket ReaderHandler returns 500 for invalid messageId query parameter

    Search before reporting

    • I searched in the issues and found nothing similar.

    Read release policy

    • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

    User environment

    Broker Version 4.0.7 Any broker OS Any broker Java version Any WebSocket client

    Issue Description

    Minimal reproduction steps

    Connect to the WebSocket reader endpoint with an invalid messageId query parameter.

    Two examples that both trigger the bug:

    1. An improperly URL-encoded base64 message ID that includes a + which the server interprets as a space (e.g. CJCj6QEQ+UQwAA== becomes CJCj6QEQ UQwAA==).

    2. An arbitrary non-base64 string: ?messageId=invalidMessageId

    What did you expect to see?

    HTTP 400 Bad Request.

    What did you see instead?

    HTTP 500 Internal Server Error in both cases.

    Case 1 — IllegalArgumentException from Base64.getDecoder().decode():

    WARN  org.apache.pulsar.websocket.ReaderHandler - [REDACTED] Failed in creating reader on topic persistent://REDACTED/REDACTED/REDACTED
    java.lang.IllegalArgumentException: Illegal base64 character 20
    	at java.base/java.util.Base64$Decoder.decode0(Unknown Source) ~[?:?]
    	at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[?:?]
    	at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[?:?]
    	at org.apache.pulsar.websocket.ReaderHandler.getMessageId(ReaderHandler.java:348) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.<init>(ReaderHandler.java:95) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.WebSocketReaderServlet.lambda$configure$0(WebSocketReaderServlet.java:44) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    

    Case 2 — IOException wrapping IndexOutOfBoundsException from MessageIdImpl.fromByteArray():

    WARN  org.apache.pulsar.websocket.ReaderHandler - [REDACTED] Failed in creating reader on topic persistent://REDACTED/REDACTED/REDACTED
    java.io.IOException: java.lang.IndexOutOfBoundsException: readerIndex(5) + length(641882) exceeds writerIndex(12): UnpooledHeapByteBuf(ridx: 5, widx: 12, cap: 12/12)
    	at org.apache.pulsar.client.impl.MessageIdImpl.fromByteArray(MessageIdImpl.java:93) ~[org.apache.pulsar-pulsar-client-original-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.getMessageId(ReaderHandler.java:348) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.<init>(ReaderHandler.java:95) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.WebSocketReaderServlet.lambda$configure$0(WebSocketReaderServlet.java:44) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    Caused by: java.lang.IndexOutOfBoundsException: readerIndex(5) + length(641882) exceeds writerIndex(12): UnpooledHeapByteBuf(ridx: 5, widx: 12, cap: 12/12)
    	at io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at io.netty.buffer.AbstractByteBuf.checkReadableBytes(AbstractByteBuf.java:1428) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at io.netty.buffer.AbstractByteBuf.skipBytes(AbstractByteBuf.java:971) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at org.apache.pulsar.common.api.proto.LightProtoCodec.skipUnknownField(LightProtoCodec.java:264) ~[org.apache.pulsar-pulsar-common-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.common.api.proto.MessageIdData.parseFrom(MessageIdData.java:304) ~[org.apache.pulsar-pulsar-common-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.client.impl.MessageIdImpl.fromByteArray(MessageIdImpl.java:91) ~[org.apache.pulsar-pulsar-client-original-4.0.7.jar:4.0.7]
    

    Details

    ReaderHandler.getMessageId() performs no validation on the messageId query parameter before passing it to Base64.getDecoder().decode() and MessageIdImpl.fromByteArray().

    ReaderHandler's constructor catches Exception during setup but hardcodes HttpServletResponse.SC_INTERNAL_SERVER_ERROR in the error response. ConsumerHandler and ProducerHandler both call AbstractWebSocketHandler.getErrorCode(e) instead, which maps IllegalArgumentException to SC_BAD_REQUEST (400).

    Error messages

    **Case 1** — `IllegalArgumentException` from `Base64.getDecoder().decode()`:
    
    WARN  org.apache.pulsar.websocket.ReaderHandler - [REDACTED] Failed in creating reader on topic persistent://REDACTED/REDACTED/REDACTED
    java.lang.IllegalArgumentException: Illegal base64 character 20
    	at java.base/java.util.Base64$Decoder.decode0(Unknown Source) ~[?:?]
    	at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[?:?]
    	at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[?:?]
    	at org.apache.pulsar.websocket.ReaderHandler.getMessageId(ReaderHandler.java:348) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.<init>(ReaderHandler.java:95) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.WebSocketReaderServlet.lambda$configure$0(WebSocketReaderServlet.java:44) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    
    
    **Case 2** — `IOException` wrapping `IndexOutOfBoundsException` from `MessageIdImpl.fromByteArray()`:
    
    WARN  org.apache.pulsar.websocket.ReaderHandler - [REDACTED] Failed in creating reader on topic persistent://REDACTED/REDACTED/REDACTED
    java.io.IOException: java.lang.IndexOutOfBoundsException: readerIndex(5) + length(641882) exceeds writerIndex(12): UnpooledHeapByteBuf(ridx: 5, widx: 12, cap: 12/12)
    	at org.apache.pulsar.client.impl.MessageIdImpl.fromByteArray(MessageIdImpl.java:93) ~[org.apache.pulsar-pulsar-client-original-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.getMessageId(ReaderHandler.java:348) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.<init>(ReaderHandler.java:95) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.WebSocketReaderServlet.lambda$configure$0(WebSocketReaderServlet.java:44) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    Caused by: java.lang.IndexOutOfBoundsException: readerIndex(5) + length(641882) exceeds writerIndex(12): UnpooledHeapByteBuf(ridx: 5, widx: 12, cap: 12/12)
    	at io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at io.netty.buffer.AbstractByteBuf.checkReadableBytes(AbstractByteBuf.java:1428) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at io.netty.buffer.AbstractByteBuf.skipBytes(AbstractByteBuf.java:971) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at org.apache.pulsar.common.api.proto.LightProtoCodec.skipUnknownField(LightProtoCodec.java:264) ~[org.apache.pulsar-pulsar-common-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.common.api.proto.MessageIdData.parseFrom(MessageIdData.java:304) ~[org.apache.pulsar-pulsar-common-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.client.impl.MessageIdImpl.fromByteArray(MessageIdImpl.java:91) ~[org.apache.pulsar-pulsar-client-original-4.0.7.jar:4.0.7]
    

    Reproducing the issue

    Connect to the WebSocket reader endpoint with an invalid messageId query parameter.

    Two examples that both trigger the bug:

    1. An improperly URL-encoded base64 message ID that includes a + which the server interprets as a space (e.g. CJCj6QEQ+UQwAA== becomes CJCj6QEQ UQwAA==).

    2. An arbitrary non-base64 string: ?messageId=invalidMessageId

    Additional information

    ReaderHandler.getMessageId() performs no validation on the messageId query parameter before passing it to Base64.getDecoder().decode() and MessageIdImpl.fromByteArray().

    ReaderHandler's constructor catches Exception during setup but hardcodes HttpServletResponse.SC_INTERNAL_SERVER_ERROR in the error response. ConsumerHandler and ProducerHandler both call AbstractWebSocketHandler.getErrorCode(e) instead, which maps IllegalArgumentException to SC_BAD_REQUEST (400).

    Are you willing to submit a PR?

    • I'm willing to submit a PR!

    Interface

    No new interfaces are introduced.

  2. Assistant

    I'll investigate the WebSocket ReaderHandler and align its error handling with ConsumerHandler and ProducerHandler.

  3. Assistant

    Checking how other handlers parse messageId and whether IOException should map to 400.

  4. Assistant

    Implementing the fix: use getErrorCode/getErrorMessage in the constructor and validate messageId in getMessageId().

  5. Assistant

    Fixed the bug. ReaderHandler was returning HTTP 500 for invalid messageId values because it hardcoded SC_INTERNAL_SERVER_ERROR instead of using the shared error-mapping logic.

    Changes

    1. ReaderHandler constructor — use getErrorCode(e) and getErrorMessage(e), matching ConsumerHandler and ProducerHandler:

                try {
                    response.sendError(getErrorCode(e), getErrorMessage(e));
    

    2. getMessageId() — treat invalid base64 and malformed message IDs as IllegalArgumentException so they map to HTTP 400:

        private MessageId getMessageId() {
            MessageId messageId = MessageId.latest;
            if (isNotBlank(queryParams.get("messageId"))) {
                String messageIdParam = queryParams.get("messageId");
                if (messageIdParam.equals("earliest")) {
                    messageId = MessageId.earliest;
                } else if (!messageIdParam.equals("latest")) {
                    try {
                        messageId = MessageIdImpl.fromByteArray(Base64.getDecoder().decode(messageIdParam));
                    } catch (IllegalArgumentException | IOException e) {
                        throw new IllegalArgumentException("Invalid messageId: " + messageIdParam, e);
                    }
                }
            }
            return messageId;
        }
    

    This covers both cases from the report:

    • Case 1 (IllegalArgumentException from base64 decode, e.g. space instead of +)
    • Case 2 (IOException from MessageIdImpl.fromByteArray() for arbitrary strings)

    3. Tests — added testInvalidMessageIdReturnsBadRequest and testImproperlyEncodedMessageIdReturnsBadRequest, and updated testCreateIllegalReaderImp to assert SC_BAD_REQUEST.

    I couldn't run the Maven tests here (no pom.xml in this workspace). To verify locally:

    mvn -pl pulsar-websocket -Dtest=ReaderHandlerTest test
    

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.