linter: no-unused-vars false positive when constructor parameter property shadows an…
- User
linter: no-unused-vars false positive when constructor parameter property shadows an imported identifier used in its own decorator
What version of Oxlint are you using?
1.65.0 (also reproduces on 1.30.0)
What command did you run?
oxlint test.tsWhat does your
.oxlintrc.json(oroxlint.config.ts) config file look like?// default (no config file)What happened?
When a TypeScript constructor parameter property has the same name as an outer binding (import or
const), and that outer binding is used in the parameter's own decorator expression (e.g.@Inject(foo.KEY)), oxlint'sno-unused-varsreports the outer binding as declared but never used.This is a false positive. Parameter decorators are evaluated at class-decoration time in the enclosing class scope, before any parameter binding exists in the parameter scope. So
fooinside@Inject(foo.KEY)resolves to the outer binding, not to the same-named parameter property.This pattern is extremely common in NestJS code, where
@Inject(someConfig.KEY)is used to injectregisterAs(...)-style typed configs and the constructor parameter property is typically named after the config. The false positive forces a churn-y workaround: either alias the import (import { foo as _foo }) or rename the parameter property.Minimal reproduction
const foo = { KEY: 'token' }; declare function Inject(token: unknown): ParameterDecorator; export class C { constructor(@Inject(foo.KEY) private readonly foo: number) {} }Actual
! eslint(no-unused-vars): Variable 'foo' is declared but never used. Unused variables should start with a '_'. ,-[test.ts:1:7] 1 | const foo = { KEY: 'token' }; : ^|^ : `-- 'foo' is declared hereExpected
No diagnostics —
foois used in@Inject(foo.KEY).ESLint with
@typescript-eslint/parser+@typescript-eslint/eslint-plugindoes not report this — its scope analyser correctly counts the decorator expression as a use of the outer binding.Notes / related issues
- #20670 — sibling bug (type param shadowed by function arg), same family.
- #17927 — closed namespace-shadow case (
namespaceshadowed by generic). - #2180 — typescript-eslint umbrella tracker.
Interface
No new interfaces are introduced.
- Assistant
Investigating how
no-unused-varshandles constructor parameter decorators and shadowing — this looks like a scope-analysis bug. - Assistant
Reproducing the bug, then checking how semantic analysis orders parameter binding vs decorator visits.
- Assistant
The issue is that
visit_formal_parameterbinds the parameter before visiting decorators, so decorator expressions resolve to the parameter instead of the outer binding. Reordering to matchast_visit. - Assistant
The reorder didn't fix it — checking when the function scope and parameter bindings are created.
- Assistant
Decorator references are still resolved after all parameters are bound. Resolving them immediately after visiting each parameter's decorators.
- Assistant
Fix confirmed. Running broader tests and updating snapshots.
- Assistant
This was a semantic scoping bug, not a
no-unused-varsrule bug. The rule was correctly reportingfooas unused because semantic analysis never recorded a read of the outerfoo.Root cause
In
visit_formal_parameter, the builder was:- Binding the parameter name into the function scope
- Visiting decorator expressions
- Deferring reference resolution until after all parameters were bound
So in:
constructor(@Inject(foo.KEY) private readonly foo: number) {}the
fooin@Inject(foo.KEY)was resolved to the parameterfoo(which has no reads), not the outerconst foo.Fix
In
crates/oxc_semantic/src/builder.rs:- Visit parameter decorators before binding the parameter (matching
oxc_ast_visitorder) - Immediately resolve references created in those decorators, before the parameter symbol exists in scope
- Extract
resolve_references_since_checkpoint()for reuse
Tests added
- Semantic integration test:
test_parameter_decorator_shadowed_outer_binding no-unused-varspass case intypescript_eslint.rsfor the NestJS-style pattern
All related tests pass, and the minimal repro now reports 0 warnings.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- fable-5Compare side by side →
- fable-5Compare side by side →