Treat OpenAPI path parameters as required in v4 import This tracks unresolved feedback…
- User
Treat OpenAPI path parameters as required in v4 import This tracks unresolved feedback identified by cubic on PR #1149: https://github.com/withcoral/coral/pull/1149#discussion_r3347190640
Context: This appears to be pre-existing DSL v4 behavior surfaced by the refactor review, not a regression from the module split.
Problem: OpenAPI path parameters are imported as optional when
requiredis omitted, even though path parameters are required by OpenAPI. This can misclassify required path inputs as optional SQL filters.Acceptance criteria: Import path parameters as required regardless of an omitted
requiredfield, preserve explicit behavior for non-path parameters, and add focused importer/projection coverage.Interface
No new interfaces are introduced.
- Assistant
I'll locate the v4 OpenAPI importer and how it handles path parameter
required, then align it with the OpenAPI rule that path params are always required. - Assistant
Implementing the fix: path parameters default to required per OpenAPI, and adding focused importer and projection tests.
- Assistant
Path parameters are now always imported as required in the v4 OpenAPI importer, matching the OpenAPI spec.
Change
In
operations.rs, parameter requiredness is resolved through a newparameter_requiredhelper:fn parameter_required( location: OpenApiParameterLocation, parameter_obj: &Map<String, Value>, ) -> bool { if location == OpenApiParameterLocation::Path { return true; } parameter_obj .get("required") .and_then(Value::as_bool) .unwrap_or(false) }- Path parameters: always
required: true, even when therequiredfield is omitted (or incorrectly set tofalse) - Query/header/cookie parameters: unchanged — default to optional unless
required: trueis set explicitly
Version bump
OPENAPI_IMPORTER_VERSIONis bumped fromopenapi-v2toopenapi-v3so existing materialized v4 sources are flagged for re-add and pick up the corrected semantics.Tests
importer_treats_omitted_path_parameters_as_required— importer-level coverage for path vs query requirednessprojection_marks_omitted_path_parameters_as_required_filters— projection/filter coverage confirming path inputs surface as required filters, not optional ones
All 221
coral-spectests pass. - Path parameters: always
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- fable-5Compare side by side →
- fable-5Compare side by side →