Skip to content
TheChatArchiveThe Chat Archive
composer-2.5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

Untitled conversation

  1. User

    [PRO]: unsetAllMarks deletes comments

    Affected Packages

    extension-comments

    Version(s)

    2.17.5

    Description of the Bug

    Our Tiptap editor has a "clear formatting" button that calls unsetAllMarks to remove formatting from the selection.

    We noticed, however, that if the selection includes content associated with a comment, the comment is also deleted (presumably because the <span> element wrapping the content is removed).

    Is this a bug? I can see how we might want unsetAllMarks to include comments, if we consider the comment tag a "mark," but at the same time I imagine users would generally not expect unsetAllMarks to delete comments.

    For now, as a workaround, we are calling unsetMark separately for all non-comment marks, e.g.

    editor.chain().focus().unsetMark('link').unsetMark('bold').unsetMark('strike') ...
    

    ... but would be nice to be able to use unsetAllMarks again for formatting-specific marks. Thanks!

    Browser Used

    Chrome

    Code Example (Preferred)

    No response

    Expected Behavior

    unsetAllMarks will remove formatting marks (listed here) but not remove comment tags or comments.

    Additional Context (Optional)

    No response

    Dependency Updates

    • Yes, I've updated all my dependencies.

    Evaluation contract

    Marks are clearable by default. A mark configured with clearable: false must survive unsetAllMarks(), while unsetAllMarks({ignoreClearable: true}) removes it. Calling can().unsetAllMarks() on a selection containing only non-clearable marks is a successful no-op and must return true; explicitly calling unsetMark may still remove a non-clearable mark.

    Interface

    Type: Mark configuration option Name: MarkConfig.clearable Path: packages/core/src/Mark.ts Type: boolean | (() => boolean) Default: true Description: Controls whether unsetAllMarks removes this mark. Set false for semantic marks such as comments that must survive clear-formatting operations.

    Type: Command Name: unsetAllMarks Path: packages/core/src/commands/unsetAllMarks.ts Input: options?: { ignoreClearable?: boolean } Output: ReturnType Description: Removes clearable marks from the current selection. Marks configured with clearable: false are preserved unless ignoreClearable is true. can().unsetAllMarks() returns true when the selection contains only non-clearable marks; this case is a successful no-op.

  2. Assistant

    I'll implement MarkConfig.clearable and update unsetAllMarks so comment marks survive clear-formatting. Exploring the current mark and command implementation first.

  3. Assistant

    Implementing clearable on marks and updating unsetAllMarks to respect it.

  4. Assistant

    Implemented support for MarkConfig.clearable and updated unsetAllMarks to respect it.

    Changes

    1. MarkConfig.clearable (packages/core/src/Mark.ts)
      New option (default: true). Set to false for semantic marks like comments that should survive clear-formatting.

    2. ExtensionManager.nonClearableMarks (packages/core/src/ExtensionManager.ts)
      Collects mark names with clearable: false at setup, following the same pattern as splittableMarks.

    3. unsetAllMarks command (packages/core/src/commands/unsetAllMarks.ts)

      • Removes only clearable marks by default
      • Accepts { ignoreClearable: true } to remove all marks
      • can().unsetAllMarks() returns true when the selection only has non-clearable marks (successful no-op)
    4. Tests (packages/core/__tests__/unsetAllMarks.spec.ts)
      Covers all evaluation contract cases.

    Usage

    For the comments extension (not in this repo), set:

    Mark.create({
      name: 'comment',
      clearable: false,
      // ...
    })
    

    Then unsetAllMarks() can be used again for clear formatting:

    editor.chain().focus().unsetAllMarks().run()
    

    unsetMark('comment') still removes comments explicitly when needed.

    All 1068 unit tests pass. Please review the changes and let me know if you'd like anything adjusted — for example, a changeset or updating extension-comments if that package is available elsewhere.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.