Untitled conversation
- User
[BUG][auto] deadcode-trailing-semicolon-empty-stmt: trailing-semicolon empty statement reported as unreachable warning (code=";", col 0-0)
Description
The dead-code detector emits a
warning-severityunreachable_branchfinding whosecodefield is a bare;(an empty statement) whenever areturn/raisestatement is written with a trailing semicolon. In Python a trailing;is a valid (if unusual) statement separator, soraise X;parses asraise Xfollowed by an empty statement. That empty statement is technically unreachable, but reporting a no-op as actionable dead code is pure noise — there is nothing for the user to "remove" beyond a stylistic semicolon, and the finding points at literal;with an impossible0-0column range.Repro
Minimal synthetic Python (
semi_repro.py):def f(x): if x is None: raise ValueError("nope"); return x def g(y): return y;Run:
pyscn analyze --json --no-open semi_repro.pyActual output
Two dead-code findings (from the generated JSON report):
{"function_name": "f", "location": {"start_line": 3, "start_column": 0, "end_column": 0}, "code": ";", "reason": "unreachable_branch", "severity": "warning"} {"function_name": "g", "location": {"start_line": 8, "start_column": 0, "end_column": 0}, "code": ";", "reason": "unreachable_branch", "severity": "warning"}Expected behavior
Empty statements (the no-op produced by a trailing
;) should be filtered out before emitting dead-code findings — they carry no actionable signal. At most this is a low-severity style hint ("redundant trailing semicolon"), not awarning-severity unreachable-code finding. The0-0column range is also a symptom of the synthetic/empty node being reported.Priority rationale
P2 (visible but bounded inaccuracy, per the FP-audit rubric): the gist isn't wrong (the
;truly follows a terminating statement), but the output is misleading — awarningthat points at literal;with a0-0column range reads as a real defect when there is none. Bounded impact: only fires on the rare trailing-semicolon style.Suggested fix (good first issue)
Skip CFG nodes that correspond to empty statements (Python
pass-equivalent / bare;separators) when collecting unreachable-branch findings in the dead-code analyzer.
pyscn version:
v1.22.5(commitbac7f16)Found via the FP-audit skill in repo
bioconvert/bioconvert@92f4655(4 real occurrences:bioconvert/utils/biocode/gff.py:618,tbl.py:114,things.py:753and:780).Interface
No new interfaces are introduced.
- Assistant
I'll track down where unreachable-branch findings are emitted and filter out empty-statement nodes from that path.
- Assistant
Reproducing the issue, then implementing the fix.
- Assistant
Reproduced the bug. Adding a no-op statement helper and filtering those blocks in reachability analysis.
- Assistant
The table-driven test counts raw unreachable blocks, so I'll add a dedicated test that uses the dead-code detector.
- Assistant
Fixed. Trailing-semicolon empty statements (
;) were treated as real dead code because unreachable blocks with only no-op statements still passedGetUnreachableBlocksWithStatements().Changes:
-
internal/analyzer/cfg.go— AddedisNoOpStatement()(matchespassand bare;) andBasicBlock.HasOnlyNoOpStatements(). -
internal/analyzer/reachability.go— UpdatedGetUnreachableBlocksWithStatements()andHasUnreachableCode()to skip blocks that contain only no-op statements. -
internal/analyzer/dead_code_test.go— AddedTestDeadCodeTrailingSemicolonIgnoredfor the repro case. -
testdata/python/edge_cases/semi_repro.py— Added the repro fixture.
Running
pyscn analyzeon the repro now reportsdead_code_count: 0instead of twounreachable_branchwarnings withcode: ";"and0-0column ranges. All analyzer tests pass. -
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- fable-5Compare side by side →
- fable-5Compare side by side →