Skip to content
TheChatArchiveThe Chat Archive
gpt-5.6-sol· openaiHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

Pages Router: gssp/getStaticProps responses missing default and user-set Cache-Control…

  1. User

    Pages Router: gssp/getStaticProps responses missing default and user-set Cache-Control header

    This issue was created by an agent analysing CI failures from the Next.js Deploy Suite (vinext main vs Next.js v16.2.6, 2026-05-22).

    Problem

    Pages Router gssp responses lack Cache-Control headers. Tests expect the default private, no-cache, no-store, max-age=0, must-revalidate for gssp pages and custom values set via res.setHeader('Cache-Control', ...), but vinext returns null. The default header is not applied and user setHeader calls are dropped.

    Expected: "private, no-cache, no-store, max-age=0, must-revalidate"
    Received: null
    

    Estimated Impact

    ~2 test failures across the deploy suite.

    Affected Test Suites

    • test/e2e/getserversideprops/test/index.test.ts (2 failures)

    Recommendation

    1. Reproduce first in vinext's own test suite. Add a Pages Router gssp page and assert the response carries the default Cache-Control header; add a second page that overrides it via res.setHeader and assert the override sticks.

    2. Emit the default gssp Cache-Control. When serving a gssp response in deploy mode, set Cache-Control: private, no-cache, no-store, max-age=0, must-revalidate unless the user set it explicitly.

    3. Preserve res.setHeader overrides. Make sure headers set during gssp dispatch are forwarded to the final HTTP response.

    Interface

    No new interfaces are introduced.

  2. Assistant

    I’ll trace the Pages Router response path in dev and production, first checking the local Next.js reference tests/source as required. Then I’ll add focused regression coverage and implement header propagation/defaulting in both paths.

  3. Assistant

    vp is not installed in this environment, so I’ll use the repository’s pnpm commands for installation and targeted validation.

  4. Assistant

    rg is also unavailable, so I’m falling back to find/grep. The worktree status is clean.

  5. Assistant

    The repository already has most custom-header forwarding in place, but the framework default is never attached. I also found that production data responses and HTML share a mutable gSSP response object, so applying the default immediately after gSSP returns will cover both without duplicating response logic; dev needs the equivalent treatment.

  6. Assistant

    I’m going to centralize gSSP header application in the typed Pages response helper and reuse it from the generated data-response wiring. This keeps the production HTML and /_next/data paths aligned, while the dev server gets the same default at the point it captures Node response headers.

  7. Assistant

    The focused helper tests pass. I’m now running the actual Pages Router fixture checks in dev and production, including the newly asserted default and override behavior.

  8. Assistant

    Both HTML and /_next/data regression checks now pass in dev and production. I’m doing the repository’s format/lint/type validation next, then I’ll review the final diff for unintended changes.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.