Tasks PR Upstream source still queries origin This was generated by AI during triage.…
- User
Tasks PR Upstream source still queries origin
This was generated by AI during triage.
Summary
In the Tasks page, selecting the
PRstab and choosingUpstreamin the source selector can showNo matching GitHub workeven when matching upstream PRs exist.The upstream/origin selector is visible in the PRs view, but the GitHub client still resolves PR list/count queries from
origin, sois:pr is:open author:@mesearches the fork/origin repo instead of the selected upstream repo.Reproduction
- Open a forked repository in Orca where
originpoints to the fork andupstreampoints to the canonical repo. - Open Tasks.
- Select
PRs. - Select
Upstreamin the source selector. - Use a PR-only query such as
is:pr is:open author:@me.
Actual behavior
The list can be empty with
No matching GitHub work, despite matching PRs existing in the upstream repository.Expected behavior
When
Upstreamis selected, PR list and PR count queries should use the upstream owner/repo, so the PRs tab returns matching upstream PRs.Code evidence
src/main/github/client.tsresolvesissueResolvedwith the selected preference, but resolvesprOwnerReposeparately viagetOwnerRepo(repoPath, connectionId), which is the origin repo.listWorkItemspasses thatprOwnerRepointo both recent and queried PR fetches.countWorkItemsuses the sameprOwnerRepofor PR count queries, so pagination/count can also be wrong.src/renderer/src/components/TaskPage.tsxrenders the selector usingorigin={s.sources.prs}andupstream={s.sources.upstreamCandidate}, which makes the control appear relevant in the PRs surface while the backend still routes PR queries to origin.
Suggested regression coverage
Add tests for:
listWorkItems('/repo-root', 10, 'is:pr is:open author:@me', undefined, 'upstream')using the upstream slug in--repo.countWorkItems('/repo-root', 'is:pr is:open author:@me', 'upstream')building a search query withrepo:<upstream-owner>/<repo>.
Interface
No new interfaces are introduced.
- Open a forked repository in Orca where
- Assistant
I’ll trace the GitHub client’s source-resolution path, patch PR list/count routing, and add focused regression tests.
- Assistant
rgisn’t installed in this workspace, so I’m using targetedgrep/findsearches. The client already has separate issue-source resolution; I’m narrowing the smallest consistent change and existing test harness. - Assistant
The intended compatibility rule is clear from existing coverage:
autokeeps upstream issues plus origin PRs, while an explicitupstreamchoice should route both work-item kinds to the resolved upstream (and naturally fall back to origin if that remote disappeared). I’m preserving that distinction. - Assistant
The implementation and focused regressions are in place. I’m running the new test plus the broader work-item/source suites now; after that I’ll run type/lint checks targeted to the changed files.
- Assistant
The broader suites pass; the new count assertion caught that the existing counter correctly preserves
author:@mein addition to the upstream repo qualifier. I’m tightening the expected query to reflect the full request, then rerunning checks. - Assistant
The tests are green. The repository’s formatter requested a mechanical wrap adjustment in the new test file; I’m applying that and completing the node typecheck (the earlier ESLint attempt was inapplicable because this project uses Oxlint).
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- fable-5Compare side by side →
- fable-5Compare side by side →