Untitled conversation
- User
[BUG] S3 GetObject suffix range fails for empty objects
Service
S3
AWS API Action
GetObject with the
Rangeheader set to a suffix byte range, for examplebytes=-1.Expected behavior
A suffix range request against an existing empty object should not fail the read. This is exercised by Trino's S3 filesystem compatibility test for empty files, where
TrinoInput.readTail(...)reads an existing zero-byte S3 object and expects an empty successful read.Actual behavior
Floci returns
416 InvalidRangefor the same request becauseS3Controller.handleRangeRequestcomputesstart = 0andend = -1for an empty object, then rejects the range.In Trino's Floci-backed S3 filesystem test this surfaces as:
software.amazon.awssdk.services.s3.model.S3Exception: The requested range is not satisfiable. (Service: S3, Status Code: 416)Reproduction
# Start Floci on localhost:4566 first. aws --endpoint-url http://localhost:4566 s3 mb s3://range-empty-repro printf '' > /tmp/empty-object aws --endpoint-url http://localhost:4566 s3 cp /tmp/empty-object s3://range-empty-repro/empty aws --endpoint-url http://localhost:4566 s3api get-object \ --bucket range-empty-repro \ --key empty \ --range 'bytes=-1' \ /tmp/range-empty-outputEnvironment
- Floci version / image tag:
floci/floci:1.5.21 - Java SDK version (if applicable): observed with Trino's AWS SDK v2 S3 client tests
- How you're running Floci (Docker / native /
mvn quarkus:dev): Docker via Testcontainers
Interface
No new interfaces are introduced.
- Floci version / image tag:
- Assistant
Now let me check existing tests for range handling:
- Assistant
Now add an integration test. Let me look at test ordering near the range tests:
- Assistant
All 99 S3 integration tests pass. Let me confirm the new test executed:
- Assistant
The new test ran and passed. Let me also run the other S3 test classes that exercise the controller:
- Assistant
All green. The fix is complete.
Summary
Bug:
GetObjectwith a suffix range (Range: bytes=-1) against an empty object returned416 InvalidRange, becausehandleRangeRequestcomputedstart = 0, end = -1and hit thestart > endrejection. Real S3 ignores a suffix range on a zero-byte object and returns200 OKwith the full (empty) body — which Trino'sreadTailon empty files depends on.Changes:
-
src/main/java/io/github/hectorvent/floci/services/s3/S3Controller.javahandleRangeRequestnow returnsnullwhen a suffix range (bytes=-N) targets a zero-byte object, signaling the caller to fall through (S3Controller.java:648-652).- The
getObjectcall site checks fornulland falls through to the normal200full-object response path (S3Controller.java:593-598). - Behavior for start-based ranges on empty objects (
bytes=0-) is unchanged — still416, matching real S3.
-
src/test/java/io/github/hectorvent/floci/services/s3/S3IntegrationTest.java- New
getEmptyObjectWithSuffixRangetest (Order 41): puts an empty object, assertsbytes=-1returns200withContent-Length: 0and empty body, and assertsbytes=0-still returns416withContent-Range: bytes */0.
- New
Verification:
S3IntegrationTest(99 tests),PreSignedUrlIntegrationTest(14), andS3PresignedPostIntegrationTest(19) all pass with no failures. -
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- composer-2.5Compare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- fable-5Compare side by side →