Skip to content
TheChatArchiveThe Chat Archive
fable-5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

Untitled conversation

  1. User

    [tabs] Tabs.Panel content not rendered if a child component suspends without boundary within Tabs.Root

    Bug report

    Current behavior

    If a tab panel has a child that suspends and the suspense unmounts the tab root (i.e., the next boundary is outside the Tabs.Root component), the panel content is not rendered when opening a tab for the first time.

    Only when clicking the trigger a second time, the panel is rendered.

    Expected behavior

    The panel content is rendered also when first opening a tab like it did in v1.4.1.

    Reproducible example

    Click on tab B in this Stackblitz

    Alternatively, run this code snippet locally:

    import { Tabs } from '@base-ui/react/tabs';
    import { Suspense, use } from 'react';
    
    // Promise used to suspend.
    const dataPromise = new Promise<string>((resolve) =>
      setTimeout(() => resolve('Panel B is rendered'), 500)
    );
    
    function SuspendingChild() {
      return <div>{use(dataPromise)}</div>;
    }
    
    export default function App() {
      return (
        // The Suspense boundary is outside the <Tabs.Root> and the panels/panel content don't use a separate suspense boundary.
        <Suspense fallback={<div>Loading…</div>}>
          <Tabs.Root defaultValue="a">
            <Tabs.List>
              <Tabs.Tab value="a">Tab A</Tabs.Tab>
              <Tabs.Tab value="b">Tab B</Tabs.Tab>
            </Tabs.List>
            <Tabs.Panel value="a">Panel A (no suspense)</Tabs.Panel>
            <Tabs.Panel value="b">
              <SuspendingChild />
            </Tabs.Panel>
          </Tabs.Root>
        </Suspense>
      );
    }
    
    

    Base UI version

    The only affected version is v1.5.0

    v1.4.1 is not affected

    Which browser are you using?

    Reproducible in Chrome/Safari/Firefox

    Additional context

    Potentially a side effect of https://github.com/mui/base-ui/pull/4704

    Interface

    No new interfaces are introduced.

  2. Assistant

    Now let me look at the composite list infrastructure to understand tab registration:

  3. Assistant

    Let me check what #4704 changed in TabsRoot:

  4. Assistant

    Now let me add a repro test to confirm the diagnosis:

  5. Assistant

    All jsdom tests pass. Let me also run the Chromium env since 26 tests are skipped in jsdom:

  6. Assistant

    All checks pass. Final review of the changes:

  7. Assistant

    The fix is complete. Summary:

    Root cause

    The regression came from #4704, which added an automatic fallback in TabsRoot: when the tab registration map becomes empty after tabs had registered, the value is committed to null with reason 'missing' (previously the effect just bailed out when tabMap.size === 0).

    When a panel child suspends and the nearest Suspense boundary is outside Tabs.Root, React doesn't unmount the tree — it hides it (keeping the DOM nodes connected with display: none) and destroys its layout effects. That destroys each tab's registration effect, transiently emptying tabMap. When the tree reappears, the fallback effect ran with the empty map before the tabs re-registered and committed value = null, deselecting the tab the user had just clicked. That's why the panel only appeared on the second click.

    Fix (packages/react/src/tabs/root/TabsRoot.tsx)

    TabsRoot now keeps a snapshot of the most recently registered tab elements. When the registration map is empty, it distinguishes the two cases via isConnected:

    • Tabs genuinely removed → their elements are disconnected from the DOM → commit the null / 'missing' fallback as before.
    • Tree hidden by a suspended descendant → the elements are still connected → keep the current selection; the tabs re-register when the tree reappears.

    Verification

    • New regression test in TabsRoot.test.tsx (Suspense integration) reproducing the issue's exact scenario — failed before the fix (both tabs ended up aria-selected="false" with no panel), passes after.
    • All 210 Tabs tests pass in both jsdom and Chromium, including the existing 'missing'-fallback tests for genuinely removed tabs.
    • pnpm typescript, pnpm eslint, and pnpm prettier all pass.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.