You are working on the hyperswitch repository (Rust payment processing system).…
- User
You are working on the hyperswitch repository (Rust payment processing system).
REPOSITORY SETUP:
- Repository: juspay/hyperswitch
- Working directory: ./repos/hyperswitch_pool_9 (already cloned)
- Base commit: 8446ffbf5992a97d79d129cade997effc60fcd85
- Task ID: juspay__hyperswitch-9063
- Version: v1.116.0
TASK DESCRIPTION: Bug: Change Underscore(_) to hyphen(-) in payment link locale.
Change Underscore(_) to hyphen(-) in payment link locale.
DETAILED CONTEXT & HINTS:
Type of Change
- Bugfix
- New feature
- Enhancement
- Refactoring
- Dependency updates
- Documentation
- CI/CD
Description
Change Underscore(_) to hyphen(-) in payment link locale according to ISO standards.
Additional Changes
- This PR modifies the API contract
- This PR modifies the database schema
- This PR modifies application configuration/environment variables
Motivation and Context
We need to follow ISO standards when accepting the locale for payment links.
How did you test it?
curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: **' \ --header 'Accept-Language: zh-hant' \ --data '{ "amount": 10, "setup_future_usage": "off_session", "currency": "EUR", "payment_link": true, "session_expiry": 60, "return_url": "https://google.com", "payment_link_config": { "theme": "#14356f", "logo": "https://logo.com/wp-content/uploads/2020/08/zurich.svg", "seller_name": "Zurich Inc." } }'zh-hant - should see traditional chinese zh_hant - english zh-hant-abcdef - traditional chinese zh - simplified chinese Zh - simplified chinese ZH-HANT - traditional chinese zh-abcdef - simplified chineseChecklist
- I formatted the code
cargo +nightly fmt --all - I addressed lints thrown by
cargo clippy - I reviewed the submitted code
- I added unit tests for my changes where possible
CRITICAL INSTRUCTIONS - WORK FAST AND EFFICIENTLY:
-
Create DENSE, ACTION-FOCUSED todos IMMEDIATELY
- Make todos specific and actionable
- Focus on HIGH-IMPACT actions only
- 5-8 todos maximum - be surgical, not exhaustive
-
Execute aggressively:
- Use bash commands to search efficiently
- Read multiple related files in quick succession
- Make ALL related changes in one edit
- Skip unnecessary exploration
-
File operations:
- All repo files: './repos/hyperswitch_pool_9/'
- Use targeted edits over whole file rewrites
-
NO TESTING UNLESS CRITICAL:
- Focus on making the actual code changes
- Only test if explicitly required
-
Maximize information density:
- Each turn should accomplish significant work
- Batch file reads when examining related code
- Use search commands to locate code quickly
EFFICIENCY IS CRITICAL. Make substantial progress every turn.
Assistant
I'll help you implement the bug fix to change underscores to hyphens in payment link locale according to ISO standards. Let me start by exploring the codebase to understand how payment link locales are currently handled.
First, I'll create a todo list to track the key tasks:
Assistant
Let me start by searching for files related to payment links and locale handling to understand the current implementation.
Assistant
Now let me search for locale-related code and Accept-Language handling:
Assistant
Let me also search for Accept-Language specifically:
Assistant
Let me look at the locale.rs file which seems relevant, and also check payment link related files:
Assistant
(no content)
Assistant
Let me look at the API models to understand the structure better:
Assistant
Let me search more specifically for the locale handling and look at the payment link configuration structures:
Assistant
Let me examine the payment link API models:
Assistant
Let me check specifically in the payment_link.rs file in the API models:
Assistant
Let me examine the PaymentLinkDetails struct to understand how locale is handled:
Assistant
Now I can see that both
PaymentLinkDetailsandPaymentLinkStatusDetailshave alocalefield of typeOption<String>(line 8616 and 8675). Let me check where the Accept-Language header is processed and how the locale is derived. Let me look at the middleware and request handling:Assistant
Perfect! I can see the
AddAcceptLanguageHeadermiddleware (lines 320-399) handles the Accept-Language header processing. Now I need to check where the locale is being used in the payment link creation flow. Let me examine the routes for payment link creation:Assistant
Now let me check the core payment link module where the actual processing happens. Let me also search for where the state.locale is used:
Assistant
Let me now check where locale conversion actually happens in the payment_link.rs. Based on what I've seen, I see that state.locale is used but it looks like it's not being converted from underscores to hyphens. Let me look closely at the relevant code again in the payment_link.rs file where the locale gets set:
Assistant
Let me look more carefully around lines 274, 310, 1041 in the payment_link.rs to see how the locale is being passed:
Assistant
And around line 1041:
Assistant
I need to now check where
state.localeis coming from and what it looks like originally. Looking at the middleware code, I can see it's derived from the Accept-Language header, but there's no conversion from underscores to hyphens happening. According to the issue, the problem is that ISO standards require hyphens (-) not underscores (_) in locale identifiers.Based on the test examples in the issue description, I can see:
zh-hant- should see traditional chinese (correct)zh_hant- english (wrong - should be traditional chinese)
So the problem is that when locale comes in with underscores from Accept-Language headers, it's being used as-is, but ISO standards require hyphens.
Let me first update the todo list to reflect the actual task:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →
claude-sonnet-4-5-20250929Compare side by side →