crash at hr = mcopyAllocator->Reset(); 3D12 ERROR: ID3D12CommandAllocator::Reset: A…
- User
crash at hr = m_copyAllocator->Reset(); 3D12 ERROR: ID3D12CommandAllocator::Reset: A command allocator 0x0000024649B7BF20:'Unnamed ID3D12CommandAllocator Object' is being reset before previous executions associated with the allocator have completed. [ EXECUTION ERROR #552: COMMAND_ALLOCATOR_SYNC] D3D12: BREAK enabled for the previous message, which was: [ ERROR EXECUTION #552: COMMAND_ALLOCATOR_SYNC ]
- Assistant
The allocator (and the command-list that lives on it) may only be reset after the GPU has executed every command that references them.
In the code I gave you we reset the allocator immediately after submitting a copy batch:m_copyQueue->ExecuteCommandLists(1, lists); m_copyQueue->Signal(m_fence.Get(), m_fenceValue); //<– GPU hasn’t finished yet m_copyAllocator->Reset(); //<– BOOM (error #552)The GPU is still chewing on the commands, so the runtime quite correctly raises
COMMAND_ALLOCATOR_SYNC.There are two ways to fix it; pick whichever you prefer.
───────────────────────────────────────────────────────────────────────────────
- Micro-fix (one allocator, wait before Reset) ───────────────────────────────────────────────────────────────────────────────
Store the fence value that protects the allocator, and don’t reset until that value is reached.
// header -------------------------------------------------------------- UINT64 m_allocatorFenceValue = 0; // “this allocator is busy until …” // SubmitUploads ------------------------------------------------------- void SubmitUploads() { std::lock_guard lock(m_mutex); if (!m_hasPendingCopies) return; ThrowIfFailed( m_copyCommandList->Close() ); ID3D12CommandList* lists[] = { m_copyCommandList.Get() }; m_copyQueue->ExecuteCommandLists(1, lists); // Signal *before* touching the allocator again m_allocatorFenceValue = m_fenceValue; m_copyQueue->Signal(m_fence.Get(), m_allocatorFenceValue); ++m_fenceValue; m_hasPendingCopies = false; // done recording this batch } // UploadMesh (when starting a new batch) ------------------------------ void BeginRecordingIfNeeded() { if (m_hasPendingCopies) return; // already recording // wait until the allocator is free if (m_fence->GetCompletedValue() < m_allocatorFenceValue) { m_fence->SetEventOnCompletion(m_allocatorFenceValue, m_fenceEvent); WaitForSingleObject(m_fenceEvent, INFINITE); } // now we are allowed to reset / reuse it ThrowIfFailed( m_copyAllocator->Reset() ); ThrowIfFailed( m_copyCommandList->Reset(m_copyAllocator.Get(), nullptr) ); m_hasPendingCopies = true; }Call
BeginRecordingIfNeeded()at the top ofUploadMesh. That’s all – the rest of the code stays the same. The CPU only waits if you try to start recording a new batch while the previous one is still in flight.─────────────────────────────────────────────────────────────────────────────── 2. Production-grade fix (allocator & cmd-list pool) ───────────────────────────────────────────────────────────────────────────────
Never wait on the CPU; instead keep a circular array of allocators / command lists (N = swap-chain back-buffer count works well).
Each slot has its own fence value.
Before re-using the slot you check the fence; if the GPU hasn’t finished you simply spin to the next slot (or wait if all slots are busy).Skeleton:
static constexpr UINT kNumSlots = 3; struct Slot { ComPtr<ID3D12CommandAllocator> alloc; ComPtr<ID3D12GraphicsCommandList> list; UINT64 fenceValue = 0; }; Slot m_slots[kNumSlots]; UINT m_curSlot = 0; // at Initialize ------------------------------------------------------- for (UINT i=0;i<kNumSlots;++i) { device->CreateCommandAllocator (COPY, IID_PPV_ARGS(&m_slots[i].alloc)); device->CreateCommandList(0, COPY, m_slots[i].alloc.Get(), nullptr, IID_PPV_ARGS(&m_slots[i].list)); m_slots[i].list->Close(); } // BeginRecording ------------------------------------------------------ void BeginRecording() { Slot& s = m_slots[m_curSlot]; // if GPU is still using this slot – wait if (m_fence->GetCompletedValue() < s.fenceValue) { m_fence->SetEventOnCompletion(s.fenceValue, m_fenceEvent); WaitForSingleObject(m_fenceEvent, INFINITE); } ThrowIfFailed( s.alloc->Reset() ); ThrowIfFailed( s.list ->Reset(s.alloc.Get(), nullptr) ); } // SubmitUploads ------------------------------------------------------- void SubmitUploads() { if (!m_hasPendingCopies) return; Slot& s = m_slots[m_curSlot]; ThrowIfFailed( s.list->Close() ); ID3D12CommandList* l[] = { s.list.Get() }; m_copyQueue->ExecuteCommandLists(1, l); s.fenceValue = m_fenceValue; m_copyQueue->Signal(m_fence.Get(), s.fenceValue); ++m_fenceValue; // advance to next slot m_curSlot = (m_curSlot + 1) % kNumSlots; m_hasPendingCopies = false; }With N slots you can record up to N in-flight batches without ever blocking the CPU, and the allocator-sync error is gone.
─────────────────────────────────────────────────────────────────────────────── Pick your poison ───────────────────────────────────────────────────────────────────────────────
• If you just want the crash gone quickly → apply the micro-fix (1).
• If you want the typical modern Direct3D 12 pattern that never stalls the CPU → implement the slot pool (2).Both solutions keep your public interface, mesh description formats, and fence query (
handle->IsReady) unchanged.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.