ome/bobac3/rosworkspace/src/myplanner/src/myplanner.cpp: In destructor ‘virtual…
- User
ome/bobac3/ros_workspace/src/my_planner/src/my_planner.cpp: In destructor ‘virtual my_planner::MyPlanner::~MyPlanner()’: /home/bobac3/ros_workspace/src/my_planner/src/my_planner.cpp:39:12: error: ‘tf_listener_’ was not declared in this scope if(tf_listener_) { ^~~~~~~~~~~~ /home/bobac3/ros_workspace/src/my_planner/src/my_planner.cpp:40:20: error: type ‘’ argument given to ‘delete’, expected pointer delete tf_listener_; ^~~~~~~~~~~~ my_planner/CMakeFiles/my_planner.dir/build.make:62: recipe for target 'my_planner/CMakeFiles/my_planner.dir/src/my_planner.cpp.o' failed make[2]: *** [my_planner/CMakeFiles/my_planner.dir/src/my_planner.cpp.o] Error 1 CMakeFiles/Makefile2:8473: recipe for target 'my_planner/CMakeFiles/my_planner.dir/all' failed make[1]: *** [my_planner/CMakeFiles/my_planner.dir/all] Error 2 Makefile:140: recipe for target 'all' failed make: *** [all] Error 2
Assistant
Of course! This is a very common C++ error, especially when working with classes. Let's break down what the compiler is telling you and how to fix it.
The Problem: "was not declared in this scope"
The compiler error
‘tf_listener_’ was not declared in this scopeis the key. It means that when the compiler was processing your destructorMyPlanner::~MyPlanner(), it looked for a variable or object namedtf_listener_that it could access, but it couldn't find one.In C++, member functions (like constructors and destructors) can only access variables that are:
- Declared locally inside that function.
- Passed as arguments to that function.
- Declared as member variables of the class itself.
- Global variables (less common and often bad practice).
You are trying to
deletetf_listener_in your destructor, which implies it should be a member variable of yourMyPlannerclass that was allocated withnewin the constructor. The error indicates you likely forgot to declare it in your class definition, which is usually in the corresponding header file (.hor.hpp).The Cause (Most Likely Scenario)
You probably have code that looks something like this:
my_planner.h(The incorrect version)// ... other includes #include <tf/transform_listener.h> // Assuming ROS 1 namespace my_planner { class MyPlanner { public: MyPlanner(); virtual ~MyPlanner(); private: // Whoops! The declaration for tf_listener_ is missing here! }; } // namespace my_plannermy_planner.cpp(The incorrect version)#include "my_planner.h" namespace my_planner { MyPlanner::MyPlanner() { // This creates a NEW LOCAL variable named tf_listener_ // that only exists inside the constructor. It is destroyed // when the constructor finishes. tf::TransformListener* tf_listener_ = new tf::TransformListener(); } MyPlanner::~MyPlanner() { // This function has no idea what tf_listener_ is, because // it was local to the constructor and is not a member of the class. if(tf_listener_) { // ERROR: 'tf_listener_' was not declared in this scope delete tf_listener_; // ERROR: Can't delete something it doesn't know about } } } // namespace my_plannerThe second error,
type ‘<type error>’ argument given to ‘delete’, expected pointer, is a direct result of the first. Since the compiler doesn't know whattf_listener_is, it can't verify that it's a pointer that can be deleted.
The Solution
You need to declare
tf_listener_as a member variable in your class definition (the header file) and then initialize that member variable in your constructor.Step 1: Fix your Header File (
my_planner/include/my_planner/my_planner.h)Declare
tf_listener_as a private member pointer in your class.#ifndef MY_PLANNER_H_ #define MY_PLANNER_H_ // ... other includes #include <ros/ros.h> #include <tf/transform_listener.h> // For ROS 1 namespace my_planner { class MyPlanner { public: MyPlanner(); virtual ~MyPlanner(); // ... other public methods private: // Add the declaration here! tf::TransformListener* tf_listener_; }; } // namespace my_planner #endif // MY_PLANNER_H_Step 2: Fix your Source File (
my_planner/src/my_planner.cpp)Modify the constructor to initialize the member variable you just declared, instead of creating a new local one.
#include <my_planner/my_planner.h> // Use the correct include path namespace my_planner { MyPlanner::MyPlanner() { // Initialize the MEMBER variable. // Notice there is no type (tf::TransformListener*) here. tf_listener_ = new tf::TransformListener(ros::Duration(10)); // It's good practice to give it a cache time } MyPlanner::~MyPlanner() { // This code will now work correctly! if(tf_listener_) { delete tf_listener_; tf_listener_ = nullptr; // Good practice to null the pointer after deleting } } // ... other functions } // namespace my_planner
A Better, Modern C++ Solution (Highly Recommended)
Manually using
newanddeleteis error-prone. A much safer and more modern approach is to use smart pointers, likestd::unique_ptr. It will handle the deletion for you automatically, even if an exception occurs.Step 1: Update Header with
std::unique_ptr// my_planner.h #ifndef MY_PLANNER_H_ #define MY_PLANNER_H_ #include <ros/ros.h> #include <tf/transform_listener.h> #include <memory> // <<< Include this for smart pointers namespace my_planner { class MyPlanner { public: MyPlanner(); virtual ~MyPlanner(); // The destructor can now be defaulted or empty private: // Use a smart pointer std::unique_ptr<tf::TransformListener> tf_listener_; }; } // namespace my_planner #endif // MY_PLANNER_H_Step 2: Update Source File
// my_planner.cpp #include <my_planner/my_planner.h> namespace my_planner { // Use the constructor's initializer list for efficiency MyPlanner::MyPlanner() : tf_listener_(std::make_unique<tf::TransformListener>(ros::Duration(10))) { // Constructor body can be empty or do other work ROS_INFO("MyPlanner created."); } // The destructor can be empty! std::unique_ptr handles the delete automatically. MyPlanner::~MyPlanner() { ROS_INFO("MyPlanner destroyed."); } } // namespace my_plannerWith this modern approach, it's impossible to forget to
deletethe object, preventing memory leaks.After making these changes, go to your catkin workspace root, delete the
buildanddevelfolders, and re-runcatkin_make(orcatkin build).cd ~/ros_workspace rm -rf build/ devel/ catkin_make
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.