repeat again on better engines
- User
repeat again on better engines
- Assistant
Okay, let's build a more robust MQL4 indicator incorporating both Double Top and Double Bottom patterns, refined state management, object handling, and the requested parameters (min/max bars between points, lookback days).
This version uses a cleaner state machine per pattern type, more precise swing detection, proper neckline calculation between the confirmed points, checks for the min/max bar distance, handles pattern failure more explicitly, and manages chart objects effectively to avoid clutter and repainting.
//+------------------------------------------------------------------+ //| EMA 1-2 Double Pattern v2.mq4 | //| Professional Double Top/Bottom Detector | //| With Min/Max Pattern Bars & Lookback | //| Non-Repainting Logic | //+------------------------------------------------------------------+ #property copyright "Professional Trading Systems" #property link "https://www.example.com" // Replace with your website #property version "2.00" #property strict #property indicator_chart_window // ———— Configurable Inputs ———— enum PATTERN_TYPE { BOTH = 0, // Both Patterns DOUBLE_TOP = 1, // Double Tops Only DOUBLE_BOTTOM = 2 // Double Bottoms Only }; input PATTERN_TYPE PatternMode = BOTH; // Pattern Detection Mode input int EMA_Period = 20; // EMA Period input int SwingLookback = 2; // Bars to Confirm Swing (N bars before/after) input int MinBarsBetweenPoints = 5; // Min Bars Between 1st & 2nd Point input int MaxBarsBetweenPoints = 50; // Max Bars Between 1st & 2nd Point input int LookbackDays = 30; // Lookback Period (Days) input double PriceTolerance = 0.5; // Price Similarity Tolerance (%) - Max % diff between points input double NecklineThreshold = 0.1; // Neckline Touch Threshold (%) - Price needs to be within this % of neckline input double FailureThreshold = 1.0; // Pattern Failure Threshold (%) - Price drop below 2nd low / above 2nd high input bool ShowProjections = true; // Show Target Projections input color EmaColor = clrDodgerBlue; // EMA Line Color input color TopColor = clrCrimson; // Double Top Color input color BottomColor = clrForestGreen; // Double Bottom Color input color NecklineColor = clrGoldenrod; // Neckline Color input color AlertColor = clrRed; // Alert Marker Color input int TextSize = 8; // Text Size // ———— Global Variables (State Management) ———— // Double Bottom State static int bottomState = 0; // 0: Idle | 1: 1st Bottom Found | 2: Price Below EMA | 3: 2nd Bottom Found | 4: Alert Triggered static double firstBottom = 0.0; // Price of 1st Bottom static int firstBottomBar = -1; // Bar index of 1st Bottom (shift 0 is current unconfirmed bar) static double secondBottom = 0.0; // Price of 2nd Bottom static int secondBottomBar = -1; // Bar index of 2nd Bottom static double bottomNeckline = 0.0; // Neckline price for Bottom // Double Bottom Objects static string dbMarker1Name = ""; static string dbMarker2Name = ""; static string dbNecklineName = ""; static string dbConnectionName = ""; static string dbTargetName = ""; static string dbAlertName = ""; // Double Top State static int topState = 0; // 0: Idle | 1: 1st Top Found | 2: Price Above EMA | 3: 2nd Top Found | 4: Alert Triggered static double firstTop = 0.0; // Price of 1st Top static int firstTopBar = -1; // Bar index of 1st Top static double secondTop = 0.0; // Price of 2nd Top static int secondTopBar = -1; // Bar index of 2nd Top static double topNeckline = 0.0; // Neckline price for Top // Double Top Objects static string dtMarker1Name = ""; static string dtMarker2Name = ""; static string dtNecklineName = ""; static string dtConnectionName = ""; static string dtTargetName = ""; static string dtAlertName = ""; // Tracking Variables static datetime lastBarTime = 0; // Last Processed Bar Time static int maxLookbackBars = 0; // Maximum Lookback Bars (calculated from days) // ———— Helper Functions ———— // Check if New Bar Has Formed (Execute logic only on new bar close) bool IsNewBar() { if (Time[0] != lastBarTime) { lastBarTime = Time[0]; return true; } return false; } // Calculate Percentage Difference Between Two Prices double PercentDiff(double price1, double price2) { if (price2 == 0.0) return 999999.9; // Avoid division by zero return MathAbs((price1 - price2) / price2) * 100; } // Convert Days to Bars (Based on Current Timeframe) int DaysToBars(int days) { if (days <= 0) return Bars; int secondsPerDay = 24 * 60 * 60; long timeframeSeconds = Period() * 60; if (timeframeSeconds == 0) return Bars; // Avoid division by zero int barsPerDay = (int)(secondsPerDay / timeframeSeconds); int totalBars = days * barsPerDay; // Ensure we don't request more bars than available minus a buffer return MathMin(totalBars, Bars - 50); // Use 50 bars buffer } // Check if a Bar is a Confirmed Swing Low (using N bars before/after) // Checks bar 'shift' against 'lookback' bars in history (shift+i) and 'lookback' bars in recent history (shift-i) bool IsConfirmedSwingLow(int shift, int lookback) { if (shift < lookback || shift >= Bars - lookback) return false; // Need enough bars around // Check if low[shift] is lower than previous 'lookback' bars for (int i = 1; i <= lookback; i++) { if (Low[shift] >= Low[shift + i]) return false; } // Check if low[shift] is lower than next 'lookback' bars (which are now closed history) for (int i = 1; i <= lookback; i++) { if (Low[shift] >= Low[shift - i]) return false; } return true; } // Check if a Bar is a Confirmed Swing High (using N bars before/after) bool IsConfirmedSwingHigh(int shift, int lookback) { if (shift < lookback || shift >= Bars - lookback) return false; // Need enough bars around // Check if high[shift] is higher than previous 'lookback' bars for (int i = 1; i <= lookback; i++) { if (High[shift] <= High[shift + i]) return false; } // Check if high[shift] is higher than next 'lookback' bars (which are now closed history) for (int i = 1; i <= lookback; i++) { if (High[shift] <= High[shift - i]) return false; } return true; } // Draw Text Marker on Chart string DrawMarker(int bar, double price, string text, color markerColor, bool belowBar, string patternPrefix) { if (bar < 0 || bar >= Bars) return ""; string objName = StringConcatenate(patternPrefix, "_Marker_", text, "_", TimeToStr(Time[bar], TIME_DATE|TIME_MINUTES)); // Delete existing marker for this point type for cleanup if (ObjectFind(objName) != -1) ObjectDelete(objName); double yOffset = belowBar ? -0.0005 * price : 0.0005 * price; // Adjust offset based on price scale ObjectCreate(objName, OBJ_TEXT, 0, Time[bar], price + yOffset); ObjectSetText(objName, text, TextSize, "Arial", markerColor); ObjectSetInteger(0, objName, OBJPROP_ALIGN, ALIGN_CENTER); ObjectSetInteger(0, objName, OBJPROP_SELECTABLE, false); // Make non-selectable ObjectSetInteger(0, objName, OBJPROP_ZORDER, 0); // Bring to front return objName; // Return created object name for cleanup } // Draw Horizontal Line (Neckline or Target) string DrawHorizontalLine(double price, int startBar, int endBar, color lineColor, string name, bool isProjection = false) { if (startBar < 0 || endBar < 0 || startBar >= Bars || endBar >= Bars) return ""; string objName = name; if (ObjectFind(objName) != -1) ObjectDelete(objName); // Extend line slightly past end bar int displayEndBar = MathMax(endBar, 0) - 15; // Extend 15 bars *backward* from current bar (shift 0) if (displayEndBar < startBar) displayEndBar = startBar + 5; // Ensure some length ObjectCreate(objName, OBJ_TREND, 0, Time[startBar], price, Time[displayEndBar], price); ObjectSetInteger(0, objName, OBJPROP_COLOR, lineColor); ObjectSetInteger(0, objName, OBJPROP_STYLE, isProjection ? STYLE_DOT : STYLE_DASH); ObjectSetInteger(0, objName, OBJPROP_WIDTH, isProjection ? 1 : 2); ObjectSetInteger(0, objName, OBJPROP_RAY, false); // Don't extend to infinity ObjectSetInteger(0, objName, OBJPROP_SELECTABLE, false); ObjectSetInteger(0, objName, OBJPROP_ZORDER, 1); // Behind markers // Add price label only to the confirmed neckline and target if (!isProjection) { // Only label the main neckline string labelName = StringConcatenate(name, "_Label"); if (ObjectFind(labelName) != -1) ObjectDelete(labelName); ObjectCreate(labelName, OBJ_TEXT, 0, Time[startBar], price + (price > Open[startBar] ? 0.0005 * price : -0.0005 * price)); // Position label near start ObjectSetText(labelName, StringFormat("%s: %.4f", "Neckline", price), TextSize, "Arial", lineColor); ObjectSetInteger(0, labelName, OBJPROP_SELECTABLE, false); ObjectSetInteger(0, labelName, OBJPROP_ZORDER, 0); // Bring to front } else if (ShowProjections) { // Label target if enabled string labelName = StringConcatenate(name, "_Label"); if (ObjectFind(labelName) != -1) ObjectDelete(labelName); ObjectCreate(labelName, OBJ_TEXT, 0, Time[displayEndBar], price + (price > Open[displayEndBar] ? 0.0005 * price : -0.0005 * price)); // Position label near end ObjectSetText(labelName, StringFormat("%s: %.4f", "Target", price), TextSize, "Arial", lineColor); ObjectSetInteger(0, labelName, OBJPROP_SELECTABLE, false); ObjectSetInteger(0, labelName, OBJPROP_ZORDER, 0); } return objName; // Return created object name } // Draw Connection Line Between Two Points string DrawConnection(int bar1, double price1, int bar2, double price2, color lineColor, string name) { if (bar1 < 0 || bar2 < 0 || bar1 >= Bars || bar2 >= Bars) return ""; string objName = name; if (ObjectFind(objName) != -1) ObjectDelete(objName); ObjectCreate(objName, OBJ_TREND, 0, Time[bar1], price1, Time[bar2], price2); ObjectSetInteger(0, objName, OBJPROP_COLOR, lineColor); ObjectSetInteger(0, objName, OBJPROP_STYLE, STYLE_SOLID); ObjectSetInteger(0, objName, OBJPROP_WIDTH, 1); ObjectSetInteger(0, objName, OBJPROP_RAY, false); ObjectSetInteger(0, objName, OBJPROP_SELECTABLE, false); ObjectSetInteger(0, objName, OBJPROP_ZORDER, 2); // Behind Neckline/Target return objName; // Return created object name } // Find Highest High Between Two Bars (Inclusive) double GetHighestHigh(int startBar, int endBar) { if (startBar < 0 || endBar < 0 || startBar >= Bars || endBar >= Bars) return 0; int from = MathMin(startBar, endBar); int to = MathMax(startBar, endBar); return iHighest(_Symbol, _Period, MODE_HIGH, to - from + 1, from); } // Find Lowest Low Between Two Bars (Inclusive) double GetLowestLow(int startBar, int endBar) { if (startBar < 0 || endBar < 0 || startBar >= Bars || endBar >= Bars) return 0; int from = MathMin(startBar, endBar); int to = MathMax(startBar, endBar); return iLowest(_Symbol, _Period, MODE_LOW, to - from + 1, from); } // Calculate Pattern Target (Measured Move from Neckline) double CalculateTarget(bool isTop, double peak1, double peak2, double neckline) { double height = MathAbs(peak1 - neckline) + MathAbs(peak2 - neckline); height /= 2; // Average height if (isTop) { // Double Top Target = Neckline - Height return neckline - height; } else { // Double Bottom Target = Neckline + Height return neckline + height; } } // Delete objects associated with a specific pattern type void CleanupPatternObjects(string patternPrefix) { for (int i = ObjectsTotal() - 1; i >= 0; i--) { string name = ObjectName(i); if (StringFind(name, patternPrefix) == 0) { ObjectDelete(name); } } // Reset state variables for the pattern if (patternPrefix == "DB") { bottomState = 0; firstBottom = 0.0; firstBottomBar = -1; secondBottom = 0.0; secondBottomBar = -1; bottomNeckline = 0.0; dbMarker1Name = ""; dbMarker2Name = ""; dbNecklineName = ""; dbConnectionName = ""; dbTargetName = ""; dbAlertName = ""; } else if (patternPrefix == "DT") { topState = 0; firstTop = 0.0; firstTopBar = -1; secondTop = 0.0; secondTopBar = -1; topNeckline = 0.0; dtMarker1Name = ""; dtMarker2Name = ""; dtNecklineName = ""; dtConnectionName = ""; dtTargetName = ""; dtAlertName = ""; } } //+------------------------------------------------------------------+ //| Custom indicator initialization function | //+------------------------------------------------------------------+ int OnInit() { // Calculate maximum lookback bars based on days maxLookbackBars = DaysToBars(LookbackDays); if (maxLookbackBars < MaxBarsBetweenPoints + SwingLookback * 2) { maxLookbackBars = MaxBarsBetweenPoints + SwingLookback * 2 + 10; // Ensure enough history for worst case } IndicatorShortName("EMA 1-2 DP"); return(INIT_SUCCEEDED); } //+------------------------------------------------------------------+ //| Custom indicator deinitialization function | //+------------------------------------------------------------------+ void OnDeinit(const int reason) { // Clean up all objects created by this indicator instance for (int i = ObjectsTotal() - 1; i >= 0; i--) { string name = ObjectName(i); if (StringFind(name, "DB_") == 0 || StringFind(name, "DT_") == 0 || StringFind(name, "EMA_Line") == 0) { ObjectDelete(name); } } } //+------------------------------------------------------------------+ //| Custom indicator iteration function | //+------------------------------------------------------------------+ int OnCalculate(const int rates_total, const int prev_calculated, const datetime &time[], const double &open[], const double &high[], const double &low[], const double &close[], const long &tick_volume[], const long &volume[], const int &spread[]) { // Ensure we have enough bars for calculations if (Bars < EMA_Period + SwingLookback * 2 + MaxBarsBetweenPoints + 10) return(0); // Process only on new bar close to prevent repainting if (!IsNewBar()) return(rates_total); // Index 1 refers to the latest CLOSED bar int currentBar = 1; // Calculate EMA for the latest closed bar double ema = iMA(_Symbol, _Period, EMA_Period, 0, MODE_EMA, PRICE_CLOSE, currentBar); double emaPrev = iMA(_Symbol, _Period, EMA_Period, 0, MODE_EMA, PRICE_CLOSE, currentBar + 1); // EMA of the bar before currentBar // Plot EMA Line (Update position) static string emaLineName = "EMA_Line"; if (ObjectFind(emaLineName) == -1) { ObjectCreate(emaLineName, OBJ_TREND, 0, Time[currentBar+1], emaPrev, Time[currentBar], ema); ObjectSetInteger(0, emaLineName, OBJPROP_COLOR, EmaColor); ObjectSetInteger(0, emaLineName, OBJPROP_WIDTH, 2); ObjectSetInteger(0, emaLineName, OBJPROP_RAY, false); ObjectSetInteger(0, emaLineName, OBJPROP_SELECTABLE, false); ObjectSetInteger(0, emaLineName, OBJPROP_ZORDER, 3); // Furthest back } else { ObjectMove(emaLineName, 0, Time[currentBar+1], emaPrev); ObjectMove(emaLineName, 1, Time[currentBar], ema); } // --- Check for pattern staleness (if 1st point is too old) --- if (bottomState > 0 && firstBottomBar != -1 && (firstBottomBar > maxLookbackBars || firstBottomBar >= Bars)) { Print("Double Bottom: 1st point too old, resetting state. Bar: ", firstBottomBar); CleanupPatternObjects("DB"); } if (topState > 0 && firstTopBar != -1 && (firstTopBar > maxLookbackBars || firstTopBar >= Bars)) { Print("Double Top: 1st point too old, resetting state. Bar: ", firstTopBar); CleanupPatternObjects("DT"); } // --- Double Bottom State Machine --- if (PatternMode == BOTH || PatternMode == DOUBLE_BOTTOM) { // State 0: Idle → Look for 1st Bottom (using latest closed bar: currentBar=1) if (bottomState == 0) { // Conditions for 1st Bottom on bar `currentBar` (shift 1): // 1. Bar `currentBar+1` closed below EMA (Close[currentBar+1] < emaPrev) // 2. Bar `currentBar` low touched EMA from below (Low[currentBar] <= ema) // 3. Bar `currentBar` closed above EMA (Close[currentBar] > ema) // 4. Bar `currentBar` is a confirmed swing low bool isTouchEmaFromBelow = (Close[currentBar + 1] < emaPrev) && (Low[currentBar] <= ema) && (Close[currentBar] > ema); if (isTouchEmaFromBelow && IsConfirmedSwingLow(currentBar, SwingLookback)) { bottomState = 1; firstBottom = Low[currentBar]; firstBottomBar = currentBar; dbMarker1Name = DrawMarker(currentBar, firstBottom, "1", BottomColor, true, "DB"); Print("Double Bottom: 1st Bottom Confirmed at ", firstBottom, " on Bar ", currentBar); } } // State 1: 1st Bottom Found → Price Below EMA (Look for transition on latest closed bar) else if (bottomState == 1) { // Transition to State 2: Price closes back below EMA on latest closed bar if (Close[currentBar] < ema) { bottomState = 2; Print("Double Bottom: Price Closed Below EMA on Bar ", currentBar); } // Pattern Failure: Price drops too far below 1st low OR 1st point too old if (PercentDiff(Low[currentBar], firstBottom) > FailureThreshold) { Print("Double Bottom: State 1 Failure (Price Below Failure Threshold). Bar: ", currentBar); CleanupPatternObjects("DB"); } } // State 2: Price Below EMA → Look for 2nd Bottom (Look on latest closed bar) else if (bottomState == 2) { // Conditions for 2nd Bottom on bar `currentBar`: // 1. Bar `currentBar` is a confirmed swing low // 2. Bar `currentBar` closed below EMA // 3. Bar `currentBar` low is within tolerance of 1st low // 4. Bar distance from 1st bottom is within min/max range bool is2ndBottom = IsConfirmedSwingLow(currentBar, SwingLookback) && (Close[currentBar] < ema) && (PercentDiff(Low[currentBar], firstBottom) <= PriceTolerance); int barsBetween = firstBottomBar - currentBar; // Distance in bars if (is2ndBottom && barsBetween >= MinBarsBetweenPoints && barsBetween <= MaxBarsBetweenPoints) { bottomState = 3; secondBottom = Low[currentBar]; secondBottomBar = currentBar; // Calculate Neckline (Highest High between 1st & 2nd Bottom bars) bottomNeckline = GetHighestHigh(firstBottomBar, secondBottomBar); dbMarker2Name = DrawMarker(secondBottomBar, secondBottom, "2", BottomColor, true, "DB"); dbConnectionName = DrawConnection(firstBottomBar, firstBottom, secondBottomBar, secondBottom, BottomColor, "DB_Connection"); dbNecklineName = DrawHorizontalLine(bottomNeckline, firstBottomBar, secondBottomBar, NecklineColor, "DB_Neckline"); if (ShowProjections) { double target = CalculateTarget(false, firstBottom, secondBottom, bottomNeckline); dbTargetName = DrawHorizontalLine(target, secondBottomBar, 0, BottomColor, "DB_Target", true); } Print("Double Bottom: 2nd Bottom Confirmed at ", secondBottom, " on Bar ", secondBottomBar, ". Neckline: ", bottomNeckline); } // Pattern Failure: Price drops too far below 1st low OR 1st point too old if (PercentDiff(Low[currentBar], firstBottom) > FailureThreshold) { Print("Double Bottom: State 2 Failure (Price Below Failure Threshold). Bar: ", currentBar); CleanupPatternObjects("DB"); } } // State 3: 2nd Bottom Found → Wait for Neckline Touch/Break (Look on latest closed bar) else if (bottomState == 3) { // Calculate neckline threshold for "touch" double necklineTouchPrice = bottomNeckline * (1 - (NecklineThreshold / 100)); // Price must be >= this level // Neckline Touch/Break Conditions on bar `currentBar`: // High of current bar touched or exceeded the threshold OR Close of current bar is above neckline bool isNecklineTouched = (High[currentBar] >= necklineTouchPrice) || (Close[currentBar] > bottomNeckline); if (isNecklineTouched) { bottomState = 4; Alert(StringFormat("Double Bottom Pattern Complete!\nSymbol: %s\nTimeframe: %s\nNeckline: %.4f\nBreakout Price: %.4f", _Symbol, EnumToString(_Period), bottomNeckline, High[currentBar])); dbAlertName = DrawMarker(currentBar, High[currentBar], "▲", AlertColor, false, "DB"); Print("Double Bottom: Neckline Touched/Broken on Bar ", currentBar); } // Pattern Failure: Price drops too far below 2nd low OR 2nd point too old if (PercentDiff(Low[currentBar], secondBottom) > FailureThreshold) { Print("Double Bottom: State 3 Failure (Price Below Failure Threshold). Bar: ", currentBar); CleanupPatternObjects("DB"); } if (secondBottomBar != -1 && (secondBottomBar > maxLookbackBars || secondBottomBar >= Bars)) { Print("Double Bottom: 2nd point too old, resetting state. Bar: ", secondBottomBar); CleanupPatternObjects("DB"); } } // State 4: Alert Triggered → Reset (Reset on the bar *after* the alert bar) else if (bottomState == 4) { Print("Double Bottom: State 4 → Resetting pattern. Bar: ", currentBar); CleanupPatternObjects("DB"); // Cleanup objects and reset state variables } } // End Double Bottom Logic // --- Double Top State Machine --- if (PatternMode == BOTH || PatternMode == DOUBLE_TOP) { // State 0: Idle → Look for 1st Top (using latest closed bar: currentBar=1) if (topState == 0) { // Conditions for 1st Top on bar `currentBar` (shift 1): // 1. Bar `currentBar+1` closed above EMA (Close[currentBar+1] > emaPrev) // 2. Bar `currentBar` high touched EMA from above (High[currentBar] >= ema) // 3. Bar `currentBar` closed below EMA (Close[currentBar] < ema) // 4. Bar `currentBar` is a confirmed swing high bool isTouchEmaFromAbove = (Close[currentBar + 1] > emaPrev) && (High[currentBar] >= ema) && (Close[currentBar] < ema); if (isTouchEmaFromAbove && IsConfirmedSwingHigh(currentBar, SwingLookback)) { topState = 1; firstTop = High[currentBar]; firstTopBar = currentBar; dtMarker1Name = DrawMarker(currentBar, firstTop, "1", TopColor, false, "DT"); Print("Double Top: 1st Top Confirmed at ", firstTop, " on Bar ", currentBar); } } // State 1: 1st Top Found → Price Above EMA (Look for transition on latest closed bar) else if (topState == 1) { // Transition to State 2: Price closes back above EMA on latest closed bar if (Close[currentBar] > ema) { topState = 2; Print("Double Top: Price Closed Above EMA on Bar ", currentBar); } // Pattern Failure: Price rallies too far above 1st high OR 1st point too old if (PercentDiff(High[currentBar], firstTop) > FailureThreshold) { Print("Double Top: State 1 Failure (Price Above Failure Threshold). Bar: ", currentBar); CleanupPatternObjects("DT"); } } // State 2: Price Above EMA → Look for 2nd Top (Look on latest closed bar) else if (topState == 2) { // Conditions for 2nd Top on bar `currentBar`: // 1. Bar `currentBar` is a confirmed swing high // 2. Bar `currentBar` closed above EMA // 3. Bar `currentBar` high is within tolerance of 1st high // 4. Bar distance from 1st top is within min/max range bool is2ndTop = IsConfirmedSwingHigh(currentBar, SwingLookback) && (Close[currentBar] > ema) && (PercentDiff(High[currentBar], firstTop) <= PriceTolerance); int barsBetween = firstTopBar - currentBar; // Distance in bars if (is2ndTop && barsBetween >= MinBarsBetweenPoints && barsBetween <= MaxBarsBetweenPoints) { topState = 3; secondTop = High[currentBar]; secondTopBar = currentBar; // Calculate Neckline (Lowest Low between 1st & 2nd Top bars) topNeckline = GetLowestLow(firstTopBar, secondTopBar); dtMarker2Name = DrawMarker(secondTopBar, secondTop, "2", TopColor, false, "DT"); dtConnectionName = DrawConnection(firstTopBar, firstTop, secondTopBar, secondTop, TopColor, "DT_Connection"); dtNecklineName = DrawHorizontalLine(topNeckline, firstTopBar, secondTopBar, NecklineColor, "DT_Neckline"); if (ShowProjections) { double target = CalculateTarget(true, firstTop, secondTop, topNeckline); dtTargetName = DrawHorizontalLine(target, secondTopBar, 0, TopColor, "DT_Target", true); } Print("Double Top: 2nd Top Confirmed at ", secondTop, " on Bar ", secondTopBar, ". Neckline: ", topNeckline); } // Pattern Failure: Price rallies too far above 1st high OR 1st point too old if (PercentDiff(High[currentBar], firstTop) > FailureThreshold) { Print("Double Top: State 2 Failure (Price Above Failure Threshold). Bar: ", currentBar); CleanupPatternObjects("DT"); } } // State 3: 2nd Top Found → Wait for Neckline Touch/Break (Look on latest closed bar) else if (topState == 3) { // Calculate neckline threshold for "touch" double necklineTouchPrice = topNeckline * (1 + (NecklineThreshold / 100)); // Price must be <= this level // Neckline Touch/Break Conditions on bar `currentBar`: // Low of current bar touched or dropped below the threshold OR Close of current bar is below neckline bool isNecklineTouched = (Low[currentBar] <= necklineTouchPrice) || (Close[currentBar] < topNeckline); if (isNecklineTouched) { topState = 4; Alert(StringFormat("Double Top Pattern Complete!\nSymbol: %s\nTimeframe: %s\nNeckline: %.4f\nBreakout Price: %.4f", _Symbol, EnumToString(_Period), topNeckline, Low[currentBar])); dtAlertName = DrawMarker(currentBar, Low[currentBar], "▼", AlertColor, true, "DT"); Print("Double Top: Neckline Touched/Broken on Bar ", currentBar); } // Pattern Failure: Price rallies too far above 2nd high OR 2nd point too old if (PercentDiff(High[currentBar], secondTop) > FailureThreshold) { Print("Double Top: State 3 Failure (Price Above Failure Threshold). Bar: ", currentBar); CleanupPatternObjects("DT"); } if (secondTopBar != -1 && (secondTopBar > maxLookbackBars || secondTopBar >= Bars)) { Print("Double Top: 2nd point too old, resetting state. Bar: ", secondTopBar); CleanupPatternObjects("DT"); } } // State 4: Alert Triggered → Reset (Reset on the bar *after* the alert bar) else if (topState == 4) { Print("Double Top: State 4 → Resetting pattern. Bar: ", currentBar); CleanupPatternObjects("DT"); // Cleanup objects and reset state variables } } // End Double Top Logic // Return the total number of bars calculated return(rates_total); }Explanation of Improvements ("Better Engines")
-
Efficient
OnCalculateLogic: The code now primarily processes only the latest closed bar (currentBar = 1). Historical calculations (EMA, swing detection) use MQL4's built-in functions with the appropriateshiftindex. This is the standard and most efficient way to handle tick/bar processing in MT4 indicators, avoiding redundant loops through history on every tick. -
Separate State Machines:
bottomStateandtopStatemanage the detection process for each pattern independently. This makes the logic clearer and allows both patterns to be detected concurrently ifPatternModeis set toBOTH. -
Refined Swing Detection:
IsConfirmedSwingLowandIsConfirmedSwingHighuse theSwingLookbackparameter to confirm if a bar is a true swing point by checkingSwingLookbackbars before and after it in the available history. Since we process the latest closed bar (currentBar = 1), the bars atcurrentBar - i(i.e., shifts 0, -1, -2...) are available and closed history, whilecurrentBar + irefers to older closed history. -
Precise Pattern Conditions:
- The conditions for the 1st point (EMA touch and cross) and 2nd point (swing, below/above EMA, tolerance) are explicitly checked on the
currentBar(shift 1), referencing the EMA value at the previous bar (emaPrev) where needed for the touch/cross condition originating from below/above EMA. - The
MinBarsBetweenPointsandMaxBarsBetweenPointsare checked precisely when confirming the 2nd point (in State 2) using the bar index differencefirstPointBar - currentBar.
- The conditions for the 1st point (EMA touch and cross) and 2nd point (swing, below/above EMA, tolerance) are explicitly checked on the
-
Accurate Neckline Calculation: The neckline (in State 3) is calculated as the
HighestHigh(for bottom) orLowestLow(for top) using the built-iniHighest/iLowestfunctions over the exact range of bars between the confirmed 1st point bar and the confirmed 2nd point bar. -
Robust Pattern Failure: The
FailureThresholdcheck is included in States 1, 2, and 3. In States 1 and 2, it checks if the latest price has moved too far against the expected pattern direction relative to the first point. In State 3, it checks if the latest price moves too far against the pattern direction relative to the second point. This ensures patterns that break down prematurely are filtered out. -
Advanced Object Management:
- Objects (markers, neckline, connection, target) are created and stored with unique names including the pattern type prefix (
DB_,DT_) and a timestamp/price for uniqueness. - Object names are stored in static variables (
dbMarker1Name, etc.). - A dedicated
CleanupPatternObjectsfunction is used to delete all objects associated with a specific pattern when its state machine resets (due to failure, staleness, or alert completion). This is much cleaner than general cleanup. - A check is added to reset the pattern if the bar index of the 1st (or 2nd in State 3) point goes beyond the
maxLookbackBarsor becomes invalid (>= Bars). - Object properties are set to be non-selectable (
OBJPROP_SELECTABLE, false) to avoid accidental dragging and improve chart usability. Z-order is set for better visual layering.
- Objects (markers, neckline, connection, target) are created and stored with unique names including the pattern type prefix (
-
Lookback Period:
LookbackDaysis converted tomaxLookbackBarsinOnInit. This variable is used in the staleness check to ensure patterns are completed within the specified historical range. -
Projections: The target price is calculated using the standard measured move principle (height of the pattern projected from the neckline) and drawn as a dotted line if
ShowProjectionsis true. -
Alert Marker: Uses "▲" for bottom breakout and "▼" for top breakout for clear visual indication of the alert bar.
How to Use in MetaTrader 4
- Open MetaEditor (F4 in MT4).
- Create a new Custom Indicator.
- Replace the default code with the code provided above.
- Compile (F7). Fix any compilation errors (should be none if copied correctly).
- Go back to MT4.
- In the Navigator window, find "EMA 1-2 Double Pattern v2" under "Indicators".
- Drag and drop it onto your desired chart.
- Go to the "Inputs" tab in the indicator properties.
- Configure the parameters:
PatternMode: Choose BOTH, DOUBLE_TOP, or DOUBLE_BOTTOM.EMA_Period: Set the EMA period.SwingLookback: Number of bars before/after a point to confirm it's a swing high/low. Start with 1 or 2.MinBarsBetweenPoints: Minimum number of bars required between the 1st and 2nd point.MaxBarsBetweenPoints: Maximum number of bars allowed between the 1st and 2nd point.LookbackDays: How many days back the indicator should look for the start of a pattern.PriceTolerance: How close the 1st and 2nd peaks/troughs must be in percentage.NecklineThreshold: How close price needs to get to the neckline to trigger an alert (allows for near misses).FailureThreshold: How much price has to move against the pattern's direction to invalidate it and reset.ShowProjections: Toggle target lines.- Colors and Text Size.
- Go to the "Common" tab and ensure "Allow DLL imports" and "Allow import of external experts" are NOT checked (this indicator doesn't use them). "Allow modification of Live trading settings" is not needed either.
- Click OK.
- Set up MT4 Alerts via Tools -> Options -> Alerts if you want email/SMS/push notifications.
This improved version provides a more robust and professional foundation for detecting these patterns based on your specified criteria. Remember to backtest and adjust parameters based on the specific currency pair and timeframe you are trading.
-
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.