package net.mattias.pedestals.client.gui.screens.inventory; import…
- User
package net.mattias.pedestals.client.gui.screens.inventory;
import com.mojang.blaze3d.systems.RenderSystem; import net.mattias.pedestals.Pedestals; import net.mattias.pedestals.core.Constants; import net.mattias.pedestals.core.world.inventory.PedestalMenu; import net.minecraft.client.gui.GuiGraphics; import net.minecraft.client.gui.screens.inventory.AbstractContainerScreen; import net.minecraft.client.renderer.GameRenderer; import net.minecraft.network.chat.Component; import net.minecraft.resources.ResourceLocation; import net.minecraft.world.entity.player.Inventory;
public class PedestalScreen extends AbstractContainerScreen { private static final ResourceLocation GUI_TEXTURE = ResourceLocation.fromNamespaceAndPath(Constants.MOD_ID, "textures/gui/pedestal/pedestal_gui.png");
public PedestalScreen(PedestalMenu pMenu, Inventory pPlayerInventory, Component pTitle) { super(pMenu, pPlayerInventory, pTitle); } @Override protected void init() { super.init(); // Gets rid of labels this.inventoryLabelY = 10000; this.titleLabelY = 10000; } @Override protected void renderBg(GuiGraphics pGuiGraphics, float pPartialTick, int pMouseX, int pMouseY) { RenderSystem.setShader(GameRenderer::getPositionTexShader); RenderSystem.setShaderColor(1.0F, 1.0F, 1.0F, 1.0F); RenderSystem.setShaderTexture(0, GUI_TEXTURE); int x = (width - imageWidth) / 2; int y = (height - imageHeight) / 2; pGuiGraphics.blit(GUI_TEXTURE, x, y, 0, 0, imageWidth, imageHeight); } @Override public void render(GuiGraphics guiGraphics, int mouseX, int mouseY, float delta) { renderBackground(guiGraphics, mouseX, mouseY, delta); super.render(guiGraphics, mouseX, mouseY, delta); renderTooltip(guiGraphics, mouseX, mouseY); }}
package net.mattias.pedestals.client.renderer.blockentity;
import com.mojang.blaze3d.vertex.PoseStack; import com.mojang.math.Axis;
import net.mattias.pedestals.core.world.block.entity.PedestalBlockEntity; import net.minecraft.client.Minecraft; import net.minecraft.client.renderer.LightTexture; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.blockentity.BlockEntityRenderer; import net.minecraft.client.renderer.blockentity.BlockEntityRendererProvider; import net.minecraft.client.renderer.entity.ItemRenderer; import net.minecraft.client.renderer.texture.OverlayTexture; import net.minecraft.core.BlockPos; import net.minecraft.world.item.ItemDisplayContext; import net.minecraft.world.item.ItemStack; import net.minecraft.world.level.Level; import net.minecraft.world.level.LightLayer;
public class PedestalRenderer implements BlockEntityRenderer { public PedestalRenderer(BlockEntityRendererProvider.Context context) {
} @Override public void render(PedestalBlockEntity pBlockEntity, float pPartialTick, PoseStack pPoseStack, MultiBufferSource pBufferSource, int pPackedLight, int pPackedOverlay) { ItemRenderer itemRenderer = Minecraft.getInstance().getItemRenderer(); ItemStack stack = pBlockEntity.inventory.getStackInSlot(0); long time = System.currentTimeMillis(); float bobbingOffset = (float) Math.sin((time % 1000) / 1000.0 * Math.PI * 2) * 0.1f; pPoseStack.pushPose(); pPoseStack.translate(0.5f, 1.5f + bobbingOffset, 0.5f); pPoseStack.scale(0.5f, 0.5f, 0.5f); pPoseStack.mulPose(Axis.YP.rotationDegrees(pBlockEntity.getRenderingRotation())); itemRenderer.renderStatic(stack, ItemDisplayContext.FIXED, getLightLevel(pBlockEntity.getLevel(), pBlockEntity.getBlockPos()), OverlayTexture.NO_OVERLAY, pPoseStack, pBufferSource, pBlockEntity.getLevel(), 1); pPoseStack.popPose(); } private int getLightLevel(Level level, BlockPos pos) { int bLight = level.getBrightness(LightLayer.BLOCK, pos); int sLight = level.getBrightness(LightLayer.SKY, pos); return LightTexture.pack(bLight, sLight); }}
NeoForge 1.21
So my Block Entity Pedestal has a gui but when trying to open it the screen menu will close immediately you can see it for a split second
Assistant
Looking at your code, I can see you've implemented a Pedestal block entity with both a GUI screen and a custom renderer. The issue where the GUI opens for a split second and then immediately closes is a common problem in Minecraft modding. Let me help you troubleshoot this.
The most likely causes for this behavior are:
- The menu is being closed on the server side due to validation failures
- There's an error in the screen initialization
- The container/menu implementation has issues
Since you're using NeoForge 1.21, here are some specific things to check:
// First, check your PedestalMenu class (not shown in your code) // Make sure it properly validates the container: @Override public boolean stillValid(Player player) { // This method needs to return true for the menu to stay open // Make sure your implementation is correct return stillValid(ContainerLevelAccess.create(level, blockPos), player, yourBlockType); }Also, check if you're properly registering your menu and screen:
// In your mod initialization public static final MenuType<PedestalMenu> PEDESTAL_MENU = registerMenuType("pedestal", PedestalMenu::new); // And in your client setup MenuScreens.register(PEDESTAL_MENU, PedestalScreen::new);Another common issue is that your block entity might not be properly syncing data between client and server. Make sure your
PedestalBlockEntityproperly implements methods for data synchronization.Finally, check your console logs for any exceptions that might be occurring when the GUI is opened. This could provide more specific information about what's going wrong.
Would you like me to explain or break down any specific part of this solution in more detail?
- User
Here is all the code for the pedestal
package net.mattias.pedestals.client.renderer.blockentity;
import com.mojang.blaze3d.vertex.PoseStack; import com.mojang.math.Axis;
import net.mattias.pedestals.core.world.block.entity.PedestalBlockEntity; import net.minecraft.client.Minecraft; import net.minecraft.client.renderer.LightTexture; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.blockentity.BlockEntityRenderer; import net.minecraft.client.renderer.blockentity.BlockEntityRendererProvider; import net.minecraft.client.renderer.entity.ItemRenderer; import net.minecraft.client.renderer.texture.OverlayTexture; import net.minecraft.core.BlockPos; import net.minecraft.world.item.ItemDisplayContext; import net.minecraft.world.item.ItemStack; import net.minecraft.world.level.Level; import net.minecraft.world.level.LightLayer;
public class PedestalRenderer implements BlockEntityRenderer { public PedestalRenderer(BlockEntityRendererProvider.Context context) {
} @Override public void render(PedestalBlockEntity pBlockEntity, float pPartialTick, PoseStack pPoseStack, MultiBufferSource pBufferSource, int pPackedLight, int pPackedOverlay) { ItemRenderer itemRenderer = Minecraft.getInstance().getItemRenderer(); ItemStack stack = pBlockEntity.inventory.getStackInSlot(0); long time = System.currentTimeMillis(); float bobbingOffset = (float) Math.sin((time % 1000) / 1000.0 * Math.PI * 2) * 0.1f; pPoseStack.pushPose(); pPoseStack.translate(0.5f, 1.5f + bobbingOffset, 0.5f); pPoseStack.scale(0.5f, 0.5f, 0.5f); pPoseStack.mulPose(Axis.YP.rotationDegrees(pBlockEntity.getRenderingRotation())); itemRenderer.renderStatic(stack, ItemDisplayContext.FIXED, getLightLevel(pBlockEntity.getLevel(), pBlockEntity.getBlockPos()), OverlayTexture.NO_OVERLAY, pPoseStack, pBufferSource, pBlockEntity.getLevel(), 1); pPoseStack.popPose(); } private int getLightLevel(Level level, BlockPos pos) { int bLight = level.getBrightness(LightLayer.BLOCK, pos); int sLight = level.getBrightness(LightLayer.SKY, pos); return LightTexture.pack(bLight, sLight); }}
package net.mattias.pedestals.client;
import net.mattias.pedestals.core.Constants; import net.mattias.pedestals.core.registry.ModBlockEntities; import net.mattias.pedestals.core.registry.ModMenus; import net.mattias.pedestals.client.gui.screens.inventory.PedestalScreen; import net.mattias.pedestals.client.renderer.blockentity.PedestalRenderer; import net.neoforged.bus.api.SubscribeEvent; import net.neoforged.fml.common.EventBusSubscriber; import net.neoforged.fml.common.EventBusSubscriber.Bus; import net.neoforged.api.distmarker.Dist; import net.neoforged.neoforge.client.event.RegisterMenuScreensEvent; import net.neoforged.neoforge.client.event.EntityRenderersEvent;
@EventBusSubscriber( modid = Constants.MOD_ID, bus = Bus.MOD, value = Dist.CLIENT ) public class PedestalsClient {
@SubscribeEvent public static void onRegisterScreens(RegisterMenuScreensEvent event) { event.register(ModMenus.PEDESTAL.get(), PedestalScreen::new); } @SubscribeEvent public static void onRegisterRenderers(EntityRenderersEvent.RegisterRenderers event) { event.registerBlockEntityRenderer(ModBlockEntities.PEDESTAL.get(), PedestalRenderer::new); }}
package net.mattias.pedestals.client.gui.screens.inventory;
import com.mojang.blaze3d.systems.RenderSystem; import net.mattias.pedestals.Pedestals; import net.mattias.pedestals.core.Constants; import net.mattias.pedestals.core.world.inventory.PedestalMenu; import net.minecraft.client.gui.GuiGraphics; import net.minecraft.client.gui.screens.inventory.AbstractContainerScreen; import net.minecraft.client.renderer.GameRenderer; import net.minecraft.network.chat.Component; import net.minecraft.resources.ResourceLocation; import net.minecraft.world.entity.player.Inventory;
public class PedestalScreen extends AbstractContainerScreen { private static final ResourceLocation GUI_TEXTURE = ResourceLocation.fromNamespaceAndPath(Constants.MOD_ID, "textures/gui/pedestal/pedestal_gui.png");
public PedestalScreen(PedestalMenu pMenu, Inventory pPlayerInventory, Component pTitle) { super(pMenu, pPlayerInventory, pTitle); } @Override protected void init() { super.init(); // Gets rid of labels this.inventoryLabelY = 10000; this.titleLabelY = 10000; } @Override protected void renderBg(GuiGraphics pGuiGraphics, float pPartialTick, int pMouseX, int pMouseY) { RenderSystem.setShader(GameRenderer::getPositionTexShader); RenderSystem.setShaderColor(1.0F, 1.0F, 1.0F, 1.0F); RenderSystem.setShaderTexture(0, GUI_TEXTURE); int x = (width - imageWidth) / 2; int y = (height - imageHeight) / 2; pGuiGraphics.blit(GUI_TEXTURE, x, y, 0, 0, imageWidth, imageHeight); } @Override public void render(GuiGraphics guiGraphics, int mouseX, int mouseY, float delta) { renderBackground(guiGraphics, mouseX, mouseY, delta); super.render(guiGraphics, mouseX, mouseY, delta); renderTooltip(guiGraphics, mouseX, mouseY); }}
package net.mattias.pedestals.core.world.block.entity;
import net.mattias.pedestals.core.registry.ModBlockEntities; import net.mattias.pedestals.core.world.inventory.PedestalMenu; import net.minecraft.core.BlockPos; import net.minecraft.core.HolderLookup; import net.minecraft.core.NonNullList; import net.minecraft.nbt.CompoundTag; import net.minecraft.network.chat.Component; import net.minecraft.network.protocol.Packet; import net.minecraft.network.protocol.game.ClientGamePacketListener; import net.minecraft.network.protocol.game.ClientboundBlockEntityDataPacket; import net.minecraft.world.*; import net.minecraft.world.entity.player.Inventory; import net.minecraft.world.entity.player.Player; import net.minecraft.world.inventory.AbstractContainerMenu; import net.minecraft.world.item.ItemStack; import net.minecraft.world.level.block.entity.BlockEntity; import net.minecraft.world.level.block.state.BlockState; import net.neoforged.neoforge.items.ItemStackHandler; import org.jetbrains.annotations.Nullable;
public class PedestalBlockEntity extends BlockEntity implements MenuProvider { public final ItemStackHandler inventory = new ItemStackHandler(1) { @Override protected int getStackLimit(int slot, ItemStack stack) { return 1; }
@Override protected void onContentsChanged(int slot) { setChanged(); if(!level.isClientSide()) { level.sendBlockUpdated(getBlockPos(), getBlockState(), getBlockState(), 3); } } }; private float rotation; public PedestalBlockEntity(BlockPos pPos, BlockState pBlockState) { super(ModBlockEntities.PEDESTAL.get(), pPos, pBlockState); } public void clearContents() { inventory.setStackInSlot(0, ItemStack.EMPTY); } public void drops() { SimpleContainer inv = new SimpleContainer(inventory.getSlots()); for(int i = 0; i < inventory.getSlots(); i++) { inv.setItem(i, inventory.getStackInSlot(i)); } Containers.dropContents(this.level, this.worldPosition, inv); } @Override protected void saveAdditional(CompoundTag pTag, HolderLookup.Provider pRegistries) { super.saveAdditional(pTag, pRegistries); pTag.put("inventory", inventory.serializeNBT(pRegistries)); } @Override protected void loadAdditional(CompoundTag pTag, HolderLookup.Provider pRegistries) { super.loadAdditional(pTag, pRegistries); inventory.deserializeNBT(pRegistries, pTag.getCompound("inventory")); } public float getRenderingRotation() { rotation += 0.5f; if(rotation >= 360) { rotation = 0; } return rotation; } @Override public Component getDisplayName() { return Component.translatable( "block.pedestals.pedestal"); } @Nullable @Override public AbstractContainerMenu createMenu(int pContainerId, Inventory pPlayerInventory, Player pPlayer) { return new PedestalMenu(pContainerId, pPlayerInventory, this); } @Nullable @Override public Packet<ClientGamePacketListener> getUpdatePacket() { return ClientboundBlockEntityDataPacket.create(this); } @Override public CompoundTag getUpdateTag(HolderLookup.Provider pRegistries) { return saveWithoutMetadata(pRegistries); }}
package net.mattias.pedestals.core.world.block;
import com.mojang.serialization.MapCodec; import net.mattias.pedestals.core.world.block.entity.PedestalBlockEntity; import net.minecraft.core.BlockPos; import net.minecraft.network.chat.Component; import net.minecraft.server.level.ServerPlayer; import net.minecraft.sounds.SoundEvents; import net.minecraft.sounds.SoundSource; import net.minecraft.world.Containers; import net.minecraft.world.InteractionHand; import net.minecraft.world.ItemInteractionResult; import net.minecraft.world.SimpleMenuProvider; import net.minecraft.world.entity.player.Player; import net.minecraft.world.item.ItemStack; import net.minecraft.world.level.BlockGetter; import net.minecraft.world.level.Level; import net.minecraft.world.level.block.BaseEntityBlock; import net.minecraft.world.level.block.Block; import net.minecraft.world.level.block.RenderShape; import net.minecraft.world.level.block.entity.BlockEntity; import net.minecraft.world.level.block.state.BlockState; import net.minecraft.world.phys.BlockHitResult; import net.minecraft.world.phys.shapes.CollisionContext; import net.minecraft.world.phys.shapes.VoxelShape; import org.jetbrains.annotations.Nullable;
public class PedestalBlock extends BaseEntityBlock { public static final VoxelShape SHAPE = Block.box(2, 0, 2, 14, 13, 14); public static final MapCodec CODEC = simpleCodec(PedestalBlock::new);
public PedestalBlock(Properties properties) { super(properties); } @Override protected MapCodec<? extends BaseEntityBlock> codec() { return CODEC; } @Override protected VoxelShape getShape(BlockState pState, BlockGetter pLevel, BlockPos pPos, CollisionContext pContext) { return SHAPE; } @Nullable @Override public BlockEntity newBlockEntity(BlockPos pPos, BlockState pState) { return new PedestalBlockEntity(pPos, pState); } @Override protected RenderShape getRenderShape(BlockState pState) { return RenderShape.MODEL; } @Override protected void onRemove(BlockState pState, Level pLevel, BlockPos pPos, BlockState pNewState, boolean pMovedByPiston) { if(pState.getBlock() != pNewState.getBlock()) { if(pLevel.getBlockEntity(pPos) instanceof PedestalBlockEntity pedestalBlockEntity) { pedestalBlockEntity.drops(); pLevel.updateNeighbourForOutputSignal(pPos, this); } } super.onRemove(pState, pLevel, pPos, pNewState, pMovedByPiston); } @Override protected ItemInteractionResult useItemOn(ItemStack pStack, BlockState pState, Level pLevel, BlockPos pPos, Player pPlayer, InteractionHand pHand, BlockHitResult pHitResult) { if(pLevel.getBlockEntity(pPos) instanceof PedestalBlockEntity pedestalBlockEntity) { if(pPlayer.isCrouching() && !pLevel.isClientSide()) { ((ServerPlayer) pPlayer).openMenu(new SimpleMenuProvider(pedestalBlockEntity, Component.literal("Pedestal")), pPos); return ItemInteractionResult.SUCCESS; } if(pedestalBlockEntity.inventory.getStackInSlot(0).isEmpty() && !pStack.isEmpty()) { pedestalBlockEntity.inventory.insertItem(0, pStack.copy(), false); pStack.shrink(1); pLevel.playSound(pPlayer, pPos, SoundEvents.ITEM_PICKUP, SoundSource.BLOCKS, 1f, 2f); } else if(pStack.isEmpty()) { ItemStack stackOnPedestal = pedestalBlockEntity.inventory.extractItem(0, 1, false); pPlayer.setItemInHand(InteractionHand.MAIN_HAND, stackOnPedestal); pedestalBlockEntity.clearContents(); pLevel.playSound(pPlayer, pPos, SoundEvents.ITEM_PICKUP, SoundSource.BLOCKS, 1f, 1f); } } return ItemInteractionResult.SUCCESS; }}
package net.mattias.pedestals.core.world.inventory;
import net.mattias.pedestals.core.registry.ModBlocks; import net.mattias.pedestals.core.registry.ModMenus; import net.mattias.pedestals.core.world.block.entity.PedestalBlockEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.world.entity.player.Inventory; import net.minecraft.world.entity.player.Player; import net.minecraft.world.inventory.AbstractContainerMenu; import net.minecraft.world.inventory.ContainerLevelAccess; import net.minecraft.world.inventory.Slot; import net.minecraft.world.item.ItemStack; import net.minecraft.world.level.Level; import net.minecraft.world.level.block.entity.BlockEntity; import net.neoforged.neoforge.items.SlotItemHandler;
public class PedestalMenu extends AbstractContainerMenu { public final PedestalBlockEntity blockEntity; private final Level level;
public PedestalMenu(int pContainerId, Inventory inv, FriendlyByteBuf extraData) { this(pContainerId, inv, inv.player.level().getBlockEntity(extraData.readBlockPos())); } public PedestalMenu(int pContainerId, Inventory inv, BlockEntity blockEntity) { super(ModMenus.PEDESTAL.get(), pContainerId); this.blockEntity = ((PedestalBlockEntity) blockEntity); this.level = inv.player.level(); addPlayerInventory(inv); addPlayerHotbar(inv); this.addSlot(new SlotItemHandler(this.blockEntity.inventory, 0, 80, 35)); } // CREDIT GOES TO: diesieben07 | https://github.com/diesieben07/SevenCommons // must assign a slot number to each of the slots used by the GUI. // For this container, we can see both the tile inventory's slots as well as the player inventory slots and the hotbar. // Each time we add a Slot to the container, it automatically increases the slotIndex, which means // 0 - 8 = hotbar slots (which will map to the InventoryPlayer slot numbers 0 - 8) // 9 - 35 = player inventory slots (which map to the InventoryPlayer slot numbers 9 - 35) // 36 - 44 = TileInventory slots, which map to our TileEntity slot numbers 0 - 8) private static final int HOTBAR_SLOT_COUNT = 9; private static final int PLAYER_INVENTORY_ROW_COUNT = 3; private static final int PLAYER_INVENTORY_COLUMN_COUNT = 9; private static final int PLAYER_INVENTORY_SLOT_COUNT = PLAYER_INVENTORY_COLUMN_COUNT * PLAYER_INVENTORY_ROW_COUNT; private static final int VANILLA_SLOT_COUNT = HOTBAR_SLOT_COUNT + PLAYER_INVENTORY_SLOT_COUNT; private static final int VANILLA_FIRST_SLOT_INDEX = 0; private static final int TE_INVENTORY_FIRST_SLOT_INDEX = VANILLA_FIRST_SLOT_INDEX + VANILLA_SLOT_COUNT; // THIS YOU HAVE TO DEFINE! private static final int TE_INVENTORY_SLOT_COUNT = 1; // must be the number of slots you have! @Override public ItemStack quickMoveStack(Player playerIn, int pIndex) { Slot sourceSlot = slots.get(pIndex); if (sourceSlot == null || !sourceSlot.hasItem()) return ItemStack.EMPTY; //EMPTY_ITEM ItemStack sourceStack = sourceSlot.getItem(); ItemStack copyOfSourceStack = sourceStack.copy(); // Check if the slot clicked is one of the vanilla container slots if (pIndex < VANILLA_FIRST_SLOT_INDEX + VANILLA_SLOT_COUNT) { // This is a vanilla container slot so merge the stack into the tile inventory if (!moveItemStackTo(sourceStack, TE_INVENTORY_FIRST_SLOT_INDEX, TE_INVENTORY_FIRST_SLOT_INDEX + TE_INVENTORY_SLOT_COUNT, false)) { return ItemStack.EMPTY; // EMPTY_ITEM } } else if (pIndex < TE_INVENTORY_FIRST_SLOT_INDEX + TE_INVENTORY_SLOT_COUNT) { // This is a TE slot so merge the stack into the players inventory if (!moveItemStackTo(sourceStack, VANILLA_FIRST_SLOT_INDEX, VANILLA_FIRST_SLOT_INDEX + VANILLA_SLOT_COUNT, false)) { return ItemStack.EMPTY; } } else { System.out.println("Invalid slotIndex:" + pIndex); return ItemStack.EMPTY; } // If stack size == 0 (the entire stack was moved) set slot contents to null if (sourceStack.getCount() == 0) { sourceSlot.set(ItemStack.EMPTY); } else { sourceSlot.setChanged(); } sourceSlot.onTake(playerIn, sourceStack); return copyOfSourceStack; } @Override public boolean stillValid(Player pPlayer) { return stillValid(ContainerLevelAccess.create(level, blockEntity.getBlockPos()), pPlayer, ModBlocks.PEDESTAL.get()); } private void addPlayerInventory(Inventory playerInventory) { for (int i = 0; i < 3; ++i) { for (int l = 0; l < 9; ++l) { this.addSlot(new Slot(playerInventory, l + i * 9 + 9, 8 + l * 18, 84 + i * 18)); } } } private void addPlayerHotbar(Inventory playerInventory) { for (int i = 0; i < 9; ++i) { this.addSlot(new Slot(playerInventory, i, 8 + i * 18, 142)); } }}
Assistant
After reviewing your complete code for the Pedestal block, I can see the issue. The problem is in your
PedestalBlockclass, specifically in how you're handling the GUI opening.The issue is in this method:
@Override protected ItemInteractionResult useItemOn(ItemStack pStack, BlockState pState, Level pLevel, BlockPos pPos, Player pPlayer, InteractionHand pHand, BlockHitResult pHitResult) { if(pLevel.getBlockEntity(pPos) instanceof PedestalBlockEntity pedestalBlockEntity) { if(pPlayer.isCrouching() && !pLevel.isClientSide()) { ((ServerPlayer) pPlayer).openMenu(new SimpleMenuProvider(pedestalBlockEntity, Component.literal("Pedestal")), pPos); return ItemInteractionResult.SUCCESS; } // Rest of your code for item insertion/extraction } return ItemInteractionResult.SUCCESS; }There are two key issues:
- You're creating a new
SimpleMenuProviderinstead of using the block entity itself as the menu provider - You're passing a literal "Pedestal" component instead of using the block entity's display name
Here's how to fix it:
@Override protected ItemInteractionResult useItemOn(ItemStack pStack, BlockState pState, Level pLevel, BlockPos pPos, Player pPlayer, InteractionHand pHand, BlockHitResult pHitResult) { if(pLevel.getBlockEntity(pPos) instanceof PedestalBlockEntity pedestalBlockEntity) { if(pPlayer.isCrouching() && !pLevel.isClientSide()) { // Use the block entity directly as it implements MenuProvider ((ServerPlayer) pPlayer).openMenu(pedestalBlockEntity, pPos); return ItemInteractionResult.SUCCESS; } // Rest of your code for item insertion/extraction } return ItemInteractionResult.SUCCESS; }Additionally, make sure your
PedestalBlockEntityclass is properly implementing theMenuProviderinterface, which it appears to be doing.Another potential issue is that you're using
useItemOninstead of overridinguse. In NeoForge 1.21, you should override theusemethod for block interaction:@Override public InteractionResult use(BlockState pState, Level pLevel, BlockPos pPos, Player pPlayer, InteractionHand pHand, BlockHitResult pHitResult) { if(pLevel.getBlockEntity(pPos) instanceof PedestalBlockEntity pedestalBlockEntity) { if(pPlayer.isCrouching() && !pLevel.isClientSide()) { ((ServerPlayer) pPlayer).openMenu(pedestalBlockEntity, pPos); return InteractionResult.SUCCESS; } ItemStack pStack = pPlayer.getItemInHand(pHand); // Rest of your item handling code } return InteractionResult.SUCCESS; }These changes should fix the issue with the GUI closing immediately after opening.
- You're creating a new
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.