找出来下面代码的问题,进行改正,然后给出改正后的位置代码出来,代码如下:#include "main.h" #include "crc.h" #include…
- User
找出来下面代码的问题,进行改正,然后给出改正后的位置代码出来,代码如下:#include "main.h" #include "crc.h" #include "usart.h" #include "gpio.h"
/* Private includes ----------------------------------------------------------/ / USER CODE BEGIN Includes */
#include "string.h" #include "stdio.h" #include "ctype.h"
/* USER CODE END Includes */
/* Private typedef -----------------------------------------------------------/ / USER CODE BEGIN PTD */
/* USER CODE END PTD */
/* Private define ------------------------------------------------------------/ / USER CODE BEGIN PD */
#define BUFFER_SIZE 1024 #define MAX_DATA_LEN 512
// ?????? #define HEADER_H 0xAA #define HEADER_L 0x55 #define FOOTER_H 0x55 #define FOOTER_L 0xAA
#define CMD_LENGTH 1 #define FLAG_LENGTH 1 #define ADDR_LENGTH 2 #define DATALEN_LENGTH 2
#define CHECKSUM_LENGTH 2
#define HEADER_LENGTH 2 #define FOOTER_LENGTH 2 #define PACKET_LENGTH_FIELD_LEN 2#define MIN_PAYLOAD_LEN (CMD_LENGTH + FLAG_LENGTH + ADDR_LENGTH + DATALEN_LENGTH)
//Receive and Send #define CMD_SEND_DATA 0x02 #define CMD_RECEIVE_DATA 0x03
typedef struct { uint8_t cmd; // ?? uint8_t flag; // ?? uint16_t addr; // ?? uint16_t data_len; // ??????? uint8_t data[MAX_DATA_LEN]; // ???? } ProtocolData;
typedef enum { STATE_WAIT_HEADER_1, // ?????1 STATE_WAIT_HEADER_2, // ?????2 STATE_READ_PACKET_LEN_1, // ???????1 STATE_READ_PACKET_LEN_2, // ???????2 STATE_READ_PAYLOAD, // ??????(CMD, FLAG, ADDR, DATALEN, DATA) STATE_READ_CHECKSUM_1, // ??CRC????1 STATE_READ_CHECKSUM_2, // ??CRC????2 STATE_WAIT_FOOTER_1, // ?????1 STATE_WAIT_FOOTER_2 // ?????2 } ParserState;
typedef struct { ParserState state; //????? uint16_t payload_index; //??????payload??? uint16_t expected_payload_length; //???payload??? uint8_t raw_payload_data[BUFFER_SIZE]; //??payload?? (CMD, FLAG, ADDR, DATALEN, DATA) uint16_t checksum_received; //?????? ProtocolData pkg_data; //???????? } ProtocolParser;
typedef enum { MODE_UPPER_TO_LOWER, MODE_LOWER_TO_UPPER,
MODE_BOTH_CONVERT, } CaseConvertMode;CaseConvertMode current_mode = MODE_UPPER_TO_LOWER;
/* USER CODE END PD */
/* Private macro -------------------------------------------------------------/ / USER CODE BEGIN PM */
/* USER CODE END PM */
/* Private variables ---------------------------------------------------------*/
/* USER CODE BEGIN PV */
uint8_t rx_buffer1[BUFFER_SIZE]; uint8_t tx_buffer1[BUFFER_SIZE]; uint8_t rx_buffer2[BUFFER_SIZE]; uint8_t tx_buffer2[BUFFER_SIZE]; ProtocolParser parser;
//Data send and keep Receive uint8_t simulated_memory[512];
uint16_t simulated_data_len = 0;/* USER CODE END PV */
/* Private function prototypes -----------------------------------------------/ void SystemClock_Config(void); / USER CODE BEGIN PFP */
void ProcessReceivedPacket1(ProtocolData *pkg); void ProcessReceivedPacket2(ProtocolData *pkg); void SendResponse1(uint8_t cmd, uint16_t addr, uint8_t *data, uint16_t data_len); void SendResponse2(uint8_t cmd, uint16_t addr, uint8_t *data, uint16_t data_len); uint16_t CalculateChecksum(const uint8_t *data, size_t length);
void ProtocolParser_Init(ProtocolParser *parser);
void HAL_UARTEx_RxEventCallback(UART_HandleTypeDef *huart, uint16_t size); void HAL_GPIO_EXTI_Callback(uint16_t GPIO_Pin); void Key_Toggle_Mode(void);int __io_putchar(int ch) { HAL_UART_Transmit(&huart1, (uint8_t *)&ch, 1, 10); return ch; }
void ProtocolParser_Init(ProtocolParser *parser) { parser->state = STATE_WAIT_HEADER_1;
parser->payload_index = 0;
parser->expected_payload_length = 0;
parser->checksum_received = 0; memset(&parser->pkg_data, 0, sizeof(ProtocolData));
memset(parser->raw_payload_data, 0, sizeof(parser->raw_payload_data));
}//CRC??????? uint16_t CalculateChecksum(const uint8_t *data, size_t length) { uint16_t checksum = 0; for(size_t i = 0; i < length; i++) { checksum += data[i]; } return checksum; }
void Key_Toggle_Mode(void) { static uint8_t mode_counter = 0; mode_counter++; if (mode_counter > 3) { mode_counter = 1; }
switch (mode_counter) { case 1: current_mode = MODE_UPPER_TO_LOWER; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); break; case 2: current_mode = MODE_LOWER_TO_UPPER; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); break; case 3: current_mode = MODE_BOTH_CONVERT; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); break; }}
void ProcessReceivedPacket1(ProtocolData *pkg) {
if((pkg == NULL) || (pkg->data_len > MAX_DATA_LEN)) { return; } switch(pkg->cmd){ case 0x01:
for(uint16_t i=0; i < pkg->data_len; i++) { switch(current_mode) { case MODE_UPPER_TO_LOWER: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_LOWER_TO_UPPER: if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_BOTH_CONVERT: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); } break; } } SendResponse1(0x83, pkg->addr, pkg->data, pkg->data_len); break; case CMD_SEND_DATA://0x02 for(uint16_t i=0; i < pkg->data_len; i++) { switch(current_mode) { case MODE_UPPER_TO_LOWER: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_LOWER_TO_UPPER: if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_BOTH_CONVERT: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); } break; } } if (pkg->data_len <= sizeof(simulated_memory)) { memcpy(simulated_memory, pkg->data, pkg->data_len); simulated_data_len = pkg->data_len; SendResponse1(0x82, pkg->addr, (uint8_t*)"SEND_OK", 7); } else { SendResponse1(0xFE, pkg->addr, (uint8_t*)"SEND_TOO_LONG", 13); } break; case CMD_RECEIVE_DATA://0x03 // send before keep data if (simulated_data_len > 0) { SendResponse1(0x83, pkg->addr, simulated_memory, simulated_data_len); } else { SendResponse1(0xFD, pkg->addr, (uint8_t*)"NO_DATA", 7); } break; default: //printf("CMD Unknown: 0x%02X\r\n", pkg->cmd); SendResponse1(0xFF, pkg->addr, (uint8_t*)"UNKNOWN_CMD", 11); break; }}
void ProcessReceivedPacket2(ProtocolData *pkg) {
if((pkg == NULL) || (pkg->data_len > MAX_DATA_LEN)) { return; } switch(pkg->cmd) //??????????????????????{ case 0x01:
for(uint16_t i=0; i < pkg->data_len; i++) //????????????? { switch(current_mode) { case MODE_UPPER_TO_LOWER: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_LOWER_TO_UPPER: if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_BOTH_CONVERT: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); } break; } } SendResponse2(0x83, pkg->addr, pkg->data, pkg->data_len); break; case CMD_SEND_DATA://0x02 for(uint16_t i=0; i < pkg->data_len; i++) //????????????? { switch(current_mode) { case MODE_UPPER_TO_LOWER: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_LOWER_TO_UPPER: if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_BOTH_CONVERT: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); } break; } } if (pkg->data_len <= sizeof(simulated_memory)) { memcpy(simulated_memory, pkg->data, pkg->data_len); simulated_data_len = pkg->data_len; SendResponse2(0x82, pkg->addr, (uint8_t*)"SEND_OK", 7); } else { SendResponse2(0xFE, pkg->addr, (uint8_t*)"SEND_TOO_LONG", 13); } break; case CMD_RECEIVE_DATA://0x03 // send before keep data if (simulated_data_len > 0) { SendResponse2(0x83, pkg->addr, simulated_memory, simulated_data_len); } else { SendResponse2(0xFD, pkg->addr, (uint8_t*)"NO_DATA", 7); } break; default: //printf("CMD Unknown: 0x%02X\r\n", pkg->cmd); SendResponse2(0xFF, pkg->addr, (uint8_t*)"UNKNOWN_CMD", 11); break; }}
void SendResponse1(uint8_t cmd, uint16_t addr, uint8_t *data, uint16_t data_len) {
// ??????????????? if (data_len > MAX_DATA_LEN) { return; } // ??payload??(?? + ?? + ?? + ?????? + ????) uint16_t payload_len = CMD_LENGTH + FLAG_LENGTH + ADDR_LENGTH + DATALEN_LENGTH + data_len; // ????????????? if ((HEADER_LENGTH + PACKET_LENGTH_FIELD_LEN + payload_len + CHECKSUM_LENGTH + FOOTER_LENGTH) > BUFFER_SIZE) { Error_Handler(); // Critical error, packet too big for tx_buffer return; } uint16_t index = 0; //???????index,??????????????????? // 1.??,?????????? tx_buffer1[index++] = HEADER_H; tx_buffer1[index++] = HEADER_L; //2. ??????(2 ??) tx_buffer1[index++] = (payload_len >> 8) & 0xFF; tx_buffer1[index++] = payload_len & 0xFF; // 3.?? payload ????,???? CRC ?? uint16_t payload_start_index = index; //4.??payload?? //CMD tx_buffer1[index++] = cmd; // FLAG tx_buffer1[index++] = 0x01; // Assuming a default flag for responses // ADDR tx_buffer1[index++] = (addr >> 8) & 0xFF; tx_buffer1[index++] = addr & 0xFF; // DATALEN (????(????????????)) tx_buffer1[index++] = (data_len >> 8) & 0xFF; tx_buffer1[index++] = data_len & 0xFF; // DATA if (data_len > 0 && data != NULL) //??????????? { memcpy(&tx_buffer1[index], data, data_len); index += data_len; /// ?????????????????? } // 5.?????????????????? if ((index - payload_start_index) != payload_len) { //printf("SendResponse Error: Payload construction mismatch. Expected %u, Got %u\r\n", payload_len, (index - payload_start_index)); Error_Handler(); return; } // 6.????? uint16_t checksum = CalculateChecksum(&tx_buffer1[payload_start_index], payload_len); tx_buffer1[index++] = (checksum >> 8) & 0xFF; // ???? tx_buffer1[index++] = checksum & 0xFF; // ???? //7. ?? ?????????????? tx_buffer1[index++] = FOOTER_H; tx_buffer1[index++] = FOOTER_L; // ????????????“index? if (index > BUFFER_SIZE) { //printf("SendResponse Error: Constructed packet size %d > BUFFER_SIZE %d\r\n", index, BUFFER_SIZE); Error_Handler(); // Critical error return; } // 8.?????? if (HAL_UART_Transmit(&huart1, tx_buffer1, index, 10) != HAL_OK) { Error_Handler(); }}
void SendResponse2(uint8_t cmd, uint16_t addr, uint8_t *data, uint16_t data_len) {
// ??????????????? if (data_len > MAX_DATA_LEN) { return; } // ??payload??(?? + ?? + ?? + ?????? + ????) uint16_t payload_len = CMD_LENGTH + FLAG_LENGTH + ADDR_LENGTH + DATALEN_LENGTH + data_len; // ????????????? if ((HEADER_LENGTH + PACKET_LENGTH_FIELD_LEN + payload_len + CHECKSUM_LENGTH + FOOTER_LENGTH) > BUFFER_SIZE) { Error_Handler(); // Critical error, packet too big for tx_buffer return; } uint16_t index = 0; //???????index,??????????????????? // 1.??,?????????? tx_buffer2[index++] = HEADER_H; tx_buffer2[index++] = HEADER_L; //2. ??????(2 ??) tx_buffer2[index++] = (payload_len >> 8) & 0xFF; tx_buffer2[index++] = payload_len & 0xFF; // 3.?? payload ????,???? CRC ?? uint16_t payload_start_index = index; //4.??payload?? //CMD tx_buffer2[index++] = cmd; // FLAG tx_buffer2[index++] = 0x01; // Assuming a default flag for responses // ADDR tx_buffer2[index++] = (addr >> 8) & 0xFF; tx_buffer2[index++] = addr & 0xFF; // DATALEN (????(????????????)) tx_buffer2[index++] = (data_len >> 8) & 0xFF; tx_buffer2[index++] = data_len & 0xFF; // DATA if (data_len > 0 && data != NULL) //??????????? { memcpy(&tx_buffer2[index], data, data_len); index += data_len; /// ?????????????????? } // 5.?????????????????? if ((index - payload_start_index) != payload_len) { //printf("SendResponse Error: Payload construction mismatch. Expected %u, Got %u\r\n", payload_len, (index - payload_start_index)); Error_Handler(); return; } // 6.????? uint16_t checksum = CalculateChecksum(&tx_buffer2[payload_start_index], payload_len); tx_buffer2[index++] = (checksum >> 8) & 0xFF; // ???? tx_buffer2[index++] = checksum & 0xFF; // ???? //7. ?? ?????????????? tx_buffer2[index++] = FOOTER_H; tx_buffer2[index++] = FOOTER_L; // ????????????“index? if (index > BUFFER_SIZE) { //printf("SendResponse Error: Constructed packet size %d > BUFFER_SIZE %d\r\n", index, BUFFER_SIZE); Error_Handler(); // Critical error return; } // 8.?????? if (HAL_UART_Transmit(&huart2, tx_buffer2, index, 10) != HAL_OK) { Error_Handler(); }}
void HAL_GPIO_EXTI_Callback(uint16_t GPIO_Pin) { if (GPIO_Pin == GPIO_PIN_15) // KEY2 -> PB15 { static uint32_t last_debounce_time = 0; uint32_t current_time = HAL_GetTick(); if (current_time - last_debounce_time > 200) { last_debounce_time = current_time; Key_Toggle_Mode(); } }
}
// UART ?????????? void HAL_UARTEx_RxEventCallback(UART_HandleTypeDef *huart, uint16_t size) { if (huart == &huart1) { //HAL_UART_Transmit(&huart1, rx_buffer, size, 100);
for (uint16_t i = 0; i < size; i++) { uint8_t byte=rx_buffer1[i]; //???????????? switch(parser.state) //??????????,?????????? { // 1. ???????????(0xAA) case STATE_WAIT_HEADER_1: if (byte == HEADER_H) { parser.state = STATE_WAIT_HEADER_2; //?????????????? } break; // ???????????(0x55) case STATE_WAIT_HEADER_2: if (byte == HEADER_L) { parser.state = STATE_READ_PACKET_LEN_1; //????????????? }else{ ProtocolParser_Init(&parser); //??????? } break; // 2. ?? payload ???? 1 case STATE_READ_PACKET_LEN_1: parser.expected_payload_length = (uint16_t)byte << 8; //???????????,???expected_payload_length???? parser.state = STATE_READ_PACKET_LEN_2; break; // ?? payload ???? 2 case STATE_READ_PACKET_LEN_2: parser.expected_payload_length |= byte; //???????????,????????????? parser.payload_index = 0; //??????payload??? if (parser.expected_payload_length < MIN_PAYLOAD_LEN || parser.expected_payload_length > sizeof(parser.raw_payload_data)) { ProtocolParser_Init(&parser); } else { parser.state = STATE_READ_PAYLOAD; } break; // 3. ?? payload ??(CMD + FLAG + ADDR + DATALEN + DATA) case STATE_READ_PAYLOAD: if (parser.payload_index < sizeof(parser.raw_payload_data)) { parser.raw_payload_data[parser.payload_index++] = byte; //????????????(????????????????????) } else { ProtocolParser_Init(&parser); break; } if (parser.payload_index >= parser.expected_payload_length) { parser.state = STATE_READ_CHECKSUM_1; } break; // 4. ???????1 case STATE_READ_CHECKSUM_1: parser.checksum_received = (uint16_t)byte << 8; // ?????????,???checksum_received???? parser.state = STATE_READ_CHECKSUM_2; break; // ???????2 case STATE_READ_CHECKSUM_2: parser.checksum_received |= byte; // ?????????,?????????? //????????????????????????? if ((CalculateChecksum(parser.raw_payload_data, parser.expected_payload_length)) == parser.checksum_received) { parser.state = STATE_WAIT_FOOTER_1; } else{ ProtocolParser_Init(&parser); } break; // 5. ?????????(0x55) case STATE_WAIT_FOOTER_1: if (byte == FOOTER_H) { parser.state = STATE_WAIT_FOOTER_2; } else { ProtocolParser_Init(&parser); } break; // ?????????(0xAA) case STATE_WAIT_FOOTER_2: if (byte == FOOTER_L) { // ?????????,?????? uint8_t *p = parser.raw_payload_data; // ???? parser.pkg_data.cmd = *p++; // ???? parser.pkg_data.flag = *p++; // ???? (???) parser.pkg_data.addr = (uint16_t)(*p++) << 8; parser.pkg_data.addr |= *p++; // ?????? (???) parser.pkg_data.data_len = (uint16_t)(*p++) << 8; parser.pkg_data.data_len |= *p++; // ??????data_len???? if (parser.expected_payload_length != (MIN_PAYLOAD_LEN + parser.pkg_data.data_len)) { ProtocolParser_Init(&parser); // ??????? break; } if (parser.pkg_data.data_len > MAX_DATA_LEN) { ProtocolParser_Init(&parser); // ???????? break; } if (parser.pkg_data.data_len > 0) { memcpy(parser.pkg_data.data, p, parser.pkg_data.data_len); } // ???????????? ProcessReceivedPacket1(&parser.pkg_data); } // ?????????????? ProtocolParser_Init(&parser); break; default: ProtocolParser_Init(&parser); break; } } // ???????? if(HAL_UARTEx_ReceiveToIdle_IT(&huart1, rx_buffer1, BUFFER_SIZE) != HAL_OK) { Error_Handler(); } } if (huart == &huart2) { //HAL_UART_Transmit(&huart1, rx_buffer, size, 100); for (uint16_t i = 0; i < size; i++) { uint8_t byte=rx_buffer2[i]; //???????????? switch(parser.state) //??????????,?????????? { // 1. ???????????(0xAA) case STATE_WAIT_HEADER_1: if (byte == HEADER_H) { parser.state = STATE_WAIT_HEADER_2; //?????????????? } break; // ???????????(0x55) case STATE_WAIT_HEADER_2: if (byte == HEADER_L) { parser.state = STATE_READ_PACKET_LEN_1; //????????????? }else{ ProtocolParser_Init(&parser); //??????? } break; // 2. ?? payload ???? 1 case STATE_READ_PACKET_LEN_1: parser.expected_payload_length = (uint16_t)byte << 8; //???????????,???expected_payload_length???? parser.state = STATE_READ_PACKET_LEN_2; break; // ?? payload ???? 2 case STATE_READ_PACKET_LEN_2: parser.expected_payload_length |= byte; //???????????,????????????? parser.payload_index = 0; //??????payload??? if (parser.expected_payload_length < MIN_PAYLOAD_LEN || parser.expected_payload_length > sizeof(parser.raw_payload_data)) { ProtocolParser_Init(&parser); } else { parser.state = STATE_READ_PAYLOAD; } break; // 3. ?? payload ??(CMD + FLAG + ADDR + DATALEN + DATA) case STATE_READ_PAYLOAD: if (parser.payload_index < sizeof(parser.raw_payload_data)) { parser.raw_payload_data[parser.payload_index++] = byte; //????????????(????????????????????) } else { ProtocolParser_Init(&parser); break; } if (parser.payload_index >= parser.expected_payload_length) { parser.state = STATE_READ_CHECKSUM_1; } break; // 4. ???????1 case STATE_READ_CHECKSUM_1: parser.checksum_received = (uint16_t)byte << 8; // ?????????,???checksum_received???? parser.state = STATE_READ_CHECKSUM_2; break; // ???????2 case STATE_READ_CHECKSUM_2: parser.checksum_received |= byte; // ?????????,?????????? //????????????????????????? if ((CalculateChecksum(parser.raw_payload_data, parser.expected_payload_length)) == parser.checksum_received) { parser.state = STATE_WAIT_FOOTER_1; } else{ ProtocolParser_Init(&parser); } break; // 5. ?????????(0x55) case STATE_WAIT_FOOTER_1: if (byte == FOOTER_H) { parser.state = STATE_WAIT_FOOTER_2; } else { ProtocolParser_Init(&parser); } break; // ?????????(0xAA) case STATE_WAIT_FOOTER_2: if (byte == FOOTER_L) { // ?????????,?????? uint8_t *p = parser.raw_payload_data; // ???? parser.pkg_data.cmd = *p++; // ???? parser.pkg_data.flag = *p++; // ???? (???) parser.pkg_data.addr = (uint16_t)(*p++) << 8; parser.pkg_data.addr |= *p++; // ?????? (???) parser.pkg_data.data_len = (uint16_t)(*p++) << 8; parser.pkg_data.data_len |= *p++; // ??????data_len???? if (parser.expected_payload_length != (MIN_PAYLOAD_LEN + parser.pkg_data.data_len)) { ProtocolParser_Init(&parser); // ??????? break; } if (parser.pkg_data.data_len > MAX_DATA_LEN) { ProtocolParser_Init(&parser); // ???????? break; } if (parser.pkg_data.data_len > 0) { memcpy(parser.pkg_data.data, p, parser.pkg_data.data_len); } // ???????????? ProcessReceivedPacket2(&parser.pkg_data); } // ?????????????? ProtocolParser_Init(&parser); break; default: ProtocolParser_Init(&parser); break; } } // ???????? if(HAL_UARTEx_ReceiveToIdle_IT(&huart2, rx_buffer2, BUFFER_SIZE) != HAL_OK) { Error_Handler(); } }}
/* USER CODE END PFP */
/* Private user code ---------------------------------------------------------/ / USER CODE BEGIN 0 */
/* USER CODE END 0 */
/**
- @brief The application entry point.
- @retval int */ int main(void) {
/* USER CODE BEGIN 1 */
/* USER CODE END 1 */
/* MCU Configuration--------------------------------------------------------*/
/* Reset of all peripherals, Initializes the Flash interface and the Systick. */ HAL_Init();
/* USER CODE BEGIN Init */
/* USER CODE END Init */
/* Configure the system clock */ SystemClock_Config();
/* USER CODE BEGIN SysInit */
/* USER CODE END SysInit */
/* Initialize all configured peripherals / MX_GPIO_Init(); MX_CRC_Init(); MX_USART1_UART_Init(); MX_USART2_UART_Init(); MX_USART3_UART_Init(); / USER CODE BEGIN 2 */
ProtocolParser_Init(&parser); //???????? if(HAL_UARTEx_ReceiveToIdle_IT(&huart1, rx_buffer1, BUFFER_SIZE) != HAL_OK) { Error_Handler(); }
ProtocolParser_Init(&parser); if(HAL_UARTEx_ReceiveToIdle_IT(&huart2, rx_buffer2, BUFFER_SIZE) != HAL_OK) { Error_Handler(); }
/* USER CODE END 2 */
/* Infinite loop / / USER CODE BEGIN WHILE / while (1) { / USER CODE END WHILE */
/* USER CODE BEGIN 3 */} /* USER CODE END 3 */ }
/**
- @brief System Clock Configuration
- @retval None */ void SystemClock_Config(void) { RCC_OscInitTypeDef RCC_OscInitStruct = {0}; RCC_ClkInitTypeDef RCC_ClkInitStruct = {0};
/** Initializes the RCC Oscillators according to the specified parameters
- in the RCC_OscInitTypeDef structure. */ RCC_OscInitStruct.OscillatorType = RCC_OSCILLATORTYPE_HSI; RCC_OscInitStruct.HSIState = RCC_HSI_ON; RCC_OscInitStruct.HSICalibrationValue = RCC_HSICALIBRATION_DEFAULT; RCC_OscInitStruct.PLL.PLLState = RCC_PLL_NONE; if (HAL_RCC_OscConfig(&RCC_OscInitStruct) != HAL_OK) { Error_Handler(); }
/** Initializes the CPU, AHB and APB buses clocks */ RCC_ClkInitStruct.ClockType = RCC_CLOCKTYPE_HCLK|RCC_CLOCKTYPE_SYSCLK |RCC_CLOCKTYPE_PCLK1|RCC_CLOCKTYPE_PCLK2; RCC_ClkInitStruct.SYSCLKSource = RCC_SYSCLKSOURCE_HSI; RCC_ClkInitStruct.AHBCLKDivider = RCC_SYSCLK_DIV1; RCC_ClkInitStruct.APB1CLKDivider = RCC_HCLK_DIV1; RCC_ClkInitStruct.APB2CLKDivider = RCC_HCLK_DIV1;
if (HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_0) != HAL_OK) { Error_Handler(); } }
/* USER CODE BEGIN 4 */
/* USER CODE END 4 */
/**
- @brief This function is executed in case of error occurrence.
- @retval None / void Error_Handler(void) { / USER CODE BEGIN Error_Handler_Debug / / User can add his own implementation to report the HAL error return state / __disable_irq(); while (1) { } / USER CODE END Error_Handler_Debug */ }
#ifdef USE_FULL_ASSERT /**
- @brief Reports the name of the source file and the source line number
-
where the assert_param error has occurred. - @param file: pointer to the source file name
- @param line: assert_param error line source number
- @retval None */ void assert_failed(uint8_t file, uint32_t line) { / USER CODE BEGIN 6 / / User can add his own implementation to report the file name and line number, ex: printf("Wrong parameters value: file %s on line %d\r\n", file, line) / / USER CODE END 6 / } #endif / USE_FULL_ASSERT */
- Assistant
下面列出了本例中最主要的问题及其改正方案:
-
同一
ProtocolParser parser同时被 UART1/2 共用
这样在两个串口数据交叉时,状态机会被干扰,导致数据解析混乱。
改正:为每一路 UART 独立维护一个ProtocolParser实例。 -
初始化和回调里也要分别使用不同的
ProtocolParser
包括ProtocolParser_Init()、状态机运转、以及最后的重置都要针对不同实例。
下面仅贴出改动处的代码,去掉原始代码中“重复”部分,标出修改前/后的对比。
———
1. 全局变量声明
- ProtocolParser parser; + ProtocolParser parser1; + ProtocolParser parser2;2.
main()函数中初始化- ProtocolParser_Init(&parser); + ProtocolParser_Init(&parser1); if (HAL_UARTEx_ReceiveToIdle_IT(&huart1, rx_buffer1, BUFFER_SIZE) != HAL_OK) { Error_Handler(); } - ProtocolParser_Init(&parser); + ProtocolParser_Init(&parser2); if (HAL_UARTEx_ReceiveToIdle_IT(&huart2, rx_buffer2, BUFFER_SIZE) != HAL_OK) { Error_Handler(); }3.
HAL_UARTEx_RxEventCallback()中分别引用不同 parservoid HAL_UARTEx_RxEventCallback(UART_HandleTypeDef *huart, uint16_t size) { if (huart == &huart1) { - for (…) - switch (parser.state) + for (uint16_t i = 0; i < size; i++) + { + uint8_t byte = rx_buffer1[i]; + switch (parser1.state) { case STATE_WAIT_HEADER_1: … case STATE_WAIT_FOOTER_2: if (byte == FOOTER_L) { // 拆包、拷贝到 parser1.pkg_data… ProcessReceivedPacket1(&parser1.pkg_data); } - ProtocolParser_Init(&parser); + ProtocolParser_Init(&parser1); break; } } /* 重新开启 UART1 接收 */ if (HAL_UARTEx_ReceiveToIdle_IT(&huart1, rx_buffer1, BUFFER_SIZE) != HAL_OK) { Error_Handler(); } } if (huart == &huart2) { - for (…) - switch (parser.state) + for (uint16_t i = 0; i < size; i++) + { + uint8_t byte = rx_buffer2[i]; + switch (parser2.state) { case STATE_WAIT_HEADER_1: … case STATE_WAIT_FOOTER_2: if (byte == FOOTER_L) { // 拆包、拷贝到 parser2.pkg_data… ProcessReceivedPacket2(&parser2.pkg_data); } - ProtocolParser_Init(&parser); + ProtocolParser_Init(&parser2); break; } } /* 重新开启 UART2 接收 */ if (HAL_UARTEx_ReceiveToIdle_IT(&huart2, rx_buffer2, BUFFER_SIZE) != HAL_OK) { Error_Handler(); } } }———
如此一来,UART1 和 UART2 分别使用
parser1/parser2,互不干扰,就能正确稳定地解析每一路的数据包了。 -
- User
继续找出下面代码错误的地方:#include "main.h" #include "crc.h" #include "usart.h" #include "gpio.h"
/* Private includes ----------------------------------------------------------/ / USER CODE BEGIN Includes */
#include "string.h" #include "stdio.h" #include "ctype.h"
/* USER CODE END Includes */
/* Private typedef -----------------------------------------------------------/ / USER CODE BEGIN PTD */
/* USER CODE END PTD */
/* Private define ------------------------------------------------------------/ / USER CODE BEGIN PD */
#define BUFFER_SIZE 1024 #define MAX_DATA_LEN 512
// ?????? #define HEADER_H 0xAA #define HEADER_L 0x55 #define FOOTER_H 0x55 #define FOOTER_L 0xAA
#define CMD_LENGTH 1 #define FLAG_LENGTH 1 #define ADDR_LENGTH 2 #define DATALEN_LENGTH 2
#define CHECKSUM_LENGTH 2
#define HEADER_LENGTH 2 #define FOOTER_LENGTH 2 #define PACKET_LENGTH_FIELD_LEN 2#define MIN_PAYLOAD_LEN (CMD_LENGTH + FLAG_LENGTH + ADDR_LENGTH + DATALEN_LENGTH)
//Receive and Send #define CMD_SEND_DATA 0x02 #define CMD_RECEIVE_DATA 0x03
typedef struct { uint8_t cmd; // ?? uint8_t flag; // ?? uint16_t addr; // ?? uint16_t data_len; // ??????? uint8_t data[MAX_DATA_LEN]; // ???? } ProtocolData;
typedef enum { STATE_WAIT_HEADER_1, // ?????1 STATE_WAIT_HEADER_2, // ?????2 STATE_READ_PACKET_LEN_1, // ???????1 STATE_READ_PACKET_LEN_2, // ???????2 STATE_READ_PAYLOAD, // ??????(CMD, FLAG, ADDR, DATALEN, DATA) STATE_READ_CHECKSUM_1, // ??CRC????1 STATE_READ_CHECKSUM_2, // ??CRC????2 STATE_WAIT_FOOTER_1, // ?????1 STATE_WAIT_FOOTER_2 // ?????2 } ParserState;
typedef struct { ParserState state; //????? uint16_t payload_index; //??????payload??? uint16_t expected_payload_length; //???payload??? uint8_t raw_payload_data[BUFFER_SIZE]; //??payload?? (CMD, FLAG, ADDR, DATALEN, DATA) uint16_t checksum_received; //?????? ProtocolData pkg_data; //???????? } ProtocolParser;
typedef enum { MODE_UPPER_TO_LOWER, MODE_LOWER_TO_UPPER,
MODE_BOTH_CONVERT, } CaseConvertMode;CaseConvertMode current_mode = MODE_UPPER_TO_LOWER;
/* USER CODE END PD */
/* Private macro -------------------------------------------------------------/ / USER CODE BEGIN PM */
/* USER CODE END PM */
/* Private variables ---------------------------------------------------------*/
/* USER CODE BEGIN PV */
uint8_t rx_buffer1[BUFFER_SIZE]; uint8_t tx_buffer1[BUFFER_SIZE]; uint8_t rx_buffer2[BUFFER_SIZE]; uint8_t tx_buffer2[BUFFER_SIZE];
//ProtocolParser parser; ProtocolParser parser1; ProtocolParser parser2;
//Data send and keep Receive uint8_t simulated_memory1[512];
uint16_t simulated_data_len1 = 0; uint8_t simulated_memory2[512];
uint16_t simulated_data_len2 = 0;/* USER CODE END PV */
/* Private function prototypes -----------------------------------------------/ void SystemClock_Config(void); / USER CODE BEGIN PFP */
void ProcessReceivedPacket1(ProtocolData *pkg); void ProcessReceivedPacket2(ProtocolData *pkg); void SendResponse1(uint8_t cmd, uint16_t addr, uint8_t *data, uint16_t data_len); void SendResponse2(uint8_t cmd, uint16_t addr, uint8_t *data, uint16_t data_len); uint16_t CalculateChecksum(const uint8_t *data, size_t length);
void ProtocolParser_Init(ProtocolParser *parser);
void HAL_UARTEx_RxEventCallback(UART_HandleTypeDef *huart, uint16_t size); void HAL_GPIO_EXTI_Callback(uint16_t GPIO_Pin); void Key_Toggle_Mode(void);int __io_putchar(int ch) { HAL_UART_Transmit(&huart1, (uint8_t *)&ch, 1, 10); return ch; }
void ProtocolParser_Init(ProtocolParser *parser) { parser->state = STATE_WAIT_HEADER_1;
parser->payload_index = 0;
parser->expected_payload_length = 0;
parser->checksum_received = 0; memset(&parser->pkg_data, 0, sizeof(ProtocolData));
memset(parser->raw_payload_data, 0, sizeof(parser->raw_payload_data));
}//CRC??????? uint16_t CalculateChecksum(const uint8_t *data, size_t length) { uint16_t checksum = 0; for(size_t i = 0; i < length; i++) { checksum += data[i]; } return checksum; }
void Key_Toggle_Mode(void) { static uint8_t mode_counter = 0; mode_counter++; if (mode_counter > 3) { mode_counter = 1; }
switch (mode_counter) { case 1: current_mode = MODE_UPPER_TO_LOWER; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); break; case 2: current_mode = MODE_LOWER_TO_UPPER; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); break; case 3: current_mode = MODE_BOTH_CONVERT; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); break; }}
void ProcessReceivedPacket1(ProtocolData *pkg) {
if((pkg == NULL) || (pkg->data_len > MAX_DATA_LEN)) { return; } switch(pkg->cmd){ case 0x01:
for(uint16_t i=0; i < pkg->data_len; i++) { switch(current_mode) { case MODE_UPPER_TO_LOWER: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_LOWER_TO_UPPER: if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_BOTH_CONVERT: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); } break; } } SendResponse1(0x83, pkg->addr, pkg->data, pkg->data_len); break; case CMD_SEND_DATA://0x02 for(uint16_t i=0; i < pkg->data_len; i++) { switch(current_mode) { case MODE_UPPER_TO_LOWER: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_LOWER_TO_UPPER: if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_BOTH_CONVERT: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); } break; } } if (pkg->data_len <= sizeof(simulated_memory1)) { memcpy(simulated_memory1, pkg->data, pkg->data_len); simulated_data_len1 = pkg->data_len; SendResponse1(0x82, pkg->addr, (uint8_t*)"SEND_OK", 7); } else { SendResponse1(0xFE, pkg->addr, (uint8_t*)"SEND_TOO_LONG", 13); } break; case CMD_RECEIVE_DATA://0x03 // send before keep data if (simulated_data_len1 > 0) { SendResponse1(0x83, pkg->addr, simulated_memory1, simulated_data_len1); } else { SendResponse1(0xFD, pkg->addr, (uint8_t*)"NO_DATA", 7); } break; default: //printf("CMD Unknown: 0x%02X\r\n", pkg->cmd); SendResponse1(0xFF, pkg->addr, (uint8_t*)"UNKNOWN_CMD", 11); break; }}
void ProcessReceivedPacket2(ProtocolData *pkg) {
if((pkg == NULL) || (pkg->data_len > MAX_DATA_LEN)) { return; } switch(pkg->cmd) //??????????????????????{ case 0x01:
for(uint16_t i=0; i < pkg->data_len; i++) //????????????? { switch(current_mode) { case MODE_UPPER_TO_LOWER: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_LOWER_TO_UPPER: if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_BOTH_CONVERT: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); } break; } } SendResponse2(0x83, pkg->addr, pkg->data, pkg->data_len); break; case CMD_SEND_DATA://0x02 for(uint16_t i=0; i < pkg->data_len; i++) //????????????? { switch(current_mode) { case MODE_UPPER_TO_LOWER: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_LOWER_TO_UPPER: if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_SET); } else { HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_RESET); } break; case MODE_BOTH_CONVERT: if (pkg->data[i] >= 'A' && pkg->data[i] <= 'Z') { pkg->data[i] = pkg->data[i] + 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); } else if (pkg->data[i] >= 'a' && pkg->data[i] <= 'z') { pkg->data[i] = pkg->data[i] - 32; HAL_GPIO_WritePin(GPIOB, GPIO_PIN_13, GPIO_PIN_RESET); HAL_GPIO_WritePin(GPIOB, GPIO_PIN_14, GPIO_PIN_SET); } break; } } if (pkg->data_len <= sizeof(simulated_memory2)) { memcpy(simulated_memory2, pkg->data, pkg->data_len); simulated_data_len2 = pkg->data_len; SendResponse2(0x82, pkg->addr, (uint8_t*)"SEND_OK", 7); } else { SendResponse2(0xFE, pkg->addr, (uint8_t*)"SEND_TOO_LONG", 13); } break; case CMD_RECEIVE_DATA://0x03 // send before keep data if (simulated_data_len2 > 0) { SendResponse2(0x83, pkg->addr, simulated_memory2, simulated_data_len2); } else { SendResponse2(0xFD, pkg->addr, (uint8_t*)"NO_DATA", 7); } break; default: //printf("CMD Unknown: 0x%02X\r\n", pkg->cmd); SendResponse2(0xFF, pkg->addr, (uint8_t*)"UNKNOWN_CMD", 11); break; }}
void SendResponse1(uint8_t cmd, uint16_t addr, uint8_t *data, uint16_t data_len) {
// ??????????????? if (data_len > MAX_DATA_LEN) { return; } // ??payload??(?? + ?? + ?? + ?????? + ????) uint16_t payload_len = CMD_LENGTH + FLAG_LENGTH + ADDR_LENGTH + DATALEN_LENGTH + data_len; // ????????????? if ((HEADER_LENGTH + PACKET_LENGTH_FIELD_LEN + payload_len + CHECKSUM_LENGTH + FOOTER_LENGTH) > BUFFER_SIZE) { Error_Handler(); // Critical error, packet too big for tx_buffer return; } uint16_t index = 0; //???????index,??????????????????? // 1.??,?????????? tx_buffer1[index++] = HEADER_H; tx_buffer1[index++] = HEADER_L; //2. ??????(2 ??) tx_buffer1[index++] = (payload_len >> 8) & 0xFF; tx_buffer1[index++] = payload_len & 0xFF; // 3.?? payload ????,???? CRC ?? uint16_t payload_start_index = index; //4.??payload?? //CMD tx_buffer1[index++] = cmd; // FLAG tx_buffer1[index++] = 0x01; // Assuming a default flag for responses // ADDR tx_buffer1[index++] = (addr >> 8) & 0xFF; tx_buffer1[index++] = addr & 0xFF; // DATALEN (????(????????????)) tx_buffer1[index++] = (data_len >> 8) & 0xFF; tx_buffer1[index++] = data_len & 0xFF; // DATA if (data_len > 0 && data != NULL) //??????????? { memcpy(&tx_buffer1[index], data, data_len); index += data_len; /// ?????????????????? } // 5.?????????????????? if ((index - payload_start_index) != payload_len) { //printf("SendResponse Error: Payload construction mismatch. Expected %u, Got %u\r\n", payload_len, (index - payload_start_index)); Error_Handler(); return; } // 6.????? uint16_t checksum = CalculateChecksum(&tx_buffer1[payload_start_index], payload_len); tx_buffer1[index++] = (checksum >> 8) & 0xFF; // ???? tx_buffer1[index++] = checksum & 0xFF; // ???? //7. ?? ?????????????? tx_buffer1[index++] = FOOTER_H; tx_buffer1[index++] = FOOTER_L; // ????????????“index? if (index > BUFFER_SIZE) { //printf("SendResponse Error: Constructed packet size %d > BUFFER_SIZE %d\r\n", index, BUFFER_SIZE); Error_Handler(); // Critical error return; } // 8.?????? if (HAL_UART_Transmit(&huart1, tx_buffer1, index, 10) != HAL_OK) { Error_Handler(); }}
void SendResponse2(uint8_t cmd, uint16_t addr, uint8_t *data, uint16_t data_len) {
// ??????????????? if (data_len > MAX_DATA_LEN) { return; } // ??payload??(?? + ?? + ?? + ?????? + ????) uint16_t payload_len = CMD_LENGTH + FLAG_LENGTH + ADDR_LENGTH + DATALEN_LENGTH + data_len; // ????????????? if ((HEADER_LENGTH + PACKET_LENGTH_FIELD_LEN + payload_len + CHECKSUM_LENGTH + FOOTER_LENGTH) > BUFFER_SIZE) { Error_Handler(); // Critical error, packet too big for tx_buffer return; } uint16_t index = 0; //???????index,??????????????????? // 1.??,?????????? tx_buffer2[index++] = HEADER_H; tx_buffer2[index++] = HEADER_L; //2. ??????(2 ??) tx_buffer2[index++] = (payload_len >> 8) & 0xFF; tx_buffer2[index++] = payload_len & 0xFF; // 3.?? payload ????,???? CRC ?? uint16_t payload_start_index = index; //4.??payload?? //CMD tx_buffer2[index++] = cmd; // FLAG tx_buffer2[index++] = 0x01; // Assuming a default flag for responses // ADDR tx_buffer2[index++] = (addr >> 8) & 0xFF; tx_buffer2[index++] = addr & 0xFF; // DATALEN (????(????????????)) tx_buffer2[index++] = (data_len >> 8) & 0xFF; tx_buffer2[index++] = data_len & 0xFF; // DATA if (data_len > 0 && data != NULL) //??????????? { memcpy(&tx_buffer2[index], data, data_len); index += data_len; /// ?????????????????? } // 5.?????????????????? if ((index - payload_start_index) != payload_len) { //printf("SendResponse Error: Payload construction mismatch. Expected %u, Got %u\r\n", payload_len, (index - payload_start_index)); Error_Handler(); return; } // 6.????? uint16_t checksum = CalculateChecksum(&tx_buffer2[payload_start_index], payload_len); tx_buffer2[index++] = (checksum >> 8) & 0xFF; // ???? tx_buffer2[index++] = checksum & 0xFF; // ???? //7. ?? ?????????????? tx_buffer2[index++] = FOOTER_H; tx_buffer2[index++] = FOOTER_L; // ????????????“index? if (index > BUFFER_SIZE) { //printf("SendResponse Error: Constructed packet size %d > BUFFER_SIZE %d\r\n", index, BUFFER_SIZE); Error_Handler(); // Critical error return; } // 8.?????? if (HAL_UART_Transmit(&huart2, tx_buffer2, index, 10) != HAL_OK) { Error_Handler(); }}
void HAL_GPIO_EXTI_Callback(uint16_t GPIO_Pin) { if (GPIO_Pin == GPIO_PIN_15) // KEY2 -> PB15 { static uint32_t last_debounce_time = 0; uint32_t current_time = HAL_GetTick(); if (current_time - last_debounce_time > 200) { last_debounce_time = current_time; Key_Toggle_Mode(); } }
}
// UART ?????????? void HAL_UARTEx_RxEventCallback(UART_HandleTypeDef *huart, uint16_t size) { if (huart == &huart1) { //HAL_UART_Transmit(&huart1, rx_buffer, size, 100);
for (uint16_t i = 0; i < size; i++) { uint8_t byte=rx_buffer1[i]; //???????????? switch(parser1.state) //??????????,?????????? { // 1. ???????????(0xAA) case STATE_WAIT_HEADER_1: if (byte == HEADER_H) { parser1.state = STATE_WAIT_HEADER_2; //?????????????? } break; // ???????????(0x55) case STATE_WAIT_HEADER_2: if (byte == HEADER_L) { parser1.state = STATE_READ_PACKET_LEN_1; //????????????? }else{ ProtocolParser_Init(&parser1); //??????? } break; // 2. ?? payload ???? 1 case STATE_READ_PACKET_LEN_1: parser1.expected_payload_length = (uint16_t)byte << 8; //???????????,???expected_payload_length???? parser1.state = STATE_READ_PACKET_LEN_2; break; // ?? payload ???? 2 case STATE_READ_PACKET_LEN_2: parser1.expected_payload_length |= byte; //???????????,????????????? parser1.payload_index = 0; //??????payload??? if (parser1.expected_payload_length < MIN_PAYLOAD_LEN || parser1.expected_payload_length > sizeof(parser1.raw_payload_data)) { ProtocolParser_Init(&parser1); } else { parser1.state = STATE_READ_PAYLOAD; } break; // 3. ?? payload ??(CMD + FLAG + ADDR + DATALEN + DATA) case STATE_READ_PAYLOAD: if (parser1.payload_index < sizeof(parser1.raw_payload_data)) { parser1.raw_payload_data[parser1.payload_index++] = byte; //????????????(????????????????????) } else { ProtocolParser_Init(&parser1); break; } if (parser1.payload_index >= parser1.expected_payload_length) { parser1.state = STATE_READ_CHECKSUM_1; } break; // 4. ???????1 case STATE_READ_CHECKSUM_1: parser1.checksum_received = (uint16_t)byte << 8; // ?????????,???checksum_received???? parser1.state = STATE_READ_CHECKSUM_2; break; // ???????2 case STATE_READ_CHECKSUM_2: parser1.checksum_received |= byte; // ?????????,?????????? //????????????????????????? if ((CalculateChecksum(parser1.raw_payload_data, parser1.expected_payload_length)) == parser1.checksum_received) { parser1.state = STATE_WAIT_FOOTER_1; } else{ ProtocolParser_Init(&parser1); } break; // 5. ?????????(0x55) case STATE_WAIT_FOOTER_1: if (byte == FOOTER_H) { parser1.state = STATE_WAIT_FOOTER_2; } else { ProtocolParser_Init(&parser1); } break; // ?????????(0xAA) case STATE_WAIT_FOOTER_2: if (byte == FOOTER_L) { // ?????????,?????? uint8_t *p = parser1.raw_payload_data; // ???? parser1.pkg_data.cmd = *p++; // ???? parser1.pkg_data.flag = *p++; // ???? (???) parser1.pkg_data.addr = (uint16_t)(*p++) << 8; parser1.pkg_data.addr |= *p++; // ?????? (???) parser1.pkg_data.data_len = (uint16_t)(*p++) << 8; parser1.pkg_data.data_len |= *p++; // ??????data_len???? if (parser1.expected_payload_length != (MIN_PAYLOAD_LEN + parser1.pkg_data.data_len)) { ProtocolParser_Init(&parser1); // ??????? break; } if (parser1.pkg_data.data_len > MAX_DATA_LEN) { ProtocolParser_Init(&parser1); // ???????? break; } if (parser1.pkg_data.data_len > 0) { memcpy(parser1.pkg_data.data, p, parser1.pkg_data.data_len); } // ???????????? ProcessReceivedPacket1(&parser1.pkg_data); } // ?????????????? ProtocolParser_Init(&parser1); break; default: ProtocolParser_Init(&parser1); break; } } // ???????? if(HAL_UARTEx_ReceiveToIdle_IT(&huart1, rx_buffer1, BUFFER_SIZE) != HAL_OK) { Error_Handler(); } } if (huart == &huart2) { //HAL_UART_Transmit(&huart1, rx_buffer, size, 100); for (uint16_t i = 0; i < size; i++) { uint8_t byte=rx_buffer2[i]; //???????????? switch(parser2.state) //??????????,?????????? { // 1. ???????????(0xAA) case STATE_WAIT_HEADER_1: if (byte == HEADER_H) { parser2.state = STATE_WAIT_HEADER_2; //?????????????? } break; // ???????????(0x55) case STATE_WAIT_HEADER_2: if (byte == HEADER_L) { parser2.state = STATE_READ_PACKET_LEN_1; //????????????? }else{ ProtocolParser_Init(&parser2); //??????? } break; // 2. ?? payload ???? 1 case STATE_READ_PACKET_LEN_1: parser2.expected_payload_length = (uint16_t)byte << 8; //???????????,???expected_payload_length???? parser2.state = STATE_READ_PACKET_LEN_2; break; // ?? payload ???? 2 case STATE_READ_PACKET_LEN_2: parser2.expected_payload_length |= byte; //???????????,????????????? parser2.payload_index = 0; //??????payload??? if (parser2.expected_payload_length < MIN_PAYLOAD_LEN || parser2.expected_payload_length > sizeof(parser2.raw_payload_data)) { ProtocolParser_Init(&parser2); } else { parser2.state = STATE_READ_PAYLOAD; } break; // 3. ?? payload ??(CMD + FLAG + ADDR + DATALEN + DATA) case STATE_READ_PAYLOAD: if (parser2.payload_index < sizeof(parser2.raw_payload_data)) { parser2.raw_payload_data[parser2.payload_index++] = byte; //????????????(????????????????????) } else { ProtocolParser_Init(&parser2); break; } if (parser2.payload_index >= parser2.expected_payload_length) { parser2.state = STATE_READ_CHECKSUM_1; } break; // 4. ???????1 case STATE_READ_CHECKSUM_1: parser2.checksum_received = (uint16_t)byte << 8; // ?????????,???checksum_received???? parser2.state = STATE_READ_CHECKSUM_2; break; // ???????2 case STATE_READ_CHECKSUM_2: parser2.checksum_received |= byte; // ?????????,?????????? //????????????????????????? if ((CalculateChecksum(parser2.raw_payload_data, parser2.expected_payload_length)) == parser2.checksum_received) { parser2.state = STATE_WAIT_FOOTER_1; } else{ ProtocolParser_Init(&parser2); } break; // 5. ?????????(0x55) case STATE_WAIT_FOOTER_1: if (byte == FOOTER_H) { parser2.state = STATE_WAIT_FOOTER_2; } else { ProtocolParser_Init(&parser2); } break; // ?????????(0xAA) case STATE_WAIT_FOOTER_2: if (byte == FOOTER_L) { // ?????????,?????? uint8_t *p = parser2.raw_payload_data; // ???? parser2.pkg_data.cmd = *p++; // ???? parser2.pkg_data.flag = *p++; // ???? (???) parser2.pkg_data.addr = (uint16_t)(*p++) << 8; parser2.pkg_data.addr |= *p++; // ?????? (???) parser2.pkg_data.data_len = (uint16_t)(*p++) << 8; parser2.pkg_data.data_len |= *p++; // ??????data_len???? if (parser2.expected_payload_length != (MIN_PAYLOAD_LEN + parser2.pkg_data.data_len)) { ProtocolParser_Init(&parser2); // ??????? break; } if (parser2.pkg_data.data_len > MAX_DATA_LEN) { ProtocolParser_Init(&parser2); // ???????? break; } if (parser2.pkg_data.data_len > 0) { memcpy(parser2.pkg_data.data, p, parser2.pkg_data.data_len); } // ???????????? ProcessReceivedPacket2(&parser2.pkg_data); } // ?????????????? ProtocolParser_Init(&parser2); break; default: ProtocolParser_Init(&parser2); break; } } // ???????? if(HAL_UARTEx_ReceiveToIdle_IT(&huart2, rx_buffer2, BUFFER_SIZE) != HAL_OK) { Error_Handler(); } }}
/* USER CODE END PFP */
/* Private user code ---------------------------------------------------------/ / USER CODE BEGIN 0 */
/* USER CODE END 0 */
/**
- @brief The application entry point.
- @retval int */ int main(void) {
/* USER CODE BEGIN 1 */
/* USER CODE END 1 */
/* MCU Configuration--------------------------------------------------------*/
/* Reset of all peripherals, Initializes the Flash interface and the Systick. */ HAL_Init();
/* USER CODE BEGIN Init */
/* USER CODE END Init */
/* Configure the system clock */ SystemClock_Config();
/* USER CODE BEGIN SysInit */
/* USER CODE END SysInit */
/* Initialize all configured peripherals / MX_GPIO_Init(); MX_CRC_Init(); MX_USART1_UART_Init(); MX_USART2_UART_Init(); MX_USART3_UART_Init(); / USER CODE BEGIN 2 */
ProtocolParser_Init(&parser1); //???????? if(HAL_UARTEx_ReceiveToIdle_IT(&huart1, rx_buffer1, BUFFER_SIZE) != HAL_OK) { Error_Handler(); }
ProtocolParser_Init(&parser2); if(HAL_UARTEx_ReceiveToIdle_IT(&huart2, rx_buffer2, BUFFER_SIZE) != HAL_OK) { Error_Handler(); }
/* USER CODE END 2 */
/* Infinite loop / / USER CODE BEGIN WHILE / while (1) { / USER CODE END WHILE */
/* USER CODE BEGIN 3 */} /* USER CODE END 3 */ }
/**
- @brief System Clock Configuration
- @retval None */ void SystemClock_Config(void) { RCC_OscInitTypeDef RCC_OscInitStruct = {0}; RCC_ClkInitTypeDef RCC_ClkInitStruct = {0};
/** Initializes the RCC Oscillators according to the specified parameters
- in the RCC_OscInitTypeDef structure. */ RCC_OscInitStruct.OscillatorType = RCC_OSCILLATORTYPE_HSI; RCC_OscInitStruct.HSIState = RCC_HSI_ON; RCC_OscInitStruct.HSICalibrationValue = RCC_HSICALIBRATION_DEFAULT; RCC_OscInitStruct.PLL.PLLState = RCC_PLL_NONE; if (HAL_RCC_OscConfig(&RCC_OscInitStruct) != HAL_OK) { Error_Handler(); }
/** Initializes the CPU, AHB and APB buses clocks */ RCC_ClkInitStruct.ClockType = RCC_CLOCKTYPE_HCLK|RCC_CLOCKTYPE_SYSCLK |RCC_CLOCKTYPE_PCLK1|RCC_CLOCKTYPE_PCLK2; RCC_ClkInitStruct.SYSCLKSource = RCC_SYSCLKSOURCE_HSI; RCC_ClkInitStruct.AHBCLKDivider = RCC_SYSCLK_DIV1; RCC_ClkInitStruct.APB1CLKDivider = RCC_HCLK_DIV1; RCC_ClkInitStruct.APB2CLKDivider = RCC_HCLK_DIV1;
if (HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_0) != HAL_OK) { Error_Handler(); } }
/* USER CODE BEGIN 4 */
/* USER CODE END 4 */
/**
- @brief This function is executed in case of error occurrence.
- @retval None / void Error_Handler(void) { / USER CODE BEGIN Error_Handler_Debug / / User can add his own implementation to report the HAL error return state / __disable_irq(); while (1) { } / USER CODE END Error_Handler_Debug */ }
#ifdef USE_FULL_ASSERT /**
- @brief Reports the name of the source file and the source line number
-
where the assert_param error has occurred. - @param file: pointer to the source file name
- @param line: assert_param error line source number
- @retval None */ void assert_failed(uint8_t file, uint32_t line) { / USER CODE BEGIN 6 / / User can add his own implementation to report the file name and line number, ex: printf("Wrong parameters value: file %s on line %d\r\n", file, line) / / USER CODE END 6 / } #endif / USE_FULL_ASSERT */
- Assistant
下面再补充几个比较“深层”的问题以及对应的改正建议:
-
在中断/回调里用 HAL_UART_Transmit(阻塞式发送)
HAL_UARTEx_RxEventCallback、ProcessReceivedPacketX、__io_putchar 这些函数都可能跑在中断上下文里(Idle-line IRQ、EXTI IRQ),又直接调用了 HAL_UART_Transmit(默认是阻塞模式)。
这样一来: • 中断里做大量阻塞 send,容易打断其它高优先级中断,甚至导致死锁(如果 TX 完成 IRQ 又被挂起)
• 如果数据量大,更会拖得很久
改正:
• 把发送改成非阻塞模式:HAL_UART_Transmit_IT 或 HAL_UART_Transmit_DMA
• 或者在回调里只做“打标记/推消息”给主循环,然后由主循环负责调用 HAL_UART_Transmit/DMA 发送 -
SendResponse 中锁死 flag 为 0x01,没有传回对方发过来的 flag
你的协议定义里 flag 字段是 1 byte,ProcessReceivedPacketX 拆包的时候也读了进来,但回应包里统一写死成 0x01,丢掉了原始包的 flag:// 原来: tx_buffer1[index++] = 0x01; // 建议改成: tx_buffer1[index++] = pkg->flag; // 或者根据需要对 flag 做“+0x80”或别的变化,而不是一律 0x01这样客户端可以做更灵活的请求/响应确认。
-
SendResponse 使用的 magic string 长度可能写错
SendResponse1(0x82, addr, (uint8_t*)"SEND_OK", 7);“SEND_OK” 本身 7 字节不含
\0,但如果你想让对方收到 C-string,则长度应写 8;或者干脆不发结束符,让对方按 data_len 丢字节更清晰。
建议:不是手算“7/11/13”,而是用#define STR_LEN(s) (sizeof(s)-1) … SendResponse1(0x82, addr, (uint8_t*)"SEND_OK", STR_LEN("SEND_OK")); -
中断里直接做“业务逻辑+协议收发”太重了
通常推荐的做法是:- 空闲中断回调/串口中断只做最小量的拆包、校验,得到一个完整的 ProtocolData 后,放入 RTOS 队列或设置一个标志量
- 主循环或专门的“业务任务”再去调用 ProcessReceivedPacketX 和 SendResponseX
这样可以保证中断快速返回,不会影响系统其他外设中断。
-
对 RX 的重启应该在中断退出之后做
有些 HAL 版本在调用 HAL_UARTEx_ReceiveToIdle_IT 时会立刻清掉 IDLE 标志,这时如果你在回调里又马上调用,会有竞态。
最保险的写法是把“重新启动 HAL_UARTEx_ReceiveToIdle_IT”放到主循环或软中断(PendSV)里执行。 -
没用到 CRC 硬件外设,却引用了 “crc.h”
如果你后面真想用 STM32 的 CRC 单元来做 32 位或 16 位 CRC,建议把 CalculateChecksum 改成:HAL_CRC_Calculate(&hcrc, (uint32_t*)data, length/4+!!(length%4));或者干脆删掉 CRC 外设初始化,去掉 “#include crc.h”,避免无用代码膨胀。
———
以上几点并不是说你的解析状态机有问题(前面“parser1/parser2 拆分”那步已经把最大的一票互相干扰给解决了),而是在可用性、实时性、可维护性和“协议一致性”上再进一步把细节打磨好。
-
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.