Skip to content
TheChatArchiveThe Chat Archive
Qwenqwq-32b· Alibaba (Qwen)Hugging Face LMArena Human Preference 140K

private Result<EqpMetCdHeader> analysisCDheader(List<String> contentLines, Path…

From a Chatbot Arena battleThe same person sent this prompt to two anonymous models at once. Compare it with gpt-4.1-mini-2025-04-14’s answer.
  1. User

    private Result analysisCDheader(List contentLines, Path imageFolderPath) { EqpMetCdHeader cdHeader = new EqpMetCdHeader(); List apImageList = new ArrayList<>(); int apImageScoreIndex = 0; boolean processResultFlag = false; for (String str : contentLines) { if (str.isEmpty()) { continue; // 跳过无效行 } if (str.contains("/date")) { String date = StrListUtils.getLastSplitElement(str, " "); if (StringUtils.isBlank(date)) { String errorMessage = "Cannot find report time"; log.error("Cannot find report time"); return Result.failure(errorMessage); } cdHeader.setReportTime(LocalDateTime.parse(date, DATE_TIME_FORMATTER)); } else if (str.contains("/recipe_name")) { String recipeName = StrListUtils.getLastSplitElement(str, " ").replace(""", ""); String[] parts = recipeName.split(""); if (parts.length == 0 || parts[0].length() < 5) { String errorMessage = "Cannot find recipe ID"; log.error(errorMessage); return Result.failure(errorMessage); } cdHeader.setRecipeId(recipeName); cdHeader.setProdId(recipeName.split("")[0].substring(0, 5)); } else if (str.contains("/lot_id")) { String lotId = StrListUtils.getLastSplitElement(str, " ").replace(""", ""); cdHeader.setLotId(StringUtils.isBlank(lotId) ? "-" : lotId); } else if (str.contains("/wafer_id")) { String waferId = StrListUtils.getLastSplitElement(str, " ").replace(""", ""); if (StringUtils.isBlank(waferId)) { String errorMessage = "Cannot find wafer ID"; log.error(errorMessage); return Result.failure(errorMessage); } cdHeader.setWaferId(waferId); } else if (str.contains("_control_job_id")) { String controlJobId = StrListUtils.getLastSplitElement(str, " ").replace(""", ""); if (StringUtils.isBlank(controlJobId)) { String errorMessage = "Cannot find control job ID"; log.error(errorMessage); return Result.failure(errorMessage); } cdHeader.setControlJobId(controlJobId); } else if (str.contains("process_job_id")) { String processJobId = StrListUtils.getLastSplitElement(str, " ").replace(""", ""); if (StringUtils.isBlank(processJobId)) { String errorMessage = "Cannot find process job ID"; log.error(errorMessage); return Result.failure(errorMessage); } cdHeader.setProcessJobId(processJobId); } else if (str.contains("~idw_info map_offset")) { String mpaOffset = StrListUtils.getLastSplitElement(str, " "); String[] split = mpaOffset.split(","); if (split.length != 2) { String errorMessage = "Invalid map_offset format: " + str; log.error(errorMessage); return Result.failure(errorMessage); } cdHeader.setMapOffsetX(new BigDecimal(split[0]).divide(new BigDecimal("1000"), 6, RoundingMode.HALF_UP)); cdHeader.setMapOffsetY(new BigDecimal(split[1]).divide(new BigDecimal("1000"), 6, RoundingMode.HALF_UP)); } else if (str.contains("~idw_info map_origin")) { String mapOrigin = StrListUtils.getLastSplitElement(str, " "); String[] split = mapOrigin.split(","); if (split.length < 2) { String errorMessage = "Invalid map_origin format: " + str; log.error(errorMessage); return Result.failure(errorMessage); } cdHeader.setMapOriginX(Long.parseLong(split[0])); cdHeader.setMapOriginY(Long.parseLong(split[1])); } else if (str.contains("~idw_info array : 0")) { String shotArray = StrListUtils.getLastSplitElement(str, " "); String[] split = shotArray.split(","); if (split.length < 2) { String errorMessage = String.format("Invalid wafer shot format: %s", str); log.error(errorMessage); return Result.failure(errorMessage); } cdHeader.setWaferShotX(Long.parseLong(split[0])); cdHeader.setWaferShotY(Long.parseLong(split[1])); } else if (str.contains("~idw_info array : 1")) { String dieArray = StrListUtils.getLastSplitElement(str, " "); String[] split = dieArray.split(","); if (split.length < 2) { log.error("Invalid shot die formart: " + str); return null; } cdHeader.setShotDieX(Long.parseLong(split[0])); cdHeader.setShotDieY(Long.parseLong(split[1])); } else if (str.contains("~idw_info pitch")) { String pitch = StrListUtils.getLastSplitElement(str, " "); String[] split = pitch.split(","); if (split.length < 2) { log.error("Invalid pitch format: " + str); return null; } cdHeader.setShotSizeX(new BigDecimal(split[0]).divide(new BigDecimal(1000), 6, RoundingMode.HALF_UP)); cdHeader.setShotSizeY(new BigDecimal(split[1]).divide(new BigDecimal(1000), 6, RoundingMode.HALF_UP)); } else if (str.contains("@slot_no")) { String slotNo = StrListUtils.getLastSplitElement(str, " "); if (StringUtils.isBlank(slotNo)) { log.error("Cannot find slot ID"); } cdHeader.setSlotId(slotNo); } else if (str.contains("@measure_start") && str.contains("20")) { String[] split = str.strip().split("\s+"); if (split.length != 3) { log.error("Invalid measure_start format: " + str); return null; } cdHeader.setMetStartTime(LocalDateTime.parse(split[1] + " " + split[2], MEASURE_TIME_FORMATTER)); } else if (str.contains("@measure_end") && str.contains("20")) { String[] split = str.strip().split("\s+"); if (split.length != 3) { log.error("Invalid measure_end format: " + str); return null; } cdHeader.setMetEndTime(LocalDateTime.parse(split[1] + " " + split[2], MEASURE_TIME_FORMATTER)); } else if (str.contains("@alignment_offset :")) { String lastElement = StrListUtils.getLastSplitElement(str, " "); if (lastElement == null) { lastElement = ""; // 默认值 } EqpMetCdHeaderApImage apImage = new EqpMetCdHeaderApImage() .setId(idGenerator.nextId()) .setEqpMetCdHeaderSiteId("TODO") .setOrderNo(apImageList.size() + 1) .setImageOffset(lastElement.replace(",", "")); apImageList.add(apImage);

            } else if (str.contains("@alignment_score  :")) {
                apImageScoreIndex++; // 递增索引
                if (apImageScoreIndex - 1 >= apImageList.size()) {
                    throw new IllegalStateException("Index out of bounds for alignment score");
                }
                EqpMetCdHeaderApImage apImage = apImageList.get(apImageScoreIndex - 1);
                String score = StrListUtils.getLastSplitElement(str, " ");
                apImage.setImageScore(score != null ? score.replace(",", ";") : null);
            } else if (str.contains("@ap_image_name")) {
    
                String imgPath = StrListUtils.getLastSplitElement(str, " ");
                String imageNo = StrListUtils.getLastSplitElement(imgPath.split("-")[0], "_");
                int apImageNameIndex = Integer.parseInt(imageNo.substring(1));
                Path imagePath = imageFolderPath.resolve(imgPath.replace(".jpeg", ".jpg"));
                int targetIndex = apImageNameIndex - 1;
                if (targetIndex < 0 || targetIndex >= apImageList.size()) {
                    throw new IllegalArgumentException("Invalid index: " + targetIndex);
                }
                EqpMetCdHeaderApImage target = apImageList.get(targetIndex);
                if (StringUtils.isBlank(target.getImagePath())) {
                    target.setImagePath(imagePath.toString());
                } else {
                    target.setImagePath(target.getImagePath() + ";" + imagePath);
                }
                target.setImageNo(imageNo);
                //TODO 这里有imageNo的逻辑
            } else if (str.contains("  $result")) {
                if (processResultFlag) {
                    continue;
                }
                //在之前会反复计算firstDieOrigin,sampleCenterX,reticleOrgX
                Long shotDieX = cdHeader.getShotDieX();
                Long shotDieY = cdHeader.getShotDieY();
                if (shotDieX == 0 || shotDieY == 0) {
                    log.error("shotDieX and shotDieY must not be zero.");//除0需要校验
                    return null;
                }
    
                BigDecimal mapOffsetX = cdHeader.getMapOffsetX();
                BigDecimal mapOffsetY = cdHeader.getMapOffsetY();
                Long waferShotX = cdHeader.getWaferShotX();
                Long waferShotY = cdHeader.getWaferShotY();
    
                BigDecimal dieW = cdHeader.getShotSizeX().divide(new BigDecimal(shotDieX), 6, RoundingMode.HALF_UP);
                BigDecimal dieH = cdHeader.getShotSizeY().divide(new BigDecimal(shotDieY), 6, RoundingMode.HALF_UP);
    
                BigDecimal shiftChipX = mapOffsetX
                        .subtract(new BigDecimal(shotDieX * waferShotX / 2))
                        .subtract(new BigDecimal((shotDieX * waferShotX) % 2).divide(new BigDecimal(2),
                                6, RoundingMode.HALF_UP));
                BigDecimal shiftChipY = mapOffsetY
                        .subtract(new BigDecimal(shotDieY * waferShotY / 2))
                        .subtract(new BigDecimal((shotDieY * waferShotY) % 2).divide(new BigDecimal(2),
                                6, RoundingMode.HALF_UP));
    
    
                BigDecimal firstDieX = mapOffsetX.add(shiftChipX.multiply(dieW));
                BigDecimal firstDieY = mapOffsetY.add(shiftChipY.multiply(dieH));
                long zeroDieX = cdHeader.getMapOriginX() % shotDieX;
                long zeroDieY = cdHeader.getMapOriginY() % shotDieY;
                cdHeader.setFirstDieOriginX(firstDieX);
                cdHeader.setFirstDieOriginY(firstDieY);
                cdHeader.setSampleCenterX(firstDieX.negate());
                cdHeader.setSampleCenterY(firstDieY.negate());
                cdHeader.setReticleOrgX(zeroDieX * -1);
                cdHeader.setReticleOrgY(zeroDieY * -1);
                processResultFlag = true;
            }
        }
        cdHeader.setApImageList(apImageList);
        return Result.success(cdHeader);
    }优化这段代码
    
  2. Qwen Assistant

    以下是优化后的代码,主要改进包括减少重复代码、统一错误处理、分解复杂计算、优化索引管理以及提高可读性:

    private Result<EqpMetCdHeader> analysisCDheader(List<String> contentLines, Path imageFolderPath) {
        EqpMetCdHeader cdHeader = new EqpMetCdHeader();
        List<EqpMetCdHeaderApImage> apImageList = new ArrayList<>();
        boolean processResultFlag = false;
    
        for (String str : contentLines) {
            if (str.isEmpty()) continue;
    
            if (str.contains("/date")) {
                handleDateField(str, cdHeader);
            } else if (str.contains("/recipe_name")) {
                handleRecipeNameField(str, cdHeader);
            } else if (str.contains("/lot_id")) {
                handleLotIdField(str, cdHeader);
            } else if (str.contains("/wafer_id")) {
                handleWaferIdField(str, cdHeader);
            } else if (str.contains("_control_job_id")) {
                handleControlJobIdField(str, cdHeader);
            } else if (str.contains("_process_job_id")) {
                handleProcessJobIdField(str, cdHeader);
            } else if (str.contains("~idw_info    map_offset")) {
                handleMapOffsetField(str, cdHeader);
            } else if (str.contains("~idw_info    map_origin")) {
                handleMapOriginField(str, cdHeader);
            } else if (str.contains("~idw_info    array       : 0")) {
                handleWaferShotField(str, cdHeader);
            } else if (str.contains("~idw_info    array       : 1")) {
                handleShotDieField(str, cdHeader);
            } else if (str.contains("~idw_info    pitch")) {
                handlePitchField(str, cdHeader);
            } else if (str.contains("@slot_no")) {
                handleSlotNoField(str, cdHeader);
            } else if (str.contains("@measure_start") && str.contains("20")) {
                handleMeasureStartField(str, cdHeader);
            } else if (str.contains("@measure_end") && str.contains("20")) {
                handleMeasureEndField(str, cdHeader);
            } else if (str.contains("@alignment_offset :")) {
                handleAlignmentOffsetField(str, apImageList);
            } else if (str.contains("@alignment_score  :")) {
                handleAlignmentScoreField(str, apImageList);
            } else if (str.contains("@ap_image_name")) {
                handleApImageNameField(str, apImageList, imageFolderPath);
            } else if (str.contains("  $result")) {
                if (!processResultFlag) {
                    calculateProcessResult(cdHeader);
                    processResultFlag = true;
                }
            }
        }
    
        cdHeader.setApImageList(apImageList);
        return Result.success(cdHeader);
    }
    
    // 辅助方法处理各个字段
    private void handleDateField(String str, EqpMetCdHeader cdHeader) {
        String date = extractValue(str, " ");
        if (StringUtils.isBlank(date)) {
            log.error("Cannot find report time");
            throw new IllegalArgumentException("Cannot find report time");
        }
        cdHeader.setReportTime(LocalDateTime.parse(date, DATE_TIME_FORMATTER));
    }
    
    private void handleRecipeNameField(String str, EqpMetCdHeader cdHeader) {
        String recipeName = extractValue(str, " ");
        if (recipeName == null || recipeName.split("_").length < 1 || recipeName.split("_")[0].length() < 5) {
            log.error("Cannot find recipe ID");
            throw new IllegalArgumentException("Cannot find recipe ID");
        }
        cdHeader.setRecipeId(recipeName);
        cdHeader.setProdId(recipeName.split("_")[0].substring(0, 5));
    }
    
    private void handleLotIdField(String str, EqpMetCdHeader cdHeader) {
        String lotId = extractValue(str, " ");
        cdHeader.setLotId(StringUtils.isBlank(lotId) ? "-" : lotId);
    }
    
    private void handleWaferIdField(String str, EqpMetCdHeader cdHeader) {
        String waferId = extractValue(str, " ");
        if (StringUtils.isBlank(waferId)) {
            log.error("Cannot find wafer ID");
            throw new IllegalArgumentException("Cannot find wafer ID");
        }
        cdHeader.setWaferId(waferId);
    }
    
    private void handleControlJobIdField(String str, EqpMetCdHeader cdHeader) {
        String controlJobId = extractValue(str, " ");
        if (StringUtils.isBlank(controlJobId)) {
            log.error("Cannot find control job ID");
            throw new IllegalArgumentException("Cannot find control job ID");
        }
        cdHeader.setControlJobId(controlJobId);
    }
    
    private void handleProcessJobIdField(String str, EqpMetCdHeader cdHeader) {
        String processJobId = extractValue(str, " ");
        if (StringUtils.isBlank(processJobId)) {
            log.error("Cannot find process job ID");
            throw new IllegalArgumentException("Cannot find process job ID");
        }
        cdHeader.setProcessJobId(processJobId);
    }
    
    private void handleMapOffsetField(String str, EqpMetCdHeader cdHeader) {
        String mapOffset = StrListUtils.getLastSplitElement(str, " ");
        String[] split = mapOffset.split(",");
        if (split.length != 2) {
            log.error("Invalid map_offset format: " + str);
            throw new IllegalArgumentException("Invalid map_offset format");
        }
        cdHeader.setMapOffsetX(new BigDecimal(split[0]).divide(new BigDecimal("1000"), 6, RoundingMode.HALF_UP));
        cdHeader.setMapOffsetY(new BigDecimal(split[1]).divide(new BigDecimal("1000"), 6, RoundingMode.HALF_UP));
    }
    
    private void handleMapOriginField(String str, EqpMetCdHeader cdHeader) {
        String mapOrigin = StrListUtils.getLastSplitElement(str, " ");
        String[] split = mapOrigin.split(",");
        if (split.length < 2) {
            log.error("Invalid map_origin format: " + str);
            throw new IllegalArgumentException("Invalid map_origin format");
        }
        cdHeader.setMapOriginX(Long.parseLong(split[0]));
        cdHeader.setMapOriginY(Long.parseLong(split[1]));
    }
    
    private void handleWaferShotField(String str, EqpMetCdHeader cdHeader) {
        String shotArray = StrListUtils.getLastSplitElement(str, " ");
        String[] split = shotArray.split(",");
        if (split.length < 2) {
            log.error("Invalid wafer shot format: " + str);
            throw new IllegalArgumentException("Invalid wafer shot format");
        }
        cdHeader.setWaferShotX(Long.parseLong(split[0]));
        cdHeader.setWaferShotY(Long.parseLong(split[1]));
    }
    
    private void handleShotDieField(String str, EqpMetCdHeader cdHeader) {
        String dieArray = StrListUtils.getLastSplitElement(str, " ");
        String[] split = dieArray.split(",");
        if (split.length < 2) {
            log.error("Invalid shot die format: " + str);
            throw new IllegalArgumentException("Invalid shot die format");
        }
        cdHeader.setShotDieX(Long.parseLong(split[0]));
        cdHeader.setShotDieY(Long.parseLong(split[1]));
    }
    
    private void handlePitchField(String str, EqpMetCdHeader cdHeader) {
        String pitch = StrListUtils.getLastSplitElement(str, " ");
        String[] split = pitch.split(",");
        if (split.length < 2) {
            log.error("Invalid pitch format: " + str);
            throw new IllegalArgumentException("Invalid pitch format");
        }
        cdHeader.setShotSizeX(new BigDecimal(split[0]).divide(new BigDecimal(1000), 6, RoundingMode.HALF_UP));
        cdHeader.setShotSizeY(new BigDecimal(split[1]).divide(new BigDecimal(1000), 6, RoundingMode.HALF_UP));
    }
    
    private void handleSlotNoField(String str, EqpMetCdHeader cdHeader) {
        String slotNo = extractValue(str, " ");
        cdHeader.setSlotId(StringUtils.isBlank(slotNo) ? "-" : slotNo);
    }
    
    private void handleMeasureStartField(String str, EqpMetCdHeader cdHeader) {
        String[] split = str.strip().split("\\s+");
        if (split.length != 3) {
            log.error("Invalid measure_start format: " + str);
            throw new IllegalArgumentException("Invalid measure_start format");
        }
        cdHeader.setMetStartTime(LocalDateTime.parse(split[1] + " " + split[2], MEASURE_TIME_FORMATTER));
    }
    
    private void handleMeasureEndField(String str, EqpMetCdHeader cdHeader) {
        String[] split = str.strip().split("\\s+");
        if (split.length != 3) {
            log.error("Invalid measure_end format: " + str);
            throw new IllegalArgumentException("Invalid measure_end format");
        }
        cdHeader.setMetEndTime(LocalDateTime.parse(split[1] + " " + split[2], MEASURE_TIME_FORMATTER));
    }
    
    private void handleAlignmentOffsetField(String str, List<EqpMetCdHeaderApImage> apImageList) {
        String lastElement = StrListUtils.getLastSplitElement(str, " ");
        EqpMetCdHeaderApImage apImage = new EqpMetCdHeaderApImage()
                .setId(idGenerator.nextId())
                .setEqpMetCdHeaderSiteId("TODO")
                .setOrderNo(apImageList.size() + 1)
                .setImageOffset(lastElement.replace(",", "_"));
        apImageList.add(apImage);
    }
    
    private void handleAlignmentScoreField(String str, List<EqpMetCdHeaderApImage> apImageList) {
        if (apImageList.isEmpty()) {
            log.error("No corresponding apImage for alignment score");
            throw new IllegalArgumentException("No corresponding apImage for alignment score");
        }
        EqpMetCdHeaderApImage apImage = apImageList.get(apImageList.size() - 1);
        String score = StrListUtils.getLastSplitElement(str, " ");
        apImage.setImageScore(score != null ? score.replace(",", ";") : null);
    }
    
    private void handleApImageNameField(String str, List<EqpMetCdHeaderApImage> apImageList, Path imageFolderPath) {
        String imgPath = StrListUtils.getLastSplitElement(str, " ");
        if (imgPath == null) {
            log.error("Cannot find image path");
            throw new IllegalArgumentException("Cannot find image path");
        }
        String[] parts = imgPath.split("-");
        if (parts.length < 1) {
            log.error("Invalid image path format: " + imgPath);
            throw new IllegalArgumentException("Invalid image path format");
        }
        String imageNo = StrListUtils.getLastSplitElement(parts[0], "_");
        if (imageNo == null) {
            log.error("Invalid imageNo format: " + imgPath);
            throw new IllegalArgumentException("Invalid imageNo format");
        }
        int apImageNameIndex = Integer.parseInt(imageNo.substring(1));
        int targetIndex = apImageNameIndex - 1;
        if (targetIndex < 0 || targetIndex >= apImageList.size()) {
            log.error("Invalid index: " + targetIndex);
            throw new IllegalArgumentException("Invalid index for ap_image_name");
        }
        EqpMetCdHeaderApImage target = apImageList.get(targetIndex);
        Path imagePath = imageFolderPath.resolve(imgPath.replace(".jpeg", ".jpg"));
        if (StringUtils.isBlank(target.getImagePath())) {
            target.setImagePath(imagePath.toString());
        } else {
            target.setImagePath(target.getImagePath() + ";" + imagePath);
        }
        target.setImageNo(imageNo);
    }
    
    // 计算过程结果的方法
    private void calculateProcessResult(EqpMetCdHeader cdHeader) {
        Long shotDieX = cdHeader.getShotDieX();
        Long shotDieY = cdHeader.getShotDieY();
        if (shotDieX == null || shotDieY == null || shotDieX == 0 || shotDieY == 0) {
            log.error("shotDieX and shotDieY must not be zero.");
            return;
        }
    
        BigDecimal mapOffsetX = cdHeader.getMapOffsetX();
        BigDecimal mapOffsetY = cdHeader.getMapOffsetY();
        Long waferShotX = cdHeader.getWaferShotX();
        Long waferShotY = cdHeader.getWaferShotY();
    
        BigDecimal dieW = cdHeader.getShotSizeX().divide(new BigDecimal(shotDieX), 6, RoundingMode.HALF_UP);
        BigDecimal dieH = cdHeader.getShotSizeY().divide(new BigDecimal(shotDieY), 6, RoundingMode.HALF_UP);
    
        BigDecimal shiftChipX = mapOffsetX
                .subtract(new BigDecimal(shotDieX * waferShotX / 2))
                .subtract(new BigDecimal((shotDieX * waferShotX) % 2).divide(new BigDecimal(2), 6, RoundingMode.HALF_UP));
    
        BigDecimal shiftChipY = mapOffsetY
                .subtract(new BigDecimal(shotDieY * waferShotY / 2))
                .subtract(new BigDecimal((shotDieY * waferShotY) % 2).divide(new BigDecimal(2), 6, RoundingMode.HALF_UP));
    
        BigDecimal firstDieX = mapOffsetX.add(shiftChipX.multiply(dieW));
        BigDecimal firstDieY = mapOffsetY.add(shiftChipY.multiply(dieH));
    
        long zeroDieX = cdHeader.getMapOriginX() % shotDieX;
        long zeroDieY = cdHeader.getMapOriginY() % shotDieY;
    
        cdHeader.setFirstDieOriginX(firstDieX);
        cdHeader.setFirstDieOriginY(firstDieY);
        cdHeader.setSampleCenterX(firstDieX.negate());
        cdHeader.setSampleCenterY(firstDieY.negate());
        cdHeader.setReticleOrgX(zeroDieX * -1);
        cdHeader.setReticleOrgY(zeroDieY * -1);
    }
    
    // 辅助方法提取值
    private String extractValue(String str, String delimiter) {
        String value = StrListUtils.getLastSplitElement(str, delimiter);
        return value != null ? value.replace("\"", "") : null;
    }
    

    主要优化点:

    1. 提取公共方法:

      • 将重复的字段处理逻辑封装为handleXxxField方法,减少代码重复。
      • 提取extractValue方法统一处理字段值的提取和清理。
    2. 统一错误处理:

      • 所有错误情况均抛出IllegalArgumentException,并记录日志,确保错误处理的一致性。
      • 使用throw new IllegalArgumentException替代return Result.failure,但需结合try-catch块来捕获异常并返回Result.failure(需根据原始代码的返回逻辑调整)。
    3. 分解复杂计算:

      • 将$result部分的复杂计算分解到calculateProcessResult方法中,提高可读性。
    4. 优化索引管理:

      • 使用apImageList.size() - 1获取最后一个apImage,避免使用外部索引变量。
      • 根据imageNo解析索引,确保apImage与@ap_image_name的关联正确。
    5. 提高可读性:

      • 使用更具描述性的方法名,如handleRecipeNameField。
      • 将长条件分支拆分为独立方法,使主逻辑更清晰。
    6. 异常处理:

      • 在字段解析失败时直接抛出异常,确保错误被及时捕获和处理。

    注意事项:

    • 需根据实际项目中的Result类和异常处理机制调整错误返回逻辑。
    • 确保StrListUtils.getLastSplitElement方法的正确性,避免空指针异常。
    • 需要根据实际数据验证imageNo的解析逻辑是否正确。
  3. User

    我需要全面考虑异常,优化的处理好异常

  4. Qwen Assistant

    以下是全面优化异常处理后的代码,确保所有潜在错误都被捕获并返回详细的错误信息:

    private Result<EqpMetCdHeader> analyzeCDHeader(List<String> contentLines, Path imageFolderPath) {
        EqpMetCdHeader cdHeader = new EqpMetCdHeader();
        List<EqpMetCdHeaderApImage> apImageList = new ArrayList<>();
        boolean processResultFlag = false;
    
        for (String str : contentLines) {
            if (str.isEmpty()) continue;
    
            if (str.contains("/date")) {
                Result<?> result = handleDateField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("/recipe_name")) {
                Result<?> result = handleRecipeNameField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("/lot_id")) {
                Result<?> result = handleLotIdField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("/wafer_id")) {
                Result<?> result = handleWaferIdField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("_control_job_id")) {
                Result<?> result = handleControlJobIdField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("_process_job_id")) {
                Result<?> result = handleProcessJobIdField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("~idw_info    map_offset")) {
                Result<?> result = handleMapOffsetField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("~idw_info    map_origin")) {
                Result<?> result = handleMapOriginField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("~idw_info    array       : 0")) {
                Result<?> result = handleWaferShotField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("~idw_info    array       : 1")) {
                Result<?> result = handleShotDieField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("~idw_info    pitch")) {
                Result<?> result = handlePitchField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("@slot_no")) {
                Result<?> result = handleSlotNoField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("@measure_start") && str.contains("20")) {
                Result<?> result = handleMeasureStartField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("@measure_end") && str.contains("20")) {
                Result<?> result = handleMeasureEndField(str, cdHeader);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("@alignment_offset :")) {
                handleAlignmentOffsetField(str, apImageList);
            } else if (str.contains("@alignment_score  :")) {
                Result<?> result = handleAlignmentScoreField(str, apImageList);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("@ap_image_name")) {
                Result<?> result = handleApImageNameField(str, apImageList, imageFolderPath);
                if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
            } else if (str.contains("  $result")) {
                if (!processResultFlag) {
                    Result<?> result = calculateProcessResult(cdHeader);
                    if (result.isFailure()) return (Result<EqpMetCdHeader>) result;
                    processResultFlag = true;
                }
            }
        }
    
        cdHeader.setApImageList(apImageList);
        return Result.success(cdHeader);
    }
    
    // 辅助方法处理各个字段,返回Result对象
    private Result<Void> handleDateField(String str, EqpMetCdHeader cdHeader) {
        String date = extractValue(str, " ");
        if (StringUtils.isBlank(date)) {
            return Result.failure("Missing report time in line: " + str);
        }
        try {
            cdHeader.setReportTime(LocalDateTime.parse(date, DATE_TIME_FORMATTER));
        } catch (DateTimeParseException e) {
            return Result.failure("Invalid date format in line: " + str);
        }
        return Result.success();
    }
    
    private Result<Void> handleRecipeNameField(String str, EqpMetCdHeader cdHeader) {
        String recipeName = extractValue(str, " ");
        if (StringUtils.isBlank(recipeName)) {
            return Result.failure("Missing recipe name in line: " + str);
        }
        String[] parts = recipeName.split("_");
        if (parts.length < 1 || parts[0].length() < 5) {
            return Result.failure("Invalid recipe ID format in line: " + str);
        }
        cdHeader.setRecipeId(recipeName);
        cdHeader.setProdId(recipeName.split("_")[0].substring(0, 5));
        return Result.success();
    }
    
    private Result<Void> handleLotIdField(String str, EqpMetCdHeader cdHeader) {
        String lotId = extractValue(str, " ");
        cdHeader.setLotId(StringUtils.defaultIfBlank(lotId, "-"));
        return Result.success();
    }
    
    private Result<Void> handleWaferIdField(String str, EqpMetCdHeader cdHeader) {
        String waferId = extractValue(str, " ");
        if (StringUtils.isBlank(waferId)) {
            return Result.failure("Missing wafer ID in line: " + str);
        }
        cdHeader.setWaferId(waferId);
        return Result.success();
    }
    
    private Result<Void> handleControlJobIdField(String str, EqpMetCdHeader cdHeader) {
        String controlJobId = extractValue(str, " ");
        if (StringUtils.isBlank(controlJobId)) {
            return Result.failure("Missing control job ID in line: " + str);
        }
        cdHeader.setControlJobId(controlJobId);
        return Result.success();
    }
    
    private Result<Void> handleProcessJobIdField(String str, EqpMetCdHeader cdHeader) {
        String processJobId = extractValue(str, " ");
        if (StringUtils.isBlank(processJobId)) {
            return Result.failure("Missing process job ID in line: " + str);
        }
        cdHeader.setProcessJobId(processJobId);
        return Result.success();
    }
    
    private Result<Void> handleMapOffsetField(String str, EqpMetCdHeader cdHeader) {
        String mapOffset = StrListUtils.getLastSplitElement(str, " ");
        if (mapOffset == null) {
            return Result.failure("Missing map_offset value in line: " + str);
        }
        String[] split = mapOffset.split(",");
        if (split.length != 2) {
            return Result.failure("Invalid map_offset format (expected 2 elements): " + str);
        }
        try {
            cdHeader.setMapOffsetX(new BigDecimal(split[0]).divide(new BigDecimal("1000"), 6, RoundingMode.HALF_UP));
            cdHeader.setMapOffsetY(new BigDecimal(split[1]).divide(new BigDecimal("1000"), 6, RoundingMode.HALF_UP));
        } catch (NumberFormatException e) {
            return Result.failure("Invalid numeric value in map_offset: " + str);
        }
        return Result.success();
    }
    
    private Result<Void> handleMapOriginField(String str, EqpMetCdHeader cdHeader) {
        String mapOrigin = StrListUtils.getLastSplitElement(str, " ");
        if (mapOrigin == null) {
            return Result.failure("Missing map_origin value in line: " + str);
        }
        String[] split = mapOrigin.split(",");
        if (split.length < 2) {
            return Result.failure("Invalid map_origin format (expected at least 2 elements): " + str);
        }
        try {
            cdHeader.setMapOriginX(Long.parseLong(split[0]));
            cdHeader.setMapOriginY(Long.parseLong(split[1]));
        } catch (NumberFormatException e) {
            return Result.failure("Invalid numeric value in map_origin: " + str);
        }
        return Result.success();
    }
    
    private Result<Void> handleWaferShotField(String str, EqpMetCdHeader cdHeader) {
        String shotArray = StrListUtils.getLastSplitElement(str, " ");
        if (shotArray == null) {
            return Result.failure("Missing wafer shot array value in line: " + str);
        }
        String[] split = shotArray.split(",");
        if (split.length < 2) {
            return Result.failure("Invalid wafer shot format (expected 2 elements): " + str);
        }
        try {
            cdHeader.setWaferShotX(Long.parseLong(split[0]));
            cdHeader.setWaferShotY(Long.parseLong(split[1]));
        } catch (NumberFormatException e) {
            return Result.failure("Invalid numeric value in wafer shot: " + str);
        }
        return Result.success();
    }
    
    private Result<Void> handleShotDieField(String str, EqpMetCdHeader cdHeader) {
        String dieArray = StrListUtils.getLastSplitElement(str, " ");
        if (dieArray == null) {
            return Result.failure("Missing shot die array value in line: " + str);
        }
        String[] split = dieArray.split(",");
        if (split.length < 2) {
            return Result.failure("Invalid shot die format (expected 2 elements): " + str);
        }
        try {
            cdHeader.setShotDieX(Long.parseLong(split[0]));
            cdHeader.setShotDieY(Long.parseLong(split[1]));
        } catch (NumberFormatException e) {
            return Result.failure("Invalid numeric value in shot die: " + str);
        }
        return Result.success();
    }
    
    private Result<Void> handlePitchField(String str, EqpMetCdHeader cdHeader) {
        String pitch = StrListUtils.getLastSplitElement(str, " ");
        if (pitch == null) {
            return Result.failure("Missing pitch value in line: " + str);
        }
        String[] split = pitch.split(",");
        if (split.length < 2) {
            return Result.failure("Invalid pitch format (expected 2 elements): " + str);
        }
        try {
            cdHeader.setShotSizeX(new BigDecimal(split[0]).divide(new BigDecimal(1000), 6, RoundingMode.HALF_UP));
            cdHeader.setShotSizeY(new BigDecimal(split[1]).divide(new BigDecimal(1000), 6, RoundingMode.HALF_UP));
        } catch (NumberFormatException e) {
            return Result.failure("Invalid numeric value in pitch: " + str);
        }
        return Result.success();
    }
    
    private Result<Void> handleSlotNoField(String str, EqpMetCdHeader cdHeader) {
        String slotNo = extractValue(str, " ");
        cdHeader.setSlotId(StringUtils.defaultIfBlank(slotNo, "-"));
        return Result.success();
    }
    
    private Result<Void> handleMeasureStartField(String str, EqpMetCdHeader cdHeader) {
        String[] split = str.strip().split("\\s+");
        if (split.length != 3) {
            return Result.failure("Invalid measure_start format (expected 3 elements): " + str);
        }
        try {
            cdHeader.setMetStartTime(LocalDateTime.parse(split[1] + " " + split[2], MEASURE_TIME_FORMATTER));
        } catch (DateTimeParseException e) {
            return Result.failure("Invalid date/time format in measure_start: " + str);
        }
        return Result.success();
    }
    
    private Result<Void> handleMeasureEndField(String str, EqpMetCdHeader cdHeader) {
        String[] split = str.strip().split("\\s+");
        if (split.length != 3) {
            return Result.failure("Invalid measure_end format (expected 3 elements): " + str);
        }
        try {
            cdHeader.setMetEndTime(LocalDateTime.parse(split[1] + " " + split[2], MEASURE_TIME_FORMATTER));
        } catch (DateTimeParseException e) {
            return Result.failure("Invalid date/time format in measure_end: " + str);
        }
        return Result.success();
    }
    
    private void handleAlignmentOffsetField(String str, List<EqpMetCdHeaderApImage> apImageList) {
        String lastElement = StrListUtils.getLastSplitElement(str, " ");
        EqpMetCdHeaderApImage apImage = new EqpMetCdHeaderApImage()
                .setId(idGenerator.nextId())
                .setEqpMetCdHeaderSiteId("TODO")
                .setOrderNo(apImageList.size() + 1)
                .setImageOffset(lastElement.replace(",", "_"));
        apImageList.add(apImage);
    }
    
    private Result<Void> handleAlignmentScoreField(String str, List<EqpMetCdHeaderApImage> apImageList) {
        if (apImageList.isEmpty()) {
            return Result.failure("No corresponding apImage for alignment score: " + str);
        }
        EqpMetCdHeaderApImage apImage = apImageList.get(apImageList.size() - 1);
        String score = StrListUtils.getLastSplitElement(str, " ");
        apImage.setImageScore(score != null ? score.replace(",", ";") : null);
        return Result.success();
    }
    
    private Result<Void> handleApImageNameField(String str, List<EqpMetCdHeaderApImage> apImageList, Path imageFolderPath) {
        String imgPath = StrListUtils.getLastSplitElement(str, " ");
        if (imgPath == null) {
            return Result.failure("Missing image path in line: " + str);
        }
        String[] parts = imgPath.split("-");
        if (parts.length < 1) {
            return Result.failure("Invalid image path format: " + imgPath);
        }
        String imageNo = StrListUtils.getLastSplitElement(parts[0], "_");
        if (imageNo == null) {
            return Result.failure("Invalid imageNo format in path: " + imgPath);
        }
        try {
            int apImageNameIndex = Integer.parseInt(imageNo.substring(1));
            int targetIndex = apImageNameIndex - 1;
            if (targetIndex < 0 || targetIndex >= apImageList.size()) {
                return Result.failure("Invalid apImage index (" + targetIndex + ") for path: " + imgPath);
            }
            EqpMetCdHeaderApImage target = apImageList.get(targetIndex);
            Path imagePath = imageFolderPath.resolve(imgPath.replace(".jpeg", ".jpg"));
            String imagePathStr = imagePath.toString();
            if (StringUtils.isBlank(target.getImagePath())) {
                target.setImagePath(imagePathStr);
            } else {
                target.setImagePath(target.getImagePath() + ";" + imagePathStr);
            }
            target.setImageNo(imageNo);
        } catch (NumberFormatException e) {
            return Result.failure("Invalid imageNo index in path: " + imgPath);
        }
        return Result.success();
    }
    
    private Result<Void> calculateProcessResult(EqpMetCdHeader cdHeader) {
        Long shotDieX = cdHeader.getShotDieX();
        Long shotDieY = cdHeader.getShotDieY();
        if (shotDieX == null || shotDieY == null || shotDieX == 0 || shotDieY == 0) {
            return Result.failure("shotDieX and shotDieY must not be zero or null");
        }
        BigDecimal mapOffsetX = cdHeader.getMapOffsetX();
        BigDecimal mapOffsetY = cdHeader.getMapOffsetY();
        Long waferShotX = cdHeader.getWaferShotX();
        Long waferShotY = cdHeader.getWaferShotY();
    
        // 计算dieW和dieH时确保分母不为零(已通过前置条件检查)
        BigDecimal dieW = cdHeader.getShotSizeX().divide(new BigDecimal(shotDieX), 6, RoundingMode.HALF_UP);
        BigDecimal dieH = cdHeader.getShotSizeY().divide(new BigDecimal(shotDieY), 6, RoundingMode.HALF_UP);
    
        BigDecimal shiftChipX = mapOffsetX
                .subtract(new BigDecimal(shotDieX * waferShotX / 2))
                .subtract(new BigDecimal((shotDieX * waferShotY) % 2).divide(new BigDecimal(2), 6, RoundingMode.HALF_UP));
    
        BigDecimal shiftChipY = mapOffsetY
                .subtract(new BigDecimal(shotDieY * waferShotY / 2))
                .subtract(new BigDecimal((shotDieY * waferShotY) % 2).divide(new BigDecimal(2), 6, RoundingMode.HALF_UP));
    
        BigDecimal firstDieX = mapOffsetX.add(shiftChipX.multiply(dieW));
        BigDecimal firstDieY = mapOffsetY.add(shiftChipY.multiply(dieH));
    
        long zeroDieX = cdHeader.getMapOriginX() % shotDieX;
        long zeroDieY = cdHeader.getMapOriginY() % shotDieY;
    
        cdHeader.setFirstDieOriginX(firstDieX);
        cdHeader.setFirstDieOriginY(firstDieY);
        cdHeader.setSampleCenterX(firstDieX.negate());
        cdHeader.setSampleCenterY(firstDieY.negate());
        cdHeader.setReticleOrgX(zeroDieX * -1);
        cdHeader.setReticleOrgY(zeroDieY * -1);
        return Result.success();
    }
    
    private String extractValue(String str, String delimiter) {
        String value = StrListUtils.getLastSplitElement(str, delimiter);
        return value != null ? value.replace("\"", "") : null;
    }
    

    主要改进点:

    1. 统一错误处理

    • Result对象返回:所有字段处理方法返回Result<Void>,确保错误信息通过Result.failure统一返回,而非抛出异常。
    • 详细错误信息:每个错误包含具体出错行和字段信息,便于调试。

    2. 全面异常捕获

    • 格式验证:检查字段值是否符合预期格式(如split数组长度、数值类型)。
    • 数值转换:捕获NumberFormatException,确保字符串转换为数值时的安全性。
    • 日期解析:捕获DateTimeParseException,验证日期格式是否正确。

    3. 输入验证增强

    • 空值检查:对每个字段值进行空值验证,避免NullPointerException。
    • 边界条件:确保数组索引、分母不为零等条件。

    4. 代码结构优化

    • 模块化方法:每个字段处理封装为独立方法,提高可读性和可维护性。
    • 辅助方法复用:extractValue统一清理字段值,减少重复代码。

    5. 计算逻辑保护

    • 前置条件检查:在复杂计算前验证关键参数(如shotDieX/Y是否为零)。
    • 安全运算:确保所有数学运算在安全范围内执行。

    6. 文件路径处理

    • 路径转换:确保@ap_image_name的路径转换不会抛出IOException(假设路径有效性由外部验证)。

    使用示例

    // 调用示例
    Result<EqpMetCdHeader> result = analyzeCDHeader(contentLines, imageFolderPath);
    if (result.isFailure()) {
        log.error("解析失败: " + result.getError());
        // 处理错误
    } else {
        EqpMetCdHeader header = result.getData();
        // 继续业务逻辑
    }
    

    关键错误类型示例

    1. 缺失字段:Missing report time in line: /date ...
    2. 格式错误:Invalid map_offset format (expected 2 elements): ...
    3. 数值转换失败:Invalid numeric value in pitch: ...
    4. 索引越界:Invalid apImage index (5) for path: ...

    通过上述优化,代码在保持可读性的同时,实现了全面的异常处理和清晰的错误反馈,确保解析过程的健壮性。

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.