Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-3-7-sonnet-20250219· AnthropicHugging Face LMArena Human Preference 140K

how would you improve this code: // AVAILABLE STOCK logger.debug("Getting AVAILABLE…

From a Chatbot Arena battleThe same person sent this prompt to two anonymous models at once. Compare it with Googlegemma-3-27b-it’s answer.
  1. User

    how would you improve this code: // AVAILABLE STOCK logger.debug("Getting AVAILABLE STOCK..."); long chkStockStartTime = System.nanoTime(); Map<String, Object> checkAvailDat;

    			HashMap<LocalDate, Integer> quantityFulfillmentDates = new HashMap<>();
    			DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd");
    			// For each store, we check build a list of what they can provide and when
    			for(String store: stores) {
    				checkAvailDat = orderDAO.MPBCHKSTKC(reqBIT.getEAN(), store, 
    						XMLUtilities.XMLGregorianCalendarToString(reqBIT.getRequestedDeliveryDate()),
    						String.valueOf(reqBIT.getRequestedQuantity()).trim());
    
    				quantityFulfillmentDates.put(LocalDate.parse(checkAvailDat.get("NEXTDUE").toString().trim(), formatter),  Integer.valueOf(checkAvailDat.get("AVAILQTY").toString().trim()));
    			}
    							
    			long chkStockEndTime = System.nanoTime();
    			long chkStockDuration = (chkStockEndTime - chkStockStartTime);
                logger.debug("MPBCHKSTK call took: {}ms", chkStockDuration / 1000000);
    
    
    			LocalDate confirmedFulfillmentDate = null;
    
    			Map<LocalDate, Integer> sortedFulfillmentDates = new TreeMap<>(quantityFulfillmentDates);
    			int totalAvailableQuantity = 0;
    			boolean canTotallyFulfill = false;
    			LocalDate fulfillmentDate = null;
    			int availableQuantity;
    			for (Map.Entry<LocalDate, Integer> entry : sortedFulfillmentDates.entrySet()) {
    				fulfillmentDate = entry.getKey();
    				availableQuantity = entry.getValue();
    				totalAvailableQuantity += availableQuantity;
    				if (reqBIT.getRequestedQuantity()<=totalAvailableQuantity){
    					canTotallyFulfill = true;
    					confirmedFulfillmentDate =  fulfillmentDate;
    					break;
    				}
    			}
    
    			if(!canTotallyFulfill){
    				resBIT.setExpectedDeliveryDate(XMLUtilities.LocalDateToXMLGregorianCalendar(fulfillmentDate));
    				resBIT.setConfirmedQuantity(totalAvailableQuantity);
    				if(resBIT.getConfirmedQuantity() > 0) {
    					ItemLevelValidations.getValidationResult().add(createValidationResult("INSUFFICIENT_STOCK_QUANTITY", "Sorry, we don't have enough stock. Would you like to order what we have?", ERRORLEVEL.WARN.val));
    
    				}
    				else{
    					resBIT.setConfirmedQuantity(0);
    					ItemLevelValidations.getValidationResult().add(createValidationResult("NO_ATP_ORDER_LINE", "Sorry, this item is now out of stock.", ERRORLEVEL.ERROR.val));
    				}
    			}
    			else{
    				resBIT.setConfirmedQuantity(reqBIT.getRequestedQuantity());
    				resBIT.setExpectedDeliveryDate(XMLUtilities.LocalDateToXMLGregorianCalendar(confirmedFulfillmentDate));
    			}
    
  2. Claude Assistant

    Here's how I would improve this code:

    // AVAILABLE STOCK
    logger.debug("Getting AVAILABLE STOCK...");
    long chkStockStartTime = System.nanoTime();
    
    // Create a sorted map directly to avoid later conversion
    TreeMap<LocalDate, Integer> quantityFulfillmentDates = new TreeMap<>();
    DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd");
    
    // For each store, check available stock
    for (String store : stores) {
        try {
            Map<String, Object> checkAvailData = orderDAO.MPBCHKSTKC(
                reqBIT.getEAN(), 
                store,
                XMLUtilities.XMLGregorianCalendarToString(reqBIT.getRequestedDeliveryDate()),
                String.valueOf(reqBIT.getRequestedQuantity()).trim()
            );
            
            String nextDueStr = checkAvailData.get("NEXTDUE").toString().trim();
            String availQtyStr = checkAvailData.get("AVAILQTY").toString().trim();
            
            // Validate data before parsing
            if (nextDueStr != null && !nextDueStr.isEmpty() && availQtyStr != null && !availQtyStr.isEmpty()) {
                LocalDate nextDueDate = LocalDate.parse(nextDueStr, formatter);
                int availQty = Integer.parseInt(availQtyStr);
                
                // Merge quantities for the same date
                quantityFulfillmentDates.merge(nextDueDate, availQty, Integer::sum);
            }
        } catch (Exception e) {
            logger.error("Error checking stock for store {}: {}", store, e.getMessage());
        }
    }
    
    long chkStockDuration = (System.nanoTime() - chkStockStartTime) / 1_000_000;
    logger.debug("MPBCHKSTK call took: {}ms", chkStockDuration);
    
    // Process fulfillment dates
    int requestedQuantity = reqBIT.getRequestedQuantity();
    int totalAvailableQuantity = 0;
    LocalDate confirmedFulfillmentDate = null;
    
    for (Map.Entry<LocalDate, Integer> entry : quantityFulfillmentDates.entrySet()) {
        LocalDate fulfillmentDate = entry.getKey();
        int availableQuantity = entry.getValue();
        totalAvailableQuantity += availableQuantity;
        
        if (requestedQuantity <= totalAvailableQuantity) {
            confirmedFulfillmentDate = fulfillmentDate;
            break;
        }
    }
    
    // Set response based on availability
    if (confirmedFulfillmentDate != null) {
        // Can fulfill completely
        resBIT.setConfirmedQuantity(requestedQuantity);
        resBIT.setExpectedDeliveryDate(XMLUtilities.LocalDateToXMLGregorianCalendar(confirmedFulfillmentDate));
    } else {
        // Cannot fulfill completely
        LocalDate latestDate = quantityFulfillmentDates.isEmpty() ? null : quantityFulfillmentDates.lastKey();
        resBIT.setExpectedDeliveryDate(XMLUtilities.LocalDateToXMLGregorianCalendar(latestDate));
        resBIT.setConfirmedQuantity(totalAvailableQuantity);
        
        if (totalAvailableQuantity > 0) {
            ItemLevelValidations.getValidationResult().add(
                createValidationResult(
                    "INSUFFICIENT_STOCK_QUANTITY", 
                    "Sorry, we don't have enough stock. Would you like to order what we have?", 
                    ERRORLEVEL.WARN.val
                )
            );
        } else {
            resBIT.setConfirmedQuantity(0);
            ItemLevelValidations.getValidationResult().add(
                createValidationResult(
                    "NO_ATP_ORDER_LINE", 
                    "Sorry, this item is now out of stock.", 
                    ERRORLEVEL.ERROR.val
                )
            );
        }
    }
    

    Would you like me to explain the improvements I made to the code?

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.