Skip to content
The Chat Archive
gpt-4o-mini-2024-07-18· OpenAI WildChat-4.8M (AI2)

// 魔法卡和陷阱卡伤害预览 protected List<CGLuaParam> PrepareExecuteLuaParams(CGGameMode gameMode,…

  1. User

    // 魔法卡和陷阱卡伤害预览 protected List PrepareExecuteLuaParams(CGGameMode gameMode, Effect effect, ActorRef triggerCard, List<ActorRef> targetCards, List<ActorRef> targetHeroes) { List luaParams = new List(); Card cardObject = gameMode.GetActorObject(triggerCard); Player player = gameMode.GetActorObject(cardObject.GetOwnerPlayer()); Hero cardHero = gameMode.GetActorObject(player.GetHero()); int spellPowerValue = cardHero.GetSpellPowerValue();

            int index = gameMode.GetRandomNumber();
            // 这个概率关键词是给胖法师使用,如果概率通过,会执行CGCopyCardsToHandCardDeck
            if (index == 1 && effect.keyword == CardKeyWordType.Possible)
            {
                return luaParams;
            }
            
            foreach (var triggerEffect in effect.triggerEffects)
            {
                if (triggerEffect.luaPath.Equals("None"))
                {
                    continue;
                }
                
                // 抽牌效果或者如果是全场则是作为攻击者
                if (!cardObject.IsNeedChooseTriggerEffect(triggerEffect))
                {
                    if (!targetCards.Any() ||
                        (targetCards.Count > 0 && 
                         (!triggerEffect.targetType.HasFlag(TargetType.Minion) && !triggerEffect.targetType.HasFlag(TargetType.Structure)))
                        || triggerEffect.targetType.ToString().Equals("609"))
                    {
                        int paramValue = triggerEffect.targetValue;
                        if (triggerEffect.luaPath.Contains("All") || gameMode.IsNeedAddSpellPower(triggerEffect.luaPath))
                        {
                            paramValue += spellPowerValue;
                        }
    
                        PrepareLuaSingleParam(gameMode, triggerEffect, cardObject, luaParams, paramValue);
                        continue;
                    }
                }
    
                int targetValue = triggerEffect.targetValue;
                Hero triggerCardHero = gameMode.GetActorObject(gameMode.GetHeroByCard(cardObject));
                // 标识伤害预览
                foreach (var targetCard in targetCards)
                {
                    Card targetCardObject = gameMode.GetActorObject(targetCard);
                    if (!gameMode.CardIsMetTriggerCondition(targetCardObject, triggerEffect) || 
                        effect.keyword == CardKeyWordType.OppoDeployTrigger)
                    {
                        continue;
                    }
                    
                    // 计算上法强的值
                    if (gameMode.IsNeedAddSpellPower(triggerEffect.luaPath))
                    {
                        targetValue += spellPowerValue;
                    }
                    
                    if (triggerEffect.luaPath.Contains("CGSacrificeHealthToDamage"))
                    {
                        targetValue = targetCardObject.GetHealth().Value.intValue;
                        targetValue += spellPowerValue;
                        foreach (var oppositeMinionCard in gameMode.GetOppositeMinionCards(targetCardObject, triggerEffect))
                        {
                            Card minion = gameMode.GetActorObject(oppositeMinionCard);
                            gameMode.SetMinionDamagePreviewData(minion, targetValue);
                        }
                        //gameMode.GetActorObject(gameMode.GetOppositeHeroByCard(targetCardObject)).SetPreviewData(-targetValue);
                    }
                    else if (triggerEffect.luaPath.Contains("CGSacrificeAmbushToDamage"))
                    {
                        targetValue = targetCardObject.GetAttack().Value.intValue;
                        targetValue += spellPowerValue;
                        foreach (var oppositeMinionCard in gameMode.GetOppositeMinionCards(targetCardObject, triggerEffect))
                        {
                            Card minion = gameMode.GetActorObject(oppositeMinionCard);
                            gameMode.SetMinionDamagePreviewData(minion, targetValue);
                        }
                    }
                    if (triggerEffect.luaPath.Contains("Damage") && !triggerEffect.luaPath.Contains("CGSacrificeAmbushToDamage"))
                    {
                        gameMode.SetMinionDamagePreviewData(targetCardObject, targetValue);
                    }
                    else if (triggerEffect.luaPath.Contains("Heal") && !triggerEffect.luaPath.Contains("BuffCardsAttackToHealth"))
                    {
                        if (triggerCardHero.GetIsPoison() || triggerCardHero.GetIsTempPoison())
                        {
                            targetCardObject.SetPreviewData(-targetValue);
                        }
                        else
                        {
                            targetCardObject.SetPreviewData(targetValue);
                        }
                    }
                }
    
                foreach (var targetHero in targetHeroes)
                {
                    if (!triggerEffect.targetType.HasFlag(TargetType.Hero))
                    {
                        continue;
                    }
                    
                    if (effect.keyword == CardKeyWordType.Continuous)
                    {
                        continue;
                    }
                    // 计算上法强的值
                    if (gameMode.IsNeedAddSpellPower(triggerEffect.luaPath))
                    {
                        targetValue += spellPowerValue;
                    }
    
                    Hero targetHeroObject = gameMode.GetActorObject(targetHero);
    
                    if (triggerEffect.luaPath.Contains("Damage"))
                    {
                        targetHeroObject.SetPreviewData(-targetValue);
                    }
                    else if (triggerEffect.luaPath.Contains("Heal"))
                    {
                        if (triggerCardHero.GetIsPoison() || triggerCardHero.GetIsTempPoison())
                        {
                            targetHeroObject.SetPreviewData(-targetValue);
                        }
                        else
                        {
                            targetHeroObject.SetPreviewData(targetValue);
                        }
                    }
                }
    
                // 如果目标只有英雄
                if (targetHeroes.Count > 0 && targetCards.Count == 0)
                {
                    if (!triggerEffect.targetType.HasFlag(TargetType.Hero))
                    {
                        continue;
                    }
                    
                    CGLuaHeroParam cgLuaHeroParam = new CGLuaHeroParam
                    {
                        Value = targetValue,
                        Heroes = targetHeroes,
                        TriggerCard = triggerCard
                    };
                    CGLuaParam cgLuaParam = new CGLuaParam
                    {
                        LuaPath = triggerEffect.luaPath,
                        LuaParam = cgLuaHeroParam
                    };
                    luaParams.Add(cgLuaParam);
                    continue;
                }
    
                // 如果目标只有卡牌
                if (targetCards.Count > 0 && targetHeroes.Count == 0)
                {
                    CGLuaCardParam cgLuaCardParam = new CGLuaCardParam
                    {
                        Value = targetValue,
                        Cards = targetCards,
                        TriggerCard = triggerCard
                    };
                    CGLuaParam cgLuaParam = new CGLuaParam
                    {
                        LuaPath = triggerEffect.luaPath,
                        LuaParam = cgLuaCardParam
                    };
                    luaParams.Add(cgLuaParam);
                    continue;
                }
    
                if (targetHeroes.Count > 0 && targetCards.Count > 0)
                {
                    CGLuaHeroParam cgLuaHeroParam = new CGLuaHeroParam
                    {
                        Value = targetValue,
                        Heroes = targetHeroes,
                        TriggerCard = triggerCard
                    };
                    CGLuaCardParam cgLuaCardParam = new CGLuaCardParam
                    {
                        Value = targetValue,
                        Cards = targetCards,
                        TriggerCard = triggerCard
                    };
                    CGLuaParam luaHeroParam = new CGLuaParam
                    {
                        LuaPath = triggerEffect.luaPath,
                        LuaParam = cgLuaHeroParam
                    };
                    luaParams.Add(luaHeroParam);
                    CGLuaParam cgLuaParam = new CGLuaParam
                    {
                        LuaPath = triggerEffect.luaPath,
                        LuaParam = cgLuaCardParam
                    };
                    luaParams.Add(cgLuaParam);
                }
            }
    
            return luaParams;
        } 怎么使这个方法简洁优雅一点
    
  2. Assistant

    我们可以通过提取重复代码、使用更清晰的命名以及引入一些辅助方法来简化和优化这个 PrepareExecuteLuaParams 方法。以下是一些可以采取的策略:

    1. 抽取重复代码:一些代码块在多个地方重复出现,例如计算目标值和添加 Lua 参数。这些可以封装为独立的方法。

    2. 使用对象封装逻辑:将与 targetValue 和 luaParams 处理相关的逻辑封装到一个类或方法中,以提高可读性。

    3. 清晰的命名:确保变量和方法命名清晰,能反应它們的用途。

    以下是重构后的代码示例:

    protected List<CGLuaParam> PrepareExecuteLuaParams(CGGameMode gameMode, Effect effect, ActorRef<Card> triggerCard,
        List<ActorRef<Card>> targetCards, List<ActorRef<Hero>> targetHeroes)
    {
        List<CGLuaParam> luaParams = new List<CGLuaParam>();
        Card cardObject = gameMode.GetActorObject(triggerCard);
        Player player = gameMode.GetActorObject(cardObject.GetOwnerPlayer());
        Hero cardHero = gameMode.GetActorObject(player.GetHero());
        int spellPowerValue = cardHero.GetSpellPowerValue();
    
        if (ShouldSkipExecution(gameMode, effect)) return luaParams;
    
        foreach (var triggerEffect in effect.triggerEffects)
        {
            if (triggerEffect.luaPath.Equals("None")) continue;
    
            ProcessTriggerEffect(gameMode, triggerEffect, cardObject, targetCards, targetHeroes, spellPowerValue, luaParams, triggerCard);
        }
    
        return luaParams;
    }
    
    private bool ShouldSkipExecution(CGGameMode gameMode, Effect effect)
    {
        int index = gameMode.GetRandomNumber();
        return index == 1 && effect.keyword == CardKeyWordType.Possible;
    }
    
    private void ProcessTriggerEffect(CGGameMode gameMode, TriggerEffect triggerEffect, Card cardObject, 
        List<ActorRef<Card>> targetCards, List<ActorRef<Hero>> targetHeroes, int spellPowerValue, 
        List<CGLuaParam> luaParams, ActorRef<Card> triggerCard)
    {
        if (!cardObject.IsNeedChooseTriggerEffect(triggerEffect))
        {
            ProcessNonChoosingEffect(gameMode, triggerEffect, cardObject, targetCards, spellPowerValue, luaParams);
            return;
        }
    
        int targetValue = triggerEffect.targetValue;
        foreach (var targetCard in targetCards)
        {
            ProcessTargets(gameMode, triggerEffect, targetCard, ref targetValue, spellPowerValue);
        }
    
        foreach (var targetHero in targetHeroes)
        {
            ProcessHeroTargets(gameMode, triggerEffect, targetHero, ref targetValue, cardObject);
        }
    
        AddLuaParamsForTargets(targetCards, targetHeroes, triggerEffect, targetValue, luaParams, triggerCard);
    }
    
    private void ProcessNonChoosingEffect(CGGameMode gameMode, TriggerEffect triggerEffect, Card cardObject, 
        List<ActorRef<Card>> targetCards, int spellPowerValue, List<CGLuaParam> luaParams)
    {
        if (!targetCards.Any() || (targetCards.Count > 0 && 
            (!triggerEffect.targetType.HasFlag(TargetType.Minion) && !triggerEffect.targetType.HasFlag(TargetType.Structure))) 
            || triggerEffect.targetType.ToString().Equals("609"))
        {
            int paramValue = triggerEffect.targetValue;
            if (triggerEffect.luaPath.Contains("All") || gameMode.IsNeedAddSpellPower(triggerEffect.luaPath))
            {
                paramValue += spellPowerValue;
            }
    
            PrepareLuaSingleParam(gameMode, triggerEffect, cardObject, luaParams, paramValue);
        }
    }
    
    private void ProcessTargets(CGGameMode gameMode, TriggerEffect triggerEffect, ActorRef<Card> targetCard, 
        ref int targetValue, int spellPowerValue)
    {
        Card targetCardObject = gameMode.GetActorObject(targetCard);
        if (!gameMode.CardIsMetTriggerCondition(targetCardObject, triggerEffect)) return;
    
        // 计算法强值
        if (gameMode.IsNeedAddSpellPower(triggerEffect.luaPath))
        {
            targetValue += spellPowerValue;
        }
    
        // 预览伤害或治疗
        HandleCardEffect(gameMode, triggerEffect, targetCardObject, ref targetValue);
    }
    
    private void HandleCardEffect(CGGameMode gameMode, TriggerEffect triggerEffect, Card targetCardObject, ref int targetValue)
    {
        if (triggerEffect.luaPath.Contains("CGSacrificeHealthToDamage"))
        {
            targetValue = targetCardObject.GetHealth().Value.intValue;
        }
        else if (triggerEffect.luaPath.Contains("CGSacrificeAmbushToDamage"))
        {
            targetValue = targetCardObject.GetAttack().Value.intValue;
        }
    
        if (triggerEffect.luaPath.Contains("Damage"))
        {
            gameMode.SetMinionDamagePreviewData(targetCardObject, targetValue);
        }
        else if (triggerEffect.luaPath.Contains("Heal"))
        {
            HandleHealEffect(targetCardObject, targetValue);
        }
    }
    
    private void HandleHealEffect(Card targetCardObject, int targetValue)
    {
        // Assuming Poison affects heal differently
        if (targetCardObject.GetCurrentPlayer().GetHero().GetIsPoison() || targetCardObject.GetCurrentPlayer().GetHero().GetIsTempPoison())
        {
            targetCardObject.SetPreviewData(-targetValue);
        }
        else
        {
            targetCardObject.SetPreviewData(targetValue);
        }
    }
    
    private void ProcessHeroTargets(CGGameMode gameMode, TriggerEffect triggerEffect, ActorRef<Hero> targetHero, 
        ref int targetValue, Card triggerCard)
    {
        if (!triggerEffect.targetType.HasFlag(TargetType.Hero)) return;
    
        // 处理伤害或治疗效果
        Hero targetHeroObject = gameMode.GetActorObject(targetHero);
        if (triggerEffect.luaPath.Contains("Damage"))
        {
            targetHeroObject.SetPreviewData(-targetValue);
        }
        else if (triggerEffect.luaPath.Contains("Heal"))
        {
            HandleHealEffect(targetHeroObject, targetValue);
        }
    }
    
    private void AddLuaParamsForTargets(List<ActorRef<Card>> targetCards, List<ActorRef<Hero>> targetHeroes, 
        TriggerEffect triggerEffect, int targetValue, List<CGLuaParam> luaParams, ActorRef<Card> triggerCard)
    {
        if (targetHeroes.Count > 0 && targetCards.Count > 0)
        {
            luaParams.Add(CreateLuaParam(triggerEffect.luaPath, new CGLuaHeroParam 
            { Value = targetValue, Heroes = targetHeroes, TriggerCard = triggerCard }));
            luaParams.Add(CreateLuaParam(triggerEffect.luaPath, new CGLuaCardParam 
            { Value = targetValue, Cards = targetCards, TriggerCard = triggerCard }));
        }
        else if (targetHeroes.Count > 0)
        {
            luaParams.Add(CreateLuaParam(triggerEffect.luaPath, new CGLuaHeroParam 
            { Value = targetValue, Heroes = targetHeroes, TriggerCard = triggerCard }));
        }
        else if (targetCards.Count > 0)
        {
            luaParams.Add(CreateLuaParam(triggerEffect.luaPath, new CGLuaCardParam 
            { Value = targetValue, Cards = targetCards, TriggerCard = triggerCard }));
        }
    }
    
    private CGLuaParam CreateLuaParam(string luaPath, object luaParam)
    {
        return new CGLuaParam
        {
            LuaPath = luaPath,
            LuaParam = luaParam
        };
    }
    

    主要改进点:

    1. 代码封装:重构了主要逻辑,将重复逻辑抽取到独立的方法中。

    2. 清晰的命名:通过使用有意义的名字,明确了每个方法的目的和责任,易于理解。

    3. 简化逻辑:将条件判断集中在方法中,减少了代码块的复杂性,使得主逻辑更清晰。

    通过这些步骤,代码的可读性和可维护性得到了显著提升,从而使整个方法变得更加简洁和优雅。