Skip to content
The Chat Archive
gpt-4o-mini-2024-07-18· OpenAI WildChat-4.8M (AI2)

extends Resource classname CogitoQuest ID number. Should be unique for each quest.…

  1. User

    extends Resource class_name CogitoQuest

    ID number. Should be unique for each quest.

    @export var id: int

    String name. Should have no spaces or special characters something like "level_quest01_a")

    @export var quest_name: String

    Quest title as it will be displayed in game.

    @export var quest_title : String

    Quest description when this quest is active.

    @export_multiline var quest_description_active: String

    Quest description when this quest was completed successfully.

    @export_multiline var quest_description_completed: String = "You completed this quest."

    Quest description when this quest was failed.

    @export_multiline var quest_description_failed: String = "You failed this quest." @export var quest_counter_current : int = 0 @export var quest_counter_goal : int

    @export_group("Quest Audio") @export var audio_on_start: AudioStream @export var audio_on_complete: AudioStream @export var audio_on_fail: AudioStream

    var quest_description : String

    var quest_completed : bool = false: set(value): quest_completed = value get: return quest_completed

    var quest_counter : int: set(value): quest_counter = value get: return quest_counter

    func start(): if audio_on_start: Audio.play_sound(audio_on_start) quest_description = quest_description_active

    func update() -> void: quest_completed = true

    func complete(): if audio_on_complete: Audio.play_sound(audio_on_complete) quest_description = quest_description_completed

    func failed(): if audio_on_fail: Audio.play_sound(audio_on_fail) quest_description = quest_description_failed

  2. Assistant

    The code you provided is a GDScript class for a quest system in a game using the Godot Engine. It encapsulates various attributes and methods related to a quest, including its identification, title, descriptions for different states, audio cues, and methods to handle starting, completing, and failing the quest.

    Here are a few suggestions and fixes to improve your script:

    1. Fixing the quest_completed and quest_counter properties: The way you have defined the setters and getters for quest_completed and quest_counter might lead to unexpected behavior because the variable is being overwritten recursively. You should use an internal variable to store the state.

    2. Defining the audio playback method: It looks like there's an expectation that an audio playback method (Audio.play_sound) exists, but it may need to be defined or replaced with Godot's built-in audio method.

    3. Ensuring type safety for counters: Consider how you increment quest_counter in your update logic, including bounds checking against quest_counter_goal.

    Here's an improved version of your script:

    extends Resource
    class_name CogitoQuest
    
    ## ID number. Should be unique for each quest.
    @export var id: int
    ## Quest name. Should have no spaces or special characters, e.g., "level_quest01_a".
    @export var quest_name: String
    ## Quest title as it will be displayed in the game.
    @export var quest_title: String
    ## Quest description when this quest is active.
    @export_multiline var quest_description_active: String
    ## Quest description when this quest was completed successfully.
    @export_multiline var quest_description_completed: String = "You completed this quest."
    ## Quest description when this quest was failed.
    @export_multiline var quest_description_failed: String = "You failed this quest."
    @export var quest_counter_current: int = 0
    @export var quest_counter_goal: int
    
    @export_group("Quest Audio")
    @export var audio_on_start: AudioStream
    @export var audio_on_complete: AudioStream
    @export var audio_on_fail: AudioStream
    
    var _quest_completed: bool = false  # Internal variable to track completion status
    var _quest_counter: int = 0  # Internal variable for current counter
    
    var quest_description: String
    
    # Property for quest completed
    var quest_completed: bool:
        set(value):
            _quest_completed = value
        get:
            return _quest_completed
    
    # Property for quest counter
    var quest_counter: int:
        set(value):
            _quest_counter = clamp(value, 0, quest_counter_goal)  # Ensure it's within bounds
        get:
            return _quest_counter
    
    func start():
        if audio_on_start:
            get_tree().call_group("audio_players", "play_sound", audio_on_start)  # Example audio play
        quest_description = quest_description_active
    
    func update() -> void:
        if quest_counter_current < quest_counter_goal:
            quest_counter_current += 1
        if quest_counter_current >= quest_counter_goal:
            complete()  # Automatically complete when the goal is met
    
    func complete():
        if audio_on_complete:
            get_tree().call_group("audio_players", "play_sound", audio_on_complete)
        quest_description = quest_description_completed
        quest_completed = true
    
    func failed():
        if audio_on_fail:
            get_tree().call_group("audio_players", "play_sound", audio_on_fail)
        quest_description = quest_description_failed
        quest_completed = true  # Mark as completed upon failure
    

    Changes made:

    • Added internal variables _quest_completed and _quest_counter to avoid recursive behavior in setters and getters.
    • Ensured that the quest_counter is clamped to not exceed quest_counter_goal.
    • Changed how the audio is played to a more generic method that calls a group, assuming you have a group of nodes that manage audio playback. Adjust to fit your architecture.
    • Included automatic quest completion logic when the counter goal is met, ensuring the quest completes as expected.

    This should give you a more robust foundation for your quest system. Make sure to adjust the audio playing function as per your implementation.