hi i have a react project i use react hook form and yup for validation, i have a this…
- User
hi i have a react project i use react hook form and yup for validation, i have a this component:
import { useForm, useQueryRequest, yupResolver, Grid, Controller, SelectField, getZonesList, getBasicPriceNameList, useState, getALLStates, getCitiesByState, Button, CheckBox, useRef, } from "@imports"; import { SLAStateCitiesFormSchemaGenerator } from "@src/schema"; import { OutputUseQueryType } from "@src/types/generalTypes"; import { SLAListRowDataType, CitiesOutputType, CitiesType, SLAListOutputType, SLAZonesType, SLACitiesSubmitHandlerInputType, StatesOutputType, StatesType, GetSLAZonesOutputType, } from "@src/types/services/SLACitiesType"; type SLAStateCitiesFormProps = { submitHandler: (data: SLACitiesSubmitHandlerInputType) => void; isMultiSelect: boolean; buttonTitle: string; disables: boolean; defaultData: SLACitiesSubmitHandlerInputType; }; const SLAStateCitiesForm: React.FC<SLAStateCitiesFormProps> = ({ submitHandler, isMultiSelect, buttonTitle, disables, defaultData, }) => { const SLAStateCitiesFormSchema = SLAStateCitiesFormSchemaGenerator(isMultiSelect); const { handleSubmit, control, formState: { errors }, setValue, } = useForm({ mode: "onTouched", resolver: yupResolver(SLAStateCitiesFormSchema), defaultValues: { ...defaultData, isActive: defaultData ? defaultData.isActive : true, slA_CitiesType: defaultData ? defaultData.slA_CitiesType : false, }, }); const slAGroupIDRef = useRef<null | any>(null); const zoneIDsRef = useRef<null | any>(null); const slA_SourceStateIDsRef = useRef<null | any>(null); const slA_SourceCityIDsRef = useRef<null | any>(null); const slA_DestStateIDsRef = useRef<null | any>(null); const slA_DestCityIDsRef = useRef<null | any>(null); const [selectedSLAGroupID, setSelectedSLAGroupID] = useState(1); const [selectedSrcStateID, setSelectedSrcStateID] = useState([ { stateID: 0, }, ]); const [selectedDesStateID, setSelectedDesStateID] = useState([ { stateID: 0, }, ]); const { data: basicPriceNameListData, isLoading: basicPriceNameListDataLoading, }: OutputUseQueryType<SLAListOutputType> = useQueryRequest({ queryFn: getBasicPriceNameList, queryKey: "get-basic-price-name-List", data: { companyID: 1, }, }); const { data: slaZonesListData, isLoading: slaZonesListDataLoading, }: OutputUseQueryType<GetSLAZonesOutputType> = useQueryRequest({ queryFn: getZonesList, queryKey: "get-sla-zones", data: { companyID: 1, slA_GroupID: defaultData ? (defaultData.slA_GroupID as { slA_GroupID: number }).slA_GroupID : selectedSLAGroupID, }, }); const { data: states, isLoading: statesLoading, }: OutputUseQueryType<StatesOutputType> = useQueryRequest({ queryFn: getALLStates, queryKey: "get-states", data: { stateID: 0, }, }); const { data: srcCities, isLoading: srcCitiesLoading, }: OutputUseQueryType<CitiesOutputType> = useQueryRequest({ queryFn: getCitiesByState, queryKey: "get-src-cities", data: defaultData && selectedSrcStateID[0].stateID === 0 ? { stateIDs: [ { stateID: (defaultData?.slA_SourceStateIDs as StatesType) .stateID, }, ], } : { stateIDs: selectedSrcStateID }, }); const { data: desCities, isLoading: desCitiesLoading, }: OutputUseQueryType<CitiesOutputType> = useQueryRequest({ queryFn: getCitiesByState, queryKey: "get-des-cities", data: defaultData && selectedDesStateID[0].stateID === 0 ? { stateIDs: [ { stateID: (defaultData?.slA_SourceStateIDs as StatesType) .stateID, }, ], } : { stateIDs: selectedDesStateID }, }); const emptyInputsHandler = () => { if (!defaultData) { slAGroupIDRef.current!.setValue({}); zoneIDsRef.current!.setValue([]); slA_SourceStateIDsRef.current!.setValue([]); slA_SourceCityIDsRef.current!.setValue([]); slA_DestStateIDsRef.current!.setValue([]); slA_DestCityIDsRef.current!.setValue([]); setValue("isActive", true); setValue("slA_CitiesType", false); } }; return ( <form className="w-full flex flex-col gap-4" onSubmit={handleSubmit((data) => { submitHandler(data); emptyInputsHandler(); })} > <Grid container spacing={4}> <Grid item xs={12} md={6}> <Controller name="slA_GroupID" control={control} render={({ field }) => ( <SelectField selectRef={slAGroupIDRef} isLoading={basicPriceNameListDataLoading} {...field} onChange={(val: SLAListRowDataType) => { field.onChange(val); setSelectedSLAGroupID(val.slA_GroupID); }} options={basicPriceNameListData && basicPriceNameListData.data} label="سرگروه SLA" error={errors.slA_GroupID?.message} getOptionLabel={(option: SLAListRowDataType) => option.slA_GroupName } getOptionValue={(option: SLAListRowDataType) => option.slA_GroupID } isRequired={true} defaultValue={defaultData?.slA_GroupID} disabled={!!defaultData} /> )} /> </Grid> <Grid item xs={12} md={6}> <Controller name="zoneIDs" control={control} render={({ field }) => ( <SelectField selectRef={zoneIDsRef} isLoading={slaZonesListDataLoading} {...field} onChange={(val: SLAZonesType[]) => { field.onChange(val); }} options={slaZonesListData && slaZonesListData.data} label="زون (ناحیه)" error={errors.zoneIDs?.message} getOptionLabel={(option: SLAZonesType) => option.zoneName} getOptionValue={(option: SLAZonesType) => option.zoneID} isRequired={true} isMultiSelect={isMultiSelect} defaultValue={defaultData?.zoneIDs} /> )} /> </Grid> <Grid item xs={12} md={6}> <Controller name="slA_SourceStateIDs" control={control} render={({ field }) => ( <SelectField selectRef={slA_SourceStateIDsRef} isLoading={statesLoading} {...field} onChange={(val: StatesType) => { field.onChange(val); const selected = Array.isArray(val) ? val.map((item) => { return { stateID: item.stateID }; }) : [{ stateID: val.stateID }]; setSelectedSrcStateID(selected); defaultData && slA_SourceCityIDsRef.current!.setValue([]); }} options={states && states.data} label="استان مبدا:" error={errors.slA_SourceStateIDs?.message} getOptionLabel={(option: StatesType) => option.statePName} getOptionValue={(option: StatesType) => option.stateID} isRequired={true} isMultiSelect={isMultiSelect} defaultValue={defaultData?.slA_SourceStateIDs} /> )} /> </Grid> <Grid item xs={12} md={6}> <Controller name="slA_SourceCityIDs" control={control} render={({ field }) => ( <SelectField selectRef={slA_SourceCityIDsRef} isLoading={srcCitiesLoading} {...field} onChange={(val: CitiesType) => { field.onChange(val); }} options={srcCities && srcCities.data} label="شهر مبدا:" error={errors.slA_SourceCityIDs?.message} getOptionLabel={(option: CitiesType) => option.cityPName} getOptionValue={(option: CitiesType) => option.cityID} isRequired={true} isMultiSelect={isMultiSelect} defaultValue={defaultData?.slA_SourceCityIDs} /> )} /> </Grid> <Grid item xs={12} md={6}> <Controller name="slA_DestStateIDs" control={control} render={({ field }) => ( <SelectField selectRef={slA_DestStateIDsRef} isLoading={statesLoading} {...field} onChange={(val: StatesType) => { field.onChange(val); const selected = Array.isArray(val) ? val.map((item) => { return { stateID: item.stateID }; }) : [{ stateID: val.stateID }]; setSelectedDesStateID(selected); defaultData && slA_DestCityIDsRef.current!.setValue([]); }} options={states && states.data} label="استان مقصد:" error={errors.slA_DestStateIDs?.message} getOptionLabel={(option: StatesType) => option.statePName} getOptionValue={(option: StatesType) => option.stateID} isRequired={true} isMultiSelect={isMultiSelect} defaultValue={defaultData?.slA_DestStateIDs} /> )} /> </Grid> <Grid item xs={12} md={6}> <Controller name="slA_DestCityIDs" control={control} render={({ field }) => ( <SelectField selectRef={slA_DestCityIDsRef} isLoading={desCitiesLoading} {...field} onChange={(val: CitiesType) => { field.onChange(val); }} options={desCities && desCities.data} label="شهر مقصد:" error={errors.slA_DestCityIDs?.message} getOptionLabel={(option: CitiesType) => option.cityPName} getOptionValue={(option: CitiesType) => option.cityID} isRequired={true} isMultiSelect={isMultiSelect} defaultValue={defaultData?.slA_DestCityIDs} /> )} /> </Grid> <Grid item xs={12}> <div className="h-full flex flex-col items-start justify-center mt-2"> <Controller name="slA_CitiesType" control={control} render={({ field }) => ( <CheckBox id="slA_CitiesType" name="slA_CitiesType" value="" label="مبادی و مقاصد انتخابی شامل مسیرهای SLA نباشند." checked={field.value} onChange={(val: React.ChangeEvent<HTMLInputElement>) => { field.onChange(val); }} /> )} /> </div> </Grid> <Grid item xs={12} sm={6} lg={2}> <div className="h-full flex flex-col items-start justify-center mt-2"> <Controller name="isActive" control={control} render={({ field }) => ( <CheckBox id="isActive" name="isActive" value="" label="فعال" checked={field.value} onChange={(val: React.ChangeEvent<HTMLInputElement>) => { field.onChange(val); }} /> )} /> </div> </Grid> <div className="flex justify-end p-4 w-full "> <Button type="submit" variant="contained" color="primary" disabled={disables} > {buttonTitle} </Button> </div> </Grid> </form> ); }; export default SLAStateCitiesForm;and this is my yup schema:
export const SLAStateCitiesFormSchemaGenerator = (isMultiSelect: boolean) => { return Yup.object().shape({ slA_GroupID: GetSLAGroupOutputDataSchema.required( " سرگروه SLA را وارد کنید" ), zoneIDs: isMultiSelect ? Yup.array().required("زون (ناحیه) را وارد کنید") : Yup.object().required("زون (ناحیه) را وارد کنید"), slA_SourceStateIDs: isMultiSelect ? Yup.array().of(StateSchema).required("استان مبدا را وارد کنید.") : StateSchema.required("استان مبدا را وارد کنید."), slA_SourceCityIDs: isMultiSelect ? Yup.array().of(CitySchema).required("شهر مبدا را وارد کنید.") : CitySchema.required("شهر مبدا را وارد کنید."), slA_DestStateIDs: isMultiSelect ? Yup.array() .of(slA_DestStateIDsSchema) .required("استان مقصد را وارد کنید.") : slA_DestStateIDsSchema.required("استان مقصد را وارد کنید."), slA_DestCityIDs: isMultiSelect ? Yup.array().of(slA_DestCityIDsSchema).required("شهر مقصد را وارد کنید.") : slA_DestCityIDsSchema.required("شهر مقصد را وارد کنید."), isActive: Yup.boolean(), slA_CitiesType: Yup.boolean(), }); };and i get this error:
Type '{ isActive: boolean | undefined; slA_CitiesType: boolean | undefined; slA_GroupID: {} | SLAListRowDataType; zoneIDs: {} | SLAZonesType; slA_DestCityIDs: {} | CitiesType; slA_DestStateIDs: {} | StatesType; slA_SourceCityIDs: {} | CitiesType; slA_SourceStateIDs: {} | StatesType; }' is not assignable to type 'AsyncDefaultValues<{ isActive?: boolean | undefined; slA_CitiesType?: boolean | undefined; slA_GroupID: { isActive?: number | undefined; slA_GroupID?: number | undefined; slA_GroupName?: string | undefined; isActiveName?: string | undefined; }; ... 4 more ...; slA_DestCityIDs: { ...; } | { ...; }[]; }> | { ...; } | ...'. Type '{ isActive: boolean | undefined; slA_CitiesType: boolean | undefined; slA_GroupID: {} | SLAListRowDataType; zoneIDs: {} | SLAZonesType; slA_DestCityIDs: {} | CitiesType; slA_DestStateIDs: {} | StatesType; slA_SourceCityIDs: {} | CitiesType; slA_SourceStateIDs: {} | StatesType; }' is not assignable to type '{ isActive?: boolean | undefined; slA_CitiesType?: boolean | undefined; slA_GroupID?: { isActive?: number | undefined; slA_GroupID?: number | undefined; slA_GroupName?: string | undefined; isActiveName?: string | undefined; } | undefined; ... 4 more ...; slA_DestCityIDs?: { ...; } | ... 1 more ... | undefined; }'. Types of property 'slA_DestStateIDs' are incompatible. Type '{} | StatesType' is not assignable to type '{ destStateID?: number | undefined; } | ({ destStateID?: number | undefined; } | undefined)[] | undefined'. Type 'StatesType' is not assignable to type '{ destStateID?: number | undefined; } | ({ destStateID?: number | undefined; } | undefined)[] | undefined'.ts(2322) (property) defaultValues?: AsyncDefaultValues<{ isActive?: boolean | undefined; slA_CitiesType?: boolean | undefined; slA_GroupID: { isActive?: number | undefined; slA_GroupID?: number | undefined; slA_GroupName?: string | undefined; isActiveName?: string | undefined; }; ... 4 more ...; slA_DestCityIDs: { ...; } | { ...; }[]; }> | { ...; } | undefinedon this line:
defaultValues: { ...defaultData, isActive: defaultData ? defaultData.isActive : true, slA_CitiesType: defaultData ? defaultData.slA_CitiesType : false, },what should id o?
- Assistant
The issue arises because the structure of your
defaultValuesdoes not match the expected input type inuseForm, specifically for theslA_DestStateIDsproperty (and likely some other ones). The propertyslA_DestStateIDsexpects a specific type, but yourdefaultDataor its transformation (...defaultData) contains a value that doesn't match this expected type.Your
defaultData's type and the schema used in theuseForm()configuration must align precisely. Let's break this down step by step to resolve the issue:
Step 1: Identify the Expected Type
The error suggests that
slA_DestStateIDshas an incompatible type. According to the error:The expected type for
slA_DestStateIDsis:{ destStateID?: number | undefined } | ({ destStateID?: number | undefined } | undefined)[] | undefinedHowever, you are providing a type of:
{} | StatesTypeThis mismatch comes from
StatesTypenot aligning with the defined expected structure ({ destStateID?: number }).
Step 2: Debug the Property Types
Check what
defaultData.slA_DestStateIDslooks like. From your code, it seems thatslA_DestStateIDsis of type:{} | StatesTypeBut the expected structure requires it to conform to
destStateID:{ destStateID?: number } | ({ destStateID?: number } | undefined)[]If
defaultData,slA_DestStateIDs, or other similar fields in the schema are generated incorrectly or in the wrong shape, you need to either convert or transform the data appropriately to match the expected type.
Step 3: Adjust the Default Values
You need to transform your
defaultDatato ensure all the properties match their expected types. For example, ifslA_DestStateIDsneeds to be{ destStateID }or an array of such objects, you can map or transform it during initialization.Here's how you might adjust the
defaultValuesconfiguration:defaultValues: { ...defaultData, isActive: defaultData ? defaultData.isActive : true, slA_CitiesType: defaultData ? defaultData.slA_CitiesType : false, slA_DestStateIDs: defaultData?.slA_DestStateIDs ? Array.isArray(defaultData.slA_DestStateIDs) ? defaultData.slA_DestStateIDs.map((state: StatesType) => ({ destStateID: state.stateID, // Map to expected structure })) : { destStateID: defaultData.slA_DestStateIDs.stateID } : [], // Provide a default empty array if undefined slA_SourceStateIDs: defaultData?.slA_SourceStateIDs ? Array.isArray(defaultData.slA_SourceStateIDs) ? defaultData.slA_SourceStateIDs.map((state: StatesType) => ({ destStateID: state.stateID, })) : { destStateID: defaultData.slA_SourceStateIDs.stateID } : [], // Adjust similarly for other state- or city-related fields }By mapping
defaultData.slA_DestStateIDsto the required structure{ destStateID: number }, you ensure type compatibility.
Step 4: Update Other Mismatched Fields
Repeat the above logic for other fields with mismatched types (e.g.,
slA_SourceStateIDs,slA_SourceCityIDs, etc.). Make sure you convert from the structure provided indefaultDatato what is expected.
Step 5: Ensure Yup Schema Matches
Ensure that the Yup schema validation (
SLAStateCitiesFormSchemaGenerator) structure matches the expected data shape. If the shape changes (e.g., you're providing{ destStateID }, but the schema expects a different structure), update the schema to reflect this:slA_DestStateIDs: isMultiSelect ? Yup.array().of( Yup.object({ destStateID: Yup.number().required(), }) ).required("استان مقصد را وارد کنید.") : Yup.object({ destStateID: Yup.number().required(), }).required("استان مقصد را وارد کنید."),This confirms that
slA_DestStateIDsis either a single object or an array of{ destStateID: number }objects.
Step 6: Final Code
The adjusted
defaultValuesinitialization should look something like this:defaultValues: { ...defaultData, isActive: defaultData ? defaultData.isActive : true, slA_CitiesType: defaultData ? defaultData.slA_CitiesType : false, slA_DestStateIDs: defaultData?.slA_DestStateIDs ? Array.isArray(defaultData.slA_DestStateIDs) ? defaultData.slA_DestStateIDs.map((state) => ({ destStateID: state.stateID, })) : { destStateID: defaultData.slA_DestStateIDs.stateID } : [], slA_SourceStateIDs: defaultData?.slA_SourceStateIDs ? Array.isArray(defaultData.slA_SourceStateIDs) ? defaultData.slA_SourceStateIDs.map((state) => ({ destStateID: state.stateID, })) : { destStateID: defaultData.slA_SourceStateIDs.stateID } : [], slA_DestCityIDs: defaultData?.slA_DestCityIDs ? Array.isArray(defaultData.slA_DestCityIDs) ? defaultData.slA_DestCityIDs.map((city) => ({ destCityID: city.cityID, })) : { destCityID: defaultData.slA_DestCityIDs.cityID } : [], },
Step 7: Types & Validation
Ensure all your types (
StatesType,CitiesType, etc.) align properly with theuseForminput, ensuring compatibility with bothdefaultValuesand Yup validation.
Conclusion
The key is to carefully transform
defaultDatainto the structure expected by youruseFormand Yup schema. Add mapping functions where necessary, and test fields one by one to ensure compliance.