Currently when i select an option in the Datatypes options dropdown menu the datatypes…
- User
Currently when i select an option in the Datatypes options dropdown menu the datatypes menu closes not just the dropdown menu. Modify the code so that it only closes the dropdown code: def show_datatype_dialog(self) -> None: """Show custom popup window for changing column data types.""" table_name = self.app.current_table_name if not table_name: messagebox.showwarning("No Table Selected", "Please select a table to change datatypes.") return current_headers = self.app.current_sheet.headers() if self.app.current_sheet else [] self.app.data_manager.headers[table_name] = current_headers self.data_types = self.app.data_manager.tables_data[table_name].get("data_types", []).copy() while len(self.data_types) < len(current_headers): self.data_types.append('string') if hasattr(self, 'datatype_popup') and self.datatype_popup.winfo_exists(): self.datatype_popup.destroy() self.datatype_popup = tk.Toplevel(self.root) self.datatype_popup.overrideredirect(True) border_frame = tk.Frame(self.datatype_popup, bg=self.colors["frame_border"]) border_frame.pack(padx=0, pady=0, expand=True, fill=tk.BOTH) content_frame = tk.Frame(border_frame, bg=self.colors["background"]) content_frame.pack(padx=1, pady=1, expand=True, fill=tk.BOTH) inner_frame = tk.Frame(content_frame, bg=self.colors["background"]) inner_frame.pack(padx=10, pady=10, expand=True, fill=tk.BOTH) self.datatype_vars = {} for header_index, header in enumerate(current_headers): current_type = self.data_types[header_index] frame = tk.Frame(inner_frame, bg=self.colors["background"]) frame.pack(fill=tk.X, pady=0) header_label = tk.Label( frame, text=f"{header}:", bg=self.colors["background"], fg=self.colors["text"], font=self.fonts["menu"] ) header_label.pack(side=tk.LEFT, padx=(0, 10)) var = tk.StringVar(value=current_type) dropdown_button = tk.Label( frame, textvariable=var, bg=self.colors["background"], fg=self.colors["header_info"], font=self.fonts["menu"], cursor="hand2", width=10, anchor='w' ) dropdown_button.pack(side=tk.RIGHT) def create_dropdown(header, var, button): def show_dropdown(event): x = button.winfo_rootx() y = button.winfo_rooty() + button.winfo_height() dropdown = tk.Toplevel(self.datatype_popup) dropdown.overrideredirect(True) dropdown.geometry(f"+{x}+{y}") # Create a border frame border_frame = tk.Frame(dropdown, bg=self.colors["frame_border"]) border_frame.pack(padx=0, pady=0, expand=True, fill=tk.BOTH) # Create an inner frame for the options inner_frame = tk.Frame(border_frame, bg=self.colors["background"]) inner_frame.pack(padx=1, pady=1, expand=True, fill=tk.BOTH) for option in self.DATA_TYPE_OPTIONS: option_label = tk.Label( inner_frame, text=option, bg=self.colors["background"], fg=self.colors["header_info"], font=self.fonts["menu"], anchor='w', width=10 ) option_label.pack(fill=tk.X) option_label.bind("", lambda e: e.widget.config(bg=self.colors["button_selected"])) option_label.bind("", lambda e: e.widget.config(bg=self.colors["background"])) option_label.bind("", lambda e, opt=option: (var.set(opt), dropdown.destroy())) def close_dropdown(event): if event.widget != dropdown and event.widget != button: dropdown.destroy() self.root.bind("", close_dropdown) dropdown.bind("", lambda e: dropdown.destroy()) button.bind("", show_dropdown) create_dropdown(header, var, dropdown_button) self.datatype_vars[header] = var separator = tk.Frame(inner_frame, bg=self.colors["separator_menu"], height=1) separator.pack(fill=tk.X, pady=(5, 5)) apply_container = tk.Frame( inner_frame, bg=self.colors["background"], cursor="hand2" ) apply_container.pack(fill=tk.X, pady=(5,0)) apply_label = tk.Label( apply_container, text="Apply Changes", bg=self.colors["background"], fg=self.colors["text"], font=self.fonts["menu"], cursor="hand2" ) apply_label.pack(expand=True, fill=tk.BOTH, pady=0) def on_hover_enter(event): apply_container.config(bg=self.colors["button_selected"]) apply_label.config(bg=self.colors["button_selected"]) def on_hover_leave(event): apply_container.config(bg=self.colors["background"]) apply_label.config(bg=self.colors["background"]) apply_container.bind("", on_hover_enter) apply_container.bind("", on_hover_leave) apply_label.bind("", on_hover_enter) apply_label.bind("", on_hover_leave) apply_container.bind("", lambda e: self._apply_changes()) apply_label.bind("", lambda e: self._apply_changes()) self.datatype_popup.update_idletasks() popup_width = self.datatype_popup.winfo_width() popup_height = self.datatype_popup.winfo_height() screen_width = self.root.winfo_screenwidth() screen_height = self.root.winfo_screenheight() menu_x = self.root.winfo_pointerx() menu_y = self.root.winfo_pointery() padding = 10 if menu_x + popup_width > screen_width - padding: menu_x = screen_width - popup_width - padding if menu_y + popup_height > screen_height - padding: menu_y = screen_height - popup_height - padding menu_x = max(padding, menu_x) menu_y = max(padding, menu_y) self.datatype_popup.geometry(f"+{menu_x}+{menu_y}") def close_popup(event=None): if self.datatype_popup.winfo_exists(): self.datatype_popup.destroy() self.root.unbind("", self.click_outside_popup) self.root.unbind("", self.window_resized) def click_outside_popup(event): if not str(event.widget).startswith(str(self.datatype_popup)): close_popup() self.click_outside_popup = self.root.bind("", click_outside_popup) self.window_resized = self.root.bind("", lambda e: close_popup()) self.datatype_popup.bind("", close_popup) self.datatype_popup.bind("", close_popup) self.datatype_popup.focus_force()
- Assistant
The issue you're experiencing is due to the focus management and event bindings in your code. When you select an option in the dropdown, the
FocusOutevent is triggered on the main data type popup (self.datatype_popup), causing it to close unintentionally. To fix this, you need to adjust the focus handling and event bindings so that the main popup doesn't close when you interact with the dropdown.Here's how you can modify your code:
-
Remove the
<FocusOut>binding on the main popup. In yourshow_datatype_dialogmethod, you have a line that bindsclose_popupto the<FocusOut>event onself.datatype_popup. This causes the main popup to close when it loses focus (e.g., when you click on the dropdown options).Modify or remove this line:
# Remove or comment out this line # self.datatype_popup.bind("<FocusOut>", close_popup) -
Adjust the
click_outside_popupfunction to check for clicks outside all popup windows, including dropdowns. Introduce a helper functionis_descendantto determine if a widget is a child of another widget. Then, in yourclick_outside_popupfunction, use this helper to prevent the main popup from closing when interacting with the dropdown.Add the
is_descendantfunction:def is_descendant(widget, ancestor): while widget: if widget == ancestor: return True widget = widget.master return FalseModify the
click_outside_popupfunction:def click_outside_popup(event): # Don't close the popup if the click was inside the main popup or dropdown if not is_descendant(event.widget, self.datatype_popup): close_popup() -
Adjust the dropdown's close function to avoid interfering with the main popup's event bindings. Remove the binding of
<Button-1>on the root in theshow_dropdownmethod. Instead, rely on the<FocusOut>event and make sure the dropdown is a child of the main popup.Modify the
show_dropdownmethod:def show_dropdown(event): # ... # Remove this line to prevent interference # self.root.bind("<Button-1>", close_dropdown) # Ensure the dropdown is a child window of the main popup dropdown = tk.Toplevel(self.datatype_popup) # ...
By making these adjustments, you ensure that the main data type popup remains open when selecting options in the dropdown, and only the dropdown menu closes after an option is selected. The main popup will still close when you click outside of it and any of its child windows.
Here's the modified portion of your code with the necessary changes:
def show_datatype_dialog(self) -> None: # ... (rest of your code) # Remove the binding to <FocusOut> on the main popup # self.datatype_popup.bind("<FocusOut>", close_popup) # Define the helper function to check if a widget is a descendant def is_descendant(widget, ancestor): while widget: if widget == ancestor: return True widget = widget.master return False def close_popup(event=None): if self.datatype_popup.winfo_exists(): self.datatype_popup.destroy() self.root.unbind("<Button-1>", self.click_outside_popup) self.root.unbind("<Configure>", self.window_resized) def click_outside_popup(event): # Don't close the popup if the click was inside the main popup or dropdown if not is_descendant(event.widget, self.datatype_popup): close_popup() self.click_outside_popup = self.root.bind("<Button-1>", click_outside_popup) self.window_resized = self.root.bind("<Configure>", lambda e: close_popup()) # ... (rest of your code in show_datatype_dialog) def show_dropdown(event): # ... (rest of your code) # Remove the binding to <Button-1> on the root # self.root.bind("<Button-1>", close_dropdown) # Ensure the dropdown is a child of the main popup dropdown = tk.Toplevel(self.datatype_popup) dropdown.overrideredirect(True) # ... # Use the <FocusOut> event to close the dropdown dropdown.bind("<FocusOut>", lambda e: dropdown.destroy()) # ... (rest of your code in show_dropdown)By making these changes, you ensure that only the dropdown closes when you select an option, and the main data type popup remains open, providing a better user experience.
-