public string[] carte = new string[52]; public Form1() { InitializeComponent(); }…
- User
public string[] carte = new string[52]; public Form1() { InitializeComponent(); }
private void Form1_Load(object sender, EventArgs e) { pb1p.Visible = false; pb2p.Visible = false; pb3p.Visible = false; lblmazziere.Visible = false; lblpunteggiopc.Visible = false; pb1p.Visible = false; pb2p.Visible = false; pb3p.Visible = false; pb4p.Visible = false; pb5p.Visible = false; btnprendi.Visible = false; btnrimani.Visible = false;
void Generacarte(string[] carte) { string[] seme = { "c", "d", "s", "h" }; int j = 0; foreach (string s in seme) { for (int i = 1; i < 14; i++, j++) { switch (i) { case 1: carte[j] = "_" + i + s; break; case 2: carte[j] = "_" + i + s; break; case 3: carte[j] = "_" + i + s; break; case 4: carte[j] = "_" + i + s; break; case 5: carte[j] = "_" + i + s; break; case 6: carte[j] = "_" + i + s; break; case 7: carte[j] = "_" + i + s; break; case 8: carte[j] = "_" + i + s; break; case 9: carte[j] = "_" + i + s; break; case 10: carte[j] = "_" + i + s; break; case 11: carte[j] = "_" + i + s; break; case 12: carte[j] = "_" + i + s; break; case 13: carte[j] = "_" + i + s; break; } } } } void Mischiacarte(string[] carte) { int totaleCarte = carte.Length; int i, j; string temporanea; Random indiciCasuali1 = new Random(); Random indiciCasuali2 = new Random(); for (int k = 0; k < totaleCarte * 2; k++) { i = indiciCasuali1.Next(0, totaleCarte); j = indiciCasuali2.Next(0, totaleCarte); if (i != j) { temporanea = carte[i]; carte[i] = carte[j]; carte[j] = temporanea; } } } rendi il mischia carte che funzioni - Assistant
The
Mischiacarte(shuffle cards) method you've implemented has a couple of issues that can be improved to ensure it shuffles the deck more effectively. Here are some suggestions:-
Single Random Instance: Use a single instance of
Random, instead of creating two different instances. InstantiatingRandommultiple times can lead to generating the same sequence of numbers if done too quickly. -
Algorithm Correction: Use a well-known algorithm like the Fisher-Yates shuffle (also known as the Knuth shuffle) to ensure a uniform shuffle across all possible permutations.
Below is the revised
Mischiacartemethod employing the Fisher-Yates shuffle algorithm, using a singleRandominstance:void Mischiacarte(string[] carte) { int totaleCarte = carte.Length; Random random = new Random(); // Single instance of Random for (int i = 0; i < totaleCarte; i++) { // Get a random index from i to totaleCarte - 1 int j = random.Next(i, totaleCarte); // Swap elements carte[i] and carte[j] string temporanea = carte[i]; carte[i] = carte[j]; carte[j] = temporanea; } }Key Improvements:
- Efficiency and Correctness: The Fisher-Yates shuffle algorithm ensures that each permutation of the deck is equally likely, making it both efficient and statistically correct.
- Reduced Complexity: Only one loop is required, reducing the complexity compared to shuffling multiple times with redundant random instances.
This code should be added to your existing method definitions to replace the existing shuffling logic. It will ensure your deck is shuffled correctly every time the method is called.
-