using Terraria; using Terraria.ID; using Terraria.ModLoader; using…
- User
using Terraria; using Terraria.ID; using Terraria.ModLoader; using Microsoft.Xna.Framework; using Terraria.Audio; using System; using ITD.Utilities;
namespace ITD.Content.Items.Accessories.Movement.Jumps { public class FirestormInABottle : ModItem { public override void SetDefaults() { Item.width = 28; Item.height = 24; Item.value = Item.sellPrice(gold: 2); Item.rare = ItemRarityID.Orange; Item.accessory = true; }
public override void UpdateAccessory(Player player, bool hideVisual) { player.GetModPlayer<FirestormPlayer>().hasFireJump = true; } } public class FirestormPlayer : ModPlayer { public const int FireCloudDuration = 180; public const int FireTrailDuration = 60; public const int RainDuration = 120; public const int FireRainLifetime = 180; public const int DamageInterval = 30; public bool hasFireJump; public bool canDoubleJump; public bool waitDoubleJump; public int fireCloudTimer; public int fireTrailTimer; public int rainTimer; public int damageTimer; public Vector2 jumpPosition; public override void ResetEffects() => hasFireJump = false; public override void PreUpdate() { HandleDoubleJump(); UpdateTimers(); } public override void PostUpdate() => UpdateFireRain(); private void HandleDoubleJump() { if ((Player.velocity.Y == 0f || Player.sliding || Player.autoJump && Player.justJumped) && hasFireJump) { canDoubleJump = true; waitDoubleJump = true; } else if (canDoubleJump && Player.controlJump && !waitDoubleJump) { PerformDoubleJump(); } waitDoubleJump = Player.controlJump; } private void PerformDoubleJump() { if (Player.jump > 0) return; Player.velocity.Y = -Player.jumpSpeed * Player.gravDir; Player.jump = Player.jumpHeight; canDoubleJump = false; SoundEngine.PlaySound(new SoundStyle($"ITD/Content/Sounds/FirestormInABottle{Main.rand.Next(1, 3)}"), Player.position); fireCloudTimer = FireCloudDuration; fireTrailTimer = FireTrailDuration; rainTimer = RainDuration; damageTimer = DamageInterval; jumpPosition = Player.Bottom; } private void UpdateTimers() { if (fireCloudTimer > 0) { fireCloudTimer--; FireCloud(); } if (fireTrailTimer > 0) { fireTrailTimer--; FireTrail(); } if (rainTimer > 0) { rainTimer--; FireRain(); } if (damageTimer > 0) damageTimer--; } private void FireCloud() { float progress = (float)fireCloudTimer / FireCloudDuration; for (int i = 0; i < 10; i++) CreateFireCloudDust(progress); DamageEnemy(jumpPosition, damageTimer <= 0); if (damageTimer <= 0) damageTimer = DamageInterval; } private void CreateFireCloudDust(float progress) { Vector2 speed = Main.rand.NextVector2Circular(5f * progress, 5f * progress); speed.Y -= Main.rand.NextFloat(2f * progress, 8f * progress); int dustType = Main.rand.Next(3) switch { 0 => DustID.Torch, 1 => DustID.Smoke, _ => DustID.Cloud }; Dust dust = Dust.NewDustPerfect( jumpPosition + new Vector2(Main.rand.Next(-50, 51), Main.rand.Next(-20, 21)), dustType, speed, 100, Color.OrangeRed * progress, Main.rand.NextFloat(1f, 2.5f) * progress ); dust.noGravity = true; dust.fadeIn = 1f * progress; if (dustType == DustID.Cloud) { dust.color = Color.Lerp(Color.OrangeRed, Color.White, Main.rand.NextFloat(0.5f)); } } private void FireTrail() { for (int i = 0; i < 3; i++) CreateFireTrailDust(); DamageEnemy(Player.Bottom, false); } private void CreateFireTrailDust() { Vector2 speed = new Vector2(Main.rand.NextFloat(-1f, 1f), Main.rand.NextFloat(-1.5f, -0.5f)); Dust dust = Dust.NewDustPerfect( Player.Bottom + new Vector2(Main.rand.Next(-10, 11), 0), DustID.Torch, speed, 100, Color.OrangeRed, Main.rand.NextFloat(0.5f, 1f) ); dust.noGravity = true; dust.fadeIn = 0.5f; dust.color = Color.Lerp(Color.OrangeRed, Color.Yellow, Main.rand.NextFloat(0.5f)); } private void FireRain() { float progress = (float)rainTimer / RainDuration; for (int i = 0; i < 3; i++) CreateFireRainDust(progress); } private void CreateFireRainDust(float progress) { Vector2 rainPosition = jumpPosition + new Vector2(Main.rand.Next(-50, 51), Main.rand.Next(-20, 0)); Vector2 rainVelocity = new Vector2(Main.windSpeedCurrent * 0.3f, Main.rand.Next(2, 4)); Dust dust = Dust.NewDustPerfect( rainPosition, DustID.Torch, rainVelocity, 0, Color.OrangeRed * progress, Main.rand.NextFloat(0.5f, 1.5f) * progress ); dust.noGravity = false; dust.fadeIn = 0.5f; dust.color = Color.Lerp(Color.OrangeRed, Color.Yellow, Main.rand.NextFloat(0.5f)); dust.customData = new FireRainData { InitialPosition = rainPosition, CreationTime = Main.GameUpdateCount }; } private void UpdateFireRain() { for (int i = 0; i < Main.maxDust; i++) { Dust dust = Main.dust[i]; if (dust.active && dust.type == DustID.Torch && dust.customData is FireRainData data) { if (Main.GameUpdateCount - data.CreationTime > FireRainLifetime) { dust.active = false; continue; } Vector2 nextPosition = dust.position + dust.velocity; if (IsTileCollision(nextPosition)) { dust.scale *= 0.9f; dust.velocity = Vector2.Zero; if (dust.scale < 0.1f) dust.active = false; } if (dust.position.Y > data.InitialPosition.Y + 300) dust.active = false; } } } private bool IsTileCollision(Vector2 position) { Point tileCoords = position.ToTileCoordinates(); return Helpers.SolidTile(tileCoords.X, tileCoords.Y); } private void DamageEnemy(Vector2 position, bool dealDamage) { for (int i = 0; i < Main.maxNPCs; i++) { NPC npc = Main.npc[i]; if (npc.active && !npc.friendly && npc.Bottom.Y > position.Y && Math.Abs(npc.Center.X - position.X) < 100f && Math.Abs(npc.Center.Y - position.Y) < 100f) { npc.AddBuff(BuffID.OnFire, 60); if (dealDamage) { npc.StrikeNPC(new NPC.HitInfo { Damage = Main.rand.Next(21, 30), Knockback = 0, HitDirection = npc.direction, Crit = false, DamageType = DamageClass.Default }); } } } } private class FireRainData { public Vector2 InitialPosition; public uint CreationTime; } }}
after unequiping the accessory, I can still double jump once, I dont want that, after unequiping it should stop
- Assistant
The issue you're experiencing is due to the
canDoubleJumpflag not being reset when the accessory is unequipped. When you unequip the accessory,hasFireJumpbecomesfalsein theResetEffects()method, butcanDoubleJumpremainstrueif it was set before unequipping. This allows for one more double jump even after the accessory is removed.To fix this, you need to reset the
canDoubleJumpflag when the accessory is unequipped. You can do this by addingcanDoubleJump = false;to yourResetEffects()method. Here's how you can modify your code:public override void ResetEffects() { hasFireJump = false; canDoubleJump = false; // Reset canDoubleJump when effects are reset }By setting
canDoubleJumptofalseinResetEffects(), you ensure that the player cannot double jump after the accessory is removed. This method is called every game tick to reset modded effects, so it's the appropriate place to reset any flags that depend on equipped items or buffs.After making this change, the double jump ability will be properly disabled upon unequipping the accessory, and the player won't be able to perform an extra double jump.
Summary:
Add
canDoubleJump = false;to theResetEffects()method to reset the double jump ability when the accessory is unequipped.