I'm getting this error when I re-enable the "Auto-EMP" after disabling it: Uncaught…
- User
I'm getting this error when I re-enable the "Auto-EMP" after disabling it:
Uncaught TypeError: Cannot read properties of undefined (reading 'push')
It still works though, still doing the EMP automatically. However, it's not drawing the red outline anymore...
code: // ==UserScript== // @name ZTweak - ZType Mod Menu // @namespace http://tampermonkey.net/ // @version 1.0 // @description Mod Menu with various mods // @author YSSF // @match https://zty.pe/* // @grant none // ==/UserScript==
(() => { 'use strict';
// Create the menu container const menu = document.createElement('div'); menu.id = 'custom-debug-menu'; menu.innerHTML = ` <div id="debug-menu-header"> <span title="Made by YSSF">ZTweak</span> <button id="debug-menu-toggle" title="Minimize">−</button> </div> <div id="debug-menu-content"> <label class="switch" title="Ships will crash upon contact, but you will remain unscathed"> <input type="checkbox" id="invincible"> <span class="slider"></span> <span class="label-text">Invincible</span> </label> <label class="switch" title="Gives you unlimited EMPs"> <input type="checkbox" id="unlimitedEmps"> <span class="slider"></span> <span class="label-text">Unlimited EMPs</span> </label> <label class="switch" title="Automatically shoots enemies"> <input type="checkbox" id="autoShoot"> <span class="slider"></span> <span class="label-text">Auto-Shoot</span> </label> <label class="switch" title="Allows you to move freely using arrow keys"> <input type="checkbox" id="moveFreely"> <span class="slider"></span> <span class="label-text">Free Movement</span> </label> <label class="switch" title="Freezing temperatures can immobilize ships, providing an opportunity for thinking or a break"> <input type="checkbox" id="freezeShips"> <span class="slider"></span> <span class="label-text">Freeze Ships</span> </label> <label class="switch" title="A red circle is drawn around the player, which triggers an automatic EMP usage when a ship enters it"> <input type="checkbox" id="autoEmp"> <span class="slider"></span> <span class="label-text">Auto-EMP</span> </label> </div> `; document.body.appendChild(menu); let empsInterval; let backupKill; let autoShootInterval; let originalPlayerUpdate; let playerMovementsTimeout; let originalPlayerDraw; let autoEmpTimeout; let mods = { unlimitedEmps() { empsInterval = setInterval(() => { ig.game.emps = 3; }, 100); }, __unlimitedEmps() { clearInterval(empsInterval); }, invincible() { backupKill = EntityPlayer.prototype.kill; EntityPlayer.prototype.kill = () => {}; }, __invincible() { EntityPlayer.prototype.kill = backupKill; }, autoShoot() { autoShootEnemies(); autoShootInterval = setInterval(() => { autoShootEnemies(); }, 1000); }, __autoShoot() { clearInterval(autoShootInterval); }, moveFreely() { playerMovements(); }, __moveFreely() { removePlayerUpdateMod('moveFreelyMod'); }, freezeShips() { // Store the original update method of EntityEnemy this.originalUpdate = EntityEnemy.prototype.update; // Override the update method of EntityEnemy to prevent movement EntityEnemy.prototype.update = function () { // Skip movement updates by not calling the original update method if (this.currentAnim) { this.currentAnim.update(); } }; // Stop all enemy movement let entities = ig.game.entities; for (let i = 0; i < entities.length; i++) { let ent = entities[i]; if (ent instanceof EntityEnemy) { ent.vel.x = 0; ent.vel.y = 0; } } }, __freezeShips() { // Restore the original update method to allow movement again EntityEnemy.prototype.update = this.originalUpdate; // Allow all enemies to resume movement let entities = ig.game.entities; for (let i = 0; i < entities.length; i++) { let ent = entities[i]; if (ent instanceof EntityEnemy) { ent.vel.x = ent.originalVel.x; ent.vel.y = ent.originalVel.y; } } }, autoEmp() { setupAutoEmp(); }, __autoEmp() { removePlayerUpdateMod('autoEmpMod'); removePlayerDrawMod('autoEmpDrawMod'); } }; function getAllEnemyWords() { let enemies = []; for (let i = 0; i < ig.game.entities.length; i++) { let ent = ig.game.entities[i]; if (ent instanceof EntityEnemy && !ent._killed) { enemies.push({ entity: ent, word: ent.remainingWord }); } } return enemies; } function autoShootEnemies() { let enemies = getAllEnemyWords(); for (let i = 0; i < enemies.length; i++) { let word = enemies[i].word; for (let j = 0; j < word.length; j++) { let letter = word[j]; ig.game.bufferedLetters.push(letter); } } ig.game.shootBufferedLetters(); } // Utility function to initialize the mod system for update and draw methods function initPlayerModSystem() { if (ig && ig.game && ig.game.player) { let player = ig.game.player; // Initialize update mods if (!player._updateMods) { player._updateMods = []; player._originalUpdate = player.update; player.update = function() { // Call the original update method this._originalUpdate(); // Call all update mods for (let i = 0; i < this._updateMods.length; i++) { this._updateMods[i].call(this); } }; } // Initialize draw mods if (!player._drawMods) { player._drawMods = []; player._originalDraw = player.draw; player.draw = function() { // Call the original draw method this._originalDraw(); // Call all draw mods for (let i = 0; i < this._drawMods.length; i++) { this._drawMods[i].call(this); } }; } } else { setTimeout(initPlayerModSystem, 100); } } // Call the initialization function initPlayerModSystem(); function playerMovements() { if (ig && ig.game && ig.game.player) { let player = ig.game.player; // Add the move freely mod to the update mods player._updateMods.push(function moveFreelyMod() { // Movement speed let speed = 200; // Check for movement input if (ig.input.state('left')) { this.pos.x -= speed * ig.system.tick; } if (ig.input.state('right')) { this.pos.x += speed * ig.system.tick; } if (ig.input.state('up')) { this.pos.y -= speed * ig.system.tick; } if (ig.input.state('down')) { this.pos.y += speed * ig.system.tick; } // Prevent the player from moving off-screen this.pos.x = this.pos.x.limit(0, ig.system.width - this.size.x); let maxY = ig.system.height - this.size.y; if (ig.game.keyboard && ig.game.keyboard.height && ig.game.keyboard.drawScale) { maxY -= ig.game.keyboard.height * ig.game.keyboard.drawScale; } this.pos.y = this.pos.y.limit(0, maxY); }); // Save reference to the mod function for removal mods.moveFreelyMod = player._updateMods[player._updateMods.length - 1]; } } function setupAutoEmp() { if (ig && ig.game && ig.game.player) { let player = ig.game.player; // Add the auto-EMP mod to the update mods player._updateMods.push(function autoEmpMod() { // Initialize empActivated flag if not present if (typeof this.empActivated === 'undefined') { this.empActivated = false; } // Check if we have any EMPs left if (ig.game.emps > 0) { // Get all entities (enemies) in the game let entities = ig.game.entities; // Get the player's position let playerPos = { x: this.pos.x + this.size.x / 2, y: this.pos.y + this.size.y / 2 }; // Flag to check if any enemy is in radius let enemyInRadius = false; // Loop through all entities for (let i = 0; i < entities.length; i++) { let ent = entities[i]; // Check if it's an enemy entity if (ent instanceof EntityEnemy) { // Calculate the distance to the enemy let enemyPos = { x: ent.pos.x + ent.size.x / 2, y: ent.pos.y + ent.size.y / 2 }; let dx = enemyPos.x - playerPos.x; let dy = enemyPos.y - playerPos.y; let distance = Math.sqrt(dx * dx + dy * dy); // Define the radius let radius = 50; // If the enemy is within the radius if (distance <= radius) { enemyInRadius = true; if (!this.empActivated) { // Activate EMP this.spawnEMP(); // Set the flag to prevent further EMPs until enemy is no longer in radius this.empActivated = true; } // Exit the loop after detecting the first enemy in radius break; } } } // If no enemy is in radius, reset empActivated flag if (!enemyInRadius) { this.empActivated = false; } } else { // Reset the flag if no EMPs are left this.empActivated = false; } }); // Save reference to the mod function for removal mods.autoEmpMod = player._updateMods[player._updateMods.length - 1]; // Add the circle drawing mod to the draw mods player._drawMods.push(function autoEmpDrawMod() { // Get the canvas context let ctx = ig.system.context; // Save the current drawing state ctx.save(); // Set the outline style ctx.strokeStyle = "red"; ctx.lineWidth = 2; // Calculate the player's center position on the screen let x = this.pos.x - ig.game._rscreen.x + this.size.x / 2; let y = this.pos.y - ig.game._rscreen.y + this.size.y / 2; // Define the radius let radius = 50; // Draw a circle around the player ctx.beginPath(); ctx.arc(x, y, radius, 0, 2 * Math.PI); ctx.stroke(); // Restore the previous drawing state ctx.restore(); }); // Save reference to the draw mod function for removal mods.autoEmpDrawMod = player._drawMods[player._drawMods.length - 1]; } else { // If player is not yet available, try again shortly setTimeout(setupAutoEmp, 100); } } // Function to remove a mod from update mods function removePlayerUpdateMod(modName) { if (ig && ig.game && ig.game.player && mods[modName]) { let player = ig.game.player; let index = player._updateMods.indexOf(mods[modName]); if (index > -1) { player._updateMods.splice(index, 1); } // If no more mods, restore original update if (player._updateMods.length === 0) { player.update = player._originalUpdate; delete player._originalUpdate; delete player._updateMods; } delete mods[modName]; } } // Function to remove a mod from draw mods function removePlayerDrawMod(modName) { if (ig && ig.game && ig.game.player && mods[modName]) { let player = ig.game.player; let index = player._drawMods.indexOf(mods[modName]); if (index > -1) { player._drawMods.splice(index, 1); } // If no more mods, restore original draw if (player._drawMods.length === 0) { player.draw = player._originalDraw; delete player._originalDraw; delete player._drawMods; } delete mods[modName]; } } menu.querySelectorAll('.switch input').forEach(checkbox => { checkbox.addEventListener('change', () => { if (checkbox.checked) { mods[checkbox.id](); } else { mods[`__${checkbox.id}`](); } }); }); // Add styles const styles = document.createElement('style'); styles.innerHTML = ` #custom-debug-menu { position: fixed; top: 100px; left: 100px; width: 200px; background-color: #333; color: #fff; border: 1px solid #555; z-index: 9999999; box-shadow: 0 2px 10px rgba(0,0,0,0.2); border-radius: 8px; overflow: hidden; user-select: none; font-family: Arial, sans-serif; } #debug-menu-header { background-color: #444; color: #fff; padding: 10px; cursor: move; display: flex; justify-content: space-between; align-items: center; } #debug-menu-header span { font-weight: bold; } #debug-menu-header button { background: none; color: #fff; border: none; font-size: 18px; cursor: pointer; } #debug-menu-content { padding: 10px; overflow: hidden; transition: max-height 0.3s ease, opacity 0.3s ease, padding 0.3s ease; max-height: 1000px; opacity: 1; } .switch { display: flex; align-items: center; margin-bottom: 10px; } .switch:last-child { margin-bottom: 0; } .switch input { display: none; } .slider { position: relative; width: 40px; height: 20px; background-color: #666; border-radius: 20px; margin-right: 10px; transition: background-color 0.3s; cursor: pointer; } .slider::before { content: ""; position: absolute; width: 16px; height: 16px; left: 2px; top: 2px; background-color: #fff; border-radius: 50%; transition: transform 0.3s; } input:checked + .slider { background-color: #2196F3; } input:checked + .slider::before { transform: translateX(20px); } .label-text { flex-grow: 1; color: #fff; } `; document.head.appendChild(styles); // Make the menu draggable dragElement(menu); function dragElement(el) { const header = document.getElementById('debug-menu-header'); let posX = 0, posY = 0, mouseX = 0, mouseY = 0; if (header) { header.onmousedown = dragMouseDown; } else { el.onmousedown = dragMouseDown; } function dragMouseDown(e) { e = e || window.event; e.preventDefault(); mouseX = e.clientX; mouseY = e.clientY; document.onmouseup = closeDragElement; document.onmousemove = elementDrag; } function elementDrag(e) { e = e || window.event; e.preventDefault(); posX = mouseX - e.clientX; posY = mouseY - e.clientY; mouseX = e.clientX; mouseY = e.clientY; // Calculate new position let newTop = el.offsetTop - posY; let newLeft = el.offsetLeft - posX; // Get viewport dimensions const viewportWidth = window.innerWidth; const viewportHeight = window.innerHeight; // Limit the menu within the viewport if (newTop < 0) newTop = 0; // Top boundary if (newLeft < 0) newLeft = 0; // Left boundary if (newTop + el.offsetHeight > viewportHeight) { newTop = viewportHeight - el.offsetHeight; // Bottom boundary } if (newLeft + el.offsetWidth > viewportWidth) { newLeft = viewportWidth - el.offsetWidth; // Right boundary } // Set the new position el.style.top = newTop + 'px'; el.style.left = newLeft + 'px'; } function closeDragElement() { document.onmouseup = null; document.onmousemove = null; } } // Set initial maxHeight of content const content = document.getElementById('debug-menu-content'); content.style.maxHeight = content.scrollHeight + 'px'; // Minimize/Restore functionality with transitions const toggleButton = document.getElementById('debug-menu-toggle'); let isMinimized = false; toggleButton.addEventListener('click', () => { if (isMinimized) { // Restore content.style.maxHeight = content.scrollHeight + 'px'; content.style.opacity = '1'; content.style.padding = '10px'; toggleButton.innerHTML = '−'; toggleButton.title = 'Minimize'; isMinimized = false; } else { // Minimize content.style.maxHeight = '0px'; content.style.opacity = '0'; content.style.padding = '0px'; toggleButton.innerHTML = '+'; toggleButton.title = 'Restore'; isMinimized = true; } });})();
- Assistant
The error you're encountering occurs because after disabling the "Auto-EMP" mod, the
player._updateModsandplayer._drawModsarrays (along with the corresponding original methods) are being deleted if they become empty. Then, when you try to re-enable the mod, these arrays don't exist anymore, leading to the error when you attempt to push to them.To fix this issue, you should avoid deleting
player._updateMods,player._drawMods,player._originalUpdate, andplayer._originalDraweven if they are empty. This way, when you re-enable the mod, these properties still exist, and you can push new mods into the arrays without encountering an error.Here's how you can modify your
removePlayerUpdateModandremovePlayerDrawModfunctions:Update
removePlayerUpdateModFunction:function removePlayerUpdateMod(modName) { if (ig && ig.game && ig.game.player && mods[modName]) { let player = ig.game.player; let index = player._updateMods.indexOf(mods[modName]); if (index > -1) { player._updateMods.splice(index, 1); } // Do NOT delete player._updateMods or player._originalUpdate // This ensures they remain available when re-enabling mods delete mods[modName]; } }Update
removePlayerDrawModFunction:function removePlayerDrawMod(modName) { if (ig && ig.game && ig.game.player && mods[modName]) { let player = ig.game.player; let index = player._drawMods.indexOf(mods[modName]); if (index > -1) { player._drawMods.splice(index, 1); } // Do NOT delete player._drawMods or player._originalDraw // This ensures they remain available when re-enabling mods delete mods[modName]; } }Explanation:
-
Why Not Delete Empty Mod Arrays?
By keepingplayer._updateModsandplayer._drawModsintact (even when they're empty), you ensure that they are always available for mods to be added or removed. Deleting them causes the issue you've encountered because when you re-enable a mod, the arrays no longer exist, and pushing toundefinedresults in the error. -
Leaving the Original Methods Intact:
Similarly, you should not deleteplayer._originalUpdateandplayer._originalDraw. Keeping these ensures that the player's update and draw methods remain overridden to call the mods (even if there are none), and the original methods are preserved.
Additional Notes:
-
Empty Mod Arrays Are Acceptable:
Having empty mod arrays (player._updateModsandplayer._drawMods) is fine. The overriddenupdateanddrawmethods will simply loop over an empty array, which doesn't cause any issues. -
Ensuring Mod System Robustness:
This change makes your mod system more robust, allowing mods to be enabled and disabled without issues, regardless of the order or how many times they are toggled.
After Making These Changes:
- Test toggling the "Auto-EMP" mod on and off multiple times.
- Verify that the error no longer occurs.
- Ensure that the red outline is drawn correctly every time the mod is enabled.
- Check other mods to make sure they still function as expected.
Why This Fix Works:
By preventing the deletion of the mod-related properties on the player object, you ensure that the mod system remains in a consistent state. This avoids errors related to undefined properties and allows your mods to be toggled without issues.
Let me know if you have any questions or need further assistance!
-