private string ConvertBuffRecordsToString(List<BuffRecord> buffRecords) { StringBuilder…
- User
private string ConvertBuffRecordsToString(List buffRecords) { StringBuilder sb = new StringBuilder();
var keywords = GameConfiguration.keywordsInfo.keywords; foreach (var record in buffRecords) { if (record.keywordTypes.Count > 0) { foreach (var keywordType in record.keywordTypes) { if (buffKeyWordDic.TryGetValue(keywordType, out string keywordName)) { sb.AppendLine($"{record.buffName}: {keywordName}"); } else { // 从keywords列表中查找与record.keywordType匹配的KeywordInfo var keywordInfo = keywords.Find(k => k.keywordType == keywordType); // 使用找到的name替换原来的keywordType if (keywordInfo != null) { sb.AppendLine($"{record.buffName}: {keywordInfo.name}"); buffKeyWordDic.Add(keywordType, keywordInfo.name); } else { sb.AppendLine($"{record.buffName}: {keywordType}"); buffKeyWordDic.Add(keywordType, keywordType.ToString()); } } } } else { sb.AppendLine($"{record.buffName}: "); } if (!record.attack.Equals( GameAttribute.Zero)) { if (record.attack > GameAttribute.Zero) { sb.Append($"+{record.attack.Value.intValue}"); } else { sb.Append($"{record.attack.Value.intValue}"); } } if (!record.health.Equals( GameAttribute.Zero)) { if (record.health > GameAttribute.Zero) { sb.Append($"/+{record.health.Value.intValue}"); } else { sb.Append($"/{record.health.Value.intValue}"); } } } return sb.ToString(); } 帮忙优化代码,只有第一个keywordtype才加上record.buffName - Assistant
Certainly! Below is an optimized version of the
ConvertBuffRecordsToStringfunction, which only attachesrecord.buffNameto the firstkeywordTypeand improves the code organization:private string ConvertBuffRecordsToString(List<BuffRecord> buffRecords) { StringBuilder sb = new StringBuilder(); var keywords = GameConfiguration.keywordsInfo.keywords; foreach (var record in buffRecords) { bool firstKeywordProcessed = false; foreach (var keywordType in record.keywordTypes) { string keywordDisplayName = GetKeywordDisplayName(keywordType, keywords); if (!firstKeywordProcessed) { sb.AppendLine($"{record.buffName}: {keywordDisplayName}"); firstKeywordProcessed = true; } else { sb.AppendLine($": {keywordDisplayName}"); } } if (record.keywordTypes.Count == 0) { sb.AppendLine($"{record.buffName}: "); } AppendAttributes(sb, record); } return sb.ToString(); } private string GetKeywordDisplayName(int keywordType, List<KeywordInfo> keywords) { if (buffKeyWordDic.TryGetValue(keywordType, out string keywordName)) { return keywordName; } var keywordInfo = keywords.Find(k => k.keywordType == keywordType); keywordName = keywordInfo != null ? keywordInfo.name : keywordType.ToString(); buffKeyWordDic[keywordType] = keywordName; return keywordName; } private void AppendAttributes(StringBuilder sb, BuffRecord record) { if (!record.attack.Equals(GameAttribute.Zero)) { sb.Append(record.attack > GameAttribute.Zero ? $"+{record.attack.Value.intValue}" : $"{record.attack.Value.intValue}"); } if (!record.health.Equals(GameAttribute.Zero)) { sb.Append(record.health > GameAttribute.Zero ? $"/+{record.health.Value.intValue}" : $"/{record.health.Value.intValue}"); } }Key Optimizations:
-
Separated Logic: Extracted the keyword display name retrieval into a separate method
GetKeywordDisplayName, improving code readability and reducing repetition. -
Attributes Handling: Moved the logic for appending attributes like attack and health to a separate method
AppendAttributes. -
Conditional Keyword Name Addition: Used a boolean flag
firstKeywordProcessedto ensurebuffNameis only coupled with the first keyword type.
This version enhances the code readability, maintains functionality, and organizes repeated operations neatly into helper methods.
-