extends Control var teams = [] var players = [] var teamrosters = {} var unpickedplayers…
- User
extends Control
var teams = [] var players = [] var team_rosters = {} var unpicked_players = []
@onready var generate_button = TransferMarketButton @onready var view_team_button = SimulateButton
func _ready(): generate_button.connect("pressed", Callable(self, "_on_generate_button_pressed")) transfer_market_button.connect("pressed", Callable(self, "_on_transfer_market_button_pressed")) view_team_button.connect("pressed", Callable(self, "_on_view_team_button_pressed")) simulate_button.connect("pressed", Callable(self, "_on_simulate_button_pressed"))
func load_teams_from_file(filename: String): teams.clear() var file = FileAccess.open(filename, FileAccess.READ) if file: while not file.eof_reached(): var line = file.get_line() var parts = line.split(":") if parts.size() == 3: var team_name = parts[0].strip_edges() var transfer_budget = parts[1].strip_edges().replace("m", "").to_float() var formation = parts[2].strip_edges() var team = load("res://Team.gd").new(team_name, transfer_budget, formation) teams.append(team) else: print("Error opening file:", filename)
func load_players_from_file(filename: String): players.clear() var file = FileAccess.open(filename, FileAccess.READ) if file: while not file.eof_reached(): var line = file.get_line() var parts = line.split(":") if parts.size() == 4: var player_name = parts[0].strip_edges() var player_position = parts[1].strip_edges() var transfer_price = parts[2].strip_edges().replace("m", "").to_int() var rating = parts[3].strip_edges().to_int() var player = load("res://Player.gd").new(player_name, player_position, transfer_price, rating) players.append(player)
func _on_generate_button_pressed(): load_players_from_file("res://Players2.txt") generate_rosters() display_rosters()
func generate_rosters(): team_rosters.clear() unpicked_players = players.duplicate() for team in teams: var roster = [] var has_gk = false for i in range(13): if unpicked_players.size() > 0: var index = randi() % unpicked_players.size() var player = unpicked_players[index] if player.position == "GK" and has_gk: continue if player.position == "GK": has_gk = true roster.append(player) unpicked_players.remove(index) team_rosters[team.name] = roster display_unpicked_players()
func display_rosters(): var roster_text = "" for team_name in team_rosters.keys(): roster_text += team_name + ":\n" for player in team_rosters[team_name]: roster_text += player.name + " (" + player.position + "), Rating: " + str(player.rating) + "\n" roster_text += "\n" $Roster.text = roster_text
func display_unpicked_players(): var unpicked_text = "Unpicked Players:\n" for player in unpicked_players: unpicked_text += player.name + " (" + player.position + "), Rating: " + str(player.rating) + "\n" $UnpickedPlayers.text = unpicked_text when i press generate all players show up in unpicked
- Assistant
It seems you're facing an issue where all players appear under "Unpicked Players" instead of being assigned to teams. This behavior could result from a few potential issues in your logic for generating rosters or displaying the players. Here's a step-by-step method to debug and fix the problem:
Step-by-Step Debugging and Fixing:
-
Ensure all necessary files are correctly loaded:
- Check if the Players2.txt file correctly contains the player data.
- Ensure that the
load_players_from_filefunction is correctly parsing and creating player objects.
-
Check the correct assignment of players to teams in
generate_rostersfunction:- Confirm that players are being removed from
unpicked_playersonce they are added to a team roster.
- Confirm that players are being removed from
-
Review the display logic:
- Ensure that the function
display_rosterscorrectly reflects the state ofteam_rosters.
- Ensure that the function
Debugging the Code:
Here's a modified version of your script with debug print statements to help track the state of variables during execution:
extends Control var teams = [] var players = [] var team_rosters = {} var unpicked_players = [] @onready var generate_button = $GenerateButton @onready var transfer_market_button = $TransferMarketButton @onready var view_team_button = $ViewTeamButton @onready var simulate_button = $SimulateButton func _ready(): generate_button.connect("pressed", Callable(self, "_on_generate_button_pressed")) transfer_market_button.connect("pressed", Callable(self, "_on_transfer_market_button_pressed")) view_team_button.connect("pressed", Callable(self, "_on_view_team_button_pressed")) simulate_button.connect("pressed", Callable(self, "_on_simulate_button_pressed")) func load_teams_from_file(filename: String): teams.clear() var file = FileAccess.open(filename, FileAccess.READ) if file: while not file.eof_reached(): var line = file.get_line() var parts = line.split(":") if parts.size() == 3: var team_name = parts[0].strip_edges() var transfer_budget = parts[1].strip_edges().replace("m", "").to_float() var formation = parts[2].strip_edges() var team = load("res://Team.gd").new(team_name, transfer_budget, formation) teams.append(team) else: print("Error opening file:", filename) func load_players_from_file(filename: String): players.clear() var file = FileAccess.open(filename, FileAccess.READ) if file: while not file.eof_reached(): var line = file.get_line() var parts = line.split(":") if parts.size() == 4: var player_name = parts[0].strip_edges() var player_position = parts[1].strip_edges() var transfer_price = parts[2].strip_edges().replace("m", "").to_int() var rating = parts[3].strip_edges().to_int() var player = load("res://Player.gd").new(player_name, player_position, transfer_price, rating) players.append(player) print("Loaded players: ", players.size()) # Debug statement func _on_generate_button_pressed(): load_players_from_file("res://Players2.txt") generate_rosters() display_rosters() func generate_rosters(): team_rosters.clear() unpicked_players = players.duplicate() for team in teams: var roster = [] var has_gk = false var attempts = 0 # Debug statement while len(roster) < 13 and attempts < 100: # Adding a cap to prevent infinite loops if unpicked_players.size() == 0: break var index = randi() % unpicked_players.size() var player = unpicked_players[index] print("Attempting to add player: ", player.name) # Debug statement attempts += 1 # Debug statement if player.position == "GK" and has_gk: continue if player.position == "GK": has_gk = true roster.append(player) unpicked_players.remove(index) attempts = 0 # reset attempts if a player is successfully added team_rosters[team.name] = roster display_unpicked_players() func display_rosters(): var roster_text = "" for team_name in team_rosters.keys(): roster_text += team_name + ":\n" for player in team_rosters[team_name]: roster_text += player.name + " (" + player.position + "), Rating: " + str(player.rating) + "\n" roster_text += "\n" print("Displaying rosters:") # Debug statement print(roster_text) # Debug statement $Roster.text = roster_text func display_unpicked_players(): var unpicked_text = "Unpicked Players:\n" for player in unpicked_players: unpicked_text += player.name + " (" + player.position + "), Rating: " + str(player.rating) + "\n" print("Unpicked Players:") # Debug statement print(unpicked_text) # Debug statement $UnpickedPlayers.text = unpicked_textPoints to Consider:
- Debugging Statements: The added print statements help follow the logic's flow and see where things might go wrong.
- Infinite Loop Prevention: The while loop now has an additional
attemptsvariable to prevent the loop from running indefinitely, which might happen if there are no suitable players to pick. - Ensure the Game Files are Correct: Double-check the structure of the files
Players2.txtandTeam.gdto ensure that they are formatted correctly.
With these modifications, you should be able to pinpoint where the issue lies. Remember to look at the Godot output console to see the debug messages. This will help you determine if the rosters are being generated correctly and if the player assignments are being made as expected.
-