I need some coding help. The serial generation works in this UI // // SerialView.swift…
- User
I need some coding help. The serial generation works in this UI // // SerialView.swift // Foxtronic // //
import SwiftUI
struct SerialView: View { @Environment(.presentationMode) private var presentationMode
@State var selectedDevice: Device = .MacBookAir @State var selectedModel: Model? = nil @State var generatedSerial = "" @State var isSerialTapped = false @State var showModelNumber = false @State var showModelIdentifier = true @State private var clipboardConfirmationShown = false @State private var seadmed = Seadmed() @State private var isEditing = false @EnvironmentObject var serialHistory: SerialHistory @State private var selectedSerialForQR: String? @State private var isQRSheetPresented = false @State private var numberOfSerials: Double = 1 func copyToClipboard(_ text: String) { let pasteboard = NSPasteboard.general pasteboard.clearContents() pasteboard.setString(text, forType: .string) clipboardConfirmationShown = true // Clear generated serials after copying generatedSerial = "" // Dismiss the confirmation after a delay DispatchQueue.main.asyncAfter(deadline: .now() + 2) { clipboardConfirmationShown = false } } // Function to determine the label for the copy button private func copyButtonLabel() -> String { let serialCount = generatedSerial.components(separatedBy: "\n").filter { !$0.isEmpty }.count return serialCount > 1 ? "Kopeeri seerianumbrid" : "Kopeeri seerianumber" } var body: some View { Form { Section(header: VStack(alignment:.leading) { Text("Intel seerianumbrite genereerimine") Text("Seerianumbrid on unikaalsed identifikaatorid, mida kasutatakse seadme autentimiseks ja jälgimiseks. Seerianumbrite generaator loob macOS seadmetele päris seerianumbrid, mis vastavad Apple standarditele.") .font(.callout) .foregroundStyle(.secondary) }){ Picker("Seade:", selection: $selectedDevice) { ForEach(Seadmed.allDevices, id: \.self) { device in Text(device.rawValue) .foregroundColor(selectedDevice == device ? .primary : .secondary) } } .pickerStyle(.segmented) Toggle(isOn: $showModelNumber) { Label("Näita mudeli numbrit", systemImage: "text.badge.checkmark") .symbolRenderingMode(.multicolor) } Toggle(isOn: $showModelIdentifier) { Label("Näita mudeli identifikaatorit", systemImage: "barcode.viewfinder") .symbolRenderingMode(.multicolor) } } Section("Mudeli valik") { List(Seadmed.saadavadMudelid(for: selectedDevice), id: \.self, selection: $selectedModel) { model in ModelItemView(model: model, showModelNumber: showModelNumber, showModelIdentifier: showModelIdentifier) } } Section("Genereeritud seerianumber") { LabeledContent("Seerianumber:") { if clipboardConfirmationShown { Label("Seerianumber kopeeritud lõikelauale!", systemImage: "checkmark.circle") .foregroundColor(.green) } else { Text(generatedSerial) } } HStack { Button("Genereeri seerianumber") { generateSerialNumber() } .controlSize(.large) .disabled(selectedModel == nil) .buttonStyle(.borderedProminent) Button(copyButtonLabel()) { if !generatedSerial.isEmpty { copyToClipboard(generatedSerial) } } .controlSize(.large) .buttonStyle(.bordered) .disabled(generatedSerial.isEmpty) } } Text("Palun veendu, et need genereeritud seerianumbrid ei oleks pilve- ega MDM lukus [siin](https://backend.replace.tech/CheckMend).") .font(.callout) .foregroundStyle(.secondary) } .sheet(isPresented: $isQRSheetPresented) { if let selectedSerial = selectedSerialForQR { QRCodeSheet(serial: selectedSerial) } } .formStyle(.grouped) .navigationTitle("Seerianumbrite generaator") .navigationSubtitle("Genereeri Intel seadmete seerianumbreid") .navigationBarBackButtonHidden(false) } private func generateSerialNumber() { guard let modelIdentifier = selectedModel?.identifier else { generatedSerial = "Palun vali mudel" isSerialTapped = false return } if let serialsString = SendCommand(modelIdentifier: modelIdentifier, numberOfSerials: Int(numberOfSerials)) { let serialsArray = serialsString.components(separatedBy: .newlines).filter { !$0.isEmpty } generatedSerial = serialsArray.joined(separator: "\n") isSerialTapped = true // Show the QR code sheet only if a single serial is generated if serialsArray.count == 1 { selectedSerialForQR = serialsArray.first isQRSheetPresented = true } for serial in serialsArray { serialHistory.addRecord(serial: serial, model: selectedModel!) } } else { generatedSerial = "Viga seerianumbrite genereerimisel" isSerialTapped = false } }}
struct ModelItemView: View { var model: Model var showModelNumber: Bool var showModelIdentifier: Bool
var body: some View { HStack { VStack(alignment: .leading) { Text(model.name) if showModelNumber { Text(model.identifier) .font(.subheadline) .foregroundStyle(.secondary) } } Spacer() VStack(alignment: .trailing) { if showModelIdentifier { Text(model.modelNumber) .font(.subheadline) .foregroundStyle(.secondary) } } } .padding(.vertical, 10.0 ) }}
#Preview { SerialView() }
But not in this UI, the second picker remains empty, even if i choose one of the models :
// // QuickSNCard.swift // Foxtronic // //
import SwiftUI
struct QuickSNCard: View { @Environment(.presentationMode) private var presentationMode @EnvironmentObject var serialHistory: SerialHistory
@State var selectedDevice: Device = .MacBookAir @State var selectedModel: Model? = nil @State var generatedSerial = "" @State var isQRSheetPresented = false @State var selectedSerialForQR: String? var headerUsesNavigationLink: Bool = false var navigation: TruckCardHeaderNavigation = .navigationLink var body: some View { VStack(alignment: .leading) { CardNavigationHeader(panel: .serial, navigation: navigation) { Label("Genereeri kiirelt", systemImage: "wand.and.stars") } Form { Section(header: Text("Vali seade ja mudel")) { Picker("Seade:", selection: $selectedDevice) { ForEach(Seadmed.allDevices, id: \.self) { device in Text(device.rawValue) } } .pickerStyle(.menu) Picker("Mudel:", selection: $selectedModel) { ForEach(Seadmed.saadavadMudelid(for: selectedDevice), id: \.self) { model in Text(model.name) } } } Section("Genereeritud seerianumber") { LabeledContent("Seerianumber:") { Text(generatedSerial) } Button("Genereeri seerianumber") { generateSerialNumber() } .controlSize(.large) .disabled(selectedModel == nil) .buttonStyle(.borderedProminent) } } .sheet(isPresented: $isQRSheetPresented) { if let selectedSerial = selectedSerialForQR { QRCodeSheet(serial: selectedSerial) } } .formStyle(.grouped) .scrollContentBackground(.hidden) } .padding(10) .clipShape(ContainerRelativeShape()) .background() } private func generateSerialNumber() { guard let modelIdentifier = selectedModel?.identifier else { generatedSerial = "Palun vali mudel" return } if let serial = SendCommand(modelIdentifier: modelIdentifier, numberOfSerials: 1) { generatedSerial = serial selectedSerialForQR = serial isQRSheetPresented = true serialHistory.addRecord(serial: serial, model: selectedModel!) } else { generatedSerial = "Viga seerianumbrite genereerimisel" } }}
#Preview { QuickSNCard() }
- Assistant
From the code provided, if your
QuickSNCardview's model picker remains empty even after a device is selected, it suggests an issue with the population of models for the selected device. Since yourSerialViewworks as expected, the logic and data handling in both should be similar. The issue may arise from howSeadmed.saadavadMudelid(for: selectedDevice)fetches data or how theselectedModelis being handled.Potential Issues and Fixes:
-
Check Data Flow for Models Ensure that
Seadmed.saadavadMudelid(for: selectedDevice)correctly returns models for anyselectedDevice. It might be helpful to print the output ofSeadmed.saadavadMudelid(for: selectedDevice)right before it's used in thePickerto confirm it's not empty and correctly reflects the selected device. -
Picker Binding and Data Source Ensure that the binding to
selectedModelis correctly updating. If theselectedModeldoes not update or if the models returned bySeadmed.saadavadMudelid(for: selectedDevice)do not change whenselectedDevicechanges, the picker won't update. To diagnose, you could add a.onChange(of: selectedDevice)modifier to the devicePickerto print something to the console or to attempt refreshing the model picker.Example:
Picker("Seade:", selection: $selectedDevice) { ForEach(Seadmed.allDevices, id: \.self) { device in Text(device.rawValue) } } .pickerStyle(.menu) .onChange(of: selectedDevice) { _ in // Debug or force refresh logic here print("Device changed to \(selectedDevice.rawValue)") self.selectedModel = nil // Reset the selected model } -
Check Conditional UI Logic If there's any logic that conditionally shows the model picker based on the selected device or other conditions, ensure those conditions are being met as expected. Misplaced conditionals can easily hide UI elements unintentionally.
-
Model Selection and Update Lifecycle SwiftUI relies on its state and binding system to update views. Ensure that the model's state change propagates correctly. The way SwiftUI renders views means it sometimes needs explicit notifications to refresh data or views, like using
@Publishedin ObservableObjects or explicitly setting state variables in closures where changes occur. -
Debugging State Changes Use
printstatements or breakpoints to trace the state changes of both device and model selections. This can help identify if and when theselectedModelvariable changes unexpectedly or if changes toselectedDevicedo not trigger updates as intended.
If after these checks your issue still persists, consider isolating the problem by creating a simplified version of the picker update logic in a new project. Sometimes, other parts of the code or SwiftUI's sometimes finicky rendering might interfere with expected behaviors, and isolating the problem can help identify overlooked issues.
-