unity 的协程在执行后会自动stop嘛
- User
unity 的协程在执行后会自动stop嘛
- Assistant
Unity中的协程(Coroutine)是一种特殊的函数执行方式,它允许你在一个函数中暂停执行,并在下一个帧或一段时间后自动继续执行。当你使用
StartCoroutine方法启动一个协程时,它并不会在执行完成后自动停止,而是一直执行到协程函数结束。协程通常会在以下几种情况下停止执行:
-
协程函数执行到底:当协程中的代码执行完毕,即到达协程函数的末尾时,协程会自然结束。
IEnumerator MyCoroutine(){ // Do something yield return null; // 暂停一帧 // Do more stuff }上面这个例子中,当"Do more stuff"代码执行完毕后,协程会停止执行。
-
遇到
yield break:你可以使用yield break来提前退出协程。IEnumerator MyCoroutine(){ while(true){ // Do something if(someCondition){ yield break; // 提前退出协程 } yield return null; } }当
someCondition为真时,协程会提前退出。 -
使用
StopCoroutine或StopAllCoroutines方法:你可以在协程外部显式地停止协程。Coroutine myCoroutine = StartCoroutine(MyCoroutine()); // ... StopCoroutine(myCoroutine); // 停止特定协程 StopAllCoroutines(); // 停止当前MonoBehaviour上的所有协程 -
MonoBehaviour被销毁:如果协程所在的游戏对象(GameObject)或它的组件(MonoBehaviour)被销毁,所有该组件上的协程都会停止。
void OnDestroy(){ StopAllCoroutines(); // 在组件销毁时停止所有协程 }
因此,如果你希望控制协程的结束,必须在协程内部使用一些逻辑控制它的终止,或者在协程外部停止它。协程不会因为自动执行完毕而自行停止,但一旦到达协程函数的最末端,它自然就结束了。
-
- User
StopCoroutine(m_autoSkipCoroutine) 后 m_autoSkipCoroutine 会是空吗
- Assistant
不会。在Unity中,当你调用
StopCoroutine并传入一个Coroutine变量来停止该协程时,传入的变量m_autoSkipCoroutine本身不会被设置为null。StopCoroutine只是告诉Unity停止执行这个协程,但并不改变该变量的值。m_autoSkipCoroutine是一个对协程执行过程的引用,即使协程已经被停止,该变量仍然会保持对它原有引用的值,直到你显式地将它设置为null或者赋予一个新的协程引用。如果你希望在停止协程后显式地清空这个变量,你应当手动地将它设置为
null,像这样:Coroutine m_autoSkipCoroutine = StartCoroutine(MyCoroutine()); // 在某个时刻停止协程 StopCoroutine(m_autoSkipCoroutine); // 手动将引用设置为null m_autoSkipCoroutine = null;这样就确保了
m_autoSkipCoroutine变量不再持有对已停止协程的任何引用,并且如果你尝试对该变量再次调用StopCoroutine,它将不会做任何事,因为它已经是null。 - User
foreach (var text in m_costTexts) { text.text = $"{cardObject.GetCost().Value.Value.Num}"; if (cardObject.GetOriginAttribute().Cost < cardObject.MetaAttribute.Cost) { text.color = Color.green; } else if (cardObject.GetOriginAttribute().Cost > cardObject.MetaAttribute.Cost) { text.color = Color.red; } else { text.color = Color.white; } } 这段代码可以怎么优化一下
- Assistant
这段代码看起来是在更新一组文本标签
m_costTexts,以显示某个cardObject对象的成本,并根据成本相比原始成本的变化来改变文本颜色。这段代码在每次迭代中多次调用了cardObject.GetCost()和cardObject.GetOriginAttribute(),这些调用可能比较昂贵,特别是如果它们涉及到计算或者数据访问的话。为了优化,你可以先计算并存储这些值,然后在循环中使用它们,避免重复调用。这样做将降低每次迭代的计算成本。此外,如果color的赋值逻辑不会太频繁地变化,你可以考虑缓存Color实例以避免重复创建新的Color对象。
这里是代码优化后的示例:
// 计算并存储需要的值 int currentCost = cardObject.GetCost().Value.Value.Num; int originalCost = cardObject.GetOriginAttribute().Cost; int metaCost = cardObject.MetaAttribute.Cost; Color costIncreasedColor = Color.red; Color costReducedColor = Color.green; Color costNeutralColor = Color.white; foreach (var text in m_costTexts) { // 直接使用预先计算好的值更新文本 text.text = currentCost.ToString(); // 只做一次颜色的比较判断 if (originalCost < metaCost) { text.color = costReducedColor; // 成本降低 } else if (originalCost > metaCost) { text.color = costIncreasedColor; // 成本增加 } else { text.color = costNeutralColor; // 成本无变化 } }在优化的代码中,我们只调用了一次
GetCost()和GetOriginAttribute(),并且提前缓存了颜色值,这样循环中的每次迭代都会更快。如果Color.green,Color.red和Color.white是直接访问的预定义颜色,那么它们不需要缓存,因为它们不会创建新的对象。在这种情况下,将颜色值赋给本地变量的做法纯粹是为了代码可读性和可能的微小性能提升。代码的性能以及优化的必要性与实际情况紧密相关。如果
GetCost()和GetOriginAttribute()都是轻量级的getter函数,那么优化可能没有太大必要。但如果它们包含复杂计算或者调用成本高昂,那么上述优化会有很大帮助。 - User
private void Refresh(object eventData = null) { RePosition(); // 墓地卡牌均显示背面 if (cardObject.GetCardPosition().CardPositionType == CardPositionTypes.GraveDeck) { m_cardBack.SetActive(true); return; }
// 反制阶段的卡都是正面 if (cardObject.GetCardPosition().CardPositionType == CardPositionTypes.CPChain) { m_cardBack.SetActive(false); } } 请帮忙优化一下这段代码 - Assistant
在这段代码中,主要的性能考虑是减少
GetCardPosition()方法的调用次数,因为它在函数内被调用了两次。此外,SetActive方法只需要根据条件设置一次。下面是优化后的代码:private void Refresh(object eventData = null) { RePosition(); // 缓存CardPositionType,避免重复获取 CardPositionTypes cardPositionType = cardObject.GetCardPosition().CardPositionType; if (cardPositionType == CardPositionTypes.GraveDeck) { // 墓地卡牌均显示背面,然后返回,因为不需要额外操作 m_cardBack.SetActive(true); return; } // 反制阶段的卡都是正面 m_cardBack.SetActive(cardPositionType != CardPositionTypes.CPChain); }在优化后的代码中,我先取得了
cardPositionType变量的值并存储起来,这样在后续判断时只需使用这个变量。这避免了调用GetCardPosition()两次带来的性能损耗。此外,我将
SetActive的调用简化为一个单独的表达式,这样就无需使用额外的if语句。如果cardPositionType等于CardPositionTypes.CPChain,则SetActive将会被设置为false(因为卡牌应该显示正面)。否则会根据墓地卡牌的条件前面已经设置为true并返回了,所以其他情况下SetActive将保持false。总体而言,这个优化保持了原有代码的逻辑,并简化了条件分支,也减少了可能的重复方法调用。
- User
using System; using System.Collections; using System.Collections.Generic; using System.Linq; using CGGame; using CGGame.Animation; using CGGame.GameData.Cards; using CGGame.Textures; using CGGame.UI; using DG.Tweening; using TMPro; using UnityEngine; using UnityEngine.Rendering;
namespace CardGameDisplayer { public class CardDisplayer : ActorDisplayerBehaviour, IMovable, IScalable, IColorable { const string ShaderEffectColor = "_EffectColor"; const string ShaderInteractionColor = "_InteractionColor"; const string ShaderRareColor = "_RareColor";
const string TargetMarkColor = "_Color"; const string AnimatorSelectParameterName = "_Select"; const string AnimatorDeSelectParameterName = "_DeSelect"; const string AnimatorPlacingParameterName = "_Placing"; const string AnimatorPlacedParameterName = "_Placed"; public CardTooltip cardTooltip; public Card cardObject => GetActorObject<Card>(); protected Player Player => GameMode.GetActorObject(cardObject.GetOwnerPlayer()); public CardPositionTypes currType => cardObject.GetCardPosition().CardPositionType; private bool m_manualPositioning; private bool m_isDrawingCard; private Vector3 m_targetMoveToPos; protected bool shouldLerpPos = true; [SerializeField] private Renderer targetMark; [SerializeField] private Renderer[] m_cardRenders; [SerializeField] private Renderer[] m_cardFaceRenders; [SerializeField] protected GameObject InteractBackground; [SerializeField] protected GameObject CostEngoughBackground; //可以释放的范围 [SerializeField] protected GameObject PostionIsScopeMaskBackground; [SerializeField] protected GameObject m_cardBack; [SerializeField] protected Dragable m_dragable; [SerializeField] protected TextMeshPro m_targetText; [SerializeField] private TextMeshPro m_blockText; [SerializeField] protected Renderer effectRender; [SerializeField] protected Canvas canvas; [SerializeField] protected Canvas cdCanvas; [SerializeField] protected Material defaultCardMaterial; [SerializeField] protected TextMeshPro[] m_costTexts; private Vector3 currentPosition => transform.position; public bool IsSelected { private set; get; } public override void SetCardData(BaseCard card) { base.SetCardData(card); m_blockText.gameObject.SetActive(card.IsBlocked); foreach (var text in m_costTexts) { text.text = $"{card.Cost}"; } } /// <summary> /// Is pointer over? /// </summary> private bool isInteracted; public bool IsCosEnough => cardObject.GetCost() <= GameMode.GetActorObject(cardObject.GetOwnerPlayer()).GetPlayerCost(); public bool IsShowingCardBack => m_cardBack != null && m_cardBack.activeSelf; public bool IsLocalPlayer => GameDisplayer.GetPlayerPositionType(cardObject.GetOwnerPlayer()) == PlayerPositionTypes.Local; /// <summary> /// Is the card dead? /// </summary> protected bool IsInGraveyard => cardObject.GetCardPosition().CardPositionType == CardPositionTypes.GraveDeck; /// <summary> /// Is the card in hand? /// </summary> protected bool IsInCardDeck => cardObject.GetCardPosition().CardPositionType == CardPositionTypes.CardDeck; /// <summary> /// Is the card in hand? /// </summary> protected bool IsInHand => cardObject.GetCardPosition().CardPositionType == CardPositionTypes.HandCardDeck; /// <summary> /// Is the card in trapField? /// </summary> protected bool IsInTrapfield => cardObject.GetCardPosition().CardPositionType == CardPositionTypes.TrapField; private AnimationQuery tooltipTimerAnimation; [Tooltip ("How much time user need to focus on the card to see the tooltip.")] [SerializeField] private float tooltipOpenTimeDistance = 1.5f; /// <summary> /// Current animation query (CardGame.Animation) of the card. /// </summary> public AnimationQuery CurrentAnimation; [SerializeField] private CardColorAnimationData colorAnimationData; private AnimationQuery interactColorAnimation; SortingGroup CardGroup => GetComponent<SortingGroup>(); int oriGroup; public bool ManualPositioning { get { return m_manualPositioning; } set { m_manualPositioning = value; } } #region Draw Card private void OnAfterCardDrew(object eventData) { if (!GameDisplayer.IsLocalPlayer(cardObject.GetOwnerPlayer())) { return; } StartCoroutine(DrawCardRoutine()); } private IEnumerator DrawCardRoutine() { Player playerObject = GameMode.GetActorObject(cardObject.GetOwnerPlayer()); Transform midTR; GameDisplayer.m_drawCardMidPoses.TryGetValue(playerObject.GetPlayerPosition(), out midTR); m_isDrawingCard = true; yield return transform.DOMove(midTR.position, 1.0f) .SetEase(Ease.InOutQuad) .WaitForCompletion(); yield return new WaitForSeconds(0.5f); m_isDrawingCard = false; } #endregion #region Redraw [SerializeField] private GameObject m_redrawIcon; private void OnAfterClickCard() { ActorRef<Card> card = GetActor<Card>(); if (GameMode.GetIsInDrawCardPhase()) { if (GameDisplayer.CardInRedrawList(card)) { GameDisplayer.RemoveCardFromRedrawList(card); } else { GameDisplayer.AddCardToRedrawList(card); } } } private void RefreshRedrawIcon() { bool displayer = true; if (!GameMode.GetIsInDrawCardPhase()) { displayer = false; } else { displayer = GameDisplayer.CardInRedrawList(GetActor<Card>()); } if (m_redrawIcon != null) { m_redrawIcon.SetActive(displayer); } } #endregion private void RePosition() { if (ManualPositioning || m_isDrawingCard || GameDisplayer == null || GameDisplayer.IsDuringOpeningAnimation) { return; } // Debug.Log("RePosition isInteracted" + isInteracted); var card = GetActor<Card>(); var pos = GameDisplayer.GetCardDisplayerPos(card); m_targetMoveToPos = GetRealPosition(pos); } protected override void OnDisPlayerStart() { canvas.worldCamera = Camera.main; if (cdCanvas) { cdCanvas.worldCamera = Camera.main; cdCanvas.sortingLayerName = "CDMask"; } GameMode.Register(ActorID, CGEventNames.OnAfterCardPositionChanged, Refresh); GameMode.Register(ActorID, CGEventNames.OnAfterDrawCard, OnAfterCardDrew); Refresh(); m_dragable.m_onPrematureEnd.AddListener(OnAfterClickCard); m_dragable.m_onPrematureStart.AddListener(OnInteractWithCard); // GetComponent<Dragable>().m_onDragStart.AddListener(OnDragStart); m_dragable.m_onDrag.AddListener(OnDrag); m_dragable.m_onDragStart.AddListener(OnDragStart); GameDisplayer.OnAfterCardsToRedrawChanged += RefreshRedrawIcon; GameMode.OnAfterIsInDrawCardPhaseChanged += RefreshRedrawIcon; RefreshRedrawIcon(); cardTooltip.UpdateTooltip(cardObject); cardObject.OnAfterAttributeChanged += HandelOnAfterAttributeChanged; oriGroup = CardGroup.sortingLayerID; } public virtual void LoadDefaultMaterial() { foreach (var render in m_cardRenders.Where(r => r.GetComponent<SpriteRenderer>() != null)) { render.GetComponent<SpriteRenderer>().material = defaultCardMaterial; render.GetComponent<SpriteRenderer>().sortingLayerName = "Default"; } foreach (var render in m_cardFaceRenders.Where(r => r.GetComponent<SpriteRenderer>() != null)) { render.GetComponent<SpriteRenderer>().material = defaultCardMaterial; render.GetComponent<SpriteRenderer>().sortingLayerName = "Default"; } } protected virtual void OnDrag() { if (GameMode.GetIsInCounterPhase()) { if (cardObject.GetCardType() == CardTypes.MinionCard) { GameMode.OnPlayerCounterMinionCardWarning?.Invoke(); }else if (cardObject.GetCardType() == CardTypes.TrapCard) { GameMode.OnPlayerCounterTrapCardWarning?.Invoke(); } } cardTooltip.Set(false); } protected virtual void OnDragStart() { var newPosition = currentPosition; newPosition.z = -3f; SetPosition(newPosition); shouldLerpPos = false; cardTooltip.Set(false); } // protected virtual void OnDragEnd(bool canceled) // { // shouldLerpPos = true; // } private void OnInteractWithCard() { cardTooltip.Set(false); } protected override void OnAfterGameTicked() { base.OnAfterGameTicked(); if (IsLocalPlayer) { RefreshLocalDisplay(); } else { RefreshOppoDisplay(); } if (GameMode.GetIsInCounterPhase()) { if (cardObject.GetCardPosition().CardPositionType == CardPositionTypes.CPChain || cardObject.GetCardPosition().CardPositionType == CardPositionTypes.TrapField && cardObject.GetIsDeployed()) { if (CardGroup.sortingLayerID == oriGroup) { CardGroup.sortingLayerName = "Player"; } } } else { CardGroup.sortingLayerID = oriGroup; m_targetText.gameObject.SetActive(false); } // 计算并存储需要的值 int currentCost = cardObject.GetCost().Value.Value.Num; PlayerCost originalCost = cardObject.GetOriginAttribute().Cost; PlayerCost metaCost = cardObject.MetaAttribute.Cost; foreach (var text in m_costTexts) { text.text = $"{currentCost}"; if (originalCost < metaCost) { text.color = Color.green; } else if (originalCost > metaCost) { text.color = Color.red; } else { text.color = Color.white; } } } private void Refresh(object eventData = null) { RePosition(); // 缓存CardPositionType,避免重复获取 CardPositionTypes cardPositionType = cardObject.GetCardPosition().CardPositionType; if (cardPositionType == CardPositionTypes.GraveDeck) { // 墓地卡牌均显示背面,然后返回,因为不需要额外操作 m_cardBack.SetActive(true); return; } // 反制阶段的卡都是正面 m_cardBack.SetActive(cardPositionType != CardPositionTypes.CPChain); } protected virtual void RefreshLocalDisplay() { switch (cardObject.GetCardPosition().CardPositionType) { case CardPositionTypes.Null: CostEngoughBackground.SetActive(false); PostionIsScopeMaskBackground.SetActive(false); m_cardBack.SetActive(true); break; case CardPositionTypes.CardDeck: CostEngoughBackground.SetActive(false); PostionIsScopeMaskBackground.SetActive(false); if (GameMode.GetIsInDrawCardPhase()) { if (GameMode.GetActorObject(cardObject.GetOwnerPlayer()).DrewCards .Exists(card => card.IsSameWith(GetActor<Card>()))) { m_cardBack.SetActive(false); CardGroup.sortingLayerName = "SpecialPhase"; CardGroup.sortingOrder = 1; } else { m_cardBack.SetActive(true); } } else { m_cardBack.SetActive(true); } /*var flag = GameMode.GetIsInDrawCardPhase() && GameDisplayer.IsDuringOpeningAnimation; m_cardBack.SetActive(!flag);*/ break; case CardPositionTypes.GraveDeck: CostEngoughBackground.SetActive(false); PostionIsScopeMaskBackground.SetActive(false); m_cardBack.SetActive(false); break; case CardPositionTypes.HandCardDeck: m_cardBack.SetActive(false); CostEngoughBackground.SetActive(IsCosEnough); break; case CardPositionTypes.BattleField: m_cardBack.SetActive(false); CostEngoughBackground.SetActive(false); PostionIsScopeMaskBackground.SetActive(false); break; case CardPositionTypes.TrapField: m_cardBack.SetActive(false); CostEngoughBackground.SetActive(false); PostionIsScopeMaskBackground.SetActive(false); break; case CardPositionTypes.CPChain: m_cardBack.SetActive(false); CostEngoughBackground.SetActive(false); PostionIsScopeMaskBackground.SetActive(false); break; default: throw new ArgumentOutOfRangeException(); } } protected virtual void RefreshOppoDisplay() { // 反制阶段的卡都是正面 if (cardObject.GetCardPosition().CardPositionType == CardPositionTypes.CPChain) { m_cardBack.SetActive(false); } else if (cardObject.GetCardPosition().CardPositionType == CardPositionTypes.BattleField) { m_cardBack.SetActive(cardObject.HasEffect(CardKeyWordType.Ambush)); } else if (cardObject.GetCardPosition().CardPositionType == CardPositionTypes.GraveDeck) { m_cardBack.SetActive(false); } else { m_cardBack.SetActive(true); } m_dragable.CanDrag = GameMode.IsPvP; } protected virtual void OnEnterHandDeck() { m_dragable.CanDrag = true; } protected virtual void OnExitHandDeck() { m_dragable.CanDrag = false; } private void Update() { RePosition(); if (GameDisplayer && shouldLerpPos) { transform.position = Vector3.Lerp(transform.position, m_targetMoveToPos, 0.05f); } } protected bool HasValidTarget() { TrapField trapField = cardObject.Game.GetTrapFieldObject(Player.GetPlayerPosition()); TrapField oppositeTrapField = cardObject.Game.GetTrapFieldObject(GameMode.GetOppositePlayerPosition(Player.GetPlayerPosition())); BattleField battleField = cardObject.Game.GetBattleFieldObject(Player.GetPlayerPosition()); BattleField oppositeBattleField = cardObject.Game.GetBattleFieldObject(GameMode.GetOppositePlayerPosition(Player.GetPlayerPosition())); List<Effect> battleCryEffects = cardObject.GetCardAllNeedSelectedTargetEffects(); foreach (var triggerEffect in battleCryEffects.SelectMany(e => e.triggerEffects)) { // 如果效果包含英雄则有效目标 bool containsHero = triggerEffect.targetType.HasFlag(TargetType.Hero); if (containsHero) { return true; } // 不包含英雄目标则判断陷阱目标 bool hasValidTrapTarget = HasValidTrapTarget(triggerEffect, trapField, oppositeTrapField); if (hasValidTrapTarget) { return true; } bool hasValidMinionTarget = HasValidMinionTarget(triggerEffect, battleField, oppositeBattleField); if (hasValidMinionTarget) { return true; } } return false; } /** * 判断是否有有效的陷阱卡目标 */ private bool HasValidTrapTarget(TriggerEffect triggerEffect, TrapField trapField, TrapField oppositeTrapField) { bool containsTrap = triggerEffect.targetType.HasFlag(TargetType.Trap); if (containsTrap) { bool isOwnSide = triggerEffect.targetType.HasFlag(TargetType.OwnSide); if (isOwnSide) { return trapField.GetCards().Any(); } bool isOppositeSide = triggerEffect.targetType.HasFlag(TargetType.OppositeSide); if (isOppositeSide) { return oppositeTrapField.GetCards().Any(); } return trapField.GetCards().Any() || oppositeTrapField.GetCards().Any(); } return false; } /** * 是否有有效的随从目标 */ private bool HasValidMinionTarget(TriggerEffect triggerEffect, BattleField battleField, BattleField oppositeBattleField) { bool containsMinion = triggerEffect.targetType.HasFlag(TargetType.Minion); if (containsMinion) { bool isOwnSide = triggerEffect.targetType.HasFlag(TargetType.OwnSide); if (isOwnSide) { return battleField.GetCards().Any(); } bool isOppositeSide = triggerEffect.targetType.HasFlag(TargetType.OppositeSide); if (isOppositeSide) { return oppositeBattleField.GetCards().Any(); } return battleField.GetCards().Any() || oppositeBattleField.GetCards().Any(); } return false; } public virtual void UpdateCardImage(string avatar) { BaseTexture baseTexture; baseTexture = TextureCollectionReader.AcquireTexture(avatar); foreach (var render in m_cardRenders) { baseTexture?.SetMaterial(ShaderTextureName, render, 255); } } public virtual void UpdateCardFaceImage(CardTypes cardtype, FaceRankTypes faceRankType) { var cardface = cardtype.ToString() + faceRankType; var baseTexture = TextureCollectionReader.AcquireTexture(cardface); foreach (var render in m_cardFaceRenders) { baseTexture?.SetMaterial(ShaderTextureName, render, 255); } } protected void HandelOnAfterAttributeChanged() { } public Vector3 GetScale() { return transform.localScale; } public void SetScale(Vector3 scale) { //localScale *= scale; transform.localScale = scale; } public Vector3 GetPosition() { return transform.position; } public Quaternion GetRotation() { return transform.rotation; } public void SetPosition(Vector3 targetPosition) { transform.position = targetPosition; } /// <summary> /// This card being dragged on the given position. /// </summary> /// <param name="position"></param> public void SetDragging(Vector3 position) { SetPosition(position); // SetPosition(position + cardDraggingOffsets.PositionOffset); // SetRotation(Quaternion.Euler (cardDraggingOffsets.EulerAngles)); } public void SetRotation(Quaternion targetRotation) { transform.rotation = targetRotation; } public void SetColor(string colorName, Color color) { // if (Application.isPlaying) { // cardRenderer.material.SetVector(colorName, color); // } else { // cardRenderer.sharedMaterial.SetVector(colorName, color); // } } /// <summary> /// User is interesting on this card. /// </summary> /// <param name="value"></param> public void Interested(bool value, bool animateColor = true) { if (IsInGraveyard) { value = false; } if (IsInCardDeck) { value = false; } if (!IsLocalPlayer && IsShowingCardBack) { value = false; } //拖拽过程中不能显示 if (m_dragable.Interacting) { value = false; } if (m_dragable.IsDraging) { value = false; } // tooltip timer. if (tooltipTimerAnimation != null) { tooltipTimerAnimation.Stop(); } if (value) { tooltipTimerAnimation = new AnimationQuery(); tooltipTimerAnimation.AddToQuery(new TimerAction(tooltipOpenTimeDistance)); tooltipTimerAnimation.Start(this, () => { if (isInteracted && !m_dragable.Interacting) { // still interacted, show tooltip. tooltipTimerAnimation = null; cardTooltip.Set(true); //向上移动10个像素 使用SetPosition() if (IsInHand) { if (cardObject.GetCardType() == CardTypes.MinionCard) { shouldLerpPos = true; } else { shouldLerpPos = false; } SetPosition(transform.position + new Vector3(0, 2.5f, -1.5f)); } } }); } else { cardTooltip.Set(false); if (IsInHand) { shouldLerpPos = true; SetPosition(transform.position); } // SetScale(((new Vector3(1, 1, 1)))); } isInteracted = value; // // if (animateColor) { // // color animation. // if (interactColorAnimation != null) { // interactColorAnimation.StopWithInstantFinish(); // } // // interactColorAnimation = new AnimationQuery(); // interactColorAnimation.AddToQuery(new ColorAction(this, // ShaderInteractionColor, // colorAnimationData.interactionColorSpeed, // value ? colorAnimationData.interactionGradient : colorAnimationData.interactionEndGradient, // colorAnimationData.interactionColorIntensity)); // // interactColorAnimation.Start(this, () => { // interactColorAnimation = null; // }); // } } public void Select() { // Selected(true); } public void Selected(bool value, bool playEffect = true) { if (IsInGraveyard) return; IsSelected = value; // if (playEffect) { // cardAnimator.SetTrigger(value ? AnimatorSelectParameterName : AnimatorDeSelectParameterName); // } } }} 这是一个卡牌显示的类,请帮忙优化一下
- Assistant
由于给出的代码内容较多,并包含了很多与UI显示和游戏逻辑相关的操作,我将添加一些一般性的优化建议。对于具体性能提升,可能还需要针对特定环境和需求进一步进行测量和调优。
下面是一些通用的优化建议:
-
减少每帧调用的计算量:
- 缓存值以避免重复计算。例如,多次调用
cardObject.GetCardPosition().CardPositionType可以被优化为一次赋值给局部变量后使用该变量。 - 避免在
Update方法中进行重复和繁琐的计算。
- 缓存值以避免重复计算。例如,多次调用
-
利用Unity生命周期的高效使用:
- 避免在
Update函数中进行不必要的判断,例如,GameDisplayer和shouldLerpPos在某些情况下可能不需要每帧检查。
- 避免在
-
缓存Component引用:
- 在
Start或Awake方法中获取并缓存组件引用,如GetComponent调用,以避免频繁的搜索操作。
- 在
-
合理使用
Coroutine:- 对于延时执行或插值操作,使用
Coroutine,但避免启动过多无用的Coroutine,因为它们会占用内存直到结束。例如,在OnAfterCardDrew函数中只有在满足条件GameDisplayer.IsLocalPlayer(cardObject.GetOwnerPlayer())时才启动协程。
- 对于延时执行或插值操作,使用
-
优化事件监听器:
- 避免不必要的或重复的事件注册和注销。
- 如果事件不会频繁发生,考虑将其更改为轮询方式。
-
优化渲染层次结构:
- 如有可能,降低复杂的组件层次结构。
- 在设置渲染器属性时避免不必要的重复调用(如
SetActive)。
-
精简冗余代码:
- 移除代码中未使用的变量和函数。
- 减少重复代码,通过封装函数来共享逻辑。
-
代码逻辑简化:
- 在
RePosition方法中的代码逻辑,如果if条件之间的操作有重复的部分,考虑合并逻辑。 - 将经常一起改变状态的对象组织到一起,作统一处理。
- 在
还有一些代码细节侧的改进:
RefreshRedrawIcon方法中的变量displayer显然是一个拼写错误,应为display。- 一些函数名和变量名有拼写错误或可能会引起混淆,例如
HandelOnAfterAttributeChanged(可能是HandleOnAfterAttributeChanged的意思) - 注释应始终保持更新且准确,以免造成误解。
针对实际性能瓶颈进行优化时,请务必利用Unity的Profiler工具来识别哪些方法或操作消耗了最多的时间。这样可以确保优化的努力放在了正确的地方。
-