Why doesn't the following register implementation work? here's app.py import os from…
- User
Why doesn't the following register implementation work? here's app.py import os
from cs50 import SQL from flask import Flask, flash, redirect, render_template, request, session from flask_session import Session from werkzeug.security import check_password_hash, generate_password_hash
from helpers import apology, login_required, lookup, usd
Configure application
app = Flask(name)
Custom filter
app.jinja_env.filters["usd"] = usd
Configure session to use filesystem (instead of signed cookies)
app.config["SESSION_PERMANENT"] = False app.config["SESSION_TYPE"] = "filesystem" Session(app)
Configure CS50 Library to use SQLite database
db = SQL("sqlite:///finance.db")
@app.after_request def after_request(response): """Ensure responses aren't cached""" response.headers["Cache-Control"] = "no-cache, no-store, must-revalidate" response.headers["Expires"] = 0 response.headers["Pragma"] = "no-cache" return response
@app.route("/") @login_required def index(): """Show portfolio of stocks""" return apology("TODO")
@app.route("/buy", methods=["GET", "POST"]) @login_required def buy(): """Buy shares of stock""" return apology("TODO")
@app.route("/history") @login_required def history(): """Show history of transactions""" return apology("TODO")
@app.route("/login", methods=["GET", "POST"]) def login(): """Log user in"""
# Forget any user_id session.clear() # User reached route via POST (as by submitting a form via POST) if request.method == "POST": # Ensure username was submitted if not request.form.get("username"): return apology("must provide username", 403) # Ensure password was submitted elif not request.form.get("password"): return apology("must provide password", 403) # Query database for username rows = db.execute("SELECT * FROM users WHERE username = ?", request.form.get("username")) # Ensure username exists and password is correct if len(rows) != 1 or not check_password_hash(rows[0]["hash"], request.form.get("password")): return apology("invalid username and/or password", 403) # Remember which user has logged in session["user_id"] = rows[0]["id"] # Redirect user to home page return redirect("/") # User reached route via GET (as by clicking a link or via redirect) else: return render_template("login.html")@app.route("/logout") def logout(): """Log user out"""
# Forget any user_id session.clear() # Redirect user to login form return redirect("/")@app.route("/quote", methods=["GET", "POST"]) @login_required def quote(): """Get stock quote.""" return apology("TODO")
@app.route("/register", methods=["GET", "POST"]) def register():
# Forget any user_id session.clear() # User reached route via POST (as by submitting a form via POST) if request.method == "POST": # Ensure username was submitted if not request.form.get("username"): return apology("must provide username", 403) # Ensure password was submitted elif not request.form.get("password"): return apology("must provide password", 403) # Query database for username username = request.form.get("username") rows = db.execute("SELECT * FROM users WHERE username = :username", {"username": username}).fetchone() # revised line with proper syntax and parameters if rows: return apology("username already exists", 403) # Hash user’s password hashed_password = generate_password_hash(request.form.get("password")) # Insert new user into the database db.execute("INSERT INTO users (username, password) VALUES (:username, :password)", {"username": username, "password": hashed_password}) db.commit() # Redirect user to login page or some other page flash("Registered successfully, please log in.") return redirect("/login") # Assuming there is a login view else: # User reached route via GET return render_template("register.html") # Assuming there is a 'register.html' template@app.route("/sell", methods=["GET", "POST"]) @login_required def sell(): """Sell shares of stock""" return apology("TODO")
And here's register.html {% extends "layout.html" %}
{% block title %} Register {% endblock %}
{% block main %} Log In {% endblock %}
- Assistant
The register implementation has the right idea, but there are some issues in your code. I'll provide some guidance on what might be causing it not to work as expected:
-
Table Column Name: In your
db.execute("INSERT INTO ...")statement, you are using the column namepassword, but in the login section, you are referencing a column namedhash. This inconsistency will cause problems as you are trying to insert into a column that might not exist, or you're looking for the wrong column on login. Ensure that the column names match and are consistent in your database schema. -
Database Transaction Commit: You're using the
CS50library'sSQLclass, which handles commits automatically. Therefore, you should not usedb.commit(). You only need to execute thedb.executestatement for insertion. Remove thedb.commit()line. -
Button Text: On the register page (
register.html), the button text says "Log In" when it should say "Register". This might be confusing to users. Change the button text to "Register". -
Password Confirmation: You don't currently have an input for password confirmation, which is a common practice in registration forms. It's typically used to ensure the user typed their intended password correctly.
Here's a revised version of your
/registerroute with the issues above addressed:@app.route("/register", methods=["GET", "POST"]) def register(): # Forget any user_id session.clear() # User reached route via POST (as by submitting a form via POST) if request.method == "POST": # Ensure username was submitted if not request.form.get("username"): return apology("must provide username", 403) # Ensure password was submitted elif not request.form.get("password"): return apology("must provide password", 403) # Query database for username username = request.form.get("username") rows = db.execute("SELECT * FROM users WHERE username = ?", username) # Use question mark placeholder for parameter substitution # Check if username already exists if rows: return apology("username already exists", 403) # Hash user’s password hashed_password = generate_password_hash(request.form.get("password")) # Insert new user into the database db.execute("INSERT INTO users (username, hash) VALUES (?, ?)", (username, hashed_password)) # Use the correct column name for the hash and replace placeholders accordingly # Redirect user to login page flash("Registered successfully, please log in.") return redirect("/login") else: # User reached route via GET return render_template("register.html")And in your
register.htmlform, you should modify the button text:<button class="btn btn-primary" type="submit">Register</button>Make sure to also consider adding a password confirmation field to your HTML form and check that both the password and confirmation match in your route logic before inserting the new user into the database.
-
- User
I'm getthing the RuntimeError: more placeholders (?, ?) than values
- Assistant
I apologize for the confusion. The CS50 SQL module uses a distinct placeholder format and passes the parameters as a dictionary, not as a tuple. When using the CS50 SQL module, the syntax should follow this pattern:
rows = db.execute("SELECT * FROM users WHERE username = :username", username=username) # ... db.execute("INSERT INTO users (username, hash) VALUES (:username, :hash)", username=username, hash=hashed_password)Here's the corrected version of your
/registerfunction:@app.route("/register", methods=["GET", "POST"]) def register(): # Forget any user_id session.clear() # User reached route via POST (as by submitting a form via POST) if request.method == "POST": # Ensure username was submitted if not request.form.get("username"): return apology("must provide username", 403) # Ensure password was submitted elif not request.form.get("password"): return apology("must provide password", 403) # Query database for username username = request.form.get("username") rows = db.execute("SELECT * FROM users WHERE username = :username", username=username) # :username is a named placeholder # Check if username already exists if rows: return apology("username already exists", 403) # Hash user’s password hashed_password = generate_password_hash(request.form.get("password")) # Insert new user into the database db.execute("INSERT INTO users (username, hash) VALUES (:username, :hash)", username=username, hash=hashed_password) # :username and :hash are named placeholders # Redirect user to login page flash("Registered successfully, please log in.") return redirect("/login") else: # User reached route via GET return render_template("register.html")This code uses named placeholders (
:usernameand:hash) in SQL statements with the corresponding parameters being passed todb.executeas part of a dictionary (username=username, hash=hashed_password). This approach matches the expected syntax of the CS50 SQL module and should resolve theRuntimeErroryou mentioned.Remember also to update the button text in your
register.htmlas mentioned in the previous response, and to ensure that the database schema infinance.dbhas a column namedhashto store the hashed password, notpassword.