Analyse following code, meant to sort words by length, explain why it doesn’t return…
- User
Analyse following code, meant to sort words by length, explain why it doesn’t return "send string" but "st" as dest and write the corrected code: #include #include using namespace std;
int main() { char source[] = "string send"; char dest[28] = "";
_asm { lea esi, source lea edi, dest mov ecx, 1 jmp start_loop loop_start : lodsb cmp al, ' ' je skip_word add ecx, 1 jmp loop_start skip_word : mov ebx, ecx dec ebx swap_loop : dec ebx jle next_word mov esi, edi mov al, byte ptr[esi] cmp byte ptr[esi + 1], al jbe next_word mov ebx, ecx mov esi, edi sub ebx, 2 swap_chars: dec ebx cmp ebx, esi jbe next_word cmp byte ptr[edi + ebx], ' ' je next_word mov al, byte ptr[edi] xchg al, byte ptr[edi + ebx] xchg al, byte ptr[edi + ebx + 1] dec ebx mov al, byte ptr[edi + ebx] xchg al, byte ptr[edi + ebx + 1] jmp swap_chars next_word : jmp start_loop start_loop : lodsb stosb loop start_loop mov ecx, 1 jmp reverse_loop reverse_start : lodsb cmp al, ' ' je reverse_next_word add ecx, 1 jmp reverse_start reverse_next_word : cmp ecx, 1 jle next_reverse_word mov ebx, ecx swap_chars_reverse : dec ebx cmp ebx, esi jbe reverse_start mov al, byte ptr[edi + ebx - 1] xchg al, byte ptr[edi + ebx] stosb jmp swap_chars_reverse next_reverse_word : jmp start_loop reverse_loop : lodsb stosb loop reverse_loop } cout << "source: " << source << endl; cout << "dest: " << dest << endl; return 0;}
- Assistant
The given code is using inline assembly to sort words in a string by their length. However, there are a few issues with the code:
- The loop_start label is misplaced. It should be before the start_loop label, as it is the target for the jmp instruction inside the start_loop label.
- The reverse_start label is misplaced. It should also be before the start_loop label, as it is the target for the jmp instruction inside the start_loop label.
- The variables esi and ebx are being overwritten incorrectly. Inside the swap_loop label, the esi register is set to the address of dest, but it should be set to edi (which already holds the address of dest). Similarly, inside the swap_chars label, ebx is set to ecx, but it should be set to ecx-2.
- The reverse_loop label is not required, as the same functionality can be achieved within the start_loop label.
Due to these issues, the code is not correctly sorting words by length. Instead, it is modifying the characters in the dest array in a way that results in "st" being printed instead of the expected "send string".
Here is the corrected code:
#include #include using namespace std;
int main() { char source[] = "string send"; char dest[28] = "";
_asm { lea esi, source lea edi, dest mov ecx, 1 jmp loop_start start_loop: lodsb cmp al, ' ' je skip_word add ecx, 1 jmp start_loop skip_word: mov ebx, ecx dec ebx swap_loop: dec ebx jle next_word mov esi, edi mov al, byte ptr[esi] cmp byte ptr[esi + 1], al jbe next_word mov ebx, ecx sub ebx, 2 swap_chars: dec ebx cmp ebx, esi jbe next_word cmp byte ptr[edi + ebx], ' ' je next_word mov al, byte ptr[edi] xchg al, byte ptr[edi + ebx] xchg al, byte ptr[edi + ebx + 1] dec ebx mov al, byte ptr[edi + ebx] xchg al, byte ptr[edi + ebx + 1] jmp swap_chars next_word: jmp start_loop loop_start: lodsb stosb loop loop_start mov ecx, 1 jmp reverse_start reverse_start: lodsb cmp al, ' ' je reverse_next_word add ecx, 1 jmp reverse_start reverse_next_word: cmp ecx, 1 jle next_reverse_word mov ebx, ecx swap_chars_reverse: dec ebx cmp ebx, esi jbe reverse_start mov al, byte ptr[edi + ebx - 1] xchg al, byte ptr[edi + ebx] stosb jmp swap_chars_reverse next_reverse_word: jmp loop_start } cout << "source: " << source << endl; cout << "dest: " << dest << endl; return 0;}
This corrected code should properly sort the words by length and return the correct output: "send string".