public async Task UpdateUserAsync1( SailplayCredentials credentials, UpdateUser…
- User
public async Task UpdateUserAsync1( SailplayCredentials credentials, UpdateUser requestData, CancellationToken cancellationToken) { var tokenResult = await this.authorisationExecutor.GetAuthorizationTokenAsync( credentials: credentials, cancellationToken: cancellationToken); var apiResponse = await Policy.HandleResult(apiResult => apiResult.IsAuthorizationTokenError) .RetryAsync( retryCount: 1, onRetryAsync: async (_, _, _) => { tokenResult = await this.authorisationExecutor.RenewAuthorizationTokenAsync( credentials: credentials, cancellationToken: cancellationToken); }) .ExecuteAsync( async () => await tokenResult .Match( onSuccess: async token => { var request = HttpRequestMessageFactory .BuildPost(ApiPath.UsersUpdate); var tokenFormData = FormDataFactory .FromToken(token.Token); var storeDepartmentIdFormData = FormDataFactory .FromStoreDepartmentId(credentials.StoreDepartmentId); var keyValuePairs = new List>() { tokenFormData, storeDepartmentIdFormData, }; keyValuePairs.AddRange(FormDataFactory.FromUserId(requestData.UserId)); requestData.Phone .MatchSome(phone => keyValuePairs.Add(FormDataFactory.FromNewPhone(phone))); requestData.Email .MatchSome(email => keyValuePairs.Add(FormDataFactory.FromNewEmail(email))); requestData.FirstName .MatchSome(firstName => keyValuePairs.Add(FormDataFactory.FromFirstName(firstName))); requestData.MiddleName .MatchSome(middleName => keyValuePairs.Add(FormDataFactory.FromMiddleName(middleName))); requestData.LastName .MatchSome(lastName => keyValuePairs.Add(FormDataFactory.FromLastName(lastName))); requestData.BirthDate .MatchSome(birthDate => keyValuePairs.Add(FormDataFactory.FromBirthDate(birthDate))); requestData.Sex .MatchSome(sex => keyValuePairs.Add(FormDataFactory.FromSex(sex))); requestData.RegisterDate .MatchSome( registerDate => keyValuePairs.Add(FormDataFactory.FromRegisterDate(registerDate))); request.Content = new FormUrlEncodedContent(keyValuePairs); return await this .requestExecutor.ExecuteApiRequestAsync( request: request, cancellationToken: cancellationToken, token: token.Token); }, onError: result => Task.FromResult( SailplayApiResult.FromError( statusCode: result.ErrorCode, message: result.Message)), onUnexpectedHttpStatusCode: result => Task.FromResult( SailplayApiResult.FromUnexpectedHttpStatusCode( httpStatusCode: result.StatusCode)))); return apiResponse.Match( onSuccess: UpdateUserResult.FromSuccess, onError: errorResult => errorResult.ErrorCode switch { ApiResponse.ErrorCodes.InvalidValue => UpdateUserResult.FromError( ErrorResult.FromInvalidValue( errorCode: errorResult.ErrorCode, message: errorResult.Message)), ApiResponse.ErrorCodes.UserNotFound => UpdateUserResult.FromError( ErrorResult.FromUserNotFound( errorCode: errorResult.ErrorCode, message: errorResult.Message)), ApiResponse.ErrorCodes.EmailIsUsed => UpdateUserResult.FromError( ErrorResult.FromEmailIsUsed( errorCode: errorResult.ErrorCode, message: errorResult.Message)), ApiResponse.ErrorCodes.PhoneIsUsed => UpdateUserResult.FromError( ErrorResult.FromPhoneIsUsed( errorCode: errorResult.ErrorCode, message: errorResult.Message)), _ => UpdateUserResult.FromError( ErrorResult.FromGeneralError( errorCode: errorResult.ErrorCode, message: errorResult.Message)), }, onUnexpectedHttpStatusCode: UpdateUserResult.FromUnexpectedHttpStatusCode); } namespace RetailRocket.Sailplay.HttpApi.Client.StrictClient { using System.Threading; using System.Threading.Tasks; using RetailRocket.Sailplay.HttpApi.Client.StrictClient.Ports; using RetailRocket.Sailplay.HttpApi.Client.ValueTypes; using RetailRocket.Sailplay.HttpApi.Client.ValueTypes.Results; internal class AuthorisationExecutor { private readonly ITokenProvider tokenProvider; public AuthorisationExecutor( ITokenProvider tokenProvider) { this.tokenProvider = tokenProvider; } public async Task GetAuthorizationTokenAsync( SailplayCredentials credentials, CancellationToken cancellationToken) { var tokenResult = await this.tokenProvider .GetTokenAsync( credentials: credentials, cancellationToken: cancellationToken); return tokenResult; } public async Task RenewAuthorizationTokenAsync( SailplayCredentials credentials, CancellationToken cancellationToken) { var tokenResult = await this.tokenProvider .RenewTokenAsync( credentials: credentials, cancellationToken: cancellationToken); return tokenResult; } } } namespace RetailRocket.Sailplay.HttpApi.Client.StrictClient { using System.Diagnostics; using System.Net; using System.Net.Http; using System.Net.Http.Json; using System.Threading; using System.Threading.Tasks; using RetailRocket.Sailplay.HttpApi.Client.StrictClient.Ports; using RetailRocket.Sailplay.HttpApi.Client.StrictClient.Responses; using RetailRocket.Sailplay.HttpApi.Client.ValueTypes.Results; internal class RequestExecutor : IRequestExecutor { private readonly IMetricsCollector metricsCollector; private readonly HttpClient httpClient; public RequestExecutor( IMetricsCollector metricsCollector, HttpClient httpClient) { this.metricsCollector = metricsCollector; this.httpClient = httpClient; } public async Task ExecuteApiRequestAsync( HttpRequestMessage request, CancellationToken cancellationToken, string token) { var stopwatch = Stopwatch.StartNew(); using var httpResponseMessage = await this .httpClient .SendAsync( request: request, cancellationToken: cancellationToken); this.metricsCollector.CollectHttpRequestDuration( uri: request.RequestUri, statusCode: httpResponseMessage.StatusCode, elapsedMilliseconds: stopwatch.ElapsedMilliseconds); var result = await this.MapHttpResponseAsync( httpResponseMessage: httpResponseMessage, cancellationToken: cancellationToken); return result; } private async Task MapHttpResponseAsync( HttpResponseMessage httpResponseMessage, CancellationToken cancellationToken) { var basicResponse = await httpResponseMessage .Content .ReadFromJsonAsync( cancellationToken: cancellationToken); return httpResponseMessage.StatusCode switch { HttpStatusCode.OK => basicResponse!.Match( onStatusOk: SailplayApiResult.FromSuccess, onStatusError: SailplayApiResult.FromError), _ => SailplayApiResult.FromUnexpectedHttpStatusCode(httpResponseMessage.StatusCode), }; } } } Отрефактори метод UpdateUserAsync1, максимально сократив его. Разнести по классам RequestExecutor и AuthorisationExecutor. В общем, сделай красиво.
- Assistant
Предлагаю следующий рефакторинг для метода
UpdateUserAsync1:public async Task<UpdateUserResult> UpdateUserAsync1(SailplayCredentials credentials, UpdateUser requestData, CancellationToken cancellationToken) { var tokenResult = await this.authorisationExecutor.GetAuthorizationTokenAsync(credentials, cancellationToken); var apiResponse = await Policy.HandleResult(apiResult => apiResult.IsAuthorizationTokenError) .RetryAsync( retryCount: 1, onRetryAsync: async (_, _, _) => { tokenResult = await this.authorisationExecutor.RenewAuthorizationTokenAsync(credentials, cancellationToken); }) .ExecuteAsync(async () => { var request = HttpRequestMessageFactory.BuildPost(ApiPath.UsersUpdate); var token = await tokenResult.Match( onSuccess: t => t.Token, onError: result => throw new SomeException(result.ErrorCode, result.Message)); // Обработка ошибки получения токена var keyValuePairs = new List<KeyValuePair<string, string>>() { FormDataFactory.FromToken(token), FormDataFactory.FromStoreDepartmentId(credentials.StoreDepartmentId) }; KeyValuePair<string, string>? CreateFormDataOption(string value, Func<string, KeyValuePair<string, string>> formDataFactory) { return value != null ? formDataFactory(value) : null; } keyValuePairs.AddRange(FormDataFactory.FromUserId(requestData.UserId)); CreateFormDataOption(requestData.Phone, FormDataFactory.FromNewPhone)?.Let(keyValuePairs.Add); CreateFormDataOption(requestData.Email, FormDataFactory.FromNewEmail)?.Let(keyValuePairs.Add); CreateFormDataOption(requestData.FirstName, FormDataFactory.FromFirstName)?.Let(keyValuePairs.Add); CreateFormDataOption(requestData.MiddleName, FormDataFactory.FromMiddleName)?.Let(keyValuePairs.Add); CreateFormDataOption(requestData.LastName, FormDataFactory.FromLastName)?.Let(keyValuePairs.Add); CreateFormDataOption(requestData.BirthDate, FormDataFactory.FromBirthDate)?.Let(keyValuePairs.Add); CreateFormDataOption(requestData.Sex, FormDataFactory.FromSex)?.Let(keyValuePairs.Add); CreateFormDataOption(requestData.RegisterDate, FormDataFactory.FromRegisterDate)?.Let(keyValuePairs.Add); request.Content = new FormUrlEncodedContent(keyValuePairs); var response = await this.requestExecutor.ExecuteApiRequestAsync(request, cancellationToken, token); return response.Match( onSuccess: UpdateUserResult.FromSuccess, onError: errorResult => errorResult.ErrorCode switch { ApiResponse.ErrorCodes.InvalidValue => UpdateUserResult.FromError(ErrorResult.FromInvalidValue(errorResult.ErrorCode, errorResult.Message)), ApiResponse.ErrorCodes.UserNotFound => UpdateUserResult.FromError(ErrorResult.FromUserNotFound(errorResult.ErrorCode, errorResult.Message)), ApiResponse.ErrorCodes.EmailIsUsed => UpdateUserResult.FromError(ErrorResult.FromEmailIsUsed(errorResult.ErrorCode, errorResult.Message)), ApiResponse.ErrorCodes.PhoneIsUsed => UpdateUserResult.FromError(ErrorResult.FromPhoneIsUsed(errorResult.ErrorCode, errorResult.Message)), _ => UpdateUserResult.FromError(ErrorResult.FromGeneralError(errorResult.ErrorCode, errorResult.Message)), }, onUnexpectedHttpStatusCode: UpdateUserResult.FromUnexpectedHttpStatusCode); }); return apiResponse; }Обновленный код следует разместить в соответствующих классах
RequestExecutorиAuthorisationExecutor. - User
Retry будет использоваться во многих методах, поэтому я бы хотел его куда-то вынести
- Assistant
Предлагаю вынести логику повторной попытки в отдельный метод, который может быть использован в различных методах. Вот пример реализации:
public static class RetryHelper { public static async Task<T> RetryAsync<T>( Func<Task<T>> action, int retryCount, Func<Exception, int, Task> onRetryAsync) { for (int attempt = 1; attempt <= retryCount + 1; attempt++) { try { return await action(); } catch (Exception exception) { if (attempt > retryCount + 1) { throw; } await onRetryAsync(exception, attempt); } } throw new InvalidOperationException("Should not reach this point."); } }Вы можете использовать этот метод в методе
UpdateUserAsync1следующим образом:public async Task<UpdateUserResult> UpdateUserAsync1(SailplayCredentials credentials, UpdateUser requestData, CancellationToken cancellationToken) { var tokenResult = await this.authorisationExecutor.GetAuthorizationTokenAsync(credentials, cancellationToken); var apiResponse = await RetryHelper.RetryAsync( action: async () => { var token = await tokenResult.Match( onSuccess: t => t.Token, onError: result => throw new SomeException(result.ErrorCode, result.Message)); // Обработка ошибки получения токена var request = HttpRequestMessageFactory.BuildPost(ApiPath.UsersUpdate); var keyValuePairs = new List<KeyValuePair<string, string>>() { FormDataFactory.FromToken(token), FormDataFactory.FromStoreDepartmentId(credentials.StoreDepartmentId) }; // Другой код request.Content = new FormUrlEncodedContent(keyValuePairs); var response = await this.requestExecutor.ExecuteApiRequestAsync(request, cancellationToken, token); return response.Match( onSuccess: UpdateUserResult.FromSuccess, onError: errorResult => errorResult.ErrorCode switch { ApiResponse.ErrorCodes.InvalidValue => UpdateUserResult.FromError(ErrorResult.FromInvalidValue(errorResult.ErrorCode, errorResult.Message)), ApiResponse.ErrorCodes.UserNotFound => UpdateUserResult.FromError(ErrorResult.FromUserNotFound(errorResult.ErrorCode, errorResult.Message)), ApiResponse.ErrorCodes.EmailIsUsed => UpdateUserResult.FromError(ErrorResult.FromEmailIsUsed(errorResult.ErrorCode, errorResult.Message)), ApiResponse.ErrorCodes.PhoneIsUsed => UpdateUserResult.FromError(ErrorResult.FromPhoneIsUsed(errorResult.ErrorCode, errorResult.Message)), _ => UpdateUserResult.FromError(ErrorResult.FromGeneralError(errorResult.ErrorCode, errorResult.Message)), }, onUnexpectedHttpStatusCode: UpdateUserResult.FromUnexpectedHttpStatusCode); }, retryCount: 1, onRetryAsync: async (exception, attempt) => { tokenResult = await this.authorisationExecutor.RenewAuthorizationTokenAsync(credentials, cancellationToken); // Логика обработки повторной попытки }); return apiResponse; }Вы можете использовать
RetryHelper.RetryAsyncв других методах, чтобы выполнить повторные попытки с разными параметрами, передавая соответствующие делегаты для логики запроса и обработки повторной попытки. Это позволяет сократить дублирование кода и повторный использовать логику повторной попытки в разных методах.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.